prometheus

Commit Graph

Author	SHA1	Message	Date
Bartlomiej Plotka	9981b3f3ee	labels: Reduce allocated memory and latency of Hash method; Added tests. (#8025 ) * labels: Reduce allocated memory by Hash method in edge cases; Added tests. Old: /tmp/___BenchmarkLabels_Hash_in_github_com_prometheus_prometheus_pkg_labels -test.v -test.bench ^\QBenchmarkLabels_Hash\E$ -test.run ^$ goos: linux goarch: amd64 pkg: github.com/prometheus/prometheus/pkg/labels BenchmarkLabels_Hash BenchmarkLabels_Hash/typical_labels_under_1KB BenchmarkLabels_Hash/typical_labels_under_1KB-12 5366161 259 ns/op 0 B/op 0 allocs/op BenchmarkLabels_Hash/bigger_labels_over_1KB BenchmarkLabels_Hash/bigger_labels_over_1KB-12 1700371 767 ns/op 2048 B/op 1 allocs/op BenchmarkLabels_Hash/extremely_large_label_value_10MB BenchmarkLabels_Hash/extremely_large_label_value_10MB-12 356 3743115 ns/op 10523442 B/op 1 allocs/op PASS New: /tmp/___BenchmarkLabels_Hash_in_github_com_prometheus_prometheus_pkg_labels -test.v -test.bench ^\QBenchmarkLabels_Hash\E$ -test.run ^$ goos: linux goarch: amd64 pkg: github.com/prometheus/prometheus/pkg/labels BenchmarkLabels_Hash BenchmarkLabels_Hash/typical_labels_under_1KB BenchmarkLabels_Hash/typical_labels_under_1KB-12 4758883 259 ns/op 0 B/op 0 allocs/op BenchmarkLabels_Hash/bigger_labels_over_1KB BenchmarkLabels_Hash/bigger_labels_over_1KB-12 3324492 357 ns/op 80 B/op 1 allocs/op BenchmarkLabels_Hash/extremely_large_label_value_10MB BenchmarkLabels_Hash/extremely_large_label_value_10MB-12 1087 1083949 ns/op 9734 B/op 1 allocs/op PASS Process finished with exit code 0 Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Addressed Kemal's comment. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Moved to v2 xxhash for improvements. New: /tmp/___BenchmarkLabels_Hash_in_github_com_prometheus_prometheus_pkg_labels -test.v -test.bench ^\QBenchmarkLabels_Hash\E$ -test.run ^$ -test.benchtime 10s goos: linux goarch: amd64 pkg: github.com/prometheus/prometheus/pkg/labels BenchmarkLabels_Hash BenchmarkLabels_Hash/typical_labels_under_1KB BenchmarkLabels_Hash/typical_labels_under_1KB-12 53447894 221 ns/op 0 B/op 0 allocs/op BenchmarkLabels_Hash/bigger_labels_over_1KB BenchmarkLabels_Hash/bigger_labels_over_1KB-12 42341754 326 ns/op 0 B/op 0 allocs/op BenchmarkLabels_Hash/extremely_large_label_value_10MB BenchmarkLabels_Hash/extremely_large_label_value_10MB-12 10000 1248546 ns/op 0 B/op 0 allocs/op PASS Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Removed old xxhash package. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Pined minor version. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>	4 years ago
Bartlomiej Plotka	dee6ac274e	labels: Extra tests and comment for WithoutLabels method. (#8024 ) Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>	4 years ago
Guangwen Feng	e6f2b8ad60	Fix golint issue in labels.go (#7730 ) Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>	4 years ago
Callum Styan	5bb7f00d00	change labelset comparison in promql engine to avoid false positive during detection of duplicates (#7058 ) * Use go1.14 new hash/maphash to hash both RHS and LHS instead of XOR'ing which has been resulting in hash collisions. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Refactor engine labelset signature generation, just use labels.Labels instead of hashes. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Address review comments; function comments + store result of lhs.String+rhs.String as key. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Replace all signatureFunc usage with signatureFuncString. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Make optimizations to labels String function and generation of rhs+lhs as string in resultMetric. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Use separate string functions that don't use strconv just for engine maps. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Use a byte invalid separator instead of quoting and have a buffer attached to EvalNodeHelper instead of using a global pool in the labels package. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Address review comments. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Address more review comments, labels has a function that now builds a byte slice without turning it into a string. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Use two different non-ascii hex codes as byte separators between labels and between sets of labels when building bytes of a Labels struct. Signed-off-by: Callum Styan <callumstyan@gmail.com> * We only need the 2nd byte invalid sep. at the beginning of a labels.Bytes Signed-off-by: Callum Styan <callumstyan@gmail.com>	5 years ago
Ben Kochie	269e7c8091	Fix golint issues. Signed-off-by: Ben Kochie <superq@gmail.com>	5 years ago
Guangwen Feng	14182c1420	Fix golint warning in labels.go (#6839 ) Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>	5 years ago
Julien Pivotto	46d18112a3	tsdb: error on series with duplicate labels (#6664 ) Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Brian Brazil	a9ed3b980d	Optimise labels.Compare (#6539 ) strings.Compare isn't meant to be used, and this way we save one comparison which is thus very slightly cheaper. benchmark old ns/op new ns/op delta BenchmarkPostingsForMatchers/Head/n="1"-4 236305440 233515705 -1.18% Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>	5 years ago
Julius Volz	ae93bae88f	Fix: exclude metric name in labels.MatchLabels() (#6523 ) This function is only used in one place to format an error message when encountering multiple matches on the "one" side of a one-to-many/many-to-one vector match, which is probably why nobodoy has noticed this before. The hashing is already done correctly and excludes the metric name label when using the "ignoring" matching modifier. Signed-off-by: Julius Volz <julius.volz@gmail.com>	5 years ago
Tom Wilkie	de0a772b8e	Port tsdb to use pkg/labels. (#6326 ) * Port tsdb to use pkg/labels. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com> * Get tests passing. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com> * Remove useless cast. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com> * Appease linters. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com> * Fix review comments Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	5 years ago
Brian Brazil	e62f30d497	Correctly handle empty labels from alert templates. (#5845 ) Fixes https://github.com/prometheus/common/issues/36 Move logic handling this into the labels package, so all the cases are handled in one place and we're less likely to have this come up again. Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>	5 years ago
Ganesh Vernekar	588eb20018	Efficient iteration and search in HashForLabels and HashWithoutLabels (#5707 ) * Efficient iteration and search in Labels.HashForLabels Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * Better names for variables Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * HashWithoutLabels optimizations Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * Refactor HashForLabels and HashWithoutLabels to take sorted names Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * Fix review comments Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	5 years ago
Thomas Jackson	a000cec011	Re-use label builder in promql aggregation (#5641 ) For my benchmarks on aggregation this reduces allocations by ~5% (~10% time improvement): ``` benchmark old ns/op new ns/op delta BenchmarkEvaluations/benchdata/aggregators.test/promxy-4 727692 649626 -10.73% benchmark old allocs new allocs delta BenchmarkEvaluations/benchdata/aggregators.test/promxy-4 2566 2434 -5.14% benchmark old bytes new bytes delta BenchmarkEvaluations/benchdata/aggregators.test/promxy-4 162760 148854 -8.54% ``` Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>	6 years ago
Tom Wilkie	c7b3535997	Use pkg/relabelling in remote write. - Unmarshall external_labels config as labels.Labels, add tests. - Convert some more uses of model.LabelSet to labels.Labels. - Remove old relabel pkg (fixes #3647). - Validate external label names. Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>	6 years ago
Tariq Ibrahim	a2a6e24f9f	show list of offending labels in the error message in many-to-many scenarios (#5189 ) Signed-off-by: tariqibrahim <tariq181290@gmail.com>	6 years ago
JoeWrightss	e158c53fa9	Fix some typos in comment (#5175 ) Signed-off-by: zhoulin xie <zhoulin.xie@daocloud.io>	6 years ago
Alin Sinpalean	96fb0b2155	Optimize PromQL aggregations (#4248 ) * Compute hash of label subsets without creating a LabelSet first. Signed-off-by: Alin Sinpalean <alin.sinpalean@gmail.com>	6 years ago
Krasi Georgiev	675ce533c9	refactored TestScrapeLoopAppend and added a test for empty labels	7 years ago
Brian Brazil	4addee2bee	Fix honor_labels for empty labels, prune empty labels. The semantics of honor_labels are that if a target exposes and empty label it will override the target labels. This PR fixes that by once again distinguishing between empty labels and missing labels in this one use case. Beyond that empty labels should be pruned and not added to storage, which this also fixes. Fixes #3841	7 years ago
Julius Volz	c3d6abc8e6	Fix some lint errors (#3334 ) I left the promql ones and some others untouched as I remember that @fabxc prefers them that way.	7 years ago
Brian Brazil	9aa8f822c1	Fix typo	8 years ago
Brian Brazil	5c9a6ce747	Add license to files. This should fix CI for dev-2.0.	8 years ago
Fabian Reinartz	8ffc851147	Merge branch 'master' into dev-2.0	8 years ago
Fabian Reinartz	e94b0899ee	rules: fix tests, remove model types	8 years ago
Fabian Reinartz	8b4e4a9d2b	notifier: fully use labels.Labels	8 years ago
Fabian Reinartz	f8fc1f5bb2	*: migrate ingestion to new batch Appender	8 years ago
Fabian Reinartz	71fe0c58a8	promql: misc fixes	8 years ago
Fabian Reinartz	5817cb5bde	: migrate from model. to promql.* types	8 years ago
Fabian Reinartz	9ea10d5265	promql: use labels.Builder to modify labels	8 years ago
Fabian Reinartz	c6cd998905	promql: use local labels, add conversion	8 years ago

30 Commits (a419b75abd190d64cadcac8fcc6c67b3b95ff46e)