prometheus

Commit Graph

Author	SHA1	Message	Date
Łukasz Mierzwa	a4317bf0ec	Run gofumpt on all files (#10392 ) * Run gofumpt on all files Getting golangci-lint errors when building on my laptop, possibly because I have newer version of gofumpt then what it was formatted with. Run gofumpt -w -extra on all files as it will be needed in the future anyway. * Update golangci-lint to v1.44.2 v1.44.0 upgraded gofumpt so bumping version in CI will help keep formatting correct for everyone * Address golangci-lint error Getting 'error-strings: error strings should not be capitalized or end with punctuation or a newline' from revive here. Drop new line. Signed-off-by: Łukasz Mierzwa <l.mierzwa@gmail.com>	3 years ago
Tobias Klausmann	b998636893	Improve error logging for missing config and QL dir (#10260 ) * Improve error logging for missing config and QL dir Currently, when Prometheus can't open its config file or the query logging dir under the data dir, it only logs what it has been given default or commandline/config. Depending on the environment this can be less than helpful, since the working directory may be unclear to the user. I have specifically kept the existing error messages as intact as possible to a) still log the parameter as given and b) cause as little disruption for log-parsers/-analyzers as possible. So in case of the config file or the data dir being non-absolute paths, I use os.GetWd to find the working dir and assemble an absolute path for error logging purposes. If GetWd fails, we just log "unknown", as recovering from an error there would be very complex measure, likely not worth the code/effort. Example errors: ``` $ ./prometheus ts=2022-02-06T16:00:53.034Z caller=main.go:445 level=error msg="Error loading config (--config.file=prometheus.yml)" fullpath=/home/klausman/src/prometheus/prometheus.yml err="open prometheus.yml: no such file or directory" $ touch prometheus.yml $ ./prometheus [...] ts=2022-02-06T16:01:00.992Z caller=query_logger.go:99 level=error component=activeQueryTracker msg="Error opening query log file" file=data/queries.active fullpath=/home/klausman/src/prometheus/data/queries.active err="open data/queries.active: permission denied" panic: Unable to create mmap-ed active query log [...] $ ``` Signed-off-by: Tobias Klausmann <klausman@schwarzvogel.de> * Replace our own logic with just using filepath.Abs() Signed-off-by: Tobias Klausmann <klausman@schwarzvogel.de> * Further simplification Signed-off-by: Tobias Klausmann <klausman@schwarzvogel.de> * Review edits Signed-off-by: Tobias Klausmann <klausman@schwarzvogel.de> * Review edits Signed-off-by: Tobias Klausmann <klausman@schwarzvogel.de> * Review edits Signed-off-by: Tobias Klausmann <klausman@schwarzvogel.de>	3 years ago
jyz0309	e40deb1086	address comment Signed-off-by: jyz0309 <45495947@qq.com>	3 years ago
jyz0309	02e032884a	add doc Signed-off-by: jyz0309 <45495947@qq.com>	3 years ago
jyz0309	7f32a5d0d6	add NaN case Signed-off-by: jyz0309 <45495947@qq.com>	3 years ago
Julien Pivotto	9a2e93228e	Switch to grafana/regexp everywhere (#10268 ) Let's have a consistent library for regexp. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	3 years ago
Matheus Pimenta	8d8ce641a4	error for invalid media type should not be completely swallowed (#10186 ) * error for invalid media type should not be completely swallowed Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>	3 years ago
Björn Rabenstein	be7ed73efc	Merge pull request #10140 from David-N-Perkins/ISS-9910 Issue 9910	3 years ago
Peter Štibraný	6d76f09c58	Extract interface from ActivityQueryTracker and allows passing custom implementation (#10071 ) * Extract interface from ActivityQueryTracker and allows passing custom implementation. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>	3 years ago
Matej Gera	2c61d29b2a	Tracing: Migrate to OpenTelemetry library (#9724 ) Signed-off-by: Matej Gera <matejgera@gmail.com>	3 years ago
beorn7	c2b80d8643	PromQL: Test negative offset in PromQL tests Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
beorn7	b39f2739e5	PromQL: Always enable negative offset and @ modifier This follows the line of argument that the invariant of not looking ahead of the query time was merely emerging behavior and not a documented stable feature. Any query that looks ahead of the query time was simply invalid before the introduction of the negative offset and the @ modifier. Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
David N Perkins	472456efde	Added issue link to the comment Signed-off-by: David N Perkins <David.N.Perkins@ibm.com>	3 years ago
David N Perkins	52662e8105	Added metric name to histogram quartile binning and associated unit test Signed-off-by: David N Perkins <David.N.Perkins@ibm.com>	3 years ago
Björn Rabenstein	d677aa4b29	storage: Consolidate iterator method names (Values -> At) (#9888 ) `BufferedSeriesIterator` and `MemoizedSeriesIterator` use a method called `Values` for exactly the purpose for which all other iterators of the same kind use a method called `At`. That alone is confusing, but on top of that, the `Values` method only returns a single sample, not multiple values. I assume the naming has historical reasons. This commit makes it more consistent. It is now easier to read, and now `BufferedSeriesIterator` and `MemoizedSeriesIterator` implement `chunkenc.Iterator` like many other iterators, too. Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
Shihao Xia	0e82a96e2f	fix potential deadlock in test (#9010 ) * fix potential deadlock Signed-off-by: Shihao Xia <charlesxsh@hotmail.com> * fix deadlock Signed-off-by: Shihao Xia <charlesxsh@hotmail.com> * Update promql/engine_test.go Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com> Signed-off-by: Shihao Xia <charlesxsh@hotmail.com> Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com>	3 years ago
beorn7	9672ade191	Promql: Add clarifying note to Point.MarshalJSON Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
Ganesh Vernekar	2a3d62ac84	Revert "promql: Remove unused Point.MarshalJSON method (#9860 )" (#9864 ) This reverts commit `427425cc9f`. Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	3 years ago
Björn Rabenstein	427425cc9f	promql: Remove unused Point.MarshalJSON method (#9860 ) JSON marshaling is only needed for the HTTP API. Since Point is such a frequently marshaled type, it gets an optimized treatment directly in web/api/v1/api.go. The MarshalJSON method still provided in the promql package is therefore unused and its existence is confusing. Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
Matthew	7ee52bfb86	feat: linreg => slope 0 for const values (#9728 ) * feat: linreg => slope 0 for const values Signed-off-by: mtfoley <mtfoley.mae@gmail.com>	3 years ago
Thomas Jackson	f0003bc0ba	Don't drop ParenExpr when creating StepInvariantExpr (#9591 ) * Add test case to showcase the problem in #9590 Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com> * Don't unwrap ParenExpr in newStepInvariantExpr Fixes #9590 Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>	3 years ago
beorn7	c954cd9d1d	Move packages out of deprecated pkg directory This creates a new `model` directory and moves all data-model related packages over there: exemplar labels relabel rulefmt textparse timestamp value All the others are more or less utilities and have been moved to `util`: gate logging modetimevfs pool runtime Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
Dieter Plaetinck	cda025b5b5	TSDB: demistify SeriesRefs and ChunkRefs (#9536 ) * TSDB: demistify seriesRefs and ChunkRefs The TSDB package contains many types of series and chunk references, all shrouded in uint types. Often the same uint value may actually mean one of different types, in non-obvious ways. This PR aims to clarify the code and help navigating to relevant docs, usage, etc much quicker. Concretely: * Use appropriately named types and document their semantics and relations. * Make multiplexing and demuxing of types explicit (on the boundaries between concrete implementations and generic interfaces). * Casting between different types should be free. None of the changes should have any impact on how the code runs. TODO: Implement BlockSeriesRef where appropriate (for a future PR) Signed-off-by: Dieter Plaetinck <dieter@grafana.com> * feedback Signed-off-by: Dieter Plaetinck <dieter@grafana.com> * agent: demistify seriesRefs and ChunkRefs Signed-off-by: Dieter Plaetinck <dieter@grafana.com>	3 years ago
Mateusz Gozdek	b7bdf6fab2	Fix imports formatting According to `2829908806 (r58457095)`. Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>	3 years ago
Mateusz Gozdek	1a6c2283a3	Format Go source files using 'gofumpt -w -s -extra' Part of #9557 Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>	3 years ago
darshanime	42d786f1ac	use kahan summation for aggregation functions Signed-off-by: darshanime <deathbullet@gmail.com>	3 years ago
darshanime	694b872dee	address stylistic nits Signed-off-by: darshanime <deathbullet@gmail.com>	3 years ago
darshanime	a905354da3	use kahan for avg_over_time Signed-off-by: darshanime <deathbullet@gmail.com>	3 years ago
darshanime	0a9deb9597	use kahan summation for numerical stability Signed-off-by: darshanime <deathbullet@gmail.com>	3 years ago
Björn Rabenstein	c092a74be9	Merge pull request #9553 from prometheus/beorn7/histogram promql: Add more test cases for `histogram_quantile`	3 years ago
beorn7	c00c6ed01f	promql: Add more test cases for `histogram_quantile` This is motivated by the doubts raised in #7970. Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
Bryan Boreham	a278ea4b58	promql: copy data when short-circuiting (#9552 ) * promql: copy data when short-circuiting Because the range query loop re-uses the output buffer each time round, we must copy results into the buffer rather than using input as output. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	3 years ago
Julien Pivotto	c812ee794e	PromQL: Comment flaky test (#9545 ) Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	3 years ago
Julien Pivotto	a18224d02d	make aggregations deterministic (#9459 ) * Add deterministic test for aggregations Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu> * Make aggregations deterministic Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu> * Increase testing Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	3 years ago
ziollek	55f9147b44	Add atan2 to scalar operators - issue #9485 (#9515 ) * Add atan2 to scalar operators Signed-off-by: Tomasz Ziolkowski <tomasz.ziolkowski@allegro.pl>	3 years ago
Levi Harrison	587cb95093	Add operator tests Signed-off-by: Levi Harrison <git@leviharrison.dev>	3 years ago
Levi Harrison	f5c6ee4df6	Add lex test Signed-off-by: Levi Harrison <git@leviharrison.dev>	3 years ago
Levi Harrison	7471208b5c	Add `ATAN2` to `maybe_label` Signed-off-by: Levi Harrison <git@leviharrison.dev>	3 years ago
Levi Harrison	8547a2bd86	Add `atan2` binary operator Signed-off-by: Levi Harrison <git@leviharrison.dev>	3 years ago
Bryan Boreham	5a754bc043	Short-circuit vector binary ops (#9362 ) In degenerate cases we can save the effort of building a map. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	3 years ago
Bryan Boreham	c4942ef3b7	Optimise query_range by computing join signatures just once (#9360 ) * Add benchmark case for many-to-one join Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * query_range: compute join signatures just once For an expression like `a + on(p,q) b`, extract the `p,q` part from each series once, instead of re-computing at every step of the range. Although there was a cache, computing the key by concatenating all labels was expensive. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	3 years ago
Bryan Boreham	7d105277fe	Optimise topk where k==1 (#9365 ) * Add benchmark for query_range with topk Modify sample data so values within a metric differ Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * Optimise topk where k==1 In this case we don't need a heap to keep track of values; just a single slot is fine. Simplify the initialization of the heap: since all cases start off as a single-item heap we can just assign the value directly. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * Allow at least one slot in results for topk, quantile k isn't set for quantile, but we need space to start collecting values Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	3 years ago
Levi Harrison	4ac4e2ca4b	Remove parenthesis Signed-off-by: Levi Harrison <git@leviharrison.dev>	3 years ago
Levi Harrison	6faca22eec	Add inverse hyperbolic functions Signed-off-by: Levi Harrison <git@leviharrison.dev>	3 years ago
Levi Harrison	9c54ee0a6e	Changed function comment Signed-off-by: Levi Harrison <git@leviharrison.dev>	3 years ago
Levi Harrison	53d88fd147	Added hyperbolic trig functions Signed-off-by: Levi Harrison <git@leviharrison.dev>	3 years ago
Levi Harrison	a8ad569db8	Change spaces to tabs Signed-off-by: Levi Harrison <git@leviharrison.dev>	3 years ago
Levi Harrison	ecc29d38b8	Fixed `pi` definition Signed-off-by: Levi Harrison <git@leviharrison.dev>	3 years ago
Levi Harrison	9fc7ba33aa	Remove `atan2()` Signed-off-by: Levi Harrison <git@leviharrison.dev>	3 years ago
Levi Harrison	f1d94cc5f6	Split and shortened tests Signed-off-by: Levi Harrison <git@leviharrison.dev>	3 years ago

1 2 3 4 5 ...

643 Commits (9ed56c6065f2602090553cc3ced90baa4e14e1f9)