prometheus

Commit Graph

Author	SHA1	Message	Date
Nathan Baulch	50cd453c8f	chore: Fix typos (#14868 ) * Fix typos --------- Signed-off-by: Nathan Baulch <nathan.baulch@gmail.com>	3 months ago
Jeanette Tan	9adc1699c3	fix according to code review Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	6 months ago
zenador	545a7e48f9	[nhcb branch] Enhance unit test framework for nhcb and warnings (#14009 ) * process custom values in histogram unit test framework * check for warnings when evaluating in unit test framework * add test cases for custom buckets in test framework Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	7 months ago
zenador	4acbb7dea6	Add custom buckets to native histogram chunks encoding (#13706 ) * add custom bounds to chunks encoding * change custom buckets schema number * rename custom bounds to custom values Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	8 months ago
György Krajcsovits	5d0a0a7542	Add custom buckets to native histogram model (#13592 ) * add custom buckets to native histogram model * simple copy for custom bounds * return errors for unsupported add/sub operations * add test cases for string and update appendhistogram in scrape to account for new schema * check fields which are supposed to be unused but may affect results in equals * allow appending custom buckets histograms regardless of max schema Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	9 months ago
Filip Petkovski	583f3e587c	Optimize histogram iterators (#13340 ) Optimize histogram iterators Histogram iterators allocate new objects in the AtHistogram and AtFloatHistogram methods, which makes calculating rates over long ranges expensive. In #13215 we allowed an existing object to be reused when converting an integer histogram to a float histogram. This commit follows the same idea and allows injecting an existing object in the AtHistogram and AtFloatHistogram methods. When the injected value is nil, iterators allocate new histograms, otherwise they populate and return the injected object. The commit also adds a CopyTo method to Histogram and FloatHistogram which is used in the BufferedIterator to overwrite items in the ring instead of making new copies. Note that a specialized HPoint pool is needed for all of this to work (`matrixSelectorHPool`). --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Co-authored-by: George Krajcsovits <krajorama@users.noreply.github.com>	10 months ago
zenador	a3ddfbd1ee	Add warnings for histogramRate applied with isCounter not matching counter/gauge histogram (#13392 ) Add warnings for histogramRate applied with isCounter not matching counter/gauge histogram --------- Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	11 months ago
Björn Rabenstein	928d07e3bd	Merge branch 'main' into arve/typos Signed-off-by: Björn Rabenstein <beorn@grafana.com>	12 months ago
Björn Rabenstein	85078b968f	Merge pull request #13208 from linasm/panic-free-float-histogram-add-sub FloatHistogram.Add/Sub: handle any schema change	12 months ago
Björn Rabenstein	de1ec731c7	Merge pull request #13212 from linasm/optimize-floatBucketIterator-for-common-case Histograms: optimize floatBucketIterator for common case	12 months ago
Linas Medziunas	bd895baefc	FloatHistogram.Add/Sub: handle any schema change Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	12 months ago
Arve Knudsen	237bfea46b	`chunks.Reader`: Fix typo in ChunkOrIterable doc string. Also fix comment typo in `FloatHistogram.Sub`. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	12 months ago
Oleksandr Redko	2a75604f8e	Enable default revive rules (#13068 ) Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>	1 year ago
Linas Medziunas	048886ae8a	Histograms: optimize floatBucketIterator for common case Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	1 year ago
Linas Medziunas	49613823f8	Reuse slices in [Float]Histogram.ReduceResolution Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	1 year ago
Björn Rabenstein	a6d4b8d97b	Merge pull request #13190 from linasm/fix-float-histogram-add-sub-mutating-argument Fix FloatHistogram.Add/Sub mutating its argument	1 year ago
Linas Medziunas	f99ecc376e	Fix FloatHistogram.Add/Sub mutating its argument Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	1 year ago
Linas Medziunas	ea1862aab4	Explicit schema check in [Float]Histogram.ReduceResolution Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	1 year ago
Ziqi Zhao	e250f09b5d	change origin schema in `ReduceResolution` method of histogram and float histogram (#13116 ) * change origin schema in ReduceResolution method of histogram and float histogram Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> --------- Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	1 year ago
Ziqi Zhao	ab2a7bb74f	add generic shrink function (#13001 ) Add `ReduceResolution` method to `Histogram` and `FloatHistogram` This takes the original `mergeToSchema` function and turns it into a more generic `reduceResolution` function, which is the building block for the new methods. The methods will help with addressing #12864. --------- Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	1 year ago
Matthieu MOREL	05fba53e57	web : use Go standard package Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	1 year ago
Linas Medziunas	ebed7d0612	Change Validate to be a method on histogram structs Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	1 year ago
Linas Medžiūnas	e3e22abadb	Merge branch 'main' into linasm/optimize-floatBucketIterator2 Signed-off-by: Linas Medžiūnas <linasm@users.noreply.github.com>	1 year ago
Marc Tuduri	af7c31ee10	PR feedback Signed-off-by: Marc Tuduri <marctc@protonmail.com>	1 year ago
Marc Tuduri	8fededf6ad	promql(histograms): Change sample total calculation for histograms Signed-off-by: Marc Tuduri <marctc@protonmail.com>	1 year ago
Linas Medziunas	62bbb81e29	Mention bucket values in the comment Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	1 year ago
Linas Medziunas	ec823d9daf	Update comments, bitwise comparison of float buckets Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	1 year ago
Linas Medziunas	c5c5c569fa	Histogram performance: optimize floatBucketIterator Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	1 year ago
Linas Medziunas	3c047a3518	Expand docs comments Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	1 year ago
Linas Medziunas	dfb6292600	Compare FloatHistogram.[Zero]Count float values as binary Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	1 year ago
Linas Medziunas	cbd01fc296	Fix NaN sum check in [Float]Histogram.Equals method Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	1 year ago
Gregor Zeitlinger	f01718262a	Unit tests for native histograms (#12668 ) promql: Extend testing framework to support native histograms This includes both the internal testing framework as well as the rules unit test feature of promtool. This also adds a bunch of basic tests. Many of the code level tests can now be converted to tests within the framework, and more tests can be added easily. --------- Signed-off-by: Harold Dost <h.dost@criteo.com> Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com> Signed-off-by: Stephen Lang <stephen.lang@grafana.com> Co-authored-by: Harold Dost <h.dost@criteo.com> Co-authored-by: Stephen Lang <stephen.lang@grafana.com> Co-authored-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>	1 year ago
zenador	54aaa2bd7e	Add `histogram_stdvar` and `histogram_stddev` functions (#12614 ) * Add new function: histogram_stdvar and histogram_stddev Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	1 year ago
Ziqi Zhao	de172049ab	fix lint error Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	1 year ago
Ziqi Zhao	d3633d4e76	Update model/histogram/float_histogram.go Co-authored-by: Björn Rabenstein <github@rabenste.in> Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	1 year ago
Ziqi Zhao	893f97556f	use switch instead of if-else to fix lint error Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	1 year ago
Ziqi Zhao	788061e509	remove unused addBucket function Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	1 year ago
Ziqi Zhao	eab3c93e80	make code ready for review Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	1 year ago
Ziqi Zhao	4787c879bc	add more elaborate benchmark test Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	1 year ago
Ziqi Zhao	bf880a6e77	enhance floathistogram add and sub method Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	1 year ago
Ziqi Zhao	ed1b307bca	enhance FloatHistogram CopyToSchema method (#12596 ) histogram: Improve performance of FloatHistogram.CopyToSchema Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> --------- Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> Co-authored-by: Björn Rabenstein <github@rabenste.in>	1 year ago
beorn7	9aadd54786	histogram: Fix bounds of buckets returned by floatBucketIterator The bounds weren't really used so far, so no actual bug in the code so far. But it's obviously confusing if the bounds returned by a floatBucketIterator with a target schema different from the original schema are wrong. Signed-off-by: beorn7 <beorn@grafana.com>	1 year ago
cui fliter	096ceca44f	remove repetitive words (#12556 ) Signed-off-by: cui fliter <imcusg@gmail.com>	1 year ago
Ziqi Zhao	42d9169ba1	enhance histogram_quantile to get min/max value Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	1 year ago
Carrie Edwards	a462f7fa21	Add function for iterating through all buckets in reverse to find max bucket Signed-off-by: Carrie Edwards <edwrdscarrie@gmail.com>	1 year ago
zenador	191bf9055b	Handle more arithmetic operators for native histograms (#12262 ) Handle more arithmetic operators and aggregators for native histograms This includes operators for multiplication (formerly known as scaling), division, and subtraction. Plus aggregations for average and the avg_over_time function. Stdvar and stddev will (for now) ignore histograms properly (rather than counting them but adding a 0 for them). Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2 years ago
beorn7	5b53aa1108	style: Replace `else if` cascades with `switch` Wiser coders than myself have come to the conclusion that a `switch` statement is almost always superior to a statement that includes any `else if`. The exceptions that I have found in our codebase are just these two: * The `if else` is followed by an additional statement before the next condition (separated by a `;`). * The whole thing is within a `for` loop and `break` statements are used. In this case, using `switch` would require tagging the `for` loop, which probably tips the balance. Why are `switch` statements more readable? For one, fewer curly braces. But more importantly, the conditions all have the same alignment, so the whole thing follows the natural flow of going down a list of conditions. With `else if`, in contrast, all conditions but the first are "hidden" behind `} else if `, harder to spot and (for no good reason) presented differently from the first condition. I'm sure the aforemention wise coders can list even more reasons. In any case, I like it so much that I have found myself recommending it in code reviews. I would like to make it a habit in our code base, without making it a hard requirement that we would test on the CI. But for that, there has to be a role model, so this commit eliminates all `if else` occurrences, unless it is autogenerated code or fits one of the exceptions above. Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
Trevor Whitney	e3513d1dd2	Change nested ifs to a switch Signed-off-by: Trevor Whitney <trevorjwhitney@gmail.com>	2 years ago
Trevor Whitney	b4e324f637	Handle valid cases of mismatched hints when adding Signed-off-by: Trevor Whitney <trevorjwhitney@gmail.com>	2 years ago
Trevor Whitney	dd94ebb87b	promql: set CounterResetHint after rate and sum Signed-off-by: Trevor Whitney <trevorjwhitney@gmail.com>	2 years ago

1 2

67 Commits (96e5a94d29707d2268feef7bd1c944ed53fd393e)