2679 Commits (836f1db04c9718bc8164e39d4dc98876c143524a)

 

All Branches   

Search

Author	SHA1	Message	Date
beorn7	836f1db04c	Improve MetricsForLabelMatchers ... WIP: This needs more tests. It now gets a from and through value, which it may opportunistically use to optimize the retrieval. With possible future range indices, this could be used in a very efficient way. This change merely applies some easy checks, which should nevertheless solve the use case of heavy rule evaluations on servers with a lot of series churn. Idea is the following: - Only archive series that are at least as old as the headChunkTimeout (which was already extremely unlikely to happen). - Then maintain a high watermark for the last archival, i.e. no archived series has a sample more recent than that watermark. - Any query that doesn't reach to a time before that watermark doesn't have to touch the archive index at all. (A production server at Soundcloud with the aforementioned series churn and heavy rule evaluations spends 50% of its CPU time in archive index lookups. Since rule evaluations usually only touch very recent values, most of those lookup should disappear with this change.) - Federation with a very broad label matcher will profit from this, too. As a byproduct, the un-needed MetricForFingerprint method was removed from the Storage interface.	9 years ago
beorn7	d77d625ad3	Merge branch 'master' into beorn7/storage6	9 years ago
Brian Brazil	84c421da8e	Merge pull request #1475 from prometheus/fabxc/targetsort ... Sort exported targets	9 years ago
Fabian Reinartz	f2e359962c	Sort exported targets	9 years ago
Fabian Reinartz	eb915ec40f	Merge pull request #1474 from prometheus/fabxc/spinfix ... Handle closed target provider channel	9 years ago
Fabian Reinartz	56fc9bdff3	Handle closed target provider channel ... This fixes the case where a target provider closes the update channel and exits before the context is canceled. This should only be true for the static provider but it's safer to generally handle this case.	9 years ago
Tobias Schmidt	2f151d02eb	Merge pull request #1456 from prometheus/validate-alertmanager-url ... Validate alertmanager URL	9 years ago
Tobias Schmidt	7763bbd993	Validate alertmanager URL	9 years ago
beorn7	167b83695c	Merge branch 'beorn7/storage5' into beorn7/storage6	9 years ago
beorn7	01795382c9	Merge branch 'beorn7/storage4' into beorn7/storage5	9 years ago
beorn7	c01658e20d	Merge branch 'beorn7/storage3' into beorn7/storage4	9 years ago
beorn7	f138847d31	Merge branch 'beorn7/storage2' into beorn7/storage3	9 years ago
beorn7	f7fc542db6	Merge branch 'master' into beorn7/storage4 ... Conflicts: storage/local/persistence.go	9 years ago
beorn7	3d86130d8c	Merge branch 'master' into beorn7/storage3	9 years ago
beorn7	1f30c8de8d	Merge branch 'master' into beorn7/storage2	9 years ago
beorn7	c13b1ecfe9	Make chunk iterators more DRY ... This finally extracts all the common code of the two chunk iterators into one. Any future chunk encodings with fast access by index can use the same iterator by simply providing an indexAccessor. Other future chunk encodings without fast index access (like Gorilla-style) can still implement the chunkIterator interface as usual.	9 years ago
beorn7	32f280a3cd	Slim down the chunkIterator interface ... For one, remove unneeded methods. Then, instead of using a channel for all values, use a bufio.Scanner-like interface. This removes the need for creating a goroutine and avoids the (unnecessary) locking performed by channel sending and receiving. This will make it much easier to write new chunk implementations (like Gorilla-style encoding).	9 years ago
Björn Rabenstein	1bd4c92e1f	Merge pull request #1457 from prometheus/beorn7/promtool ... Add a command to promtool that dumps metadata of heads.db	9 years ago
beorn7	b6fdb355d7	Move dump-heads into its own tool	9 years ago
beorn7	f193f2b8ef	Add a command to promtool that dumps metadata of heads.db ... I needed this today for debugging. It can certainly be improved, but it's already quite helpful. I refactored the reading of heads.db files out of persistence, which is an improvement, too. I made minor changes to the cli package to allow outputting via the io.Writer interface.	9 years ago
Fabian Reinartz	6bbb4af837	Merge pull request #1465 from prometheus/beorn7/fix-test2 ... Fix flaky file-sd test	9 years ago
beorn7	d44b83690e	Fix flaky file-sd test	9 years ago
Björn Rabenstein	2a2cc52828	Merge pull request #1405 from prometheus/beorn7/storage ... Streamline series iterator creation	9 years ago
Fabian Reinartz	5b9e85e556	Merge pull request #1404 from prometheus/scraperef2 ... Retrieval refactoring	9 years ago
Fabian Reinartz	6ceb7e7887	Merge pull request #1463 from mischief/linuxisms ... scripts: drop -f from hostname, openbsd does not support it	9 years ago
Nick Owens	53777e7bc4	scripts: drop -f from hostname, openbsd does not support it	9 years ago
Fabian Reinartz	8d2a73aff0	Merge pull request #1451 from pdbogen/origin/1446 ... rewrite operator balancing to be recursive	9 years ago
Patrick Bogen	250344b344	use short variable assignment	9 years ago
beorn7	fc7de5374a	Quarantine series upon problem writing to the series file ... This fixes https://github.com/prometheus/prometheus/issues/1059 , but not in the obvious way (simply not updating the persist watermark, because that's actually not that simple - we don't really know what has gone wrong exactly). As any errors relevant here are most likely caused by severe and unrecoverable problems with the series file, Using the now quarantine feature is the right step. We don't really have to be worried about any inconsistent state of the series because it will be removed for good ASAP. Another plus is that we don't have to declare the whole storage dirty anymore.	9 years ago
Fabian Reinartz	29e31dc3c6	Merge pull request #1452 from prometheus/fix-style-checker ... Detect code style violations in deeply nested files	9 years ago
Tobias Schmidt	d7889e61bb	Detect code style violations in deeply nested files ... So far the style check did not recognize issues in files in deeply nested directories, e.g. retrieval/discovery/kubernetes/discovery.go.	9 years ago
Patrick Bogen	2062fbae0f	rewrite operator balancing to be recursive	9 years ago
beorn7	0ea5801e47	Handle errors caused by data corruption more gracefully ... This requires all the panic calls upon unexpected data to be converted into errors returned. This pollute the function signatures quite lot. Well, this is Go... The ideas behind this are the following: - panic only if it's a programming error. Data corruptions happen, and they are not programming errors. - If we detect a data corruption, we "quarantine" the series, essentially removing it from the database and putting its data into a separate directory for forensics. - Failure during writing to a series file is not considered corruption automatically. It will call setDirty, though, so that a crashrecovery upon the next restart will commence and check for that. - Series quarantining and setDirty calls are logged and counted in metrics, but are hidden from the user of the interfaces in interface.go, whith the notable exception of Append(). The reasoning is that we treat corruption by removing the corrupted series, i.e. a query for it will return no results on its next call anyway, so return no results right now. In the case of Append(), we want to tell the user that no data has been appended, though. Minor side effects: - Now consistently using filepath.* instead of path.*. - Introduced structured logging where I touched it. This makes things less consistent, but a complete change to structured logging would be out of scope for this PR.	9 years ago
beorn7	8766f99085	Merge branch 'beorn7/storage2' into beorn7/storage3	9 years ago
beorn7	162f6fa6f6	Merge branch 'beorn7/storage' into beorn7/storage2	9 years ago
beorn7	79a2ae2d2e	Add missing test file	9 years ago
Fabian Reinartz	7a0c0c3ca2	Remove noise from CHANGELOG	9 years ago
Fabian Reinartz	1e7ce3ffdb	Bump version to 0.17.0	9 years ago
Fabian Reinartz	2bfb86d77c	Update changelog for 0.17.0 release	9 years ago
beorn7	b6840997a7	Merge branch 'beorn7/storage2' into beorn7/storage3	9 years ago
beorn7	ce58fd357b	Merge branch 'beorn7/storage' into beorn7/storage2 ... Conflicts: storage/local/chunk.go storage/local/interface.go	9 years ago
beorn7	2581648f70	Separate iterators by offset ... Add test that exposes the problem.	9 years ago
Fabian Reinartz	6adf77e411	Merge pull request #1447 from prometheus/fabxc/alertfix ... Make copying alerting state safer.	9 years ago
Fabian Reinartz	d89c254849	Make copying alerting state safer. ... This considers static labels in the equality of alerts to avoid falsely copying state from a different alert definition with the same name across reloads. To be safe, it also copies the state map rather than just its pointer so that remaining collisions disappear after one evaluation interval.	9 years ago
Fabian Reinartz	95c9706d2d	Fix missing comment period.	9 years ago
Fabian Reinartz	ddc74f712b	Add sortable target list	9 years ago
Julius Volz	9ea2465b99	Fix typo in lexer test.	9 years ago
Brian Brazil	ca31d36382	Merge pull request #1444 from prometheus/add-tests-for-string-parsing ... Add tests to specify the string escaping behavior	9 years ago
Tobias Schmidt	907b1380a7	Add tests to specify the string escaping behavior	9 years ago
Fabian Reinartz	5b78fdd6b7	Merge pull request #1439 from prometheus/fabxc/notifier ... Rename notification to notifier	9 years ago