prometheus

Commit Graph

Author	SHA1	Message	Date
Ziqi Zhao	e250f09b5d	change origin schema in `ReduceResolution` method of histogram and float histogram (#13116 ) * change origin schema in ReduceResolution method of histogram and float histogram Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> --------- Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	1 year ago
Ziqi Zhao	ab2a7bb74f	add generic shrink function (#13001 ) Add `ReduceResolution` method to `Histogram` and `FloatHistogram` This takes the original `mergeToSchema` function and turns it into a more generic `reduceResolution` function, which is the building block for the new methods. The methods will help with addressing #12864. --------- Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	1 year ago
Matthieu MOREL	05fba53e57	web : use Go standard package Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	1 year ago
Linas Medziunas	ebed7d0612	Change Validate to be a method on histogram structs Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	1 year ago
Linas Medziunas	1f8aea11d6	Move histogram validation code to model/histogram Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	1 year ago
Björn Rabenstein	fae4561369	Merge pull request #12954 from linasm/linasm/optimize-floatBucketIterator2 Histogram performance: optimize floatBucketIterator	1 year ago
Oleksandr Redko	fa90ca46e5	ci(lint): enable godot; append dot at the end of comments Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>	1 year ago
Linas Medžiūnas	e3e22abadb	Merge branch 'main' into linasm/optimize-floatBucketIterator2 Signed-off-by: Linas Medžiūnas <linasm@users.noreply.github.com>	1 year ago
Marc Tuduri	1ce066e51c	More periods Signed-off-by: Marc Tuduri <marctc@protonmail.com>	1 year ago
Marc Tuduri	af7c31ee10	PR feedback Signed-off-by: Marc Tuduri <marctc@protonmail.com>	1 year ago
Marc Tuduri	8fededf6ad	promql(histograms): Change sample total calculation for histograms Signed-off-by: Marc Tuduri <marctc@protonmail.com>	1 year ago
Linas Medziunas	62bbb81e29	Mention bucket values in the comment Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	1 year ago
Linas Medziunas	ec823d9daf	Update comments, bitwise comparison of float buckets Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	1 year ago
Linas Medziunas	c5c5c569fa	Histogram performance: optimize floatBucketIterator Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	1 year ago
Linas Medziunas	3c047a3518	Expand docs comments Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	1 year ago
Linas Medziunas	dfb6292600	Compare FloatHistogram.[Zero]Count float values as binary Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	1 year ago
Linas Medziunas	cbd01fc296	Fix NaN sum check in [Float]Histogram.Equals method Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	1 year ago
Gregor Zeitlinger	f01718262a	Unit tests for native histograms (#12668 ) promql: Extend testing framework to support native histograms This includes both the internal testing framework as well as the rules unit test feature of promtool. This also adds a bunch of basic tests. Many of the code level tests can now be converted to tests within the framework, and more tests can be added easily. --------- Signed-off-by: Harold Dost <h.dost@criteo.com> Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com> Signed-off-by: Stephen Lang <stephen.lang@grafana.com> Co-authored-by: Harold Dost <h.dost@criteo.com> Co-authored-by: Stephen Lang <stephen.lang@grafana.com> Co-authored-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>	1 year ago
zenador	54aaa2bd7e	Add `histogram_stdvar` and `histogram_stddev` functions (#12614 ) * Add new function: histogram_stdvar and histogram_stddev Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	1 year ago
Ziqi Zhao	de172049ab	fix lint error Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	1 year ago
Ziqi Zhao	d3633d4e76	Update model/histogram/float_histogram.go Co-authored-by: Björn Rabenstein <github@rabenste.in> Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	1 year ago
Ziqi Zhao	893f97556f	use switch instead of if-else to fix lint error Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	1 year ago
Ziqi Zhao	788061e509	remove unused addBucket function Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	1 year ago
Ziqi Zhao	eab3c93e80	make code ready for review Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	1 year ago
Ziqi Zhao	4787c879bc	add more elaborate benchmark test Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	1 year ago
Ziqi Zhao	bf880a6e77	enhance floathistogram add and sub method Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	1 year ago
Ziqi Zhao	ed1b307bca	enhance FloatHistogram CopyToSchema method (#12596 ) histogram: Improve performance of FloatHistogram.CopyToSchema Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> --------- Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com> Co-authored-by: Björn Rabenstein <github@rabenste.in>	1 year ago
beorn7	9aadd54786	histogram: Fix bounds of buckets returned by floatBucketIterator The bounds weren't really used so far, so no actual bug in the code so far. But it's obviously confusing if the bounds returned by a floatBucketIterator with a target schema different from the original schema are wrong. Signed-off-by: beorn7 <beorn@grafana.com>	1 year ago
cui fliter	096ceca44f	remove repetitive words (#12556 ) Signed-off-by: cui fliter <imcusg@gmail.com>	1 year ago
Ziqi Zhao	42d9169ba1	enhance histogram_quantile to get min/max value Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	1 year ago
Carrie Edwards	a462f7fa21	Add function for iterating through all buckets in reverse to find max bucket Signed-off-by: Carrie Edwards <edwrdscarrie@gmail.com>	1 year ago
zenador	191bf9055b	Handle more arithmetic operators for native histograms (#12262 ) Handle more arithmetic operators and aggregators for native histograms This includes operators for multiplication (formerly known as scaling), division, and subtraction. Plus aggregations for average and the avg_over_time function. Stdvar and stddev will (for now) ignore histograms properly (rather than counting them but adding a 0 for them). Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2 years ago
beorn7	5b53aa1108	style: Replace `else if` cascades with `switch` Wiser coders than myself have come to the conclusion that a `switch` statement is almost always superior to a statement that includes any `else if`. The exceptions that I have found in our codebase are just these two: * The `if else` is followed by an additional statement before the next condition (separated by a `;`). * The whole thing is within a `for` loop and `break` statements are used. In this case, using `switch` would require tagging the `for` loop, which probably tips the balance. Why are `switch` statements more readable? For one, fewer curly braces. But more importantly, the conditions all have the same alignment, so the whole thing follows the natural flow of going down a list of conditions. With `else if`, in contrast, all conditions but the first are "hidden" behind `} else if `, harder to spot and (for no good reason) presented differently from the first condition. I'm sure the aforemention wise coders can list even more reasons. In any case, I like it so much that I have found myself recommending it in code reviews. I would like to make it a habit in our code base, without making it a hard requirement that we would test on the CI. But for that, there has to be a role model, so this commit eliminates all `if else` occurrences, unless it is autogenerated code or fits one of the exceptions above. Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
Trevor Whitney	e3513d1dd2	Change nested ifs to a switch Signed-off-by: Trevor Whitney <trevorjwhitney@gmail.com>	2 years ago
Trevor Whitney	b4e324f637	Handle valid cases of mismatched hints when adding Signed-off-by: Trevor Whitney <trevorjwhitney@gmail.com>	2 years ago
Trevor Whitney	dd94ebb87b	promql: set CounterResetHint after rate and sum Signed-off-by: Trevor Whitney <trevorjwhitney@gmail.com>	2 years ago
Ganesh Vernekar	a87e7e9e33	tsdb: Add counter reset hint to histograms and support in WAL Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	2 years ago
Marc Tudurí	9474610baf	Support FloatHistogram in TSDB (#11522 ) Extends Appender.AppendHistogram function to accept the FloatHistogram. TSDB supports appending, querying, WAL replay, for this new type of histogram. Signed-off-by: Marc Tudurí <marctc@protonmail.com> Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> Co-authored-by: Ganesh Vernekar <ganeshvern@gmail.com>	2 years ago
beorn7	bf0847073d	histogram: Modify getBound to deal properly with infinity The bucket receiving math.MaxFloat64 observations now has math.MaxFloat64 as upper bound, while the bucket after it (the last possible bucket) has +Inf. This also adds a test for getBound and moves the getBound code to generic.go (where it should have been in the first place). Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
Björn Rabenstein	dccfb9db4e	histogram: Remove code replication via generics (#11361 ) * histogram: Simplify iterators We don't really need currLower and currUpper and can calculate it when needed (as already done for the floatBucketIterator). The calculation is cheap, while keeping those extra variables around costs RAM (potentially a lot with many iterators). * histogram: Convert Bucket/FloatBucket to one generic type * histogram: Move some bucket iterator code into generic base iterator * histogram: Remove cumulative iterator for FloatHistogram We added it in the past for completeness (Histogram has one), but it has never been used. Plus, even the cumulative iterator for Histogram is only there for test reasons. We can always add it back, and then maybe even using generics. Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
beorn7	a7c519930e	histograms: Add Compact method to the normal integer Histogram And use the new method to call to compact Histograms during parsing. This happens for both `Histogram` and `FloatHistogram`. In this way, if targets decide to optimize the exposition size by merging spans with empty buckets in between, we still get a normalized results. It will also normalize away any valid but weird representations like empty spans, spans with offset zero, and empty buckets at the start or end of a span. The implementation seemed easy at first as it just turns the `compactBuckets` helper into a generic function (which now got its own file). However, the integer Histograms have delta buckets instead of absolute buckets, which had to be treated specially in the generic `compactBuckets` function. To make sure it works, I have added plenty of explicit tests for `Histogram` in addition to the `FloatHistogram` tests. I have also updated the doc comment for the `Compact` method. Based on the insights now expressed in the doc comment, compacting with a maxEmptyBuckets > 0 is rarely useful. Therefore, this commit also sets the value to 0 in the two cases we were using 3 so far. We might still want to reconsider, so I don't want to remove the maxEmptyBuckets parameter right now. Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
Ganesh Vernekar	2474c6fb2c	Error on amending histograms on append (#11308 ) * Error on amending histograms on append Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> * Rename Matches to Equals Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com> Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	2 years ago
beorn7	2d233cf95e	Histogram: Fix allFloatBucketIterator If the zero threshold overlaps with the highest negative bucket and/or the lowest positive bucket, its upper or lower boundary, respectively, has to be adjusted. In valid histograms, only ever the highest negative bucket and/or the lowest positive bucket may overlap with the zero bucket. This is assumed in this code to simplify the checks. Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
beorn7	56db51c826	Histgram: Fix Compact for spans of only empty buckets Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
beorn7	15583af9bb	Histogram: Fix crash when compacting only empty buckets Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
beorn7	08efde4de5	Adjust to newest gofumpt Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
beorn7	f9c411604d	Fix spelling errors Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
beorn7	9fbcf14e5c	histogram: Handle changes of the ZeroThreshold and the Schema Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
Björn Rabenstein	ec80745884	Merge pull request #10075 from prometheus/beorn7/histogram model: Implement FloatHistogram.Compact	3 years ago
beorn7	3b4d6c3fdb	model: Implement FloatHistogram.Compact Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago

1 2

61 Commits (7e2c6fc8f3e0e42927325bdac623ea848575a66e)