prometheus

Commit Graph

Author	SHA1	Message	Date
beorn7	7f912db15a	promql: Fix limiting of extrapolation to negative values This is a bit tough to explain, but I'll try: `rate` & friends have a sophisticated extrapolation algorithm. Usually, we extrapolate the result to the total interval specified in the range selector. However, if the first sample within the range is too far away from the beginning of the interval, or if the last sample within the range is too far away from the end of the interval, we assume the series has just started half a sampling interval before the first sample or after the last sample, respectively, and shorten the extrapolation interval correspondingly. We calculate the sampling interval by looking at the average time between samples within the range, and we define "too far away" as "more than 110% of that sampling interval". However, if this algorithm leads to an extrapolated starting value that is negative, we limit the start of the extrapolation interval to the point where the extrapolated starting value is zero. At least that was the intention. What we actually implemented is the following: If extrapolating all the way to the beginning of the total interval would lead to an extrapolated negative value, we would only extrapolate to the zero point as above, even if the algorithm above would have selected a starting point that is just half a sampling interval before the first sample and that starting point would not have an extrapolated negative value. In other word: What was meant as a _limitation_ of the extrapolation interval yielded a _longer_ extrapolation interval in this case. There is an exception to the case just described: If the increase of the extrapolation interval is more than 110% of the sampling interval, we suddenly drop back to only extrapolate to half a sampling interval. This behavior can be nicely seen in the testcounter_zero_cutoff test, where the rate goes up all the way to 0.7 and then jumps back to 0.6. This commit changes the behavior to what was (presumably) intended from the beginning: The extension of the extrapolation interval is only limited if actually needed to prevent extrapolation to negative values, but the "limitation" never leads to _more_ extrapolation anymore. The difference is subtle, and probably it never bothered anyone. However, if you calculate a rate of a classic histograms, the old behavior might create non-monotonic histograms as a result (because of the jumps you can see nicely in the old version of the testcounter_zero_cutoff test). With this fix, that doesn't happen anymore. Signed-off-by: beorn7 <beorn@grafana.com>	9 months ago
beorn7	384ab025e0	promql: Expose issue #11708 The shorter range in the test makes early points drop out of the range in range queries, exposing the issue. Signed-off-by: beorn7 <beorn@grafana.com>	10 months ago
Faustas Butkus	6feffeb92e	promql: add histogram_avg function (#13467 ) Add histogram_avg function --------- Signed-off-by: Faustas Butkus <faustas.butkus@gmail.com> Signed-off-by: Björn Rabenstein <github@rabenste.in> Co-authored-by: Björn Rabenstein <github@rabenste.in>	10 months ago
Filip Petkovski	a577a0a542	Fix last_over_time for native histograms The last_over_time retains a histogram sample without making a copy. This sample is now coming from the buffered iterator used for windowing functions, and can be reused for reading subsequent samples as the iterator progresses. I would propose copying the sample in the last_over_time function, similar to how it is done for rate, sum_over_time and others. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>	10 months ago
Ivan Babrou	a6b35ff304	promql: use natural sort in sort_by_label and sort_by_label_desc (#13411 ) These functions are intended for humans, as robots can already sort the results however they please. Humans like things sorted "naturally": * https://blog.codinghorror.com/sorting-for-humans-natural-sort-order/ A similar thing has been done to Grafana, which is also used by humans: * https://github.com/grafana/grafana/pull/78024 * https://github.com/grafana/grafana/pull/78494 Signed-off-by: Ivan Babrou <github@ivan.computer>	10 months ago
Jeanette Tan	2910b48180	Make mad_over_time experimental and move tests Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	1 year ago
Alexander Trost	5051a993ab	promql: add sort_by_label and sort_by_label_desc functions This adds functions to sort a vector by its label value. Based on https://github.com/prometheus/prometheus/pull/1533 Signed-off-by: Alexander Trost <galexrt@googlemail.com>	1 year ago
Gregor Zeitlinger	f01718262a	Unit tests for native histograms (#12668 ) promql: Extend testing framework to support native histograms This includes both the internal testing framework as well as the rules unit test feature of promtool. This also adds a bunch of basic tests. Many of the code level tests can now be converted to tests within the framework, and more tests can be added easily. --------- Signed-off-by: Harold Dost <h.dost@criteo.com> Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com> Signed-off-by: Stephen Lang <stephen.lang@grafana.com> Co-authored-by: Harold Dost <h.dost@criteo.com> Co-authored-by: Stephen Lang <stephen.lang@grafana.com> Co-authored-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>	1 year ago
Julius Volz	531567d46e	Drop metric name for "atan2" binary operator The operator changes the meaning of the metric, so the metric name should be dropped. Technically this would be a breaking change, but it's also very obviously a bug and not likely that anyone depends on it. Signed-off-by: Julius Volz <julius.volz@gmail.com>	1 year ago
Ivo Gosemann	e22b54e253	Adds day_of_year function to PromQL Signed-off-by: Ivo Gosemann <ivo.gosemann@sap.com>	3 years ago
jyz0309	e40deb1086	address comment Signed-off-by: jyz0309 <45495947@qq.com>	3 years ago
jyz0309	02e032884a	add doc Signed-off-by: jyz0309 <45495947@qq.com>	3 years ago
jyz0309	7f32a5d0d6	add NaN case Signed-off-by: jyz0309 <45495947@qq.com>	3 years ago
Björn Rabenstein	be7ed73efc	Merge pull request #10140 from David-N-Perkins/ISS-9910 Issue 9910	3 years ago
beorn7	c2b80d8643	PromQL: Test negative offset in PromQL tests Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
David N Perkins	52662e8105	Added metric name to histogram quartile binning and associated unit test Signed-off-by: David N Perkins <David.N.Perkins@ibm.com>	3 years ago
beorn7	c00c6ed01f	promql: Add more test cases for `histogram_quantile` This is motivated by the doubts raised in #7970. Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
Julien Pivotto	c812ee794e	PromQL: Comment flaky test (#9545 ) Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	3 years ago
Julien Pivotto	a18224d02d	make aggregations deterministic (#9459 ) * Add deterministic test for aggregations Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu> * Make aggregations deterministic Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu> * Increase testing Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	3 years ago
ziollek	55f9147b44	Add atan2 to scalar operators - issue #9485 (#9515 ) * Add atan2 to scalar operators Signed-off-by: Tomasz Ziolkowski <tomasz.ziolkowski@allegro.pl>	3 years ago
Levi Harrison	587cb95093	Add operator tests Signed-off-by: Levi Harrison <git@leviharrison.dev>	3 years ago
Levi Harrison	6faca22eec	Add inverse hyperbolic functions Signed-off-by: Levi Harrison <git@leviharrison.dev>	3 years ago
Levi Harrison	53d88fd147	Added hyperbolic trig functions Signed-off-by: Levi Harrison <git@leviharrison.dev>	3 years ago
Levi Harrison	a8ad569db8	Change spaces to tabs Signed-off-by: Levi Harrison <git@leviharrison.dev>	3 years ago
Levi Harrison	f1d94cc5f6	Split and shortened tests Signed-off-by: Levi Harrison <git@leviharrison.dev>	3 years ago
Levi Harrison	814cd5844d	Added tests Signed-off-by: Levi Harrison <git@leviharrison.dev>	3 years ago
Darshan Chaudhary	c4f2e9eec5	Add present_over_time (#9097 ) * Add present_over_time Signed-off-by: darshanime <deathbullet@gmail.com> * Add tests for present_over_time Signed-off-by: darshanime <deathbullet@gmail.com> * Address PR comments Signed-off-by: darshanime <deathbullet@gmail.com> * Add documentation for present_over_time Signed-off-by: darshanime <deathbullet@gmail.com> * Update documentation Signed-off-by: darshanime <deathbullet@gmail.com> * Update documentation comment Signed-off-by: darshanime <deathbullet@gmail.com>	3 years ago
pschou	aff3c702ab	promql: Add sgn, clamp and last_over_time functions (#8457 ) * Add sgn, clamp and last_over_time functions Signed-off-by: schou <pschou@users.noreply.github.com>	4 years ago
Ganesh Vernekar	9199fcb8d1	'@ <timestamp>' modifier (#8121 ) This commit adds `@ <timestamp>` modifier as per this design doc: https://docs.google.com/document/d/1uSbD3T2beM-iX4-Hp7V074bzBRiRNlqUdcWP6JTDQSs/edit. An example query: ``` rate(process_cpu_seconds_total[1m]) and topk(7, rate(process_cpu_seconds_total[1h] @ 1234)) ``` which ranks based on last 1h rate and w.r.t. unix timestamp 1234 but actually plots the 1m rate. Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	4 years ago
Ganesh Vernekar	d30da66d77	Fix timestamp() method for vector selector inside paren (#8164 ) Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	4 years ago
Harold Dost	bf7c771f54	promql: Organize legacy tests into appropriate files (#7989 ) * Separate tests into: Aggregators Functions Operators Selectors * Remove simple files and place tests into other files. * Eliminate some of the _over_time tests since there are already plenty of edge cases present in the functions.test file. Relates to #740 Signed-off-by: Harold Dost <harolddost@gmail.com>	4 years ago
Brian Brazil	924ce978b7	Don't do literal regex matching optimisation when case insensitive. (#8013 ) Fixes #7994 Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>	4 years ago
Julien Pivotto	6f9e7ff750	Drop metric name in bool comparison between two instant vectors (#7819 ) * Drop metric name in bool comparison between two instant vectors Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	4 years ago
Julien Pivotto	20ab94fedf	Hints: Separating out the range and offsets of PromQL subqueries (#7667 ) Fix #7629 Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	4 years ago
Julien Pivotto	d77b56e88e	Fix avg_over_time for nan and float64 overflows (#7346 ) * Fix avg_over_time with Inf and NaN values Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	4 years ago
Julien Pivotto	72425d4e3d	Add group() aggregator (#7480 ) * Add group() aggregator Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	4 years ago
Linas Medžiūnas	7eaffa7180	Fix off-by-one error in funcHistogramQuantile / ensureMonotonic (#7393 ) * Fix off-by-one error in funcHistogramQuantile / ensureMonotonic * Additional coverage for nonmonotonic histogram buckets Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	5 years ago
B++	d6374ae1b6	Return NaN for histogram_quantile when buckets have 0 observations (#7318 ) Signed-off-by: jberny <f.bernardi89@gmail.com>	5 years ago
Callum Styan	5bb7f00d00	change labelset comparison in promql engine to avoid false positive during detection of duplicates (#7058 ) * Use go1.14 new hash/maphash to hash both RHS and LHS instead of XOR'ing which has been resulting in hash collisions. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Refactor engine labelset signature generation, just use labels.Labels instead of hashes. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Address review comments; function comments + store result of lhs.String+rhs.String as key. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Replace all signatureFunc usage with signatureFuncString. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Make optimizations to labels String function and generation of rhs+lhs as string in resultMetric. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Use separate string functions that don't use strconv just for engine maps. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Use a byte invalid separator instead of quoting and have a buffer attached to EvalNodeHelper instead of using a global pool in the labels package. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Address review comments. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Address more review comments, labels has a function that now builds a byte slice without turning it into a string. Signed-off-by: Callum Styan <callumstyan@gmail.com> * Use two different non-ascii hex codes as byte separators between labels and between sets of labels when building bytes of a Labels struct. Signed-off-by: Callum Styan <callumstyan@gmail.com> * We only need the 2nd byte invalid sep. at the beginning of a labels.Bytes Signed-off-by: Callum Styan <callumstyan@gmail.com>	5 years ago
Tobias Guggenmos	3a204be6b7	PromQL: Fix string and parentheses handling in engine (#6612 ) * WIP: PromQL: Allow engine to return strings Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com> * Add test suggested by @roidelapluie Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com> * Fix typo in React UI Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com> * Fix parenthesis handling for functions and aggregator params Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com> * Add more tests Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com> * Fix React UI test Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Tobias Guggenmos	d8bc24349c	PromQL: Fix unary operator precedence (#6579 ) * PromQL: Fix unary operator precedence Fixes #6575 Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Julien Pivotto	e0afec906f	add absent_over_time (#6490 ) * Implement absent_over_time Fixes #2882 Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Julien Pivotto	4b3bab890d	Fix absent output where two label matchers are identical (#6493 ) Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Julius Volz	bc1c7f1809	Fix scalar-vector comparisons (#5454 ) * Fix scalar-vector comparisons Fixes https://github.com/prometheus/prometheus/issues/5452 Signed-off-by: Julius Volz <julius.volz@gmail.com>	6 years ago
Daisy T	683fbc59ec	exponentation operator to drop metric name in result of op operation (#5329 ) Signed-off-by: Daisy T <daisyts@gmx.com>	6 years ago
Brian Brazil	858c363e94	Fix panic when aggregator param is not a literal. The return value for checkForSeriesSetExpansion is always nil, simplify. Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>	6 years ago
Brian Brazil	c66aeb3fff	In histogram_quantile merge buckets with equivalent le values (#5158 ) This makes things generally more resilient, and will help with OpenMetrics transitions (and inconsistencies). Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>	6 years ago
Ganesh Vernekar	dbe55c1352	Subquery (#4831 ) Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	6 years ago
Ben Kochie	c6399296dc	Fix spelling/typos (#4921 ) * Fix spelling/typos Fix spelling/typos reported by codespell/misspell. * UK -> US spelling changes. Signed-off-by: Ben Kochie <superq@gmail.com>	6 years ago
Thomas Jackson	abf6fe0a98	Change max/min over_time to handle NaNs properly (#4386 ) We only want to return a NaN if the NaN is the only value Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com> Fixes #4385	6 years ago

1 2 3

132 Commits (7aacef9b42a275f7ad8f60a707abb6de2a5d1448)