13 Commits (75fc8a1535c5fd1acca6036b349e76a42a1f6ddf)

Author	SHA1	Message	Date
Oleksandr Redko	2a75604f8e	Enable default revive rules (#13068) ... Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>	1 year ago
zenador	ccfe14d7e7	PromQL: ignore small errors for bucketQuantile (#13153) ... promql: Improve histogram_quantile calculation for classic buckets Tiny differences between classic buckets are most likely caused by floating point precision issues. With this commit, relative changes below a certain threshold are ignored. This makes the result of histogram_quantile more meaningful, and also avoids triggering the _input to histogram_quantile needed to be fixed for monotonicity_ annotations in unactionable cases. This commit also adds explanation of the new adjustment and of the monotonicity annotation to the documentation of `histogram_quantile`. --------- Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	1 year ago
Matthieu MOREL	fe057fc60d	use Go standard errors package ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	1 year ago
Julien Pivotto	f568221610	Merge pull request #13057 from prometheus/release-2.48 ... Merge release-2.48 back into main	1 year ago
Oleksandr Redko	8e5f0387a2	ci(lint): enable nolintlint and remove redundant comments (#12926) ... Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>	1 year ago
Jeanette Tan	754e7df97e	Make it possible to unwrap annotation errors ... Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	1 year ago
Jeanette Tan	72cc93d225	Hide position info for warnings when position is unknown (empty query string passed in) ... Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	1 year ago
zenador	80e977aae6	Remove `NewPossibleNonCounterInfo` and minimise creating empty annotations (#13012) ... * Remove NewPossibleNonCounterInfo until it can be made more efficient, and avoid creating empty annotations as much as possible Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	1 year ago
Jeanette Tan	9a8bd8eac6	Fix possible non-counter warning for empty names and native histograms ... Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	1 year ago
Julius Volz	191c24a0ed	Fix: Exempt "_bucket" suffix from PossibleNonCounterInfo warning (#12982) ... Related to PR #12152 Signed-off-by: Julius Volz <julius.volz@gmail.com> Signed-off-by: Levi Harrison <git@leviharrison.dev>	1 year ago
Jeanette Tan	0cbf0c1c68	Revise according to code review ... Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	1 year ago
Jeanette Tan	feaa93da77	Add warning when monotonicity is forced in the input to histogram_quantile ... Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	1 year ago
zenador	69edd8709b	Add warnings (and annotations) to PromQL query results (#12152) ... Return annotations (warnings and infos) from PromQL queries This generalizes the warnings we have already used before (but only for problems with remote read) as "annotations". Annotations can be warnings or infos (the latter could be false positives). We do not treat them different in the API for now and return them all as "warnings". It would be easy to distinguish them and return infos separately, should that appear useful in the future. The new annotations are then used to create a lot of warnings or infos during PromQL evaluations. Partially these are things we have wanted for a long time (e.g. inform the user that they have applied `rate` to a metric that doesn't look like a counter), but the new native histograms have created even more needs for those annotations (e.g. if a query tries to aggregate float numbers with histograms). The annotations added here are not yet complete. A prominent example would be a warning about a range too short for a rate calculation. But such a warnings is more tricky to create with good fidelity and we will tackle it later. Another TODO is to take annotations into account when evaluating recording rules. --------- Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	1 year ago