prometheus

Commit Graph

Author	SHA1	Message	Date
beorn7	817a2396cb	Name float values as "floats", not as "values" In the past, every sample value was a float, so it was fine to call a variable holding such a float "value" or "sample". With native histograms, a sample might have a histogram value. And a histogram value is still a value. Calling a float value just "value" or "sample" or "V" is therefore misleading. Over the last few commits, I already renamed many variables, but this cleans up a few more places where the changes are more invasive. Note that we do not to attempt naming in the JSON APIs or in the protobufs. That would be quite a disruption. However, internally, we can call variables as we want, and we should go with the option of avoiding misunderstandings. Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
beorn7	630bcb494b	storage: Use separate sample types for histogram vs. float Previously, we had one “polymorphous” `sample` type in the `storage` package. This commit breaks it up into `fSample`, `hSample`, and `fhSample`, each still implementing the `tsdbutil.Sample` interface. This reduces allocations in `sampleRing.Add` but inflicts the penalty of the interface wrapper, which makes things worse in total. This commit therefore just demonstrates the step taken. The next commit will tackle the interface overhead problem. Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
beorn7	c0879d64cf	promql: Separate `Point` into `FPoint` and `HPoint` In other words: Instead of having a “polymorphous” `Point` that can either contain a float value or a histogram value, use an `FPoint` for floats and an `HPoint` for histograms. This seemingly small change has a _lot_ of repercussions throughout the codebase. The idea here is to avoid the increase in size of `Point` arrays that happened after native histograms had been added. The higher-level data structures (`Sample`, `Series`, etc.) are still “polymorphous”. The same idea could be applied to them, but at each step the trade-offs needed to be evaluated. The idea with this change is to do the minimum necessary to get back to pre-histogram performance for functions that do not touch histograms. Here are comparisons for the `changes` function. The test data doesn't include histograms yet. Ideally, there would be no change in the benchmark result at all. First runtime v2.39 compared to directly prior to this commit: ``` name old time/op new time/op delta RangeQuery/expr=changes(a_one[1d]),steps=1-16 391µs ± 2% 542µs ± 1% +38.58% (p=0.000 n=9+8) RangeQuery/expr=changes(a_one[1d]),steps=10-16 452µs ± 2% 617µs ± 2% +36.48% (p=0.000 n=10+10) RangeQuery/expr=changes(a_one[1d]),steps=100-16 1.12ms ± 1% 1.36ms ± 2% +21.58% (p=0.000 n=8+10) RangeQuery/expr=changes(a_one[1d]),steps=1000-16 7.83ms ± 1% 8.94ms ± 1% +14.21% (p=0.000 n=10+10) RangeQuery/expr=changes(a_ten[1d]),steps=1-16 2.98ms ± 0% 3.30ms ± 1% +10.67% (p=0.000 n=9+10) RangeQuery/expr=changes(a_ten[1d]),steps=10-16 3.66ms ± 1% 4.10ms ± 1% +11.82% (p=0.000 n=10+10) RangeQuery/expr=changes(a_ten[1d]),steps=100-16 10.5ms ± 0% 11.8ms ± 1% +12.50% (p=0.000 n=8+10) RangeQuery/expr=changes(a_ten[1d]),steps=1000-16 77.6ms ± 1% 87.4ms ± 1% +12.63% (p=0.000 n=9+9) RangeQuery/expr=changes(a_hundred[1d]),steps=1-16 30.4ms ± 2% 32.8ms ± 1% +8.01% (p=0.000 n=10+10) RangeQuery/expr=changes(a_hundred[1d]),steps=10-16 37.1ms ± 2% 40.6ms ± 2% +9.64% (p=0.000 n=10+10) RangeQuery/expr=changes(a_hundred[1d]),steps=100-16 105ms ± 1% 117ms ± 1% +11.69% (p=0.000 n=10+10) RangeQuery/expr=changes(a_hundred[1d]),steps=1000-16 783ms ± 3% 876ms ± 1% +11.83% (p=0.000 n=9+10) ``` And then runtime v2.39 compared to after this commit: ``` name old time/op new time/op delta RangeQuery/expr=changes(a_one[1d]),steps=1-16 391µs ± 2% 547µs ± 1% +39.84% (p=0.000 n=9+8) RangeQuery/expr=changes(a_one[1d]),steps=10-16 452µs ± 2% 616µs ± 2% +36.15% (p=0.000 n=10+10) RangeQuery/expr=changes(a_one[1d]),steps=100-16 1.12ms ± 1% 1.26ms ± 1% +12.20% (p=0.000 n=8+10) RangeQuery/expr=changes(a_one[1d]),steps=1000-16 7.83ms ± 1% 7.95ms ± 1% +1.59% (p=0.000 n=10+8) RangeQuery/expr=changes(a_ten[1d]),steps=1-16 2.98ms ± 0% 3.38ms ± 2% +13.49% (p=0.000 n=9+10) RangeQuery/expr=changes(a_ten[1d]),steps=10-16 3.66ms ± 1% 4.02ms ± 1% +9.80% (p=0.000 n=10+9) RangeQuery/expr=changes(a_ten[1d]),steps=100-16 10.5ms ± 0% 10.8ms ± 1% +3.08% (p=0.000 n=8+10) RangeQuery/expr=changes(a_ten[1d]),steps=1000-16 77.6ms ± 1% 78.1ms ± 1% +0.58% (p=0.035 n=9+10) RangeQuery/expr=changes(a_hundred[1d]),steps=1-16 30.4ms ± 2% 33.5ms ± 4% +10.18% (p=0.000 n=10+10) RangeQuery/expr=changes(a_hundred[1d]),steps=10-16 37.1ms ± 2% 40.0ms ± 1% +7.98% (p=0.000 n=10+10) RangeQuery/expr=changes(a_hundred[1d]),steps=100-16 105ms ± 1% 107ms ± 1% +1.92% (p=0.000 n=10+10) RangeQuery/expr=changes(a_hundred[1d]),steps=1000-16 783ms ± 3% 775ms ± 1% -1.02% (p=0.019 n=9+9) ``` In summary, the runtime doesn't really improve with this change for queries with just a few steps. For queries with many steps, this commit essentially reinstates the old performance. This is good because the many-step queries are the one that matter most (longest absolute runtime). In terms of allocations, though, this commit doesn't make a dent at all (numbers not shown). The reason is that most of the allocations happen in the sampleRingIterator (in the storage package), which has to be addressed in a separate commit. Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
Hayk Davtyan	408f31f786	[WebUI/ScrapePoolList] Case-insensitive search of "Scrape Pools" (#12207 ) Signed-off-by: hayk96 <hayko5999@gmail.com>	2 years ago
Alison	3ac49d4ae2	Set SourceMap to false to fix UI in MCR builds (#12175 ) * Set sourceMap to false Signed-off-by: Alison Burgess <alburgess@microsoft.com> * add sourcemap=false to package.json build Signed-off-by: Alison Burgess <alburgess@microsoft.com> * set sourcemap to true in tsconfig Signed-off-by: Alison Burgess <alburgess@microsoft.com> --------- Signed-off-by: Alison Burgess <alburgess@microsoft.com> Co-authored-by: Alison Burgess <alburgess@microsoft.com>	2 years ago
Julien Pivotto	de50efbf7a	Merge pull request #12165 from prometheus/release-2.43 Merge 2.43 in main	2 years ago
Julien Pivotto	1070c9b06c	Release 2.43.0 Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Julien Pivotto	2c6168be5f	Release 2.43.0-rc.1 Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
pbudner	46683eadf7	fix: advertise correct flag to enable remote write receiver Signed-off-by: pbudner <mail@pascalbudner.de>	2 years ago
Julien Pivotto	b6d91e8bf8	Release 2.43.0-rc.0 Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Julien Pivotto	db2d759b81	Add support for lookbackdelta per query via the API Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Julien Pivotto	8e4350dd59	Directly include SVG logo in the page. Use HTML <svg> element to include Prometheus logo in the status page. Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Shan Aminzadeh	3f6f5d3357	Scope GroupBy labels to metric (#11914 ) Signed-off-by: Shan Aminzadeh <shan.aminzadeh@chronosphere.io>	2 years ago
Fish-pro	43d77f7c41	Use http constants instead of string Signed-off-by: Fish-pro <zechun.chen@daocloud.io>	2 years ago
Julien Pivotto	c70d85baed	Merge pull request #11916 from prometheus/release-2.42 Merge 2.42 to main	2 years ago
Kemal Akkoyun	225c61122d	Cut v2.42.0 (#11912 ) Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>	2 years ago
Kemal Akkoyun	7b9cc7eea3	Cut v2.42.0-rc.0 (#11902 ) * Cut v2.42.0-rc.0 Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Add missing log items Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>	2 years ago
Bartlomiej Plotka	6dcfb71740	Merge pull request #11897 from pracucci/propose-to-change-query-canceled-status-code API: change HTTP status code from 503/422 to 499 if a request is canceled	2 years ago
Marco Pracucci	3db77b4491	API: change HTTP status code tracked in metrics form 503/422 to 499 if a request is canceled Signed-off-by: Marco Pracucci <marco@pracucci.com>	2 years ago
Kemal Akkoyun	bab3b4e3c3	Upgrade dependencies Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>	2 years ago
Kemal Akkoyun	ae597cac62	Upgrade several UI dependencies (#11894 ) * build(deps): bump @codemirror/autocomplete in /web/ui Bumps [@codemirror/autocomplete](https://github.com/codemirror/autocomplete) from 6.3.0 to 6.4.0. - [Release notes](https://github.com/codemirror/autocomplete/releases) - [Changelog](https://github.com/codemirror/autocomplete/blob/main/CHANGELOG.md) - [Commits](https://github.com/codemirror/autocomplete/compare/6.3.0...6.4.0) --- updated-dependencies: - dependency-name: "@codemirror/autocomplete" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump @fortawesome/fontawesome-svg-core in /web/ui Bumps [@fortawesome/fontawesome-svg-core](https://github.com/FortAwesome/Font-Awesome) from 6.2.0 to 6.2.1. - [Release notes](https://github.com/FortAwesome/Font-Awesome/releases) - [Changelog](https://github.com/FortAwesome/Font-Awesome/blob/6.x/CHANGELOG.md) - [Commits](https://github.com/FortAwesome/Font-Awesome/compare/6.2.0...6.2.1) --- updated-dependencies: - dependency-name: "@fortawesome/fontawesome-svg-core" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>	2 years ago
Julien Pivotto	44ef49805c	Merge pull request #11890 from prometheus/release-2.41 Merge back Release 2.41	2 years ago
Shan Aminzadeh	cdfd18ce00	[lezer-promql] Fix package.json main to point to correct cjs module (#11888 ) Signed-off-by: Shan Aminzadeh <shan.aminzadeh@chronosphere.io>	2 years ago
Julien Pivotto	2c408289f8	Add stabilizing to UI Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Julien Pivotto	ce55e5074d	Add 'keep_firing_for' field to alerting rules This commit adds a new 'keep_firing_for' field to Prometheus alerting rules. The 'resolve_delay' field specifies the minimum amount of time that an alert should remain firing, even if the expression does not return any results. This feature was discussed at a previous dev summit, and it was determined that a feature like this would be useful in order to allow the expression time to stabilize and prevent confusing resolved messages from being propagated through Alertmanager. This approach is simpler than having two PromQL queries, as was sometimes discussed, and it should be easy to implement. This commit does not include tests for the 'resolve_delay' field. This is intentional, as the purpose of this commit is to gather comments on the proposed design of the 'resolve_delay' field before implementing tests. Once the design of the 'resolve_delay' field has been finalized, a follow-up commit will be submitted with tests." See https://github.com/prometheus/prometheus/issues/11570 Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
beorn7	d121db7a65	federate: Fix PeekBack usage In most cases, there is no sample at `maxt`, so `PeekBack` has to be used. So far, `PeekBack` did not return a float histogram, and we disregarded even any returned normal histogram. This fixes both, and also tweaks the unit test to discover the problem (by using an earlier timestamp than "now" for the samples in the TSDB). Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
Ganesh Vernekar	7a88bc3581	Test federation with native histograms Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	2 years ago
Ganesh Vernekar	33f880d123	Add native histogram support in federation Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	2 years ago
Levi Harrison	3b4cbf8da4	Inject readiness state through context (#11617 ) Signed-off-by: Levi Harrison <git@leviharrison.dev> Signed-off-by: Levi Harrison <git@leviharrison.dev>	2 years ago
Aleksey Smirnov	84c6f0e584	Init value for useState hook calls once (#11802 ) Signed-off-by: Smirnov Aleksey <aleksey.smirnov@sbermarket.ru> Signed-off-by: Smirnov Aleksey <aleksey.smirnov@sbermarket.ru> Co-authored-by: Smirnov Aleksey <aleksey.smirnov@sbermarket.ru>	2 years ago
Łukasz Mierzwa	e1b7082008	Show individual scrape pools on /targets page (#11142 ) * Add API endpoints for getting scrape pool names This adds api/v1/scrape_pools endpoint that returns the list of names of all the scrape pools configured. Having it allows to find out what scrape pools are defined without having to list and parse all targets. The second change is adding scrapePool query parameter support in api/v1/targets endpoint, that allows to filter returned targets by only finding ones for passed scrape pool name. Both changes allow to query for a specific scrape pool data, rather than getting all the targets for all possible scrape pools. The problem with api/v1/targets endpoint is that it returns huge amount of data if you configure a lot of scrape pools. Signed-off-by: Łukasz Mierzwa <l.mierzwa@gmail.com> * Add a scrape pool selector on /targets page Current targets page lists all possible targets. This works great if you only have a few scrape pools configured, but for systems with a lot of scrape pools and targets this slow things down a lot. Not only does the /targets page load very slowly in such case (waiting for huge API response) but it also take a long time to render, due to huge number of elements. This change adds a dropdown selector so it's possible to select only intersting scrape pool to view. There's also scrapePool query param that will open selected pool automatically. Signed-off-by: Łukasz Mierzwa <l.mierzwa@gmail.com> Signed-off-by: Łukasz Mierzwa <l.mierzwa@gmail.com>	2 years ago
Julien Pivotto	d7937d4be2	Release 2.41.0 Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Bryan Boreham	fd57569683	Update package web tests for new labels.Labels type Use `FromStrings` instead of assuming the data structure. And don't sort individual labels, since `labels.Labels` are always sorted. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Bryan Boreham	5bc4643122	Update package web for new labels.Labels type Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Bryan Boreham	3c7de69059	storage: allow re-use of iterators Patterned after `Chunk.Iterator()`: pass the old iterator in so it can be re-used to avoid allocating a new object. (This commit does not do any re-use; it is just changing all the method signatures so re-use is possible in later commits.) Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Julien Pivotto	75af6531e4	Release v2.41.0-rc.0 Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Julien Pivotto	475cfe8a6b	Merge remote-tracking branch 'origin/release-2.40' Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Julien Pivotto	106d06a032	Release 2.40.7 We have 2 bugfixes, one which is important for Windows users and another one on native histograms. I think it is worth cutting another bugfix release before 2.41 comes out. Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Julien Pivotto	5198eac6f4	Release 2.40.6 with security fixes Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Julien Pivotto	0b302f8a39	Merge pull request #11662 from prometheus/release-2.40 Merge back release-2.40 branch again	2 years ago
Ganesh Vernekar	44af4716c8	Cut v2.40.5 (#11646 ) Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	2 years ago
Julien Pivotto	0372e259ba	Merge pull request #11634 from prometheus/release-2.40 Merge release-2.40 branch into main	2 years ago
Julien Pivotto	31a2db3ae9	Fix Basic Authentication Bypass (CVE-2022-46146) Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Bryan Boreham	6bdecf377c	Switch from 'sanity' to more inclusive lanuage (#9376 ) * Switch from 'sanity' to more inclusive lanuage "Removing ableist language in code is important; it helps to create and maintain an environment that welcomes all developers of all backgrounds, while emphasizing that we as developers select the most articulate, precise, descriptive language we can rather than relying on metaphors. The phrase sanity check is ableist, and unnecessarily references mental health in our code bases. It denotes that people with mental illnesses are inferior, wrong, or incorrect, and the phrase sanity continues to be used by employers and other individuals to discriminate against these people." From https://gist.github.com/seanmhanson/fe370c2d8bd2b3228680e38899baf5cc Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Ganesh Vernekar	aa3f8d0975	Cut v2.40.3 Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	2 years ago
Levi Harrison	8b48e36933	Put flot under MIT (#11603 ) Signed-off-by: Levi Harrison <git@leviharrison.dev> Signed-off-by: Levi Harrison <git@leviharrison.dev>	2 years ago
Julien Pivotto	3910b09969	Merge pull request #11596 from prometheus/release-2.40 Merge back release-2.40 branch	2 years ago
Ganesh Vernekar	ef886ac4b3	Cut v2.40.2 Signed-off-by: Ganesh Vernekar <ganeshvern@gmail.com>	2 years ago
Julius Volz	1eb327b99b	Fix black-on-black metric name color in dark mode (#11572 ) The color should not be set explicitly at all. That way it simply inherits the theme's default color, as before https://github.com/prometheus/prometheus/pull/11068. Fixes https://github.com/prometheus/prometheus/issues/11568 Signed-off-by: Julius Volz <julius.volz@gmail.com> Signed-off-by: Julius Volz <julius.volz@gmail.com>	2 years ago
Julius Volz	98f1d64762	Fix black-on-black metric name color in dark mode (#11572 ) The color should not be set explicitly at all. That way it simply inherits the theme's default color, as before https://github.com/prometheus/prometheus/pull/11068. Fixes https://github.com/prometheus/prometheus/issues/11568 Signed-off-by: Julius Volz <julius.volz@gmail.com> Signed-off-by: Julius Volz <julius.volz@gmail.com>	2 years ago

1 2 3 4 5 ...

1467 Commits (717a3f8e2546863013e0b3284ae99fa4917115ef)