prometheus

Commit Graph

Author	SHA1	Message	Date
Matt T. Proud	8339a189cb	Code Review: Fix seriesPresent scope. The seriesPresent scope should be constrained to the scope of a scanJob, since this is keyed to given series.	12 years ago
Matt T. Proud	fe41ce0b19	Conditionalize disk initializations. This commit conditionalizes the creation of the diskFrontier and seriesFrontier along with the iterator such that they are provisioned once something is actually required from disk.	12 years ago
Julius Volz	a8468a2e5e	Fix reversed disk flush cutoff behavior.	12 years ago
Julius Volz	eb1f956909	Revert "Revert "Ensure that all extracted samples are added to view."" This reverts commit `4b30fb86b4`.	12 years ago
Matt T. Proud	4b30fb86b4	Revert "Ensure that all extracted samples are added to view." This reverts commit `008314b5a8`. By running an automated git bisection described in https://gist.github.com/matttproud-soundcloud/22a371a8d2cba382ea64 this commit was found.	12 years ago
Julius Volz	750f862d9a	Use GetBoundaryValues() for non-counter deltas.	12 years ago
Julius Volz	f2b48b8c4a	Make getValuesAtIntervalOp consume all chunk data in one pass. This is mainly a small performance improvement, since we skip past the last extracted time immediately if it was also the last sample in the chunk, instead of trying to extract non-existent values before the chunk end again and again and only gradually approaching the end of the chunk.	12 years ago
Julius Volz	83d60bed89	extractValuesAroundTime() code simplification.	12 years ago
Julius Volz	008314b5a8	Ensure that all extracted samples are added to view. The current behavior only adds those samples to the view that are extracted by the last pass of the last processed op and throws other ones away. This is a bug. We need to append all samples that are extracted by each op pass. This also makes view.appendSamples() take an array of samples.	12 years ago
Matt T. Proud	b586801830	Code Review: Fix to-disk queue infinite growth. We discovered a bug while manually testing this branch on a live instance, whereby the to-disk queue was never actually dumped to disk.	12 years ago
Matt T. Proud	285a8b701b	Code Review: Extend lock.	12 years ago
Matt T. Proud	2526ab8c81	Code Review: Extend lock scope for appending.	12 years ago
Matt T. Proud	f994482d15	Code Review: Avenues for future improvemnet noted.	12 years ago
Matt T. Proud	298a90c143	Code Review: Initial arena size name.	12 years ago
Matt T. Proud	c07abf8521	Initial move away from skiplist.	12 years ago
Matt T. Proud	74a66fd938	Spawn grouping of fingerprints with free semaphore. The previous implementation spawned N goroutines to group samples together and would not start work until the semaphore unblocked. While this didn't leak, it polluted the scheduling space. Thusly, the routine only starts after a semaphore has been acquired.	12 years ago
Julius Volz	5b105c77fc	Repointerize fingerprints.	12 years ago
Matt T. Proud	ec5b5bae28	Fuck you, Travis.	12 years ago
Matt T. Proud	e5ac91222b	Benchmark memory arena; simplify map generation. The one-off keys have been replaced with ``model.LabelPair``, which is indexable. The performance impact is negligible, but it represents a cognitive simplification.	12 years ago
juliusv	360477f66c	Merge pull request #257 from prometheus/feature/better-memory-behaviors Pointerize memorySeriesArena.	12 years ago
Matt T. Proud	e1f20de2e9	Pointerize memorySeriesArena.	12 years ago
Matt T. Proud	8f4c7ece92	Destroy naked returns in half of corpus. The use of naked return values is frowned upon. This is the first of two bulk updates to remove them.	12 years ago
Matt T. Proud	4e0c932a4f	Simplify Encoder's encoding signature. The reality is that if we ever try to encode a Protocol Buffer and it fails, it's likely that such an error is ultimately not a runtime error and should be fixed forthwith. Thusly, we should rename ``Encoder.Encode`` to ``Encoder.MustEncode`` and drop the error return value.	12 years ago
juliusv	516101f015	Merge pull request #250 from prometheus/refactor/drop-unused-storage-setting Drop unused writeMemoryInterval	12 years ago
juliusv	9ff00b651d	Merge pull request #251 from prometheus/fix/memory-metric-mutability Fix GetMetricForFingerprint() metric mutability.	12 years ago
Bernerd Schaefer	63d9988b9c	Drop unused writeMemoryInterval	12 years ago
Julius Volz	83c60ad43a	Fix GetMetricForFingerprint() metric mutability. Some users of GetMetricForFingerprint() end up modifying the returned metric labelset. Since the memory storage's implementation of GetMetricForFingerprint() returned a pointer to the metric (and maps are reference types anyways), the external mutation propagated back into the memory storage. The fix is to make a copy of the metric before returning it.	12 years ago
Bernerd Schaefer	428d91c86f	Rename test helper files to helpers_test.go This ensures that these files are properly included only in testing.	12 years ago
juliusv	98e512d755	Merge pull request #246 from prometheus/fix/interval-value-extraction Fix and optimize getValuesAtIntervalOp data extraction.	12 years ago
Julius Volz	71a3172abb	Fix and optimize getValuesAtIntervalOp data extraction. - only the data extracted in the last loop iteration of ExtractSamples() was emitted as output - if e.g. op interval < sample interval, there were situations where the same sample was added multiple times to the output	12 years ago
Matt T. Proud	244a4a9cdb	Update to go1.1. This commit updates the documentation, Makefiles, formatting, and code semantics to support the 1.1. runtime, which includes ... 1. ``make advice``, 2. ``make format``, and 3. ``go fix`` on various targets.	12 years ago
Matt T. Proud	b224251981	Simplify compaction and expose database sizes. This commit simplifies the way that compactions across a database's keyspace occur due to reading the LevelDB internals. Secondarily it introduces the database size estimation mechanisms. Include database health and help interfaces. Add database statistics; remove status goroutines. This commit kills the use of Go routines to expose status throughout the web components of Prometheus. It also dumps raw LevelDB status on a separate /databases endpoint.	12 years ago
juliusv	92ad65ff13	Merge pull request #232 from prometheus/optimize/granular-storage-locking Synchronous memory appends and more fine-grained storage locks.	12 years ago
Matt T. Proud	1f7f89b4e3	Simplify compaction and expose database sizes. This commit simplifies the way that compactions across a database's keyspace occur due to reading the LevelDB internals. Secondarily it introduces the database size estimation mechanisms.	12 years ago
Matt T. Proud	d538b0382f	Include long-tail data deletion mechanism. This commit introduces the long-tail deletion mechanism, which will automatically cull old sample values. It is an acceptable hold-over until we get a resampling pipeline implemented. Kill legacy OS X documentation, too.	12 years ago
Julius Volz	ce1ee444f1	Synchronous memory appends and more fine-grained storage locks. This does two things: 1) Make TieredStorage.AppendSamples() write directly to memory instead of buffering to a channel first. This is needed in cases where a rule might immediately need the data generated by a previous rule. 2) Replace the single storage mutex by two new ones: - memoryMutex - needs to be locked at any time that two concurrent goroutines could be accessing (via read or write) the TieredStorage memoryArena. - memoryDeleteMutex - used to prevent any deletion of samples from memoryArena as long as renderView is running and assembling data from it. The LevelDB disk storage does not need to be protected by a mutex when rendering a view since renderView works off a LevelDB snapshot. The rationale against adding memoryMutex directly to the memory storage: taking a mutex does come with a small inherent time cost, and taking it is only required in few places. In fact, no locking is required for the memory storage instance which is part of a view (and not the TieredStorage).	12 years ago
Matt T. Proud	fa6a1f97d0	Expose interfaces for pruner and make pruner tool. In order to run database cleanups and diagnostics, we should have a means for pruning a database---even if LevelDB does this for us.	12 years ago
Matt T. Proud	161c8fbf9b	Include deletion processor for long-tail values. This commit extracts the model.Values truncation behavior into the actual tiered storage, which uses it and behaves in a peculiar way—notably the retention of previous elements if the chunk were to ever go empty. This is done to enable interpolation between sparse sample values in the evaluation cycle. Nothing necessarily new here—just an extraction. Now, the model.Values TruncateBefore functionality would do what a user would expect without any surprises, which is required for the DeletionProcessor, which may decide to split a large chunk in two if it determines that the chunk contains the cut-off time.	12 years ago
Matt Proud	7f0d816574	Schedule the background compactors to run. This commit introduces three background compactors, which compact sparse samples together. 1. Older than five minutes is grouped together into chunks of 50 every 30 minutes. 2. Older than 60 minutes is grouped together into chunks of 250 every 50 minutes. 3. Older than one day is grouped together into chunks of 5000 every 70 minutes.	12 years ago
Julius Volz	caab131ada	Repointerize TieredStorage method receiver types.	12 years ago
juliusv	89de116ea9	Merge pull request #225 from prometheus/refactor/fmt-cleanups Slice expression simplifications.	12 years ago
Julius Volz	05afa970d2	Slice expression simplifications.	12 years ago
Matt T. Proud	f897164bcf	Expose TieredStorage.DiskStorage.	12 years ago
Matt T. Proud	ce45787dbf	Storage interface to TieredStorage. This commit drops the Storage interface and just replaces it with a publicized TieredStorage type. Storage had been anticipated to be used as a wrapper for testability but just was not used due to practicality. Merely overengineered. My bad. Anyway, we will eventually instantiate the TieredStorage dependencies in main.go and pass them in for more intelligent lifecycle management. These changes will pave the way for managing the curators without Law of Demeter violations.	12 years ago
Bernerd Schaefer	5eb9840ed7	Fix goroutine leak in leveldb.AppendSamples The error channels in AppendSamples need to be buffered, since in the presence of errors their values may not be consumed.	12 years ago
Matt T. Proud	a3f1d81e24	Publicize a few storage components for curation. This commit introduces the publicization of Stop and other components, which the compaction curator shall take advantage of.	12 years ago
Matt T. Proud	4298bab2b0	Publicize Curator and Processors. This commit publicizes the curation and processor frameworks for purposes of making them available in the main processor loop.	12 years ago
Julius Volz	368a792dd2	Adjust memory queue size after change to send arrays over channel.	12 years ago
juliusv	b02debd69c	Merge pull request #205 from prometheus/julius-channel-arrays Send sample arrays instead of single samples over channels.	12 years ago
Julius Volz	d8110fcd9c	Send sample arrays instead of single samples over channels.	12 years ago

1 2 3 4

192 Commits (6c36beb76481d3ed3777d2fd591b286fcadfdfd9)