213 Commits (697d3139d09d7513bc491f093003acd44cb69178)

Author	SHA1	Message	Date
Matt T. Proud	a73f061d3c	Persist solely Protocol Buffers. ... An design question was open for me in the beginning was whether to serialize other types to disk, but Protocol Buffers quickly won out, which allows us to drop support for other types. This is a good start to cleaning up a lot of cruft in the storage stack and can let us eventually decouple the various moving parts into separate subsystems for easier reasoning. This commit is not strictly required, but it is a start to making the rest a lot more enjoyable to interact with.	12 years ago
juliusv	95400cb785	Merge pull request #290 from prometheus/fix/go-vet ... Minor "go tool vet" cleanups	12 years ago
Julius Volz	558281890b	Minor "go tool vet" cleanups	12 years ago
juliusv	615972dd01	Merge pull request #288 from prometheus/fix/curator/fallthrough-compaction-ordering ... Fix fallthrough compaction value ordering.	12 years ago
Matt T. Proud	86f63b078b	Fix fallthrough compaction value ordering. ... We discovered a regression whereby data chunks could be appended out of order if the fallthrough case was hit.	12 years ago
Julius Volz	7b9ee95030	Minor LevelDB watermark handling cleanups.	12 years ago
Julius Volz	84741b227d	Use LRU cache to avoid querying stale series.	12 years ago
Julius Volz	f98853d7b7	Fix type error in watermark list handling.	12 years ago
Matt T. Proud	ef1d5fd8a2	Introduce semaphores for tiered storage. ... This commit wraps the tiered storage access componnets in semaphores, since we can handle several concurrent memory reads.	12 years ago
Matt T. Proud	819045541e	Code Review: Make double-drain a panic.	12 years ago
Matt T. Proud	e217a9fb41	Race Work: Make memory arena locks more coarse. ... We can optimize these as needed later.	12 years ago
Matt T. Proud	beaaf386e7	Add storage state guards and transition callbacks. ... To ensure that we access tiered storage in the proper way, we have guards now.	12 years ago
Matt T. Proud	abb5353ade	Merge pull request #283 from prometheus/feature/storage/consult-watermark ... Include LRU cache for fingerprint watermarks.	12 years ago
Matt T. Proud	2c3df44af6	Ensure database access waits until it is started. ... This commit introduces a channel message to ensure serving state has been reached with the storage stack before anything attempts to use it.	12 years ago
Matt T. Proud	cbe2f3a7b1	Include LRU cache for fingerprint watermarks.	12 years ago
Julius Volz	51689d965d	Add debug timers to instant and range queries. ... This adds timers around several query-relevant code blocks. For now, the query timer stats are only logged for queries initiated through the UI. In other cases (rule evaluations), the stats are simply thrown away. My hope is that this helps us understand where queries spend time, especially in cases where they sometimes hang for unusual amounts of time.	12 years ago
Matt T. Proud	8339a189cb	Code Review: Fix seriesPresent scope. ... The seriesPresent scope should be constrained to the scope of a scanJob, since this is keyed to given series.	12 years ago
Matt T. Proud	fe41ce0b19	Conditionalize disk initializations. ... This commit conditionalizes the creation of the diskFrontier and seriesFrontier along with the iterator such that they are provisioned once something is actually required from disk.	12 years ago
Julius Volz	a8468a2e5e	Fix reversed disk flush cutoff behavior.	12 years ago
Julius Volz	eb1f956909	Revert "Revert "Ensure that all extracted samples are added to view."" ... This reverts commit 4b30fb86b4.	12 years ago
Matt T. Proud	4b30fb86b4	Revert "Ensure that all extracted samples are added to view." ... This reverts commit 008314b5a8. By running an automated git bisection described in https://gist.github.com/matttproud-soundcloud/22a371a8d2cba382ea64 this commit was found.	12 years ago
Julius Volz	750f862d9a	Use GetBoundaryValues() for non-counter deltas.	12 years ago
Julius Volz	f2b48b8c4a	Make getValuesAtIntervalOp consume all chunk data in one pass. ... This is mainly a small performance improvement, since we skip past the last extracted time immediately if it was also the last sample in the chunk, instead of trying to extract non-existent values before the chunk end again and again and only gradually approaching the end of the chunk.	12 years ago
Julius Volz	83d60bed89	extractValuesAroundTime() code simplification.	12 years ago
Julius Volz	008314b5a8	Ensure that all extracted samples are added to view. ... The current behavior only adds those samples to the view that are extracted by the last pass of the last processed op and throws other ones away. This is a bug. We need to append all samples that are extracted by each op pass. This also makes view.appendSamples() take an array of samples.	12 years ago
Matt T. Proud	b586801830	Code Review: Fix to-disk queue infinite growth. ... We discovered a bug while manually testing this branch on a live instance, whereby the to-disk queue was never actually dumped to disk.	12 years ago
Matt T. Proud	285a8b701b	Code Review: Extend lock.	12 years ago
Matt T. Proud	2526ab8c81	Code Review: Extend lock scope for appending.	12 years ago
Matt T. Proud	f994482d15	Code Review: Avenues for future improvemnet noted.	12 years ago
Matt T. Proud	298a90c143	Code Review: Initial arena size name.	12 years ago
Matt T. Proud	c07abf8521	Initial move away from skiplist.	12 years ago
Matt T. Proud	74a66fd938	Spawn grouping of fingerprints with free semaphore. ... The previous implementation spawned N goroutines to group samples together and would not start work until the semaphore unblocked. While this didn't leak, it polluted the scheduling space. Thusly, the routine only starts after a semaphore has been acquired.	12 years ago
Julius Volz	5b105c77fc	Repointerize fingerprints.	12 years ago
Matt T. Proud	ec5b5bae28	Fuck you, Travis.	12 years ago
Matt T. Proud	e5ac91222b	Benchmark memory arena; simplify map generation. ... The one-off keys have been replaced with ``model.LabelPair``, which is indexable. The performance impact is negligible, but it represents a cognitive simplification.	12 years ago
juliusv	360477f66c	Merge pull request #257 from prometheus/feature/better-memory-behaviors ... Pointerize memorySeriesArena.	12 years ago
Matt T. Proud	e1f20de2e9	Pointerize memorySeriesArena.	12 years ago
Matt T. Proud	8f4c7ece92	Destroy naked returns in half of corpus. ... The use of naked return values is frowned upon. This is the first of two bulk updates to remove them.	12 years ago
Matt T. Proud	4e0c932a4f	Simplify Encoder's encoding signature. ... The reality is that if we ever try to encode a Protocol Buffer and it fails, it's likely that such an error is ultimately not a runtime error and should be fixed forthwith. Thusly, we should rename ``Encoder.Encode`` to ``Encoder.MustEncode`` and drop the error return value.	12 years ago
juliusv	516101f015	Merge pull request #250 from prometheus/refactor/drop-unused-storage-setting ... Drop unused writeMemoryInterval	12 years ago
juliusv	9ff00b651d	Merge pull request #251 from prometheus/fix/memory-metric-mutability ... Fix GetMetricForFingerprint() metric mutability.	12 years ago
Bernerd Schaefer	63d9988b9c	Drop unused writeMemoryInterval	12 years ago
Julius Volz	83c60ad43a	Fix GetMetricForFingerprint() metric mutability. ... Some users of GetMetricForFingerprint() end up modifying the returned metric labelset. Since the memory storage's implementation of GetMetricForFingerprint() returned a pointer to the metric (and maps are reference types anyways), the external mutation propagated back into the memory storage. The fix is to make a copy of the metric before returning it.	12 years ago
Bernerd Schaefer	428d91c86f	Rename test helper files to helpers_test.go ... This ensures that these files are properly included only in testing.	12 years ago
juliusv	98e512d755	Merge pull request #246 from prometheus/fix/interval-value-extraction ... Fix and optimize getValuesAtIntervalOp data extraction.	12 years ago
Julius Volz	71a3172abb	Fix and optimize getValuesAtIntervalOp data extraction. ... - only the data extracted in the last loop iteration of ExtractSamples() was emitted as output - if e.g. op interval < sample interval, there were situations where the same sample was added multiple times to the output	12 years ago
Matt T. Proud	244a4a9cdb	Update to go1.1. ... This commit updates the documentation, Makefiles, formatting, and code semantics to support the 1.1. runtime, which includes ... 1. ``make advice``, 2. ``make format``, and 3. ``go fix`` on various targets.	12 years ago
Matt T. Proud	b224251981	Simplify compaction and expose database sizes. ... This commit simplifies the way that compactions across a database's keyspace occur due to reading the LevelDB internals. Secondarily it introduces the database size estimation mechanisms. Include database health and help interfaces. Add database statistics; remove status goroutines. This commit kills the use of Go routines to expose status throughout the web components of Prometheus. It also dumps raw LevelDB status on a separate /databases endpoint.	12 years ago
juliusv	92ad65ff13	Merge pull request #232 from prometheus/optimize/granular-storage-locking ... Synchronous memory appends and more fine-grained storage locks.	12 years ago
Matt T. Proud	1f7f89b4e3	Simplify compaction and expose database sizes. ... This commit simplifies the way that compactions across a database's keyspace occur due to reading the LevelDB internals. Secondarily it introduces the database size estimation mechanisms.	12 years ago