prometheus

Commit Graph

Author	SHA1	Message	Date
Julius Volz	740d448983	Use custom timestamp type for sample timestamps and related code. So far we've been using Go's native time.Time for anything related to sample timestamps. Since the range of time.Time is much bigger than what we need, this has created two problems: - there could be time.Time values which were out of the range/precision of the time type that we persist to disk, therefore causing incorrectly ordered keys. One bug caused by this was: https://github.com/prometheus/prometheus/issues/367 It would be good to use a timestamp type that's more closely aligned with what the underlying storage supports. - sizeof(time.Time) is 192, while Prometheus should be ok with a single 64-bit Unix timestamp (possibly even a 32-bit one). Since we store samples in large numbers, this seriously affects memory usage. Furthermore, copying/working with the data will be faster if it's smaller. MEMORY USAGE RESULTS Initial memory usage comparisons for a running Prometheus with 1 timeseries and 100,000 samples show roughly a 13% decrease in total (VIRT) memory usage. In my tests, this advantage for some reason decreased a bit the more samples the timeseries had (to 5-7% for millions of samples). This I can't fully explain, but perhaps garbage collection issues were involved. WHEN TO USE THE NEW TIMESTAMP TYPE The new clientmodel.Timestamp type should be used whenever time calculations are either directly or indirectly related to sample timestamps. For example: - the timestamp of a sample itself - all kinds of watermarks - anything that may become or is compared to a sample timestamp (like the timestamp passed into Target.Scrape()). When to still use time.Time: - for measuring durations/times not related to sample timestamps, like duration telemetry exporting, timers that indicate how frequently to execute some action, etc. NOTE ON OPERATOR OPTIMIZATION TESTS We don't use operator optimization code anymore, but it still lives in the code as dead code. It still has tests, but I couldn't get all of them to pass with the new timestamp format. I commented out the failing cases for now, but we should probably remove the dead code soon. I just didn't want to do that in the same change as this. Change-Id: I821787414b0debe85c9fffaeb57abd453727af0f	11 years ago
Matt T. Proud	df2f9e47b8	Fix arguments for format string. Change-Id: Ie0d55a70969c992b1afc6fa96b0e3f2171f0de5a	11 years ago
Matt T. Proud	33d6f73d18	Remove unused import. Change-Id: Ic2415bd1abb07c43a9df3adc4b13c75fd465c767	11 years ago
Matt T. Proud	4a87c002e8	Update low-level i'faces to reflect wireformats. This commit fixes a critique of the old storage API design, whereby the input parameters were always as raw bytes and never Protocol Buffer messages that encapsulated the data, meaning every place a read or mutation was conducted needed to manually perform said translations on its own. This is taxing. Change-Id: I4786938d0d207cefb7782bd2bd96a517eead186f	11 years ago
Matt T. Proud	12d5e6ca5a	Curation should not starve user-interactive ops. The background curation should be staggered to ensure that disk I/O yields to user-interactive operations in a timely manner. The lack of routine prioritization necessitates this. Change-Id: I9b498a74ccd933ffb856e06fedc167430e521d86	11 years ago
Julius Volz	93a8d03221	Merge "Add alert-expression console links to notifications."	11 years ago
Matt T. Proud	0d73b8f87e	Adjust curation thresholds and intervals. Curation is an expensive process. We can perform it less frequently; and in the case of compaction processors, we can afford to let them group more together. Change-Id: I421e27958ed7a98dfacaababefad19462772b6a3	11 years ago
Julius Volz	1eb1ceac8c	Add alert-expression console links to notifications. The ConsoleLinkForExpression() function now escapes console URLs in such a way that works both in emails and in HTML. Change-Id: I917bae0b526cbbac28ccd2a4ec3c5ac03ee4c647	11 years ago
Julius Volz	305662bfdd	Handle SIGTERM in addition to SIGINT. Change-Id: I9c91ec7e2b9026b9eb152b98a6986f2bf773eb03	11 years ago
Matt T. Proud	972e856d9b	Kill the curation state channel. The use of the channels for curation state were always unidiomatic. Change-Id: I1cb1d7175ebfb4faf28dff84201066278d6a0d92	11 years ago
Julius Volz	d69b85e6c9	Add global label support via Ingesters.	11 years ago
Matt T. Proud	417e6ffa0c	Rename the queue arguments for another trial. Again, playing around. Change-Id: I5413f7723a38ae18792802c5ed91753101adf491 Moving order of arguments by priority. Testing out patch sets. Change-Id: I5413f7723a38ae18792802c5ed91753101adf491	11 years ago
Matt T. Proud	014c5ef176	Move version to the bottom. Again, dummy commit. Just to demonstrate naive drafting with Gerrit. Change-Id: I43afaf346c61738a17be60eaa22c966545e1eccf	11 years ago
Matt T. Proud	13bfc6c120	Consolidate queue arguments in main. This is a no-op commit to demonstrate Gerrit workflow. Change-Id: I3f09ccd91e4645753517fa31ca97384e7548317f	11 years ago
Julius Volz	0003027dce	Add needed trailing spaces in logs.	11 years ago
Julius Volz	aa5d251f8d	Use github.com/golang/glog for all logging.	11 years ago
Julius Volz	3b970c5133	Add variable interpolation to notification messages. This includes required refactorings to enable replacing the http client (for testing) and moving the NotificationReq type definitions to the "notifications" package, so that this package doesn't need to depend on "rules" anymore and that it can instead use a representation of the required data which only includes the necessary fields.	11 years ago
Julius Volz	ecf0ee8f39	Transfer alerting rule and Prometheus URL to alertmanager.	11 years ago
Matt T. Proud	9baaadfc53	Include forgotten interval.	11 years ago
Matt T. Proud	07ac921aec	Code Review: First pass.	11 years ago
Matt T. Proud	d8792cfd86	Extract HighWatermarking. Clean up the rest.	11 years ago
Julius Volz	35ee2cd3cb	Add alertmanager notification support to Prometheus. Alert definitions now also have mandatory SUMMARY and DESCRIPTION fields that get sent along a firing alert to the alert manager.	11 years ago
Matt T. Proud	30b1cf80b5	WIP - Snapshot of Moving to Client Model.	12 years ago
Julius Volz	0226d1ac7a	Implement alerts dashboard and expression console links.	12 years ago
Julius Volz	ba29d07901	Show loaded rules in Status dashboard.	12 years ago
Matt T. Proud	2c3df44af6	Ensure database access waits until it is started. This commit introduces a channel message to ensure serving state has been reached with the storage stack before anything attempts to use it.	12 years ago
Julius Volz	adb87816f4	Put RuleManager concurrency in hands of caller, fix races.	12 years ago
Matt T. Proud	0d2d6e9a27	Include uptime in the status console. In order to help corroborate whether a Prometheus instance has flapped until meta-monitoring is in-place, we ought to provide the instance's start time in the console to aid in diagnostics.	12 years ago
Matt T. Proud	b063338ae6	Expand the in-memory arena size. We need to exercise this code path sooner versus later. This will be a cheap way of doing so.	12 years ago
Bernerd Schaefer	63d9988b9c	Drop unused writeMemoryInterval	12 years ago
Matt T. Proud	b224251981	Simplify compaction and expose database sizes. This commit simplifies the way that compactions across a database's keyspace occur due to reading the LevelDB internals. Secondarily it introduces the database size estimation mechanisms. Include database health and help interfaces. Add database statistics; remove status goroutines. This commit kills the use of Go routines to expose status throughout the web components of Prometheus. It also dumps raw LevelDB status on a separate /databases endpoint.	12 years ago
juliusv	92ad65ff13	Merge pull request #232 from prometheus/optimize/granular-storage-locking Synchronous memory appends and more fine-grained storage locks.	12 years ago
Matt T. Proud	d538b0382f	Include long-tail data deletion mechanism. This commit introduces the long-tail deletion mechanism, which will automatically cull old sample values. It is an acceptable hold-over until we get a resampling pipeline implemented. Kill legacy OS X documentation, too.	12 years ago
Julius Volz	ce1ee444f1	Synchronous memory appends and more fine-grained storage locks. This does two things: 1) Make TieredStorage.AppendSamples() write directly to memory instead of buffering to a channel first. This is needed in cases where a rule might immediately need the data generated by a previous rule. 2) Replace the single storage mutex by two new ones: - memoryMutex - needs to be locked at any time that two concurrent goroutines could be accessing (via read or write) the TieredStorage memoryArena. - memoryDeleteMutex - used to prevent any deletion of samples from memoryArena as long as renderView is running and assembling data from it. The LevelDB disk storage does not need to be protected by a mutex when rendering a view since renderView works off a LevelDB snapshot. The rationale against adding memoryMutex directly to the memory storage: taking a mutex does come with a small inherent time cost, and taking it is only required in few places. In fact, no locking is required for the memory storage instance which is part of a view (and not the TieredStorage).	12 years ago
Matt Proud	7f0d816574	Schedule the background compactors to run. This commit introduces three background compactors, which compact sparse samples together. 1. Older than five minutes is grouped together into chunks of 50 every 30 minutes. 2. Older than 60 minutes is grouped together into chunks of 250 every 50 minutes. 3. Older than one day is grouped together into chunks of 5000 every 70 minutes.	12 years ago
Julius Volz	af7920126c	Fix build errors and add default build step to "make".	12 years ago
Julius Volz	56324d8ce2	Make AST query storage non-global.	12 years ago
Matt T. Proud	3b9b1c6ab4	Define dependencies for web. stack concretely. This commit destroys the use of AppState, which makes passing concrete state along to various serving components onerous.	12 years ago
Matt T. Proud	ce45787dbf	Storage interface to TieredStorage. This commit drops the Storage interface and just replaces it with a publicized TieredStorage type. Storage had been anticipated to be used as a wrapper for testability but just was not used due to practicality. Merely overengineered. My bad. Anyway, we will eventually instantiate the TieredStorage dependencies in main.go and pass them in for more intelligent lifecycle management. These changes will pave the way for managing the curators without Law of Demeter violations.	12 years ago
Julius Volz	9cea5d9df8	Convert the Prometheus configuration to protocol buffers.	12 years ago
Julius Volz	368a792dd2	Adjust memory queue size after change to send arrays over channel.	12 years ago
juliusv	b02debd69c	Merge pull request #205 from prometheus/julius-channel-arrays Send sample arrays instead of single samples over channels.	12 years ago
Julius Volz	d8110fcd9c	Send sample arrays instead of single samples over channels.	12 years ago
Matt T. Proud	3362bf36e2	Include curator status in web heads-up-display.	12 years ago
Matt T. Proud	6fac20c8af	Harden the tests against OOMs. This commit employs explicit memory freeing for the in-memory storage arenas. Secondarily, we take advantage of smaller channel buffer sizes in the test.	12 years ago
Bernerd Schaefer	c152aa514f	Always print version information when starting up	12 years ago
Bernerd Schaefer	a2a4f94aae	StatusHandler renders build info	12 years ago
Bernerd Schaefer	033533c4c5	Capture build information and print with -version	12 years ago
Matt T. Proud	d468271e2f	Fix append queue telemetry and parameterize sizes. The original append queue telemetry never worked, because it was updated only upon the exit of the select statement, which would usually liberate the queues of contents. This has been fixed to be reported arbitrarily. The queue sizes are now parameterizable via flags.	12 years ago
Julius Volz	c4d0969c00	Propagate more errors during rule evaluation.	12 years ago

1 2

83 Commits (6947ee9bc9f971dfb44443fbe15833b4e2d2e577)