739 Commits (5be753f17731b1d37646737d5e0c8fe73d2b67d2)

Author	SHA1	Message	Date
Marcin Skalski	19709f75d0	fix kuma_sd docs ... Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>	12 months ago
Björn Rabenstein	4b55a71210	Merge pull request #11583 from windsonsea/story ... Tweak line wrappings in docs/storage.md	12 months ago
Marcin Skalski	0af810aa71	fix go lint ... Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>	12 months ago
Marcin Skalski	d12ccf9fa2	kuma_sd: Extend Kuma SD configuration to allow users to specify ClientId ... Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>	12 months ago
Bartlomiej Plotka	91a383f52c	Merge pull request #13059 from zenador/add-mad-function ... Add mad_over_time function	12 months ago
Julien Pivotto	74cd1b6a09	Merge branch 'main' into add-focus-flag-to-promtool-test-rules ... Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	12 months ago
Julien Pivotto	52b15d2195	Merge pull request #13219 from djcode/main ... Discovery: Add support for NS records to DNS Discovery	1 year ago
Jeanette Tan	9bf4cc993e	Add mad_over_time function ... Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	1 year ago
Daniel Jolly	2c420b518e	Add support for NS records in DNS discovery ... Signed-off-by: Daniel Jolly <code@danieljolly.com>	1 year ago
beorn7	0eb0ca42c5	Update “conventional histogram” → “classic histogram” ... Signed-off-by: beorn7 <beorn@grafana.com>	1 year ago
Julien Pivotto	c1ec6ae851	sort_by_label: Switch to feature flag ... Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	1 year ago
Alexander Trost	5051a993ab	promql: add sort_by_label and sort_by_label_desc functions ... This adds functions to sort a vector by its label value. Based on https://github.com/prometheus/prometheus/pull/1533 Signed-off-by: Alexander Trost <galexrt@googlemail.com>	1 year ago
David Peleg	969a9b7090	Fix docs: in labelname, convert to underscore (#12555) ... Fixes https://github.com/prometheus/docs/issues/735 Signed-off-by: David Peleg <107049994+dapeleg-dn@users.noreply.github.com>	1 year ago
zenador	ccfe14d7e7	PromQL: ignore small errors for bucketQuantile (#13153) ... promql: Improve histogram_quantile calculation for classic buckets Tiny differences between classic buckets are most likely caused by floating point precision issues. With this commit, relative changes below a certain threshold are ignored. This makes the result of histogram_quantile more meaningful, and also avoids triggering the _input to histogram_quantile needed to be fixed for monotonicity_ annotations in unactionable cases. This commit also adds explanation of the new adjustment and of the monotonicity annotation to the documentation of `histogram_quantile`. --------- Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	1 year ago
Łukasz Mierzwa	870627fbed	Add enable_compression scrape config option ... Currently Prometheus will always request gzip compression from the target when sending scrape requests. HTTP compression does reduce the amount of bytes sent over the wire and so is often desirable. The downside of compression is that it requires extra resources - cpu & memory. This also affects the resource usage on the target since it has to compress the response before sending it to Prometheus. This change adds a new option to the scrape job configuration block: enable_compression. The default is true so it remains the same as current Prometheus behaviour. Setting this option to false allows users to disable compression between Prometheus and the scraped target, which will require more bandwidth but it lowers the resource usage of both Prometheus and the target. Fixes #12319. Signed-off-by: Łukasz Mierzwa <l.mierzwa@gmail.com>	1 year ago
Julien Pivotto	c92fbf3fdf	Add feature flag for PromQL experimental functions. ... This PR adds an Experimental flag to the functions. This can be used by https://github.com/prometheus/prometheus/pull/13059 but also xrate and other future functions. Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	1 year ago
George Krajcsovits	e399395b01	Native histograms vs labels (#13005) ... * Document le and quantile label transition due to native histograms Fixes: #12984 For full explanation see the related issue. The le and quantile labels are formatted as float with trailing .0 for whole number values when native histograms is enabled, e.g. 10.0. This changes the resulting series in Prometheus if previously we scraped the whole number itself, e.g. 10 over the text format. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> --------- Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com> Signed-off-by: George Krajcsovits <krajorama@users.noreply.github.com>	1 year ago
Julien Pivotto	84aadfc45b	scrape: Added trackTimestampsStaleness configuration option ... Add the ability to track staleness when an explicit timestamp is set. Useful for cAdvisor. Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	1 year ago
Julien Pivotto	0c1e447d68	Exclude alerts: improve documentation (#13046) ... Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	1 year ago
Julien Pivotto	156a23d06d	Merge pull request #12999 from rajagopalanand/filter-alerts ... Adding a query parameter to filter out active alerts	1 year ago
Rens Groothuijsen	122f9506e9	Set test group interval default to evaluation interval (#13011) ... Signed-off-by: Rens Groothuijsen <l.groothuijsen@alumni.maastrichtuniversity.nl>	1 year ago
Anand Rajagopal	2ade8adf9e	Adding a query parameter to filter out active alerts ... Signed-off-by: Anand Rajagopal <anrajag@amazon.com>	1 year ago
Björn Rabenstein	35ec9d1f89	Merge pull request #12868 from jdellithorpe-db/alert-unit-test-doc-fix ... Promtool: Fix/clarify documentation for axn notation.	1 year ago
Bartlomiej Plotka	624b973ebf	Added ability to specify scrape protocols to accept during HTTP content type negotiation. (#12738) ... * Added ability to specify scrape protocols to accept during HTTP content type negotiation. This is done via new option in GlobalConfig and ScrapeConfig: "scrape_protocol" Signed-off-by: bwplotka <bwplotka@gmail.com> * Fixed readability and log message. Signed-off-by: bwplotka <bwplotka@gmail.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com>	1 year ago
Jonathan Ellithorpe	91650a32cc	Fix/clarify documentation for axn notation ... Signed-off-by: Jonathan Ellithorpe <jelli@databricks.com>	1 year ago
rakshith210	cdad64002a	Added Azure OAuth support (#12572) ... * Added Azure OAuth support Signed-off-by: rakshith210 <rakshith.me@gmail.com> * Added missing comment Signed-off-by: rakshith210 <rakshith.me@gmail.com> * Addressing comment Signed-off-by: rakshith210 <rakshith.me@gmail.com> * Fixed lint issue Signed-off-by: rakshith210 <rakshith.me@gmail.com> * Fix test Signed-off-by: rakshith210 <rakshith.me@gmail.com> * Addressing comments Signed-off-by: rakshith210 <rakshith.me@gmail.com> * Added documentation and updated unit tests Signed-off-by: rakshith210 <rakshith.me@gmail.com> * Addressing comments Signed-off-by: rakshith210 <rakshith.me@gmail.com> --------- Signed-off-by: rakshith210 <rakshith.me@gmail.com>	1 year ago
Jennifer Villa	ea7bec4cc7	Update recording_rules.md ... updated language to be a bit more clear Signed-off-by: Jennifer Villa <jvilla2013@gmail.com>	1 year ago
Jennifer Villa	65ffa0c511	Update recording_rules.md ... adding Josh's suggestion Signed-off-by: Jennifer Villa <jvilla2013@gmail.com>	1 year ago
Jennifer Villa	601e5b9028	Update recording_rules.md ... specified the evaluation interval defines when the next evaluation should start. Signed-off-by: Jennifer Villa <jvilla2013@gmail.com>	1 year ago
Jennifer Villa	5027863c40	Clarify what happens when a rule group takes too long to execute ... Namely, call out that all subsequent evaluations will be skipped until the initial evaluation completes. Signed-off-by: Jennifer Villa <jvilla2013@gmail.com>	1 year ago
Julien Pivotto	ac0919d48c	Update docs/querying/functions.md ... Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	1 year ago
lasea75	f15f0ac16a	Update functions.md ... Signed-off-by: lasea75 <lasea75@gmail.com>	1 year ago
Julien Pivotto	a8cdb7eb6c	Merge branch 'main' into template_reference ... Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	1 year ago
Ben Ye	c78124427e	Support specifying series matchers to analyze tsdb (#12842) ... * support specifying series matchers to analyze tsdb Signed-off-by: Ben Ye <benye@amazon.com> * fix cli docs Signed-off-by: Ben Ye <benye@amazon.com> --------- Signed-off-by: Ben Ye <benye@amazon.com>	1 year ago
TJ Hoplock	51d1d2cd96	feat: add AWS sigv4 support to alertmanager endpoints ... Addresses: #12536 This commit adds support for configuring sigv4 to an `alertmanager_config`. Based heavily on the sigv4 work in the remote write client. Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>	1 year ago
Julien Pivotto	c5e1498ae2	Merge pull request #12743 from wasim-nihal/documentation-alignment ... Correcting indentation of basic_auth configuration for uyuni_sd_config	1 year ago
Gregor Zeitlinger	f01718262a	Unit tests for native histograms (#12668) ... promql: Extend testing framework to support native histograms This includes both the internal testing framework as well as the rules unit test feature of promtool. This also adds a bunch of basic tests. Many of the code level tests can now be converted to tests within the framework, and more tests can be added easily. --------- Signed-off-by: Harold Dost <h.dost@criteo.com> Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com> Signed-off-by: Stephen Lang <stephen.lang@grafana.com> Co-authored-by: Harold Dost <h.dost@criteo.com> Co-authored-by: Stephen Lang <stephen.lang@grafana.com> Co-authored-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>	1 year ago
zenador	54aaa2bd7e	Add `histogram_stdvar` and `histogram_stddev` functions (#12614) ... * Add new function: histogram_stdvar and histogram_stddev Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	1 year ago
Wasim Nihal	daca364b70	Correcting indentation of basic_auth configuration for uyuni_sd_config ... Signed-off-by: Wasim Nihal <sswasim64@gmail.com>	1 year ago
Salar Nosrati-Ershad	fd96996b75	docs: fix: correct reference to native histograms feature flag ... Signed-off-by: Salar Nosrati-Ershad <snosratiershad@gmail.com>	1 year ago
Bryan Boreham	1e3fef6ab0	scraping: limit detail on dropped targets, to save memory (#12647) ... It's possible (quite common on Kubernetes) to have a service discovery return thousands of targets then drop most of them in relabel rules. The main place this data is used is to display in the web UI, where you don't want thousands of lines of display. The new limit is `keep_dropped_targets`, which defaults to 0 for backwards-compatibility. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	1 year ago
Julien Pivotto	4a56a6bf59	Merge pull request #12643 from gouthamve/add-otlp-docs ... Add initial OTLP ingestion docs	1 year ago
Julien Pivotto	4c81a8f681	Merge pull request #11578 from chancefeick/fix/querying-documentation ... Fix Querying Documentation Links	1 year ago
Goutham	acb1f8a097	Fix API endpoint ... Signed-off-by: Goutham <gouthamve@gmail.com>	1 year ago
Goutham Veeramachaneni	9df36c3e5e	Apply suggestions from code review ... Co-authored-by: Julien Pivotto <roidelapluie@o11y.eu> Signed-off-by: Goutham Veeramachaneni <gouthamve+github@gmail.com>	1 year ago
Goutham	6bb5720141	Add initial OTLP ingestion docs ... We still need a guide that we can link users to in https://github.com/prometheus/docs/tree/main/content/docs/guides This guide should show sending metrics from application directly via the OTel SDKs and also sending through the Collector. Signed-off-by: Goutham <gouthamve@gmail.com>	1 year ago
Julien Pivotto	bb90379163	Merge pull request #11404 from gberche-orange/patch-2 ... docs (label_replace): illustrate use of named capturing group	1 year ago
Goutham Veeramachaneni	ad4f514e66	Add OTLP Ingestion endpoint (#12571) ... * Add OTLP Ingestion endpoint We copy files from the otel-collector-contrib. See the README in `storage/remote/otlptranslator/README.md`. This supersedes: https://github.com/prometheus/prometheus/pull/11965 Signed-off-by: gouthamve <gouthamve@gmail.com> * Return a 200 OK It is what the OTEL Golang SDK expect :( https://github.com/open-telemetry/opentelemetry-go/issues/4363 Signed-off-by: Goutham <gouthamve@gmail.com> --------- Signed-off-by: gouthamve <gouthamve@gmail.com> Signed-off-by: Goutham <gouthamve@gmail.com>	1 year ago
Julien Pivotto	03e549cc39	Merge pull request #8747 from shoce/patch-1 ... Add instructions how to persist prometheus docker container data	1 year ago
m.nabokikh	9d8463339d	Fixes according to the code review ... Signed-off-by: m.nabokikh <maksim.nabokikh@flant.com>	1 year ago
Guillaume Berche	f5fb37dbab	Update functions.md ... Add missing linefeed as requested by https://github.com/prometheus/prometheus/pull/11404#discussion_r1266625301 Signed-off-by: Guillaume Berche <guillaume.berche@orange.com>	1 year ago
Julien Pivotto	2bdb2e627f	Merge pull request #10914 from wangrzneu/add-endpointslice-label ... Add more labels for endpointslice and endpoints role in k8s discovery	1 year ago
Julien Pivotto	fd5b01afdc	promtool docs: write flags between backtits in help ... Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	1 year ago
Julien Pivotto	b3b669fd9a	Add experimental flag and docs ... Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	1 year ago
Guillaume Berche	60b380da70	Refine functions.md as suggested during review ... See https://github.com/prometheus/prometheus/pull/11404#issuecomment-1631165746 Signed-off-by: Guillaume Berche <guillaume.berche@orange.com>	1 year ago
Ziqi Zhao	42d9169ba1	enhance histogram_quantile to get min/max value ... Signed-off-by: Ziqi Zhao <zhaoziqi9146@gmail.com>	1 year ago
Carrie Edwards	f93ac97867	Update querying function docs ... Signed-off-by: Carrie Edwards <edwrdscarrie@gmail.com>	1 year ago
Julien Pivotto	fc2e4cd3b9	docs: Fix link to feature flags. ... Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	1 year ago
Taavi Väänänen	0f4c27e2bf	discovery/openstack: Include instance image ID in labels ... Adds a new label to include the ID of the image that an instance is using. This can be used for example to filter a job to only include instances using a certain image as that image includes some exporter. Sometimes the image information isn't available, such as when the image is private and the user doesn't have the roles required to see it. In those cases we just don't set the label, as the rest of the information from the discovery provider can still be used. Signed-off-by: Taavi Väänänen <hi@taavi.wtf>	1 year ago
João Vilaça	81394ea1c5	Add --run flag to promtool test rules ... Signed-off-by: João Vilaça <jvilaca@redhat.com>	1 year ago
Julien Pivotto	1214d314c3	Merge pull request #12225 from fgouteroux/feat/promtool_check_rules_stdin ... promtool: read from stdin if no filenames are provided in check rules	1 year ago
Julien Pivotto	53d7aac39e	Merge pull request #12281 from jlosito/patch-1 ... Update configuration.md	1 year ago
Julien Pivotto	771f512757	Merge pull request #12299 from fgouteroux/promtool_push_metrics_cmd ... feat(promtool): add push metrics command	1 year ago
Julien Pivotto	e043b273a6	Merge pull request #12439 from prometheus/release-2.45 ... Merge release 2.45.0 back to main	1 year ago
Julien Pivotto	0de855508c	Add support for inline TLS certificates ... Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	1 year ago
timmartin-stripe	0c6cf86828	Add sentence explaining what happens when the `for` clause is omitted (#12457) ... Just adding a statement here explaining that the default is an immediate move to "active" without a pending state. Signed-off-by: Tim Martin <tim@timmartin.me>	1 year ago
Jayapriya Pai	81bf3e63a4	docs: update prometheus-operator link ... Signed-off-by: Jayapriya Pai <janantha@redhat.com>	1 year ago
Arthur Silva Sens	1ea477f4bc	Add feature flag to squash metadata from /api/v1/metadata (#12391) ... Signed-off-by: ArthurSens <arthursens2005@gmail.com>	1 year ago
sinkingpoint	f7abe27fef	Remove trailing commas from Exemplar API docs ... The trailing commas here make this example invalid JSON. Here we remove them. Signed-off-by: sinkingpoint <colin@quirl.co.nz>	1 year ago
rakshith210	b1675e23af	Add Azure AD package for remote write (#11944) ... * Add Azure AD package for remote write * Made AzurePublic default and updated configuration.md * Updated config structure and removed getToken at initialization * Changed passing context from request Signed-off-by: Rakshith Padmanabha <rapadman@microsoft.com> Signed-off-by: rakshith210 <rakshith.me@gmail.com>	2 years ago
François Gouteroux	6ae4a46845	feat: enhance stdin check and add tests parsing error ... Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>	2 years ago
renzheng.wang	98ffad01b8	update tests and docs ... Signed-off-by: renzheng.wang <wangrzneu@gmail.com>	2 years ago
Arianna Vespri	a16b876a05	Add limits to global config (#12126) ... * Add limits to global config Signed-off-by: Arianna Vespri <arianna.vespri@yahoo.it> * Move changes into Validate func Signed-off-by: Arianna Vespri <arianna.vespri@yahoo.it> * Make comments consistent wrt 0 meaning no limit Signed-off-by: Arianna Vespri <arianna.vespri@yahoo.it> * Document global limits Signed-off-by: Arianna Vespri <arianna.vespri@yahoo.it> --------- Signed-off-by: Arianna Vespri <arianna.vespri@yahoo.it>	2 years ago
SuperQ	044e004a81	Update exporter-toolkit ... Adds web config option `client_allowed_sans`. This enables Prometheus to limit the Subject Alternate Name (SAN) allowed to connect. Signed-off-by: SuperQ <superq@gmail.com>	2 years ago
François Gouteroux	9cf1b4a2e6	fix: update doc ... Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>	2 years ago
marcoderama	a308ea773d	Update functions.md ... Fix small typo Signed-off-by: marcoderama <marcoderamagit@gmail.com>	2 years ago
François Gouteroux	934c5ddb8d	feat: make push metrics labels generic and repeatable ... Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>	2 years ago
François Gouteroux	3524a16aa0	feat: add suggested changes, tests, and stdin support ... Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>	2 years ago
Baskar Shanmugam	905a0bd63a	Added 'limit' query parameter support to /api/v1/status/tsdb endpoint (#12336) ... * Added 'topN' query parameter support to /api/v1/status/tsdb endpoint Signed-off-by: Baskar Shanmugam <baskar.shanmugam.career@gmail.com> * Updated query parameter for tsdb status to 'limit' Signed-off-by: Baskar Shanmugam <baskar.shanmugam.career@gmail.com> * Corrected Stats() parameter name from topN to limit Signed-off-by: Baskar Shanmugam <baskar.shanmugam.career@gmail.com> * Fixed p.Stats CI failure Signed-off-by: Baskar Shanmugam <baskar.shanmugam.career@gmail.com> --------- Signed-off-by: Baskar Shanmugam <baskar.shanmugam.career@gmail.com>	2 years ago
Julien Pivotto	0dc31ade41	Add support for consul path_prefix ... Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Julien Pivotto	41b3db198c	Merge pull request #12367 from AkshaySiwal/main ... Updating signal for graceful shutdown in docs/getting_started.md	2 years ago
zenador	191bf9055b	Handle more arithmetic operators for native histograms (#12262) ... Handle more arithmetic operators and aggregators for native histograms This includes operators for multiplication (formerly known as scaling), division, and subtraction. Plus aggregations for average and the avg_over_time function. Stdvar and stddev will (for now) ignore histograms properly (rather than counting them but adding a 0 for them). Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2 years ago
Akshay Siwal	4c898fc4a1	Update getting_started.md ... Updating signal for graceful shutdown. Signed-off-by: Akshay Siwal <akshay.singh.siwal@gmail.com>	2 years ago
Björn Rabenstein	b727e69b76	Merge pull request #12350 from prometheus/beorn7/histogram ... textparse/scrape: Add option to scrape both classic and native histograms	2 years ago
beorn7	9e500345f3	textparse/scrape: Add option to scrape both classic and native histograms ... So far, if a target exposes a histogram with both classic and native buckets, a native-histogram enabled Prometheus would ignore the classic buckets. With the new scrape config option `scrape_classic_histograms` set, both buckets will be ingested, creating all the series of a classic histogram in parallel to the native histogram series. For example, a histogram `foo` would create a native histogram series `foo` and classic series called `foo_sum`, `foo_count`, and `foo_bucket`. This feature can be used in a migration strategy from classic to native histograms, where it is desired to have a transition period during which both native and classic histograms are present. Note that two bugs in classic histogram parsing were found and fixed as a byproduct of testing the new feature: 1. Series created from classic _gauge_ histograms didn't get the _sum/_count/_bucket prefix set. 2. Values of classic _float_ histograms weren't parsed properly. Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
Bryan Boreham	734baa37e0	Merge pull request #12344 from bboreham/rw-stable ... docs: state that remote write sending is stable	2 years ago
Bryan Boreham	b1b8fd77c4	docs: state that remote write is stable ... Since https://github.com/prometheus/docs/pull/2313 has been merged declaring remote write to be stable at version 1.0. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Jeanette Tan	40240c9c1c	Update according to code review ... Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2 years ago
François Gouteroux	b1bab7bc54	feat(promtool): add push metrics command ... Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>	2 years ago
Jeanette Tan	2ad39baa72	Treat bucket limit like sample limit and make it fail the whole scrape and return an error ... Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2 years ago
Jeanette Tan	d3ad158a66	Update docs and comments ... Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	2 years ago
John Losito	ecf6bfa619	Update configuration.md ... Signed-off-by: John Losito <lositojohnj@gmail.com>	2 years ago
gotjosh	74e6668e87	update docs ... Signed-off-by: gotjosh <josue.abreu@gmail.com>	2 years ago
gotjosh	cf230bcd18	more wordsmithing ... Signed-off-by: gotjosh <josue.abreu@gmail.com>	2 years ago
gotjosh	28909a4636	more worthsmithing ... Signed-off-by: gotjosh <josue.abreu@gmail.com>	2 years ago
gotjosh	e2a2790b2c	add more docs ... Signed-off-by: gotjosh <josue.abreu@gmail.com>	2 years ago
gotjosh	f3394bf7a1	Rules API: Allow filtering by rule name ... Introduces support for a new query parameter in the `/rules` API endpoint that allows filtering by rule names. If all the rules of a group are filtered, we skip the group entirely. Signed-off-by: gotjosh <josue.abreu@gmail.com>	2 years ago
beorn7	c0879d64cf	promql: Separate `Point` into `FPoint` and `HPoint` ... In other words: Instead of having a “polymorphous” `Point` that can either contain a float value or a histogram value, use an `FPoint` for floats and an `HPoint` for histograms. This seemingly small change has a _lot_ of repercussions throughout the codebase. The idea here is to avoid the increase in size of `Point` arrays that happened after native histograms had been added. The higher-level data structures (`Sample`, `Series`, etc.) are still “polymorphous”. The same idea could be applied to them, but at each step the trade-offs needed to be evaluated. The idea with this change is to do the minimum necessary to get back to pre-histogram performance for functions that do not touch histograms. Here are comparisons for the `changes` function. The test data doesn't include histograms yet. Ideally, there would be no change in the benchmark result at all. First runtime v2.39 compared to directly prior to this commit: ``` name old time/op new time/op delta RangeQuery/expr=changes(a_one[1d]),steps=1-16 391µs ± 2% 542µs ± 1% +38.58% (p=0.000 n=9+8) RangeQuery/expr=changes(a_one[1d]),steps=10-16 452µs ± 2% 617µs ± 2% +36.48% (p=0.000 n=10+10) RangeQuery/expr=changes(a_one[1d]),steps=100-16 1.12ms ± 1% 1.36ms ± 2% +21.58% (p=0.000 n=8+10) RangeQuery/expr=changes(a_one[1d]),steps=1000-16 7.83ms ± 1% 8.94ms ± 1% +14.21% (p=0.000 n=10+10) RangeQuery/expr=changes(a_ten[1d]),steps=1-16 2.98ms ± 0% 3.30ms ± 1% +10.67% (p=0.000 n=9+10) RangeQuery/expr=changes(a_ten[1d]),steps=10-16 3.66ms ± 1% 4.10ms ± 1% +11.82% (p=0.000 n=10+10) RangeQuery/expr=changes(a_ten[1d]),steps=100-16 10.5ms ± 0% 11.8ms ± 1% +12.50% (p=0.000 n=8+10) RangeQuery/expr=changes(a_ten[1d]),steps=1000-16 77.6ms ± 1% 87.4ms ± 1% +12.63% (p=0.000 n=9+9) RangeQuery/expr=changes(a_hundred[1d]),steps=1-16 30.4ms ± 2% 32.8ms ± 1% +8.01% (p=0.000 n=10+10) RangeQuery/expr=changes(a_hundred[1d]),steps=10-16 37.1ms ± 2% 40.6ms ± 2% +9.64% (p=0.000 n=10+10) RangeQuery/expr=changes(a_hundred[1d]),steps=100-16 105ms ± 1% 117ms ± 1% +11.69% (p=0.000 n=10+10) RangeQuery/expr=changes(a_hundred[1d]),steps=1000-16 783ms ± 3% 876ms ± 1% +11.83% (p=0.000 n=9+10) ``` And then runtime v2.39 compared to after this commit: ``` name old time/op new time/op delta RangeQuery/expr=changes(a_one[1d]),steps=1-16 391µs ± 2% 547µs ± 1% +39.84% (p=0.000 n=9+8) RangeQuery/expr=changes(a_one[1d]),steps=10-16 452µs ± 2% 616µs ± 2% +36.15% (p=0.000 n=10+10) RangeQuery/expr=changes(a_one[1d]),steps=100-16 1.12ms ± 1% 1.26ms ± 1% +12.20% (p=0.000 n=8+10) RangeQuery/expr=changes(a_one[1d]),steps=1000-16 7.83ms ± 1% 7.95ms ± 1% +1.59% (p=0.000 n=10+8) RangeQuery/expr=changes(a_ten[1d]),steps=1-16 2.98ms ± 0% 3.38ms ± 2% +13.49% (p=0.000 n=9+10) RangeQuery/expr=changes(a_ten[1d]),steps=10-16 3.66ms ± 1% 4.02ms ± 1% +9.80% (p=0.000 n=10+9) RangeQuery/expr=changes(a_ten[1d]),steps=100-16 10.5ms ± 0% 10.8ms ± 1% +3.08% (p=0.000 n=8+10) RangeQuery/expr=changes(a_ten[1d]),steps=1000-16 77.6ms ± 1% 78.1ms ± 1% +0.58% (p=0.035 n=9+10) RangeQuery/expr=changes(a_hundred[1d]),steps=1-16 30.4ms ± 2% 33.5ms ± 4% +10.18% (p=0.000 n=10+10) RangeQuery/expr=changes(a_hundred[1d]),steps=10-16 37.1ms ± 2% 40.0ms ± 1% +7.98% (p=0.000 n=10+10) RangeQuery/expr=changes(a_hundred[1d]),steps=100-16 105ms ± 1% 107ms ± 1% +1.92% (p=0.000 n=10+10) RangeQuery/expr=changes(a_hundred[1d]),steps=1000-16 783ms ± 3% 775ms ± 1% -1.02% (p=0.019 n=9+9) ``` In summary, the runtime doesn't really improve with this change for queries with just a few steps. For queries with many steps, this commit essentially reinstates the old performance. This is good because the many-step queries are the one that matter most (longest absolute runtime). In terms of allocations, though, this commit doesn't make a dent at all (numbers not shown). The reason is that most of the allocations happen in the sampleRingIterator (in the storage package), which has to be addressed in a separate commit. Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
François Gouteroux	8472596fd0	fix: apply suggested changes ... Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>	2 years ago
François Gouteroux	034eb2b3f2	promtool: read from stdin if no filenames are provided in check rules ... Signed-off-by: François Gouteroux <francois.gouteroux@gmail.com>	2 years ago