prometheus

Commit Graph

Author	SHA1	Message	Date
Björn Rabenstein	dbb4055633	Merge pull request #13593 from machine424/no-index discovery: kubernetes: Avoid creating unnecessary Kubernetes indexers…	9 months ago
Augustin Husson	9738e48a7d	Merge pull request #13629 from prometheus/release-2.50 merge back release 2.50	9 months ago
machine424	92544c00bf	discovery: kubernetes: Avoid creating unnecessary Kubernetes indexers in RoleEndpointSlice This was due to a missing "return", see https://github.com/prometheus/prometheus/pull/13554#discussion_r1490965817 Signed-off-by: machine424 <ayoubmrini424@gmail.com>	9 months ago
Darshan Chaudhary	0e8a2e44a4	Azure SD: check for nil before accessing and dereferencing (#13578 ) Signed-off-by: darshanime <deathbullet@gmail.com>	10 months ago
Bryan Boreham	6005ac6f9d	Merge pull request #9311 from Creatone/creatone/use-testify-3 tests: Move from t.Errorf and others. (Part 3)	10 months ago
Bryan Boreham	857138d3ce	review feedback Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	10 months ago
Bryan Boreham	b17f88b7fb	consul sd tests: don't call FailNow from a background goroutine This is not allowed by the Go test framework. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	10 months ago
Bryan Boreham	46008fdecd	lint Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	10 months ago
Ayoub Mrini	581d8d86b4	Pod status changes not discovered by Kube Endpoints SD (#13337 ) * fix(discovery/kubernetes/endpoints): react to changes on Pods because some modifications can occur on them without triggering an update on the related Endpoints (The Pod phase changing from Pending to Running e.g.). --------- Signed-off-by: machine424 <ayoubmrini424@gmail.com> Co-authored-by: Guillermo Sanchez Gavier <gsanchez@newrelic.com>	10 months ago
Paweł Szulik	7f24efccdb	Refactor discovery tests to use testify. Signed-off-by: Paweł Szulik <paul.szulik@gmail.com>	10 months ago
tyltr	b538919258	remove redundant code Signed-off-by: tyltr <tylitianrui@126.com>	10 months ago
Julien Pivotto	960b6266e2	Merge pull request #13447 from ptodev/update-puppetdb-metric-label Change metric label for Puppet SD from 'http' to 'puppetdb'	10 months ago
Augustin Husson	9a9e73b34a	update all go dependencies (#13438 ) Signed-off-by: Augustin Husson <husson.augustin@gmail.com>	10 months ago
Paulin Todev	53589fde4f	Change metric label for Puppetdb from 'http' to 'puppetdb' Signed-off-by: Paulin Todev <paulin.todev@gmail.com>	10 months ago
Paulin Todev	78411d5e8b	SD Managers taking over responsibility for registration of debug metrics (#13375 ) SD Managers take over responsibility for SD metrics registration --------- Signed-off-by: Paulin Todev <paulin.todev@gmail.com> Signed-off-by: Björn Rabenstein <github@rabenste.in> Co-authored-by: Björn Rabenstein <github@rabenste.in>	10 months ago
Bryan Boreham	b9952ff571	Merge pull request #13380 from machine424/fixes fix(discovery tests): allow requireUpdate util to timeout in discovery/file…	10 months ago
machine424	2d01e56695	chore(kubernetes): check preconditions earlier and avoid unnecessary checks or iterations Signed-off-by: machine424 <ayoubmrini424@gmail.com>	10 months ago
Bartlomiej Plotka	db3544c552	Merge branch 'main' into merge-2.49.0-back Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>	11 months ago
machine424	afc05129f1	fix(discovery): allow requireUpdate util to timeout in discovery/file/file_test.go. The loop ran indefinitely if the condition isn't met. Before, each iteration created a new timer channel which was always outpaced by the other timer channel with smaller duration. minor detail: There was a memory leak: resources of the ~10 previous timers were constantly kept. With the fix, we may keep the resources of one timer around for defaultWait but this isn't worth the changes to make it right. Signed-off-by: machine424 <ayoubmrini424@gmail.com>	11 months ago
daniel-resdiary	d79ad810aa	Get VM Scale Set NIC (#13283 ) Calling `armnetwork.InterfacesClient.Get()` doesn't work for Scale Set VM NIC, because these use a different Resource ID format. Use `armnetwork.InterfacesClient.GetVirtualMachineScaleSetNetworkInterface()` instead. This needs both the scale set name and the instance ID, so add an `InstanceID` field to the `virtualMachine` struct. `InstanceID` is empty for a VM that isn't a ScaleSetVM. Signed-off-by: Daniel Nicholls <daniel.nicholls@resdiary.com>	11 months ago
Julien Pivotto	5d5303c746	Merge pull request #13285 from daniel-resdiary/DedupGetNic Dedup code handling getting network interface	11 months ago
Julien Pivotto	7600e6cc05	Merge pull request #13294 from mmorel-35/azure build(deps): bump github.com/Azure/azure-sdk-for-go/sdk/resourcemanager	11 months ago
Julien Pivotto	10557ed8e0	Merge pull request #13278 from Automaat/feat/extend-kuma-sd-api kuma_sd: Extend Kuma SD configuration to allow users to specify ClientId	11 months ago
Matthieu MOREL	952cb41373	build(deps): bump github.com/Azure/azure-sdk-for-go/sdk/resourcemanager Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	12 months ago
Daniel Nicholls	0704c72548	Dedup code handling getting network interface Signed-off-by: Daniel Nicholls <daniel.nicholls@resdiary.com>	12 months ago
daniel-resdiary	103133124a	Get VM Scale Set NIC (#13283 ) Calling `armnetwork.InterfacesClient.Get()` doesn't work for Scale Set VM NIC, because these use a different Resource ID format. Use `armnetwork.InterfacesClient.GetVirtualMachineScaleSetNetworkInterface()` instead. This needs both the scale set name and the instance ID, so add an `InstanceID` field to the `virtualMachine` struct. `InstanceID` is empty for a VM that isn't a ScaleSetVM. Signed-off-by: Daniel Nicholls <daniel.nicholls@resdiary.com>	12 months ago
Marcin Skalski	e27232614a	code review Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>	12 months ago
Marcin Skalski	0af810aa71	fix go lint Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>	12 months ago
Marcin Skalski	d12ccf9fa2	kuma_sd: Extend Kuma SD configuration to allow users to specify ClientId Signed-off-by: Marcin Skalski <skalskimarcin33@gmail.com>	12 months ago
Paulin Todev	d2e997030e	Fix linter issues Signed-off-by: Paulin Todev <paulin.todev@gmail.com>	12 months ago
Paulin Todev	27bb57a37b	Define metric label values in one place Signed-off-by: Paulin Todev <paulin.todev@gmail.com>	12 months ago
Paulin Todev	108a749a45	Set up labels for counters in advance Signed-off-by: Paulin Todev <paulin.todev@gmail.com>	12 months ago
Paulin Todev	6a5306a53c	Use const labels for Discovery Manager metrics. Signed-off-by: Paulin Todev <paulin.todev@gmail.com>	12 months ago
Paulin Todev	6de80d7fb0	Allow non-default registry to be used for metrics of SD components Signed-off-by: Paulin Todev <paulin.todev@gmail.com>	12 months ago
Gavin Lam	d5924f305b	Fix missing public IP addresses in Azure service discovery (#13241 ) Fixes #5588, #9293 Signed-off-by: Gavin Lam <gavin.oss@tutamail.com>	12 months ago
Matthieu MOREL	9c4782f1cc	golangci-lint: enable testifylint linter (#13254 ) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	12 months ago
Julien Pivotto	52b15d2195	Merge pull request #13219 from djcode/main Discovery: Add support for NS records to DNS Discovery	1 year ago
Daniel Jolly	9ebea5e1ca	Removed extra whitespace Signed-off-by: Daniel Jolly <code@danieljolly.com>	1 year ago
Oleksandr Redko	2a75604f8e	Enable default revive rules (#13068 ) Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>	1 year ago
Daniel Jolly	2c420b518e	Add support for NS records in DNS discovery Signed-off-by: Daniel Jolly <code@danieljolly.com>	1 year ago
Charles Korn	2329fba0e5	Fix linting issues in comments (#13178 ) Signed-off-by: Charles Korn <charles.korn@grafana.com>	1 year ago
Etourneau Gwenn	b37258c99b	Added Caching of network interface for Azure (#12622 ) * Added Caching of network interface for Azure Signed-off-by: Etourneau Gwenn <getourneau@yugabyte.com> * Rename Counter for Azure cache Signed-off-by: Etourneau Gwenn <getourneau@yugabyte.com> * Format with goimports Signed-off-by: Etourneau Gwenn <getourneau@yugabyte.com> * Updated duration comparaison Enabled cache by default with 5x the default refresh time Signed-off-by: Etourneau Gwenn <getourneau@yugabyte.com> * Change random function Signed-off-by: Etourneau Gwenn <getourneau@yugabyte.com> * Remove refresh interval Signed-off-by: Etourneau Gwenn <getourneau@yugabyte.com> * Remove from config as well Signed-off-by: Etourneau Gwenn <getourneau@yugabyte.com> * Reformat config_test Removed uneeded error Signed-off-by: Etourneau Gwenn <getourneau@yugabyte.com> --------- Signed-off-by: Etourneau Gwenn <getourneau@yugabyte.com>	1 year ago
Bryan Boreham	6613195487	Merge pull request #13097 from roidelapluie/gpu Linode SD: Add __meta_linode_gpus label	1 year ago
Julien Pivotto	222d46d243	Linode: Add GPU label Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	1 year ago
Matthieu MOREL	fe057fc60d	use Go standard errors package Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	1 year ago
Oleksandr Redko	fa90ca46e5	ci(lint): enable godot; append dot at the end of comments Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>	1 year ago
Matthieu MOREL	68e6b4dd34	ci(lint): enable errorlint on discovery (#12918 ) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	1 year ago
Oleksandr Redko	8e5f0387a2	ci(lint): enable nolintlint and remove redundant comments (#12926 ) Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>	1 year ago
Matthieu MOREL	bbdc7d5902	Update Azure SDK For Go Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	1 year ago
Julien Pivotto	4b735f02a6	Merge pull request #10569 from zzJinux/discovery-manager-run Fix discovery managers to be properly cancelled	1 year ago
Julien Pivotto	d659e672f1	Merge pull request #12816 from slashpai/lightsail LIGHTSAIL SD: Validate HTTP config	1 year ago
Julien Pivotto	738e0dbaf0	Merge pull request #12814 from slashpai/puppetdb PUPPETDB SD: Validate HTTP config	1 year ago
Julien Pivotto	a2208b2849	Merge pull request #12815 from slashpai/Uyuni UYUNI SD: Validate HTTP config	1 year ago
Jayapriya Pai	57988fda75	LIGHTSAIL SD: Validate HTTP config Related-to #12810 Signed-off-by: Jayapriya Pai <janantha@redhat.com>	1 year ago
Jayapriya Pai	344f9d8d15	PUPPETDB SD: Validate HTTP config Related-to #12810 Signed-off-by: Jayapriya Pai <janantha@redhat.com>	1 year ago
Jayapriya Pai	34c8dcc73f	UYUNI SD: Validate HTTP config Related-to #12810 Signed-off-by: Jayapriya Pai <janantha@redhat.com>	1 year ago
Julien Pivotto	75470ba815	Merge pull request #12812 from slashpai/azure AZURE SD: Validate HTTP config	1 year ago
Jayapriya Pai	e44d5dfb3a	AZURE SD: Validate HTTP config Related-to #12810 Signed-off-by: Jayapriya Pai <janantha@redhat.com>	1 year ago
Jayapriya Pai	7f085aeb6a	EC2 SD: Validate HTTP config Related-to #12810 Signed-off-by: Jayapriya Pai <janantha@redhat.com>	1 year ago
Julien Pivotto	8498b96a2b	HTTP SD: Validate HTTP config Fixes #12762 Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	1 year ago
Julien Pivotto	009017a3fb	Revert "Remove deleted target from discovery manager" Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	1 year ago
Julien Pivotto	103b8567d6	Merge pull request #12541 from haleyao/main Remove deleted target from discovery manager	1 year ago
Julien Pivotto	ea039fcebf	Merge pull request #11463 from proggga/small_refactor marathon.go: Simplified conditions in method	1 year ago
Marc Tuduri	98383fdc63	sd: change hetzner role type and constants to be exportable Signed-off-by: Marc Tuduri <marctc@protonmail.com>	1 year ago
Julien Pivotto	2bdb2e627f	Merge pull request #10914 from wangrzneu/add-endpointslice-label Add more labels for endpointslice and endpoints role in k8s discovery	1 year ago
Julian Tölle	7aa7965716	build(deps): bump github.com/hetznercloud/hcloud-go to v2.0.0 Version 2 introduced a breaking change in the `id` field of all resources. They were changed from `int` to `int64` to make sure that all future numerical IDs are supported on all architectures. You can learn more about this [here](https://docs.hetzner.cloud/#deprecation-notices-%E2%9A%A0%EF%B8%8F) Signed-off-by: Julian Tölle <julian.toelle@hetzner-cloud.de>	1 year ago
Daniel Swarbrick	de89a8c827	Linode SD: cast InstanceSpec values to int64 to avoid overflows InstanceSpec struct members are untyped integers, so they can overflow on 32-bit arch when bit-shifted left. Signed-off-by: Daniel Swarbrick <daniel.swarbrick@gmail.com>	1 year ago
Mikhail Fesenko	02e11cc2a7	Fix from discussion Signed-off-by: Mikhail Fesenko <proggga@gmail.com>	1 year ago
Mikhail Fesenko	17cdfdd79f	maraphon.go: Simplified conditions in method Signed-off-by: Mikhail Fesenko <proggga@gmail.com>	1 year ago
haleyao	c5a37ddad5	Remove deleted target from discovery manager Signed-off-by: haleyao <haleyao@tencent.com>	1 year ago
Julien Pivotto	076056ccdf	Merge pull request #11642 from zoonage/main Do not add pods to target group if the PodIP status is not set	1 year ago
Taavi Väänänen	0f4c27e2bf	discovery/openstack: Include instance image ID in labels Adds a new label to include the ID of the image that an instance is using. This can be used for example to filter a job to only include instances using a certain image as that image includes some exporter. Sometimes the image information isn't available, such as when the image is private and the user doesn't have the roles required to see it. In those cases we just don't set the label, as the rest of the information from the discovery provider can still be used. Signed-off-by: Taavi Väänänen <hi@taavi.wtf>	1 year ago
Matt Harbison	02277bbe0d	Fix path handling in File-SD watcher to allow directory monitoring on Windows Previously, `d.paths` were normalized to backslashes on Windows, even when if the config file used Unix style. The end result meant always watching `./`, so changes for this config were always ignored: scrape_configs: - job_name: 'envmsc1' file_sd_configs: - files: - 'targets/envmsc1.d/.yml' - 'targets/envmsc1.d/.yaml' Additionally, unlike the other platforms, no warning was emitted on startup about not being able to install the watch if the directory didn't exist. Now it is logged. Signed-off-by: Matt Harbison <mharbison@atto.com>	1 year ago
renzheng.wang	b2c5de2e65	fix lint issue Signed-off-by: renzheng.wang <wangrzneu@gmail.com>	2 years ago
renzheng.wang	98ffad01b8	update tests and docs Signed-off-by: renzheng.wang <wangrzneu@gmail.com>	2 years ago
renzheng.wang	866fa25b20	add label and labelpresent for endpointslice role in k8s discovery Signed-off-by: renzheng.wang <wangrzneu@gmail.com>	2 years ago
Julien Pivotto	0dc31ade41	Add support for consul path_prefix Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Mickael Carl	2f35619710	discovery/kubernetes: attach node labels when the endpoints TargetRef's kind are Node Signed-off-by: Mickael Carl <mcarl@apple.com>	2 years ago
cui fliter	276ca6a883	fix some comments Signed-off-by: cui fliter <imcusg@gmail.com>	2 years ago
Matthieu MOREL	bae9a21200	Merge branch 'main' into linter/nilerr Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	2 years ago
beorn7	5b53aa1108	style: Replace `else if` cascades with `switch` Wiser coders than myself have come to the conclusion that a `switch` statement is almost always superior to a statement that includes any `else if`. The exceptions that I have found in our codebase are just these two: * The `if else` is followed by an additional statement before the next condition (separated by a `;`). * The whole thing is within a `for` loop and `break` statements are used. In this case, using `switch` would require tagging the `for` loop, which probably tips the balance. Why are `switch` statements more readable? For one, fewer curly braces. But more importantly, the conditions all have the same alignment, so the whole thing follows the natural flow of going down a list of conditions. With `else if`, in contrast, all conditions but the first are "hidden" behind `} else if `, harder to spot and (for no good reason) presented differently from the first condition. I'm sure the aforemention wise coders can list even more reasons. In any case, I like it so much that I have found myself recommending it in code reviews. I would like to make it a habit in our code base, without making it a hard requirement that we would test on the CI. But for that, there has to be a role model, so this commit eliminates all `if else` occurrences, unless it is autogenerated code or fits one of the exceptions above. Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
beorn7	c3c7d44d84	lint: Adjust to the lint warnings raised by current versions of golint-ci We haven't updated golint-ci in our CI yet, but this commit prepares for that. There are a lot of new warnings, and it is mostly because the "revive" linter got updated. I agree with most of the new warnings, mostly around not naming unused function parameters (although it is justified in some cases for documentation purposes – while things like mocks are a good example where not naming the parameter is clearer). I'm pretty upset about the "empty block" warning to include `for` loops. It's such a common pattern to do something in the head of the `for` loop and then have an empty block. There is still an open issue about this: https://github.com/mgechev/revive/issues/810 I have disabled "revive" altogether in files where empty blocks are used excessively, and I have made the effort to add individual `// nolint:revive` where empty blocks are used just once or twice. It's borderline noisy, though, but let's go with it for now. I should mention that none of the "empty block" warnings for `for` loop bodies were legitimate. Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
Matthieu MOREL	fb3eb21230	enable gocritic, unconvert and unused linters Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	2 years ago
Julien Pivotto	5f3a02f1e2	Update go dependencies Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Fish-pro	43d77f7c41	Use http constants instead of string Signed-off-by: Fish-pro <zechun.chen@daocloud.io>	2 years ago
Peter Nicholson	138a1362d8	Add support for EndpointSlice conditions Signed-off-by: Peter Nicholson <petergoods@hotmail.com>	2 years ago
Frederic Branczyk	9f91215bf6	Merge pull request #11844 from bawhetst/add-pod-container-id discovery/kubernetes: add container ID as a meta label for pod targets	2 years ago
Bryan Boreham	b768247df8	Merge pull request #11760 from bboreham/discovery-log-setname service discovery: add name to log messages	2 years ago
Bryan Boreham	2f58be840d	service discovery: add config name to log messages This makes it easier to connect a log message with the config it relates to. Each SD config has a name, either the scrape job name or something like "config-0" for Alertmanager config. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Ben Whetstone	32e9f6a39c	Add container ID as a meta label for pod targets Signed-off-by: Ben Whetstone <ben.whetstone@sysdig.com>	2 years ago
Jens Erat	728fdc959e	Kubernetes SD: disable resync timer While originally the resync period also forced refreshing from Kubernetes API server, this has been removed for some years now because watching the API server got more stable [1]. Today, this just results in all entities being sent to the service discovery again, which is valid from a general Prometheus perspective, but results in unnecessary CPU load and also breaks service discovery metrics. In especially, this makes monitoring "do we actually observe changes from Kubernetes API server" impossible (receiving constant updates from Kubernetes service discovery is a pretty valid assumption, for example nodes get frequent status updates, ...). Signed-off-by: Jens Erat <jens.erat@mercedes-benz.com>	2 years ago
David Fridman	52adf55631	Add VM size label to azure service discovery (#11575 ) (#11650 ) * Add VM size label to azure service discovery (#11575) Signed-off-by: davidifr <davidfr.mail@gmail.com> * Add VM size label to azure service discovery (#11575) Signed-off-by: davidifr <davidfr.mail@gmail.com> * Add VM size label to azure service discovery (#11575) Signed-off-by: davidifr <davidfr.mail@gmail.com> Signed-off-by: davidifr <davidfr.mail@gmail.com>	2 years ago
Julien Pivotto	3677d61a4b	Update kubernetes dependencies A new API is available for AddEventHandlers, to get errors but also be able to cancel handlers. Doing the easy thing for the release, which is just to log errors. We could see how to improve this in the future to handle the errors properly and cancel the handlers. Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Aaron George	d542483e8c	k8s discovery: Ensure that the pod IP is in the status before adding to target group Signed-off-by: Aaron George <aaron@ometria.com> Signed-off-by: Aaron George <aaron@ometria.com>	2 years ago
Levi Harrison	f81fae2414	Add common HTTP client to AWS SDs (#11611 ) * Common client in EC2 and Lightsail Signed-off-by: Levi Harrison <git@leviharrison.dev> * Azure -> AWS Signed-off-by: Levi Harrison <git@leviharrison.dev> Signed-off-by: Levi Harrison <git@leviharrison.dev>	2 years ago
Michael Fuller	15ba7a0d2d	file sd: create and increment an inotify error counter when file-SD i… (#11066 ) * file sd: create and increment an inotify error counter when file-SD is unable to watch files. Additionally, order metrics alphabetically. Signed-off-by: Michael Fuller <mfuller@digitalocean.com> * file.go: consistent naming and help for prometheus_sd_file_watcher_errors_total Signed-off-by: Michael Fuller <mfuller@digitalocean.com> Signed-off-by: Michael Fuller <mfuller@digitalocean.com> Co-authored-by: Michael Fuller <mfuller@digitalocean.com>	2 years ago
Julien Pivotto	7a67a728a8	Followup on OVHCloud merge (#11529 ) Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu> Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Marine Bal	16c3aa75c0	Add service discovery for OvhCloud (#10802 ) * feat(ovhcloud): add ovhcloud management Signed-off-by: Marine Bal <marine.bal@corp.ovh.com> Co-authored-by: Arnaud Sinays <sinaysarnaud@gmail.com>	2 years ago
Viacheslav Panasovets	3d2e18bad5	Fix time.Since() in defer. Wrap in anonymous function (#11489 ) Function arguments in defer evaluated during definition of defer, not during execution Signed-off-by: Slavik Panasovets <slavik@google.com> Signed-off-by: Slavik Panasovets <slavik@google.com>	2 years ago
David Cañadillas	51a44e6657	Adding Consul Enterprise Admin Partitions (#11482 ) * Adding Consul Enterprise Admin Partitions Signed-off-by: dcanadillas <dcanadillas@hashicorp.com>	2 years ago

1 2 3 4 5 ...

738 Commits (5aa3d8260a7335a0da6946dea82f608cafa46c20)