7ec4a11472
promtool: Avoid using testify for user rule tests
...
Using testify outside of unit tests results in panics rather than a
useful error for the user.
Fixes #13703
Signed-off-by: David Leadbeater <dgl@dgl.cx>
2024-03-21 22:08:10 +11:00
191c467f16
build(deps): bump github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute/v5
...
Bumps [github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute/v5](https://github.com/Azure/azure-sdk-for-go ) from 5.5.0 to 5.6.0.
- [Release notes](https://github.com/Azure/azure-sdk-for-go/releases )
- [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md )
- [Commits](https://github.com/Azure/azure-sdk-for-go/compare/sdk/resourcemanager/compute/armcompute/v5.5.0...sdk/resourcemanager/compute/armcompute/v5.6.0 )
---
updated-dependencies:
- dependency-name: github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/compute/armcompute/v5
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-03-21 08:15:52 +00:00
9bdb6f6554
build(deps): bump github.com/linode/linodego from 1.29.0 to 1.30.0
...
Bumps [github.com/linode/linodego](https://github.com/linode/linodego ) from 1.29.0 to 1.30.0.
- [Release notes](https://github.com/linode/linodego/releases )
- [Commits](https://github.com/linode/linodego/compare/v1.29.0...v1.30.0 )
---
updated-dependencies:
- dependency-name: github.com/linode/linodego
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-03-21 08:15:15 +00:00
33138174d4
build(deps): bump the k8s-io group with 3 updates
...
Bumps the k8s-io group with 3 updates: [k8s.io/api](https://github.com/kubernetes/api ), [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery ) and [k8s.io/client-go](https://github.com/kubernetes/client-go ).
Updates `k8s.io/api` from 0.29.2 to 0.29.3
- [Commits](https://github.com/kubernetes/api/compare/v0.29.2...v0.29.3 )
Updates `k8s.io/apimachinery` from 0.29.2 to 0.29.3
- [Commits](https://github.com/kubernetes/apimachinery/compare/v0.29.2...v0.29.3 )
Updates `k8s.io/client-go` from 0.29.2 to 0.29.3
- [Changelog](https://github.com/kubernetes/client-go/blob/master/CHANGELOG.md )
- [Commits](https://github.com/kubernetes/client-go/compare/v0.29.2...v0.29.3 )
---
updated-dependencies:
- dependency-name: k8s.io/api
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/apimachinery
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
- dependency-name: k8s.io/client-go
dependency-type: direct:production
update-type: version-update:semver-patch
dependency-group: k8s-io
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-03-21 08:15:04 +00:00
0c58987bc9
build(deps): bump actions/setup-node from 4.0.1 to 4.0.2
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.0.1 to 4.0.2.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](b39b52d121...60edb5dd54
2024-03-21 08:14:40 +00:00
94d13099b4
build(deps): bump actions/cache from 4.0.1 to 4.0.2
...
Bumps [actions/cache](https://github.com/actions/cache ) from 4.0.1 to 4.0.2.
- [Release notes](https://github.com/actions/cache/releases )
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md )
- [Commits](ab5e6d0c87...0c45773b62
2024-03-21 08:14:36 +00:00
4eadb42c43
build(deps): bump bufbuild/buf-setup-action from 1.28.1 to 1.30.0
...
Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action ) from 1.28.1 to 1.30.0.
- [Release notes](https://github.com/bufbuild/buf-setup-action/releases )
- [Commits](382440cdb8...517ee23296
2024-03-21 08:14:24 +00:00
b5a2331c69
build(deps): bump golangci/golangci-lint-action from 3.7.0 to 4.0.0
...
Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action ) from 3.7.0 to 4.0.0.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases )
- [Commits](3a91952989...3cfe3a4abb
2024-03-21 08:14:18 +00:00
a192d4a04b
build(deps): bump actions/checkout from 4.1.1 to 4.1.2 in /scripts
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.1 to 4.1.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](b4ffde65f4...9bb56186c3
2024-03-21 08:14:12 +00:00
61481160d7
Merge pull request #13386 from linuxgcc/dev2
...
Fix binary detection in Makefile
2024-03-21 09:13:32 +01:00
d9e4353520
Fix binary detection in Makefile
...
Signed-off-by: heyitao <heyitao@uniontech.com>
2024-03-21 11:32:23 +08:00
c7ca85388f
Fix yaml file format and clear ci errors
...
Signed-off-by: heyitao <heyitao@uniontech.com>
2024-03-21 11:32:02 +08:00
f6834c347a
promql: validate `label_join` destination label
...
Signed-off-by: tdakkota <tanc13@yandex.ru>
2024-03-20 22:02:10 +03:00
2a2e2ed28b
chore(tsdb): set the wbl to nil as well in DBReadOnly.loadDataAsQueryable
...
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
2024-03-20 17:13:39 +01:00
07332f7427
TestTimeRetention: Split into two sub-tests
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2024-03-20 15:06:36 +01:00
a9a4fbafb0
Merge pull request #13795 from prometheus/beorn7/maintainers
...
Tweak MAINTAINERS.md
2024-03-20 13:19:10 +01:00
af694dc295
Merge TestDB_BeyondTimeRetention into TestTimeRetention
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2024-03-20 09:07:16 +01:00
11fc7b1d83
chores: bump to golangci-lint v1.56.2 ( #13753 )
...
bump to golangci-lint to v1.56.2
---------
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
2024-03-19 19:24:37 +01:00
7ba218fbd0
Merge pull request #13791 from bboreham/merge-2.51.0
...
Merge 2.51.0 into main
2024-03-19 19:15:25 +01:00
70c7be647b
Merge pull request #13781 from gouthamve/add-arve-as-codeowner-for-otlp
...
Add Arve as OTLP ingest maintainer
2024-03-19 18:41:02 +01:00
742196b6c4
add context cancellation check at get series result iteration ( #13766 )
...
* add context cancellation check at get series iteration
* add warnings and closer on error
* add test
---------
Signed-off-by: Erlan Zholdubai uulu <erlanz@amazon.com>
2024-03-19 18:37:43 +01:00
16164226e5
Merge pull request #13782 from colega/improve-stringlabels-compare
...
Improve `Labels.Compare()` performance with `stringlabels`
2024-03-19 18:29:32 +01:00
e14af52e48
Tweak MAINTAINERS.md
...
After #13771 , the list for specific parts of the codebase looks like
it is part of the "general maintainers" list. This commit makes things
clearer.
Signed-off-by: beorn7 <beorn@grafana.com>
2024-03-19 18:23:55 +01:00
ac257aa071
Merge pull request #13789 from prometheus/superq/common_repo
...
Fixup make target in container description
2024-03-19 12:00:17 +01:00
0630e49c0d
Merge branch 'main' into merge-2.51.0
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-03-19 11:56:14 +01:00
c05c15512a
Cut v2.51.0 ( #13787 )
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-03-19 10:49:40 +00:00
45c2b11187
Fixup make target in container description
...
Use `docker-repo-name` as the make target so that a repo Makfile can
override the common target implementation.
Signed-off-by: SuperQ <superq@gmail.com>
2024-03-19 11:29:39 +01:00
9c7a734063
tsdb.BeyondTimeRetention: Fix comment and test at retention duration
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2024-03-19 09:10:21 +01:00
d0ecf9b8fc
Merge pull request #13783 from prometheus/superq/sync_fixup
...
Add container_description.yml to force sync list
2024-03-18 11:58:15 +01:00
d12e785075
Improve readability
...
As suggested by @bboreham
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
2024-03-18 11:16:09 +01:00
161354e861
Add container_description.yml to force sync list
...
Since we skip repos that don't have a Dockerfile, we can force sync the
`.github/workflows/container_description.yml` config.
Signed-off-by: SuperQ <superq@gmail.com>
2024-03-18 08:20:42 +01:00
2c267389f6
Merge pull request #13768 from charleskorn/readme-publish-workflow
...
Signed-off-by: Ben Kochie <superq@gmail.com>
2024-03-18 08:17:40 +01:00
b641715363
Support copying workflow as-is to other Prometheus repositories.
...
Signed-off-by: Charles Korn <charles.korn@grafana.com>
2024-03-18 10:33:56 +11:00
9699598952
Improve Labels.Compare performance w/stringlabels
...
I was bored on a train and I spent some amount of time trying to scratch
some nanoseconds off the Labels.Compare when running with stringlabels.
I would be ashamed to admit the real amount of time I spent on it.
The worst thing is, I can't really explain why this is performing so
much better, and someone should re-run the benchmarks on their machine
to confirm that it's not something related to general relativity because
the train is moving. I also added some extra real-life benchmark cases
with longer labelsets (these aren't the longest we have in production,
but kubernetes labelsets are fairly common in Prometheus so I thought it
would be nice to have them).
My benchmarks show this diff:
goos: darwin
goarch: arm64
pkg: github.com/prometheus/prometheus/model/labels
│ old │ new │
│ sec/op │ sec/op vs base │
Labels_Compare/equal 5.898n ± 0% 5.875n ± 1% -0.40% (p=0.037 n=10)
Labels_Compare/not_equal 11.78n ± 2% 11.01n ± 1% -6.54% (p=0.000 n=10)
Labels_Compare/different_sizes 4.959n ± 1% 4.906n ± 2% -1.05% (p=0.050 n=10)
Labels_Compare/lots 21.32n ± 0% 17.54n ± 5% -17.75% (p=0.000 n=10)
Labels_Compare/real_long_equal 15.06n ± 1% 14.92n ± 0% -0.93% (p=0.000 n=10)
Labels_Compare/real_long_different_end 25.20n ± 0% 24.43n ± 0% -3.04% (p=0.000 n=10)
geomean 11.86n 11.25n -5.16%
Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com>
2024-03-17 17:08:06 +01:00
ed9deb1f90
Add Arve as OTLP ingest maintainer
...
Also remove myself :)
Arve has been doing a lot of maintainance on the upstream component
and also reviewing PRs on Prometheus for this otlp ingest. I continue
to have less and less time for this, so I'd like make Arve a maintainer
for OTLP Ingestion.
Signed-off-by: Goutham <gouthamve@gmail.com>
2024-03-17 12:27:20 +01:00
a0e93e403e
Merge pull request #13764 from bboreham/remove-deprecated-wal
...
[Cleanup] TSDB: Remove old deprecated WAL implementation
Deprecated since 2018.
2024-03-17 09:34:57 +00:00
302e151de8
{discovery,remote_write}/azure: Support default SDK authentication ( #13099 )
...
* discovery/azure: Offer default SDK authentication
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
2024-03-16 11:06:57 +00:00
5ed21c0d76
Merge pull request #12933 from prymitive/duplicated_samples
...
When Prometheus scrapes a target and it sees the same time series repeated multiple times it currently silently ignores that. This change adds a test for that and fixes the scrape loop so that:
* Only first sample for each unique time series is appended
* Duplicated samples increment the prometheus_target_scrapes_sample_duplicate_timestamp_total metric
This allows one to identify such scrape jobs and targets.
Also fix some tests and benchmark.
2024-03-16 09:18:46 +00:00
b7047f7fcb
Fix retention boundary so 2h retention deletes blocks right at the 2h boundary ( #9633 )
...
Signed-off-by: darshanime <deathbullet@gmail.com>
2024-03-15 19:35:16 +01:00
c8c1ab36dc
MAINTAINERS: Add Bryan Boreham, Ayoub Mrini ( #13771 )
...
Also simplify structure. Ordering of 'general' maintainers is alphabetical by 2nd name.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-03-15 16:47:14 +00:00
d1abc3f255
Merge pull request #13777 from roidelapluie/remoteread2
...
Chunked remote read: close the querier earlier
2024-03-15 14:42:30 +01:00
53091126c2
Chunked remote read: close the querier earlier
...
I have seen prometheis instances misebehaving because of broken chinked remote
read requests.
In order to avoid OOM's when this happens, I propose to close the
queries used by the streamed remote read requests earlier.
Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>
2024-03-15 14:03:16 +01:00
cef1025ea8
tsdb/wlog.Checkpoint: Fix counting of histogram samples
...
Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>
2024-03-15 10:23:59 +01:00
d45b5deb75
TSDB: move function only used in tests
...
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-03-15 08:54:47 +00:00
3274cac0d3
TSDB: remove unused function
...
Was only used in old WAL implementation.
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
2024-03-15 08:51:57 +00:00
15809223c7
Merge pull request #13759 from jcajka/main
...
otlptranslator: fix up import paths
2024-03-15 09:40:26 +01:00
dca47ce2c9
Only run on prometheus/prometheus repo
...
Signed-off-by: Charles Korn <charles.korn@grafana.com>
2024-03-15 11:44:35 +11:00
0f70fc7687
Merge pull request #13772 from machine424/signals
...
adjust signal termination warning log
2024-03-14 19:34:37 +01:00
3eed6c760a
adjust signal termination warning log
...
Signed-off-by: machine424 <ayoubmrini424@gmail.com>
2024-03-14 18:45:45 +01:00
537ce87d6b
Merge pull request #13770 from prometheus/superq/sync_description
...
Add container_description.yml to repo sync
2024-03-14 12:11:42 +01:00
David Leadbeater