prometheus

Commit Graph

Author	SHA1	Message	Date
Tobias Guggenmos	213a8fe89a	PromQL: Parse Series descriptions using the generated parser (#6494 ) * Use generated parser for series descriptions Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Julien Pivotto	f363a71ef7	promql: function: fix typo (#6501 ) Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Julien Pivotto	4b3bab890d	Fix absent output where two label matchers are identical (#6493 ) Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Tobias Guggenmos	a48acbcb23	PromQL: Fix parser benchmark (#6495 ) The parser benchmarks called the `ParseMetric` function instead of the `ParseExpr` function, which resulted in parsing failing every time. This means only the case of PromQL parser failure was benchmarked. Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Tobias Guggenmos	1e0cd28bf6	PromQL: Support trailing commas in grouping opts (#6480 ) * PromQL: Support trailing commas in grouping opts Fixes #6470 Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Julien Pivotto	f315c69129	promql: fix typo in value.go (#6491 ) Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Tobias Guggenmos	db1258f2a5	PromQL: Refactor error message generation (#6481 ) * Add parser method to produce errors messages about unexpected items * PromQL: use parser.unexpected in generated parser Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Tobias Guggenmos	9e34f08ac3	PromQL: Parse grouping opts with the generated parser (#6472 ) * PromQL: Parse grouping opts with the generated parser Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Tobias Guggenmos	53615412b4	PromQL: Parse Metrics using generated parser (#6466 ) * Parse Metrics with the generated parser Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Tobias Guggenmos	b38b25e9e1	Add Benchmark for the PromQL Parser (#6355 ) Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Tobias Guggenmos	8cb4a48e2e	PromQL: Parse label sets using the generated parser (#6432 ) * Add grammar for label_sets * Parse label Sets using the generated parser * Allow trailing commas for label sets and selectors * Add test to trigger all possible error messages for label matchers Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Tobias Guggenmos	5c503d85f7	PromQL: export lexer (#6435 ) Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Tobias Guggenmos	35c1f31721	PromQL: Use more standart format for error positions (#6433 ) The most common format (used by go, gcc and clang) for compiler error positions seems to be `filename:line:char:` or `line:char:` if the filename is unknown. This PR adapts the PromQL parser to use this convention. Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Tobias Guggenmos	cd39ebe7c6	PromQL: export function list (#6434 ) This PR exports the list of supported PromQL functions and their signatures. The reason for that is that the PromQL language server likes to use that list. Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Mark Nevill	b0a5c51b95	Return unused point slice to pool in Call and VectorSelector eval. (#6427 ) Signed-off-by: Mark Nevill <mark.nevill@gmail.com>	5 years ago
Tobias Guggenmos	3bb715031f	PromQL: Use generated parser to parse label matchers (#6410 ) Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Garrett	5a9c4acfbf	Pushdown aggregator group by through read hint (#6401 ) * Pushdown aggregator group by through read hint Implement https://github.com/prometheus/prometheus/issues/6400 * add temporal aggregation pushdown support Signed-off-by: xiancli <xiancli@ebay.com>	5 years ago
Tobias Guggenmos	408574a6e1	promql: Allow injecting fake tokens into the generated parser (#6381 ) * promql: Allow injecting fake tokens into the generated parser Yacc grammars do not support having multiple start symbols. To work around that restriction, it is possible to inject fake tokens into the lexer stream, as described here https://www.gnu.org/software/bison/manual/html_node/Multiple-start_002dsymbols.html . This is part of the parser rewrite effort described in #6256. Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Tobias Guggenmos	bbd92b85da	promql: Use capitalized names for item types (#6371 ) For yacc generated parsers there is the convention to capitalize the names of item types provided by the lexer, which makes it easy to distinct lexer tokens (capitalized) from nonterminal symbols (not capitalized) in language grammars. This convention is also followed by the (non generated) go compiler (see https://golang.org/pkg/go/token/#Token). Part of the parser rewrite described in #6256. Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Tobias Guggenmos	c229ed17e2	promql: Implement yyLexer interface (#6370 ) This is the first step towards a generated lexer as described in #6256. It adds methods to the parser struct, that make it implement the yyLexer interface required by a yacc generated parser, as described here: https://godoc.org/golang.org/x/tools/cmd/goyacc . The yyLexer interface is implemented by the parser struct instead of the lexer struct for the following reasons: * Both parsers have a lookahead that the lexer does not know about. This solution makes it possible to synchronize these lookaheads when switching parsers. * The routines to handle parser errors are not accessible to the lexer. Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Bartosz Jakubski	80ba03c67d	fix subquery with offset conversion to string (#6373 ) Signed-off-by: Bartosz Jakubski <b.jakubski@gmail.com>	5 years ago
Tobias Guggenmos	c63259b83c	promql: Clean up parser struct (#6360 ) * promql: Clean up parser struct The parser struct used two have two somewhat misused fields: peekCount int token [3]item By reading the code carefully one notices, that peekCount always has the value 0 or 1 and that only the first element of token is ever accessed. To make this clearer, this commit replaces the token array with a single variable and the peekCount int with a boolean. Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Tobias Guggenmos	d0cff29749	PromQL: Reduce Code duplication in AST traversion (#6362 ) * promql: Add Children function for easier AST traversion Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Tobias Guggenmos	ac3932ea35	Improve PromQL parser performance by making it non-concurrent (#6356 ) Before this commit, the PromQL parser ran in two goroutines: * The lexer goroutine that splits the input into tokens and sent them over a channel to * the parser goroutine which produces the abstract syntax tree The Problem with this approach is that the parser spends more time on goroutine creation and syncronisation than on actual parsing. This commit removes that concurrency and replaces the channel by a slice based buffer. Benchmarks show that this makes the up to 7 times faster than before. Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Harkishen Singh	37d666949c	fixes space issue in duration range promql (#6295 ) * fix space issue in duration range promql Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com> * updated logic Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com> * fixed lexer to skip over the spaces Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com> * added unittests for updated lexer Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com> * added unittests for updated lexer Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>	5 years ago
Tobias Guggenmos	fe80cf4734	promql: Eliminate dead code (#6215 ) peek() already ensures to not return a ItemComment so checking for this is redundant. Signed-off-by: Tobias Guggenmos <tguggenm@redhat.com>	5 years ago
Krasi Georgiev	5b8ff9b8a4	Merge the 2.13 release branch (#6169 ) * Include tsdb tool in builds (#6085) (#6089) Add the tsdb tool to promu so that it's included in the release tarballs. Signed-off-by: Ben Kochie <superq@gmail.com> * web/ui: fix for CVE-2019-10215 (#6098) Signed-off-by: Simon Pasquier <spasquie@redhat.com> * cut 2.13 release (#6099) Signed-off-by: Krasi Georgiev <8903888+krasi-georgiev@users.noreply.github.com> * Fix panic in ARM builds of Prometheus (#6110) An extra sync.Pool was added during a refactor which caused some 64 bit, atomically accessed variables to no longer be 64 bit aligned. By moving all atomically accessed variables to the beginning of the struct they are guaranteed to be 64 bit aligned. Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com> * promql: fix potential panic in the query logger (#6094) Signed-off-by: Simon Pasquier <spasquie@redhat.com> * Cut release 2.13.1 (#6145) Signed-off-by: Krasi Georgiev <8903888+krasi-georgiev@users.noreply.github.com>	5 years ago
Alex Dzyoba	e3882629ba	promql: Move tests to testutil (#6103 ) * promql: Move tests to testutil Signed-off-by: Alex Dzyoba <alex@dzyoba.com> * promql: Match error type via errors.As in tests Signed-off-by: Alex Dzyoba <alex@dzyoba.com> * promql: Remove unused `expectedList` func from lex_test.go Signed-off-by: Alex Dzyoba <alex@dzyoba.com>	5 years ago
AllenZMC	1e62435960	fix wrong spells in live_reader.go (#5899 ) * fix wrong spells in live_reader.go * fix wrong spells in lex.go Signed-off-by: czm <zhongming.chang@daocloud.io>	5 years ago
yuxiaobo96	5f6a56a0bb	Third correction (#6012 ) Signed-off-by: yuxiaobo <yuxiaobogo@163.com>	5 years ago
johncming	ac3cedb108	promql: Modify the order of return values. (#5940 ) Signed-off-by: johncming <johncming@yahoo.com>	5 years ago
johncming	d1b3a6e013	promql: Optimize the writing (#5941 ) Signed-off-by: johncming <johncming@yahoo.com>	5 years ago
Krzysztof Kowalczyk	6e53980bbf	fix fuzz targets (#5851 ) Signed-off-by: Krzysztof Kowalczyk <kkowalczyk@gmail.com>	5 years ago
AllenZMC	3638e4ab18	fix mis-spelling in fuzz.go (#5848 ) Signed-off-by: czm <zhongming.chang@daocloud.io>	5 years ago
Chris Marchbanks	529ccff07b	Remove all usages of stretchr/testify Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>	5 years ago
Chris Marchbanks	0685eb5395	Refactor testutil.NewStorage into a new package This avoids a circular dependency between the testutil and storage packages. Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>	5 years ago
AllenZMC	04cb37fea8	fix wrong spells in query_logger.go (#5843 ) Signed-off-by: czm <zhongming.chang@daocloud.io>	5 years ago
ethan	8928094b56	func name ref correct "qauntile" -> "quantile" (#5834 ) Signed-off-by: ethan <guangming.wang@daocloud.io>	5 years ago
AllenZMC	8d6ec5acdc	fix word 'seriess' to 'series' (#5828 ) Signed-off-by: czm <zhongming.chang@daocloud.io>	5 years ago
AllenZMC	ead0933dd9	fix word 'substracting' to 'subtracting' (#5822 ) Signed-off-by: czm <zhongming.chang@daocloud.io>	5 years ago
Advait Bhatwadekar	5d401f1e1b	Added query logging for prometheus. Issue #1315 (#5794 ) * Added query logging for prometheus. Options added: 1) active.queries.filepath: Filename where queries will be recorded 2) active.queries.filesize: Size of the file where queries will be recorded. Functionality added: All active queries are now logged in a file. If prometheus crashes unexpectedly, these queries are also printed out on stdout in the rerun. Queries are written concurrently to an mmaped file, and removed once they are done. Their positions in the file are reused. They are written in json format. However, due to dynamic nature of application, the json has an extra comma after the last query, and is missing an ending ']'. There may also null bytes in the tail of file. Signed-off-by: Advait Bhatwadekar <advait123@ymail.com>	5 years ago
Ganesh Vernekar	588eb20018	Efficient iteration and search in HashForLabels and HashWithoutLabels (#5707 ) * Efficient iteration and search in Labels.HashForLabels Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * Better names for variables Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * HashWithoutLabels optimizations Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * Refactor HashForLabels and HashWithoutLabels to take sorted names Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * Fix review comments Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	5 years ago
Thomas Jackson	91d7175eaa	Add storage.Warnings to LabelValues and LabelNames (#5673 ) Fixes #5661 Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>	6 years ago
beorn7	dd81912554	Add objectives to Summaries With the next release of client_golang, Summaries will not have objectives by default. To not lose the objectives we have right now, explicitly state the current default objectives. Signed-off-by: beorn7 <beorn@grafana.com>	6 years ago
Thomas Jackson	a000cec011	Re-use label builder in promql aggregation (#5641 ) For my benchmarks on aggregation this reduces allocations by ~5% (~10% time improvement): ``` benchmark old ns/op new ns/op delta BenchmarkEvaluations/benchdata/aggregators.test/promxy-4 727692 649626 -10.73% benchmark old allocs new allocs delta BenchmarkEvaluations/benchdata/aggregators.test/promxy-4 2566 2434 -5.14% benchmark old bytes new bytes delta BenchmarkEvaluations/benchdata/aggregators.test/promxy-4 162760 148854 -8.54% ``` Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>	6 years ago
Brian Brazil	36dbf042e3	Correctly handle {__name__="a"} (#5552 ) This can cause problems in alerts. Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>	6 years ago
Simon Pasquier	45506841e6	*: enable all default linters (#5504 ) Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Björn Rabenstein	0be9388f8d	Merge pull request #5463 from prometheus/beorn7/templating Follow-up on #5009	6 years ago
Goutham Veeramachaneni	3cc5f9d880	Make sure subquery range is taken into account for selection (#5467 ) * Make sure subquery range is taken into account for selection Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>	6 years ago
Bjoern Rabenstein	a92ef68dd8	Fix staticcheck errors Not sure why they only show up now. Signed-off-by: Bjoern Rabenstein <bjoern@rabenste.in>	6 years ago

1 2 3 4 5 ...

430 Commits (54654340ad9ecd286b7f5966d2aabf008b27809d)