b8217720ac
Review feedback.
...
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
2018-06-19 13:03:01 +01:00
db9dbeeaec
federation: nil pointer deference when using remove read
...
```
level=error ts=2018-06-13T07:19:04.515149169Z caller=stdlib.go:89 component=web caller="http: panic serving [::1" msg="]:56202: runtime error: invalid memory address or nil pointer dereference"
level=error ts=2018-06-13T07:19:04.516199547Z caller=stdlib.go:89 component=web caller="http: panic serving [::1" msg="]:56204: runtime error: invalid memory address or nil pointer dereference"
level=error ts=2018-06-13T07:19:04.51717692Z caller=stdlib.go:89 component=web caller="http: panic serving [::1" msg="]:56206: runtime error: invalid memory address or nil pointer dereference"
level=error ts=2018-06-13T07:19:04.564952878Z caller=stdlib.go:89 component=web caller="http: panic serving [::1" msg="]:56208: runtime error: invalid memory address or nil pointer dereference"
level=error ts=2018-06-13T07:19:04.566575791Z caller=stdlib.go:89 component=web caller="http: panic serving [::1" msg="]:56210: runtime error: invalid memory address or nil pointer dereference"
level=error ts=2018-06-13T07:19:04.567106063Z caller=stdlib.go:89 component=web caller="http: panic serving [::1" msg="]:56212: runtime error: invalid memory address or nil pointer dereference"
```
When remove read is enabled, federation will call `q.Select(nil, mset...)`
which will break remote reads because it currently doesn't handle empty
SelectParams.
Signed-off-by: Corentin Chary <c.chary@criteo.com>
2018-06-19 13:03:01 +01:00
2952387ed1
Pass query hints down into remote read query proto ( #4122 )
...
Signed-off-by: Henri DF <henridf@gmail.com>
2018-05-08 09:48:13 +01:00
464e747f1e
fix some comments typos ( #4059 )
2018-04-08 10:51:54 +01:00
434f0374f7
Refactor remote storage querier handling
...
* Decouple remote client from ReadRecent feature.
* Separate remote read filter into a small, testable function.
* Use storage.Queryable interface to compose independent
functionalities.
2017-11-13 23:19:15 +01:00
9f10c63cff
Fix remote read labelset corruption ( #3456 )
...
The labelsets returned from remote read are mutated in higher levels
(like seriesFilter.Labels()) and since the concreteSeriesSet didn't
return a copy, the external mutation affected the labelset in the
concreteSeries itself. This resulted in bizarre bugs where local and
remote series would show with identical label sets in the UI, but not be
deduplicated, since internally, a series might come to look like:
{__name__="node_load5", instance="192.168.1.202:12090", job="node_exporter", node="odroid", node="odroid"}
(note the repetition of the last label)
2017-11-12 00:47:47 +01:00
746752b946
Merge external labels in order.
2017-10-26 11:44:49 +01:00
ee011d906d
Port remote read server to 2.0.
2017-10-26 11:09:14 +01:00
56820726fa
Move a couple of the encoding/decoding functions into codec.go
2017-10-26 11:08:33 +01:00
16f71a7723
Port codec.go over form 1.8 branch.
2017-10-26 11:08:33 +01:00
Tom Wilkie