prometheus

Commit Graph

Author	SHA1	Message	Date
Stephan Erb	0b9fca983b	Fix reload of ZooKeeper service discovery config (#2669 ) Rational: * When the config is reloaded and the provider context is canceled, we need to exit the current ZK `TargetProvider.Run` method as a new provider will be instantiated. * In case `Stop` is called on the `ZookeeperTreeCache`, the update/events channel may not be closed as it is shared by multiple caches and would thus be double closed. * Stopping all `zookeeperTreeCacheNode`s on teardown ensures all associated watcher go-routines will be closed eagerly rather than implicityly on connection close events.	2017-05-02 18:21:37 -05:00
Tobias Schmidt	58cd39aacd	Follow golang naming conventions in discovery packages	2017-03-16 23:40:46 -03:00
Fabian Reinartz	d19d1bcad3	discovery: move into top-level package	2016-11-22 12:56:33 +01:00

Author

SHA1

Message

Date

Stephan Erb

0b9fca983b

Fix reload of ZooKeeper service discovery config (#2669 )

Rational:

* When the config is reloaded and the provider context is canceled, we need to
  exit the current ZK `TargetProvider.Run` method as a new provider will be
  instantiated.
* In case `Stop` is called on the `ZookeeperTreeCache`, the update/events
  channel may not be closed as it is shared by multiple caches and would
  thus be double closed.
* Stopping all `zookeeperTreeCacheNode`s on teardown ensures all associated
  watcher go-routines will be closed eagerly rather than implicityly on
  connection close events.

2017-05-02 18:21:37 -05:00

Tobias Schmidt

58cd39aacd

Follow golang naming conventions in discovery packages

2017-03-16 23:40:46 -03:00

Fabian Reinartz

d19d1bcad3

discovery: move into top-level package

2016-11-22 12:56:33 +01:00

3 Commits (4d9b917d111f3ad0e0f482a42fe5930d47742d94)