401 Commits (492414542ec8502e8885c8fefc3402ec51167457)

Author	SHA1	Message	Date
Julien Pivotto	0e912faf4f	rules: Cleanup unused function alert.Duration (#6734) ... The function HoldDuration and Duration did the exact same thing. Let's only keep HoldDuration() as Duration() is more confusing. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Julien Pivotto	f82d55e79f	Refactor and simplify rule_group_interval_seconds (#6711) ... Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Julien Pivotto	9adad8ad30	Remove MaxConcurrent from the PromQL engine opts (#6712) ... Since we use ActiveQueryTracker to check for concurrency in d992c36b3a it does not make sense to keep the MaxConcurrent value as an option of the PromQL engine. This pull request removes it from the PromQL engine options, sets the max concurrent metric to -1 if there is no active query tracker, and use the value of the active query tracker otherwise. It removes dead code and also will inform people who import the promql package that we made that change, as it breaks the EngineOpts struct. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Julien Pivotto	56ebd5afde	Delete prometheus_rule_group metrics when groups are removed (#6693) ... * Delete prometheus_rule_group metrics when groups are removed Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Julien Pivotto	cf42888e4d	Fix order of testutil.Equals (#6695) ... Equals takes the expected value as first parameter, and the actual value as second parameter. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Julien Pivotto	5f27ac3583	Refactor query log fields (#6694) ... * Refactor query log fields Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Harkishen Singh	84e6459c4d	Adds support for line-column numbers for invalid rules, promtool (#6533) ... Signed-off-by: Harkishen Singh <harkishensingh@hotmail.com>	5 years ago
Julien Pivotto	0011bba19b	Query Log: add origin of the rules (#6592) ... * Query Log: add origin of the rules We don't set rule name and rule kind because the added value would be quite low, given we have now the file, the group and the query. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Julien Pivotto	e079c9ed45	manager: add full stops on comments ... Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
alburthoffman	156dcb8cca	avoid stopping rule groups if new rule groups are as same as old rule… (#6450) ... * avoid stopping rule groups if new rule groups are as same as old rule groups Signed-off-by: alburthoffman <alburthoffman@gmail.com>	5 years ago
Julien Pivotto	2d7c8069d0	Check that rules don't contain metrics with the same labelset (#6469) ... Closes #5529 Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
Simon Pasquier	06066a3619	*: improve error messages when parsing bad rules (#5965) ... Signed-off-by: Simon Pasquier <spasquie@redhat.com>	5 years ago
Brian Brazil	e62f30d497	Correctly handle empty labels from alert templates. (#5845) ... Fixes https://github.com/prometheus/common/issues/36 Move logic handling this into the labels package, so all the cases are handled in one place and we're less likely to have this come up again. Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>	5 years ago
Chris Marchbanks	0685eb5395	Refactor testutil.NewStorage into a new package ... This avoids a circular dependency between the testutil and storage packages. Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>	5 years ago
Brian Brazil	2184b79763	Mark deleted rule's series as stale on next evaluation. (#5759) ... Fixes #5755 Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>	5 years ago
AllenZMC	5c2c9a03e9	fix word 'consequentally' to 'consequently' (#5827) ... Signed-off-by: czm <zhongming.chang@daocloud.io>	5 years ago
beorn7	dd81912554	Add objectives to Summaries ... With the next release of client_golang, Summaries will not have objectives by default. To not lose the objectives we have right now, explicitly state the current default objectives. Signed-off-by: beorn7 <beorn@grafana.com>	6 years ago
pbhudiaBAE	43953b105b	Sorting alerts by group name in /alerts (#5448) ... * Working group name Signed-off-by: Pritam Bhudia <pritam.bhudia@baesystems.com> * Working categorised by group name Signed-off-by: Pritam Bhudia <pritam.bhudia@baesystems.com> * Changed group sorting in web Signed-off-by: Pritam Bhudia <pritam.bhudia@baesystems.com> * Fixed group sorting and comments Signed-off-by: Pritam Bhudia <pritam.bhudia@baesystems.com> * Fixed group sorting and comments with gofmt Signed-off-by: Pritam Bhudia <pritam.bhudia@baesystems.com> * Added file and group name Signed-off-by: Pritam Bhudia <pritam.bhudia@baesystems.com> * reverted back to full path to yml file Signed-off-by: Pritam Bhudia <pritam.bhudia@baesystems.com>	6 years ago
Yao Zengzeng	5544cb252a	fix some mistakes in comments (#5533) ... Signed-off-by: YaoZengzeng <yaozengzeng@zju.edu.cn>	6 years ago
Simon Pasquier	45506841e6	*: enable all default linters (#5504) ... Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Bjoern Rabenstein	76102d570c	Add test for external labels in label template ... Signed-off-by: Bjoern Rabenstein <bjoern@rabenste.in>	6 years ago
Bjoern Rabenstein	38d518c0fe	Rework #5009 after comments ... Signed-off-by: Bjoern Rabenstein <bjoern@rabenste.in>	6 years ago
Sylvain Rabot	335a34486e	Add external labels to template expansion ... This affects the expansion of templates in alert labels and annotations and console templates. Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>	6 years ago
Tariq Ibrahim	8fdfa8abea	refine error handling in prometheus (#5388) ... i) Uses the more idiomatic Wrap and Wrapf methods for creating nested errors. ii) Fixes some incorrect usages of fmt.Errorf where the error messages don't have any formatting directives. iii) Does away with the use of fmt package for errors in favour of pkg/errors Signed-off-by: tariqibrahim <tariq181290@gmail.com>	6 years ago
James Ravn	e15d8c5802	reload: copy state on both name and labels (#5368) ... * reload: copy state on both name and labels Fix https://github.com/prometheus/prometheus/issues/5193 Using just name causes the linked issue - if new rules are inserted with the same name (but different labels), the reordering will cause stale markers to be inserted in the next eval for all shifted rules, despite them not being stale. Ideally we want to avoid stale markers for time series that still exist in the new rules, with name and labels being the unique identifer. This change adds labels to the internal map when copying the old rule data to the new rule data. This prevents the problem of staling rules that simply shifted order. If labels change, it is a new time series and the old series will stale regardless. So it should be safe to always match on name and labels when copying state. Signed-off-by: James Ravn <james@r-vn.org>	6 years ago
David Symonds	46361a7c85	rules: Fix sorting of result from (*Manager).RuleGroups (#5260) ... The previous code was defective in that it never sorted groups within a file due to doing a multi-key sort incorrectly. Signed-off-by: David Symonds <dsymonds@gmail.com>	6 years ago
beorn7	2db1eeb4ec	Fix prometheus_rule_group_last_evaluation_timestamp_seconds ... It should be a unix timestamp, not the seconds in the minute. Signed-off-by: beorn7 <beorn@soundcloud.com>	6 years ago
Ganesh Vernekar	787eb1e904	Set rule_group_last_duration_seconds to seconds (#5153) ... Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	6 years ago
Matt Layher	302148fd69	*: apply gofmt -s ... Signed-off-by: Matt Layher <mdlayher@gmail.com>	6 years ago
Vishnunarayan K I	fd3ef6ba34	Add metric rule_group_rules_loaded to get the number of rules loaded (#5090) ... Signed-off-by: Vishnunarayan K I <appukuttancr@gmail.com>	6 years ago
Simon Pasquier	f678e27eb6	*: use latest release of staticcheck (#5057) ... * *: use latest release of staticcheck It also fixes a couple of things in the code flagged by the additional checks. Signed-off-by: Simon Pasquier <spasquie@redhat.com> * Use official release of staticcheck Also run 'go list' before staticcheck to avoid failures when downloading packages. Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Tom Wilkie	121603c417	Expose rules.NewGroupMetrics and rules.Metrics. (#5059) ... Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>	6 years ago
Tom Wilkie	6e08029b56	Move err to be the last return value from storage.Select. (#5054) ... Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>	6 years ago
Bartek Płotka	de213d4a5e	rule manager: Moved metric registration to custom registerer which is already available. (#4961) ... Signed-off-by: Bartek Plotka <bwplotka@gmail.com>	6 years ago
AixesHunter	fb8479a677	Variable 'labels' collides with imported package name (#5012) ... Signed-off-by: aixeshunter <aixeshunter@gmail.com>	6 years ago
mknapphrt	f0e9196dca	Return warnings on a remote read fail (#4832) ... Signed-off-by: Mark Knapp <mknapp@hudson-trading.com>	6 years ago
Krasi Georgiev	0754e5334b	querier for RestoreForState not closed. (#4922) ... Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>	6 years ago
Ben Kochie	c6399296dc	Fix spelling/typos (#4921) ... * Fix spelling/typos Fix spelling/typos reported by codespell/misspell. * UK -> US spelling changes. Signed-off-by: Ben Kochie <superq@gmail.com>	6 years ago
Wei Guo	e329cbf673	Add metric prometheus_rule_group_last_evaluation for recording and alerting (#4852) ... * add metric prometheus_rule_group_last_evaluation for recording and alerting Signed-off-by: Wei Guo <me@imkira.com> * fix issues from comments Signed-off-by: Wei Guo <me@imkira.com>	6 years ago
Will Hegedus	193ebe7e34	Updates to /targets and /rules (scrape duration, last evaluation time) (#4722) ... * Add evaluationTimestamp (Last Evaluation) column to display on /rules Signed-off-by: Will Hegedus <wbhegedus@liberty.edu> * Add lastScrapeDuration ("Scrape Duration") to display on /targets Signed-off-by: Will Hegedus <wbhegedus@liberty.edu> * Updates based on Julius' feedback Signed-off-by: Will Hegedus <wbhegedus@liberty.edu> * Update to set timestamp to when eval started (after eval completes) Signed-off-by: Will Hegedus <wbhegedus@liberty.edu> * Update /rules to display time since last evaluation Signed-off-by: Will Hegedus <wbhegedus@liberty.edu> * Re-order Last Eval/Eval Time to be consistent with targets page Signed-off-by: Will Hegedus <wbhegedus@liberty.edu>	6 years ago
Callum Styan	9bca041285	WIP: keep track of samples per query, set a max # of samples (#4513) ... * keep track of samples per query, set a max # of samples that can be in memory at once Signed-off-by: Callum Styan <callumstyan@gmail.com>	6 years ago
Ganesh Vernekar	5790d23fd8	Unit testing for rules (#4350) ... * Unit testing for rules * Specifying order of group evaluation in unit tests Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	6 years ago
Ganesh Vernekar	05726c5ea2	Test template expansion while loading groups (#4537) ... Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	6 years ago
Chris Marchbanks	63ed9d1b70	Send EndsAt along with alerts (#4550) ... Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>	6 years ago
Chris Marchbanks	87f1dad16d	throttle resends of alerts to 1 minute by default (#4538) ... Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>	6 years ago
Goutham Veeramachaneni	f3b7c22827	rules: add comment about lock taking (#4525) ... Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>	6 years ago
Ganesh Vernekar	c663477688	Fixed TestUpdate in rules/manager_test.go (#4516) ... Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	6 years ago
Julius Volz	8fbe1b5133	Handle a bunch of unchecked errors (#4461) ... There are many more (mostly finalizers like Close/Stop/etc.), but most of the others seemed like one couldn't do much about them anyway. Signed-off-by: Julius Volz <julius.volz@gmail.com>	6 years ago
Ganesh Vernekar	a0a9e7df91	Fix TestForStateRestore (#4476) (#4512) ... Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	6 years ago
Julien Pivotto	0b4d22b245	rules/manager: remove a no-longer-relevant comment (#4503) ... Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	6 years ago