prometheus

Commit Graph

Author	SHA1	Message	Date
Bjoern Rabenstein	f298af5756	Use named returns in flock.New.	10 years ago
Bjoern Rabenstein	baca6faa1c	Add double-start protection. This mimics the locking leveldb is performing anyway. Advantages of doing it separately: - Should we ever replace the leveldb implementation by one without double-start protection, we are still good. - In contrast to leveldb, the new code creates a meaningful error message.	10 years ago
Julius Volz	a6bc42bc61	Minor formatting/spelling fixups.	10 years ago
Bjoern Rabenstein	0851945054	Add a heuristics to checkpoint early if there are many "dirty" series..	10 years ago
Bjoern Rabenstein	622e8350cd	Fix a bug handling freshly unarchived series. Usually, if you unarchive a series, it is to add something to it, which will create a new head chunk. However, if a series in unarchived, and before anything is added to it, it is handled by the maintenance loop, it will be archived again. In that case, we have to load the chunkDescs to know the lastTime of the series to be archived. Usually, this case will happen only rarely (as a race, has never happened so far, possibly because the locking around unarchiving and the subsequent sample append is smart enough). However, during crash recovery, we sometimes treat series as "freshly unarchived" without directly appending a sample. We might add more cases of that type later, so better deal with archiving properly and load chunkDescs if required.	10 years ago
Bjoern Rabenstein	eb932d1524	Remove a deadlock during shutdown.	10 years ago
Brian Brazil	e56786b221	Have scrape time as a pseudovariable, not a prometheus variable. This ensures it has the right timestamp, and is easier to work with. Switch sd variable away from 'outcome', using total/failed instead.	10 years ago
Bjoern Rabenstein	ff24070a03	Fix embarrassing bug in crash recovery. (And yes, we always knew we need tests for that. I have added a TODO now.) Change-Id: I9cf52bbf98e263e0b79404bda4c442beba9696a8	10 years ago
Julius Volz	c9618d11e8	Introduce copy-on-write for metrics in AST. This depends on changes in: https://github.com/prometheus/client_golang/tree/cow-metrics. Change-Id: I80b94833a60ddf954c7cd92fd2cfbebd8dd46142	10 years ago
Bjoern Rabenstein	afd864e7f4	Adjust to the new version of goleveldb. (And yes, we do want vendoring for that... This is just the quick fix.) Change-Id: I9d347a64d96de6b3390a0e35c8d466f14bb83e4e	10 years ago
Bjoern Rabenstein	fee88a7a77	Remove the remaining races, new and old. Also, resolve a few other TODOs. Change-Id: Icb39b5a5e8ca22ebcb48771cd8951c5d9e112691	10 years ago
Bjoern Rabenstein	66c80b5ebd	Fix typo. Change-Id: I72608c7841c00145458807d3c3ee29db7b5ac2bc	10 years ago
Bjoern Rabenstein	674624f1c8	Completed more TODOs. - Documented checkpoint file format. - High-level description of series sanitation. - Replace fp.LoadFromString panic with an error. (Change in client_golang already submitted.) - Introduced checks for series file size where appropriate. - Removed two Law of Demeter violations. Change-Id: I555d97a2c8f4769820c2fc8bf5d6f4e160222abc	10 years ago
Bjoern Rabenstein	7d11019aa2	Squash a few trivial TODOs. - Delete unneeded file view_adapter.go. - Assessed that we still need the fingerprints in nodes (to create iterators). - Turned numMemChunkDescs into a metric. Change-Id: I29be963c795a075ec00c095f76bf26405535609d	10 years ago
Bjoern Rabenstein	49683c0c20	Avoid test flags in normal binary. Change-Id: If1fba813a73bf93ea5918dcda326e3ffa81a797d	10 years ago
Bjoern Rabenstein	9bc05052ad	Add line that has mysteriously disappeared after rebase. Change-Id: I3612eb0b626e66e607b363e9801f187d2ba637a3	10 years ago
Bjoern Rabenstein	14bda4180c	Changes after pair code review. Change-Id: Ib72d40f8e9027818cfbbd32a7a7201eebda07455	10 years ago
Bjoern Rabenstein	9ea808cd8b	Remove debug log line. Change-Id: Icdd2351b89f2d37ac2b615f9cf872e054c694ad1	10 years ago
Bjoern Rabenstein	bb42cc2e2d	Evict based on memory pressure. Evict recently used chunks last. Change-Id: Ie6168f0cdb3917bdc63b6fe15585dd70c1e42afe	10 years ago
Bjoern Rabenstein	e23ee0f7cc	Fix race in test. Change-Id: I53e1a4c5a6b5f846acd76043166b6cb7bf7d5dc7	10 years ago
Bjoern Rabenstein	d73e851b14	Tweak timing in the maintenance loop. Change-Id: I9801c4f9a22c3b3dc1ce1af81fdd9e992a4f4dd7	10 years ago
Bjoern Rabenstein	2672aa8ece	Instrument series maintenance. Change-Id: Ie4269d07ad4d23d44230c95a523088b472718e54	10 years ago
Bjoern Rabenstein	74c143c4c9	Improve scraper shutdown time. - Stop target pools in parallel. - Stop individual scrapers in goroutines, too. - Timing tweaks. Change-Id: I9dff1ee18616694f14b04408eaf1625d0f989696	10 years ago
Bjoern Rabenstein	3f61d304ce	Reorganize maintenance loop. Change-Id: Iac10f988ba3e93ffb188f49c30f92e0b6adce5a3	10 years ago
Bjoern Rabenstein	c087ee35f7	Remove archiveMtx. Change-Id: Ie8019f860bbda68621f74380c90a4e57930d3d7a	10 years ago
Bjoern Rabenstein	7af42eda65	Optimize purging. Now only purge if there is something to purge. Also, set savedFirstTime and archived time range appropriately. (Which is needed for the optimization.) Change-Id: Idcd33319a84def3ce0318d886f10c6800369e7f9	10 years ago
Bjoern Rabenstein	33b959b898	Persist savedFirstTime in checkpoint. Change-Id: Ibdfdea16fad0608ec104fbccc749e824a171f227	10 years ago
Bjoern Rabenstein	904acd43da	Add crash recovery. Fix the behavior if preload for non-existent series is requested. Instead of returning an error (which triggers a panic further up), simply count those incidents. They can happen regularly, we just want to know if they happen too frequently because that would mean the indexing is behind or broken. Change-Id: I4b2d1b93c4146eeea897d188063cb9574a270f8b	10 years ago
Bjoern Rabenstein	7a9efc9c59	Fix typo in test. Change-Id: I3c2fd76bc5f50446c58f8ef693d9c6595197feaa	10 years ago
Bjoern Rabenstein	4efc60174b	Tweak and verify a few parameters. Remove TODOs accordingly. Change-Id: Ic062e13b6ae89a9135d3f14011114fe1cca1cef8	10 years ago
Bjoern Rabenstein	5f8e9617ef	Add more tests. Add an end-to-end fuzz and race test. Fix a race exposed by the above. Change-Id: Ifaa39a90cefbde8d4c29bda197cc92592ded21bb	10 years ago
Bjoern Rabenstein	d215e013b7	Fix the weird chunkDesc shuffling bug. The root cause was that after chunkDesc eviction, the offset between memory representation of chunk layout (via chunkDescs in memory) was shiftet against chunks as layed out on disk. Keeping the offset up to date is by no means trivial, so this commit is pretty involved. Also, found a race that for some reason didn't bite us so far: Persisting chunks was completel unlocked, so if chunks were purged on disk at the same time, disaster would strike. However, locking the persisting of chunk revealed interesting dead locks. Basically, never queue under the fp lock. Change-Id: I1ea9e4e71024cabbc1f9601b28e74db0c5c55db8	10 years ago
Bjoern Rabenstein	a617269b12	Avoid unnecessary cloning of the head chunk. Change-Id: I5da774515d5493166a197b5814d0a720628cfaff	10 years ago
Bjoern Rabenstein	f1de5b0c4e	Run checkpointing of in-memory metrics and head chunks periodically. Checkpointing interval is now a command line flag. Along the way, several things were refactored. - Restructure the way the storage is started and stopped.. - Number of series in checkpoint is now a uint64, not a varint. (Breaks old checkpoints, needs wipe!) - More consistent naming and order of methods. Change-Id: I883d9170c9a608ee716bb0ab3d0ded8ca03760d9	10 years ago
Bjoern Rabenstein	74c9b34a5e	Improve storage instrumentation even more. Add gauge for chunks and chunkdescs in memory (backed by a global variable to be used later not only for instrumentation but also for memory management). Refactored instrumentation code once more (instrumentation.go is back :). Change-Id: Ife39947e22a48cac4982db7369c231947f446e17	10 years ago
Julius Volz	c3fcea45e3	Support finer time resolutions than 1 second. Change-Id: I4c5f1d6d2361e841999b23283d1961b1bd0c2859	10 years ago
Bjoern Rabenstein	443dd33805	Improve instrumentation in storage. Also, fix some other minor bugs. Change-Id: If72f1c058b0f47d3e378fdf80228d7e9a8db06c7	10 years ago
Bjoern Rabenstein	1936a40e75	Minor loging improvement. Change-Id: I7875d1a58ef9c5ff149f18e36f65959a4712fea2	10 years ago
Bjoern Rabenstein	192bf52c41	Evict chunkDescs, too. Change-Id: I8b70f22fbf1dfcbc49f9ec391985144649e6ce9c	10 years ago
Bjoern Rabenstein	95f392fb2c	Prevent an indexing death spiral. Change-Id: I86b20cd0830d02f87b2f020767257e2d3fb2033c	10 years ago
Bjoern Rabenstein	40354eaa29	Reduce directory depth by one. Change-Id: I7f89df61135ff19169ed97633a662685d414c448	10 years ago
Bjoern Rabenstein	096fa0f8b2	Squash a number of TODOs. - Staleness delta is no a proper function parameter and not replicated from package ast. - Named type 'chunks' replaced by explicit '[]chunk' to avoid confusion. - For the same reason, replaced 'chunkDescs' by '[]*chunkDescs'. - Verified that math.Modf is not a speed enhancement over conversion (actually 5x slower). - Renamed firstTimeField, lastTimeField into chunkFirstTime and chunkLastTime. - Verified unpin() is sufficiently goroutine-safe. - Decided not to update archivedFingerprintToTimeRange upon series truncation and added a rationale why. Change-Id: I863b8d785e5ad9f71eb63e229845eacf1bed8534	10 years ago
Bjoern Rabenstein	427c8d53a5	Fix handling of empty chunkDescs while preloading chunks. Change-Id: I73ce89fe0ef90c6eda78218e5be2cbfa0207c364	10 years ago
Bjoern Rabenstein	ecee5d8281	Fix head chunk persisting and a chunkDesc race condition. - Head chunk persisting only happens in evictOlderThan, so do it there. (With the previous code, it would never happen.) - Raw accesses to chunkDesc.chunk are now done via isEvicted (with locking). Change-Id: I48b07b56dfea4899b50df159b4ea566954396fcd	10 years ago
Bjoern Rabenstein	6b37e47f9e	Remove unused metrics. Change-Id: Icf03ba4ce92a5e38daf12930f9661daba79c83bb	10 years ago
Bjoern Rabenstein	2b4ff620aa	Return a nop iterator for series that have been purged completely. Change-Id: I6e92cac4472486feefdecba8593c17867e8c710d	10 years ago
Bjoern Rabenstein	6e3a366f91	Only archive a time series when none of its chunks is pinned. Change-Id: I7e4b67c34b417b8980173bc5dc3b213bd7d698e5	10 years ago
Julius Volz	bfa64248b7	Deal with missing series in preloading. Change-Id: Ibf3a57b329f40a3d5e0b98464a2f45d2f1bd07bf	10 years ago
Bjoern Rabenstein	ca42a22e20	Add safety panic to seriesMap.put. Change-Id: I4d4d2e45cc0f908a33eb1ae6e3ee6796adfcbd1e	10 years ago
Bjoern Rabenstein	83b4fa868d	Fix GetBoundaryValues. Change-Id: I8f8bbdb88e9b24e4c37ff869126ed9343f261ce2	10 years ago

1 2

93 Commits (39d20140c88de16570c7c8f26b3be6ca30860a43)