68 Commits (26886d6d95fbf290df1526cc2a51355da611f8be)

Author	SHA1	Message	Date
beorn7	0f760f63dd	lint: Revamp our linting rules, mostly around doc comments ... Several things done here: - Set `max-issues-per-linter` to 0 so that we actually see all linter warnings and not just 50 per linter. (As we also set `max-same-issues` to 0, I assume this was the intention from the beginning.) - Stop using the golangci-lint default excludes (by setting `exclude-use-default: false`. Those are too generous and don't match our style conventions. (I have re-added some of the excludes explicitly in this commit. See below.) - Re-add the `errcheck` exclusion we have used so far via the defaults. - Exclude the signature requirement `govet` has for `Seek` methods because we use non-standard `Seek` methods a lot. (But we keep other requirements, while the default excludes completely disabled the check for common method segnatures.) - Exclude warnings about missing doc comments on exported symbols. (We used to be pretty adamant about doc comments, but stopped that at some point in the past. By now, we have about 500 missing doc comments. We may consider reintroducing this check, but that's outside of the scope of this commit. The default excludes of golangci-lint essentially ignore doc comments completely.) - By stop using the default excludes, we now get warnings back on malformed doc comments. That's the most impactful change in this commit. It does not enforce doc comments (again), but _if_ there is a doc comment, it has to have the recommended form. (Most of the changes in this commit are fixing this form.) - Improve wording/spelling of some comments in .golangci.yml, and remove an outdated comment. - Leave `package-comments` inactive, but add a TODO asking if we should change that. - Add a new sub-linter `comment-spacings` (and fix corresponding comments), which avoids missing spaces after the leading `//`. Signed-off-by: beorn7 <beorn@grafana.com>	3 months ago
Arve Knudsen	fbcd50f32c	Upgrade golangci-lint to v1.60.2 ... Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	3 months ago
Arve Knudsen	3a78e76282	Upgrade golangci-lint to v1.60.1 ... Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	3 months ago
Sergey	9caba4be7d	chore: use HumanizeDuration and ConvertToFloat from prometheus/common ... Signed-off-by: Sergey <freak12techno@gmail.com>	4 months ago
Sergey	5a5a6f08ef	chore: use HumanizeDuration from prometheus/common (#14202) ... * chore: use HumanizeDuration from prometheus/common Signed-off-by: Sergey <freak12techno@gmail.com> * chore: fixed linting Signed-off-by: Sergey <freak12techno@gmail.com> * chore: review fixes --------- Signed-off-by: Sergey <freak12techno@gmail.com>	6 months ago
suntala	9a7c6a5cc4	Support native histogram values in template functions ... Co-authored-by: Aleks Fazlieva <britishrum@users.noreply.github.com> Signed-off-by: suntala <arati.rana@grafana.com>	8 months ago
suntala	44f385fd51	Support expansion of native histogram values in alert templates ... Co-authored-by: Aleks Fazlieva <britishrum@users.noreply.github.com> Signed-off-by: suntala <arati.rana@grafana.com>	8 months ago
Oleksandr Redko	8e5f0387a2	ci(lint): enable nolintlint and remove redundant comments (#12926) ... Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>	1 year ago
Matthieu MOREL	fb3eb21230	enable gocritic, unconvert and unused linters ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	2 years ago
beorn7	c0879d64cf	promql: Separate `Point` into `FPoint` and `HPoint` ... In other words: Instead of having a “polymorphous” `Point` that can either contain a float value or a histogram value, use an `FPoint` for floats and an `HPoint` for histograms. This seemingly small change has a _lot_ of repercussions throughout the codebase. The idea here is to avoid the increase in size of `Point` arrays that happened after native histograms had been added. The higher-level data structures (`Sample`, `Series`, etc.) are still “polymorphous”. The same idea could be applied to them, but at each step the trade-offs needed to be evaluated. The idea with this change is to do the minimum necessary to get back to pre-histogram performance for functions that do not touch histograms. Here are comparisons for the `changes` function. The test data doesn't include histograms yet. Ideally, there would be no change in the benchmark result at all. First runtime v2.39 compared to directly prior to this commit: ``` name old time/op new time/op delta RangeQuery/expr=changes(a_one[1d]),steps=1-16 391µs ± 2% 542µs ± 1% +38.58% (p=0.000 n=9+8) RangeQuery/expr=changes(a_one[1d]),steps=10-16 452µs ± 2% 617µs ± 2% +36.48% (p=0.000 n=10+10) RangeQuery/expr=changes(a_one[1d]),steps=100-16 1.12ms ± 1% 1.36ms ± 2% +21.58% (p=0.000 n=8+10) RangeQuery/expr=changes(a_one[1d]),steps=1000-16 7.83ms ± 1% 8.94ms ± 1% +14.21% (p=0.000 n=10+10) RangeQuery/expr=changes(a_ten[1d]),steps=1-16 2.98ms ± 0% 3.30ms ± 1% +10.67% (p=0.000 n=9+10) RangeQuery/expr=changes(a_ten[1d]),steps=10-16 3.66ms ± 1% 4.10ms ± 1% +11.82% (p=0.000 n=10+10) RangeQuery/expr=changes(a_ten[1d]),steps=100-16 10.5ms ± 0% 11.8ms ± 1% +12.50% (p=0.000 n=8+10) RangeQuery/expr=changes(a_ten[1d]),steps=1000-16 77.6ms ± 1% 87.4ms ± 1% +12.63% (p=0.000 n=9+9) RangeQuery/expr=changes(a_hundred[1d]),steps=1-16 30.4ms ± 2% 32.8ms ± 1% +8.01% (p=0.000 n=10+10) RangeQuery/expr=changes(a_hundred[1d]),steps=10-16 37.1ms ± 2% 40.6ms ± 2% +9.64% (p=0.000 n=10+10) RangeQuery/expr=changes(a_hundred[1d]),steps=100-16 105ms ± 1% 117ms ± 1% +11.69% (p=0.000 n=10+10) RangeQuery/expr=changes(a_hundred[1d]),steps=1000-16 783ms ± 3% 876ms ± 1% +11.83% (p=0.000 n=9+10) ``` And then runtime v2.39 compared to after this commit: ``` name old time/op new time/op delta RangeQuery/expr=changes(a_one[1d]),steps=1-16 391µs ± 2% 547µs ± 1% +39.84% (p=0.000 n=9+8) RangeQuery/expr=changes(a_one[1d]),steps=10-16 452µs ± 2% 616µs ± 2% +36.15% (p=0.000 n=10+10) RangeQuery/expr=changes(a_one[1d]),steps=100-16 1.12ms ± 1% 1.26ms ± 1% +12.20% (p=0.000 n=8+10) RangeQuery/expr=changes(a_one[1d]),steps=1000-16 7.83ms ± 1% 7.95ms ± 1% +1.59% (p=0.000 n=10+8) RangeQuery/expr=changes(a_ten[1d]),steps=1-16 2.98ms ± 0% 3.38ms ± 2% +13.49% (p=0.000 n=9+10) RangeQuery/expr=changes(a_ten[1d]),steps=10-16 3.66ms ± 1% 4.02ms ± 1% +9.80% (p=0.000 n=10+9) RangeQuery/expr=changes(a_ten[1d]),steps=100-16 10.5ms ± 0% 10.8ms ± 1% +3.08% (p=0.000 n=8+10) RangeQuery/expr=changes(a_ten[1d]),steps=1000-16 77.6ms ± 1% 78.1ms ± 1% +0.58% (p=0.035 n=9+10) RangeQuery/expr=changes(a_hundred[1d]),steps=1-16 30.4ms ± 2% 33.5ms ± 4% +10.18% (p=0.000 n=10+10) RangeQuery/expr=changes(a_hundred[1d]),steps=10-16 37.1ms ± 2% 40.0ms ± 1% +7.98% (p=0.000 n=10+10) RangeQuery/expr=changes(a_hundred[1d]),steps=100-16 105ms ± 1% 107ms ± 1% +1.92% (p=0.000 n=10+10) RangeQuery/expr=changes(a_hundred[1d]),steps=1000-16 783ms ± 3% 775ms ± 1% -1.02% (p=0.019 n=9+9) ``` In summary, the runtime doesn't really improve with this change for queries with just a few steps. For queries with many steps, this commit essentially reinstates the old performance. This is good because the many-step queries are the one that matter most (longest absolute runtime). In terms of allocations, though, this commit doesn't make a dent at all (numbers not shown). The reason is that most of the allocations happen in the sampleRingIterator (in the storage package), which has to be addressed in a separate commit. Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
Jonathan K. Stevens	ce1bf8b15a	template: adding formatTime function to TemplateExpander (#10993) ... Signed-off-by: Jonathan Stevens <jonathanstevens89@gmail.com> Signed-off-by: Jonathan Stevens <jon.stevens@getweave.com> Co-authored-by: Jonathan Stevens <jon.stevens@getweave.com>	2 years ago
Matthieu MOREL	554f3f32f8	refactor (template): move from github.com/pkg/errors to 'errors' and 'fmt' (#10818) ... Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com> Co-authored-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>	2 years ago
Ziqi Zhao	74e5b596da	add stripDomain to template function (#10475) ... * add stripDomain to template function Signed-off-by: Ziqi Zhao <zzqwf12345@163.com>	3 years ago
Sylvain Rabot	c31a3e4c92	Build with Go 1.18 (#10501) ... * Build with Go 1.18 * Update golangci-lint version Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>	3 years ago
Martina Ferrari	3e4bd4d913	Avoid literal integer overflows in 32 bit arches. ... This commit ensures 64-bit integers are used in various tests that other wise fail in 32-bit architectures. It also adds support for int64 and uint64 types in the template.convertToFloat function to support the test changes. Closes: 10481 Signed-off-by: Martina Ferrari <tina@debian.org>	3 years ago
Julien Pivotto	9a2e93228e	Switch to grafana/regexp everywhere (#10268) ... Let's have a consistent library for regexp. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	3 years ago
Levi Harrison	71a0f42331	template: Fix failing tests on non-amd64 architectures (#10196)	3 years ago
uesyn	13af2470bf	Add stripPort to template function (#10002) ... * template: add `stripPort` to template functions Signed-off-by: GitHub <suemura@zlab.co.jp>	3 years ago
David Leadbeater	c0c5f3227b	Update to return a float ... Signed-off-by: David Leadbeater <dgl@dgl.cx>	3 years ago
David Leadbeater	89ebb3dcf2	Add parseDuration to template functions ... This can be useful when generating rules, a query may use a duration, and it may be useful to template that into a URL parameter. Therefore this allows interfacing with systems that don't implement Prometheus style duration parsing. Signed-off-by: David Leadbeater <dgl@dgl.cx>	3 years ago
Jacques-Etienne Beaudet	9fae120f2a	Support int and uint as datatype for template formatting ... Fixes GH-9679 Signed-off-by: Jacques-Etienne Beaudet <jebeaudet@coveo.com>	3 years ago
beorn7	c954cd9d1d	Move packages out of deprecated pkg directory ... This creates a new `model` directory and moves all data-model related packages over there: exemplar labels relabel rulefmt textparse timestamp value All the others are more or less utilities and have been moved to `util`: gate logging modetimevfs pool runtime Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
Mateusz Gozdek	1a6c2283a3	Format Go source files using 'gofumpt -w -s -extra' ... Part of #9557 Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>	3 years ago
George Robinson	049b4f4f13	Support customization of template options in TemplateExpander (#9290) ... Signed-off-by: George Robinson <george.robinson@grafana.com>	3 years ago
George Robinson	9397402bd3	Fix template_test.go to check that error messages match the expected error message ... Signed-off-by: George Robinson <george.robinson@grafana.com>	3 years ago
Levi Harrison	17ea8d006a	Added external URL access ... Signed-off-by: Levi Harrison <git@leviharrison.dev>	4 years ago
Julien Pivotto	ea6f6bba74	Enable parsing strings in humanize functions (#8682) ... * Enable parsing strings in humanize functions This is useful to humanize count_values or buckets labels. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	4 years ago
Julien Pivotto	6c56a1faaa	Testify: move to require (#8122) ... * Testify: move to require Moving testify to require to fail tests early in case of errors. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu> * More moves Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	4 years ago
Julien Pivotto	4e5b1722b3	Move away from testutil, refactor imports (#8087) ... Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	4 years ago
Guangwen Feng	663016ee0c	Add unit test case to improve test coverage for template.go (#7537) ... Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>	4 years ago
johncming	099b0d7c29	template: remove redundant parentheses. (#5904) ... Signed-off-by: johncming <johncming@yahoo.com>	5 years ago
AllenZMC	00b556e9b5	fix mis-spelling in template.go ... Signed-off-by: czm <zhongming.chang@daocloud.io>	5 years ago
Jens Erat	375aeb9158	Added humanizePercentage formatting to templates (#5670) ... Lots of alerts are based on ratios (eg. disk usage), and humans are used to values in percentage in textual descriptions. Signed-off-by: Jens Erat <email@jenserat.de>	6 years ago
Simon Pasquier	45506841e6	*: enable all default linters (#5504) ... Signed-off-by: Simon Pasquier <spasquie@redhat.com>	6 years ago
Bjoern Rabenstein	38d518c0fe	Rework #5009 after comments ... Signed-off-by: Bjoern Rabenstein <bjoern@rabenste.in>	6 years ago
Sylvain Rabot	335a34486e	Add external labels to template expansion ... This affects the expansion of templates in alert labels and annotations and console templates. Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>	6 years ago
Tariq Ibrahim	8fdfa8abea	refine error handling in prometheus (#5388) ... i) Uses the more idiomatic Wrap and Wrapf methods for creating nested errors. ii) Fixes some incorrect usages of fmt.Errorf where the error messages don't have any formatting directives. iii) Does away with the use of fmt package for errors in favour of pkg/errors Signed-off-by: tariqibrahim <tariq181290@gmail.com>	6 years ago
Mucahit Kurt	4a6c329d71	add alert template expanding failure metric (#4747) ... Signed-off-by: Mucahit Kurt <mucahitkurt@gmail.com>	6 years ago
Ganesh Vernekar	05726c5ea2	Test template expansion while loading groups (#4537) ... Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	6 years ago
Elif T. Kuş	daebf68ea2	Rewrote tests for relabel and template (#3754) ... * relabel: use testutil for testing * template: use testutil for testing	7 years ago
Dominik-K	67c13ba156	template: all `text_template` settings before parsing (bugfix "nil-pointer dereference") (#3854)	7 years ago
Fabian Reinartz	2d0e3746ac	rules: remove dependency on promql.Engine	7 years ago
Julius Volz	099df0c5f0	Migrate "golang.org/x/net/context" -> "context" (#3333) ... In some places, where ctxhttp or gRPC are concerned, we still need to use the old contexts.	7 years ago
Fabian Reinartz	06c2b76cd4	Merge branch 'master' into uptsdb	8 years ago
Julius Volz	ac203ef0ee	Add externalURL template function (#2716) ... This allows users to e.g. add links back to the generating Prometheus right in their alert templates.	8 years ago
Fabian Reinartz	311e7b5069	storage/vendor: update to latest fabxc/tsdb	8 years ago
Fabian Reinartz	157e698958	web/api: fix min/max timestamps to valid range	8 years ago
Fabian Reinartz	fecf9532b9	*: fix misc compile errors	8 years ago
Fabian Reinartz	5817cb5bde	*: migrate from model.* to promql.* types	8 years ago
Fabian Reinartz	09666e2e2a	promql: make scalar public	8 years ago