prometheus

Commit Graph

Author	SHA1	Message	Date
Giedrius Statkevičius	a1d6ba59ac	promql: pass down subquery interval (#11163 ) If we are populating series for a subquery then set the interval parameter accordingly so that downstream users could use that information. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>	2 years ago
Bryan Boreham	3330d85ba8	Replace sort.Strings and sort.Ints with faster slices.Sort (#11318 ) Use new experimental package `golang.org/x/exp/slices`. slices.Sort works on values that are directly comparable, like ints, so avoids the overhad of an interface call to `.Less()`. Left tests unchanged, because they don't need the speed and it may be a cross-check that slices.Sort gives the same answer. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Bryan Boreham	8b863c42dd	Optimise relabeling by re-using memory (#11147 ) * model/relabel: Add benchmark Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * model/relabel: re-use Builder across relabels Saves memory allocations. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * labels.Builder: allow re-use of result slice This reduces memory allocations where the caller has a suitable slice available. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * model/relabel: re-use source values slice To reduce memory allocations. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * Unwind one change causing test failures Restore original behaviour in PopulateLabels, where we must not overwrite the input set. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * relabel: simplify values optimisation Use a stack-based array for up to 16 source labels, which will be the vast majority of cases. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * lint Signed-off-by: Bryan Boreham <bjboreham@gmail.com> Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Vilius Pranckaitis	4660656312	Allow setting custom lookback delta for instant queries (#9946 ) * Allow setting custom lookback delta for instant queries Signed-off-by: Vilius Pranckaitis <vpranckaitis@gmail.com>	2 years ago
Łukasz Mierzwa	54a3c3ba3f	Print query that caused a panic (#10995 ) We print the stacktrace of a panic when query causes one, but there's no information about the query itself, which makes it harder to debug and reproduce the issue. This adds the 'expr' string to the logged panic. Signed-off-by: Łukasz Mierzwa <l.mierzwa@gmail.com>	2 years ago
Matthieu MOREL	0906f2eafa	refactor (promql): move from github.com/pkg/errors to 'errors' and 'fmt' (#10817 ) Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com> Co-authored-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>	3 years ago
Bryan Boreham	2e2c014d52	Labels: optimise creation of signature with/without labels (#10667 ) * Labels: create signature with/without labels Instead of creating a new Labels slice then converting to signature, go directly to the signature and save time. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * Labels: refactor Builder tests Have one test with a range of cases, and have them check the final output rather than checking the internal structure of the Builder. Also add a couple of cases where the value is "", which should be interpreted as 'delete'. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * Labels: add 'Keep' function to Builder This lets us replace `Labels.WithLabels` with the more general `Builder`. In `engine.resultMetric()` we can call `Keep()` instead of checking and calling `Del()`. Avoid calling `Sort()` in `Builder.Labels()` if we didn't add anything, so that `Keep()` has the same performance as `WithLabels()`. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	3 years ago
Alan Protasio	ce6a643ee8	Changing TotalQueryableSamples from int to int64 (#10549 ) * Changing TotalQueryableSamples from int to int64 Signed-off-by: Alan Protasio <approtas@amazon.com>	3 years ago
Andrew Bloomgarden	a64b9fe323	Report PeakSamples in query statistics This exactly corresponds to the statistic compared against MaxSamples during the course of query execution, so users can see how close their queries are to a limit. Co-authored-by: Harkishen Singh <harkishensingh@hotmail.com> Co-authored-by: Andrew Bloomgarden <blmgrdn@amazon.com> Signed-off-by: Andrew Bloomgarden <blmgrdn@amazon.com>	3 years ago
Alan Protasio	606ef33d91	Track and report Samples Queried per query We always track total samples queried and add those to the standard set of stats queries can report. We also allow optionally tracking per-step samples queried. This must be enabled both at the engine and query level to be tracked and rendered. The engine flag is exposed via a Prometheus feature flag, while the query flag is set when stats=all. Co-authored-by: Alan Protasio <approtas@amazon.com> Co-authored-by: Andrew Bloomgarden <blmgrdn@amazon.com> Co-authored-by: Harkishen Singh <harkishensingh@hotmail.com> Signed-off-by: Andrew Bloomgarden <blmgrdn@amazon.com>	3 years ago
Julien Pivotto	9a2e93228e	Switch to grafana/regexp everywhere (#10268 ) Let's have a consistent library for regexp. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	3 years ago
Peter Štibraný	6d76f09c58	Extract interface from ActivityQueryTracker and allows passing custom implementation (#10071 ) * Extract interface from ActivityQueryTracker and allows passing custom implementation. Signed-off-by: Peter Štibraný <pstibrany@gmail.com>	3 years ago
Matej Gera	2c61d29b2a	Tracing: Migrate to OpenTelemetry library (#9724 ) Signed-off-by: Matej Gera <matejgera@gmail.com>	3 years ago
beorn7	b39f2739e5	PromQL: Always enable negative offset and @ modifier This follows the line of argument that the invariant of not looking ahead of the query time was merely emerging behavior and not a documented stable feature. Any query that looks ahead of the query time was simply invalid before the introduction of the negative offset and the @ modifier. Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
Björn Rabenstein	d677aa4b29	storage: Consolidate iterator method names (Values -> At) (#9888 ) `BufferedSeriesIterator` and `MemoizedSeriesIterator` use a method called `Values` for exactly the purpose for which all other iterators of the same kind use a method called `At`. That alone is confusing, but on top of that, the `Values` method only returns a single sample, not multiple values. I assume the naming has historical reasons. This commit makes it more consistent. It is now easier to read, and now `BufferedSeriesIterator` and `MemoizedSeriesIterator` implement `chunkenc.Iterator` like many other iterators, too. Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
Thomas Jackson	f0003bc0ba	Don't drop ParenExpr when creating StepInvariantExpr (#9591 ) * Add test case to showcase the problem in #9590 Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com> * Don't unwrap ParenExpr in newStepInvariantExpr Fixes #9590 Signed-off-by: Thomas Jackson <jacksontj.89@gmail.com>	3 years ago
beorn7	c954cd9d1d	Move packages out of deprecated pkg directory This creates a new `model` directory and moves all data-model related packages over there: exemplar labels relabel rulefmt textparse timestamp value All the others are more or less utilities and have been moved to `util`: gate logging modetimevfs pool runtime Signed-off-by: beorn7 <beorn@grafana.com>	3 years ago
Mateusz Gozdek	1a6c2283a3	Format Go source files using 'gofumpt -w -s -extra' Part of #9557 Signed-off-by: Mateusz Gozdek <mgozdekof@gmail.com>	3 years ago
Bryan Boreham	a278ea4b58	promql: copy data when short-circuiting (#9552 ) * promql: copy data when short-circuiting Because the range query loop re-uses the output buffer each time round, we must copy results into the buffer rather than using input as output. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	3 years ago
Julien Pivotto	a18224d02d	make aggregations deterministic (#9459 ) * Add deterministic test for aggregations Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu> * Make aggregations deterministic Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu> * Increase testing Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	3 years ago
ziollek	55f9147b44	Add atan2 to scalar operators - issue #9485 (#9515 ) * Add atan2 to scalar operators Signed-off-by: Tomasz Ziolkowski <tomasz.ziolkowski@allegro.pl>	3 years ago
Levi Harrison	8547a2bd86	Add `atan2` binary operator Signed-off-by: Levi Harrison <git@leviharrison.dev>	3 years ago
Bryan Boreham	5a754bc043	Short-circuit vector binary ops (#9362 ) In degenerate cases we can save the effort of building a map. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	3 years ago
Bryan Boreham	c4942ef3b7	Optimise query_range by computing join signatures just once (#9360 ) * Add benchmark case for many-to-one join Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * query_range: compute join signatures just once For an expression like `a + on(p,q) b`, extract the `p,q` part from each series once, instead of re-computing at every step of the range. Although there was a cache, computing the key by concatenating all labels was expensive. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	3 years ago
Bryan Boreham	7d105277fe	Optimise topk where k==1 (#9365 ) * Add benchmark for query_range with topk Modify sample data so values within a metric differ Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * Optimise topk where k==1 In this case we don't need a heap to keep track of values; just a single slot is fine. Simplify the initialization of the heap: since all cases start off as a single-item heap we can just assign the value directly. Signed-off-by: Bryan Boreham <bjboreham@gmail.com> * Allow at least one slot in results for topk, quantile k isn't set for quantile, but we need space to start collecting values Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	3 years ago
Darshan Chaudhary	c4f2e9eec5	Add present_over_time (#9097 ) * Add present_over_time Signed-off-by: darshanime <deathbullet@gmail.com> * Add tests for present_over_time Signed-off-by: darshanime <deathbullet@gmail.com> * Address PR comments Signed-off-by: darshanime <deathbullet@gmail.com> * Add documentation for present_over_time Signed-off-by: darshanime <deathbullet@gmail.com> * Update documentation Signed-off-by: darshanime <deathbullet@gmail.com> * Update documentation comment Signed-off-by: darshanime <deathbullet@gmail.com>	3 years ago
darshanime	364c40be57	Add Stringer to Query interface Signed-off-by: darshanime <deathbullet@gmail.com>	3 years ago
Levi Harrison	b5f6f8fb36	Switched to go-kit/log Signed-off-by: Levi Harrison <git@leviharrison.dev>	4 years ago
yeya24	d698e062dc	improve grouping label match logic Signed-off-by: yeya24 <yb532204897@gmail.com>	4 years ago
Marco Pracucci	6719071a0f	Optimize aggregations in PromQL engine (#8594 ) * Optimize aggregations in PromQL engine Signed-off-by: Marco Pracucci <marco@pracucci.com>	4 years ago
Marco Pracucci	7bbab380b6	Added tracing span to evaluator.eval() Signed-off-by: Marco Pracucci <marco@pracucci.com>	4 years ago
Marco Pracucci	b92c03023d	Optimized vector selector Signed-off-by: Marco Pracucci <marco@pracucci.com>	4 years ago
pschou	f80b52be69	Merge branch 'main' into dev_neg_offset	4 years ago
schou	75d932a172	var init for bool Signed-off-by: schou <pschou@users.noreply.github.com>	4 years ago
schou	22bfc11738	aggregate booleans for ease of reading Signed-off-by: schou <pschou@users.noreply.github.com>	4 years ago
schou	22cd48868a	adding feature flag, promql-negative-offset Signed-off-by: schou <pschou@users.noreply.github.com>	4 years ago
pschou	aff3c702ab	promql: Add sgn, clamp and last_over_time functions (#8457 ) * Add sgn, clamp and last_over_time functions Signed-off-by: schou <pschou@users.noreply.github.com>	4 years ago
Ganesh Vernekar	86c71856e8	Add start() and end() pre-processors for @ modifier (#8425 ) * Add start() and end() pre-processors for @ modifier Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * Fix reviews Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * Fix review comments Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * Fix review comments Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	4 years ago
Marcelo E. Magallon	75d86c6747	Update golangci-lint to 1.36.0 In the previous version, 1.18.0, the "megacheck" linter paid attention to the '//lint:ignore' comment, but that is no longer there. Newer version pay attention to '//nolint:<linter>,<linter>,...' comments, optionally followed by a "second" comment introduced by '//'. Update the directives to use this style. This is related to prometheus/blackbox_exporter#738 and prometheus/blackbox_exporter#745. Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>	4 years ago
Ganesh Vernekar	b18fde996e	Fix timestamp() function for @ modifier Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	4 years ago
Ganesh Vernekar	9199fcb8d1	'@ <timestamp>' modifier (#8121 ) This commit adds `@ <timestamp>` modifier as per this design doc: https://docs.google.com/document/d/1uSbD3T2beM-iX4-Hp7V074bzBRiRNlqUdcWP6JTDQSs/edit. An example query: ``` rate(process_cpu_seconds_total[1m]) and topk(7, rate(process_cpu_seconds_total[1h] @ 1234)) ``` which ranks based on last 1h rate and w.r.t. unix timestamp 1234 but actually plots the 1m rate. Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	4 years ago
Ganesh Vernekar	d30da66d77	Fix timestamp() method for vector selector inside paren (#8164 ) Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	4 years ago
Harkishen Singh	fc8e769d71	Use ASSIGN when using = inside braces (#7911 ) * Fix EQL when using = inside braces. Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com> * EQL => EQLC and ASSIGN => EQL Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com> * Aligned yacc code. Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>	4 years ago
Vijay Samuel	00ee73ef91	Export members of EvalNodeHelper to facilitate usage in external functions (#7860 ) Signed-off-by: Vijay Samuel <vjsamuel@ebay.com>	4 years ago
Julien Pivotto	6f9e7ff750	Drop metric name in bool comparison between two instant vectors (#7819 ) * Drop metric name in bool comparison between two instant vectors Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	4 years ago
Julien Pivotto	20ab94fedf	Hints: Separating out the range and offsets of PromQL subqueries (#7667 ) Fix #7629 Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	4 years ago
Annanay Agarwal	118aeab02c	Make context key type public (#7748 ) Signed-off-by: Annanay <annanayagarwal@gmail.com>	4 years ago
Julien Pivotto	22acb87e09	refactoring: make sure that query_duration_seconds metrics are the same (#7668 ) * refactoring: make sure that query_duration_seconds are the same Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	4 years ago
Bartlomiej Plotka	841b13641c	promql: Refactored subquery hint tests and added todos. (#7636 ) * promql: Refactorer subquery hint tests and added todos. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * fmt. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Fixes. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>	4 years ago
Bartlomiej Plotka	a0df8a383a	promql: Removed global and add ability to have better interval for subqueries if not specified (#7628 ) * promql: Removed global and add ability to have better interval for subqueries if not specified ## Changes * Refactored tests for better hints testing * Added various TODO in places to enhance. * Moved DefaultEvalInterval global to opts with func(rangeMillis int64) int64 function instead Motivation: At Thanos we would love to have better control over the subqueries step/interval. This is important to choose proper resolution. I think having proper step also does not harm for Prometheus and remote read users. Especially on stateless querier we do not know evaluation interval and in fact putting global can be wrong to assume for Prometheus even. I think ideally we could try to have at least 3 samples within the range, the same way Prometheus UI and Grafana assumes. Anyway this interfaces allows to decide on promQL user basis. Open question: Is taking parent interval a smart move? Motivation for removing global: I spent 1h fighting with: === RUN TestEvaluations TestEvaluations: promql_test.go:31: unexpected error: error evaluating query "absent_over_time(rate(nonexistant[5m])[5m:])" (line 687): unexpected error: runtime error: integer divide by zero --- FAIL: TestEvaluations (0.32s) FAIL At the end I found that this fails on most of the versions including this master if you run this test alone. If run together with many other tests it passes. This is due to SetDefaultEvaluationInterval(1 * time.Minute) in test that is ran before TestEvaluations. Thanks to globals (: Let's fix it by dropping this global. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Added issue links for TODOs. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Removed irrelevant changes. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>	4 years ago

1 2 3 4 5

249 Commits (2673f94eb1e2435f904ede57b2796fb9cb209766)