214 Commits (235623b45de383f6f6f255edd7f6bcfef38c91e5)

Author	SHA1	Message	Date
Matt T. Proud	1f7f89b4e3	Simplify compaction and expose database sizes. ... This commit simplifies the way that compactions across a database's keyspace occur due to reading the LevelDB internals. Secondarily it introduces the database size estimation mechanisms.	12 years ago
Matt T. Proud	d538b0382f	Include long-tail data deletion mechanism. ... This commit introduces the long-tail deletion mechanism, which will automatically cull old sample values. It is an acceptable hold-over until we get a resampling pipeline implemented. Kill legacy OS X documentation, too.	12 years ago
Julius Volz	ce1ee444f1	Synchronous memory appends and more fine-grained storage locks. ... This does two things: 1) Make TieredStorage.AppendSamples() write directly to memory instead of buffering to a channel first. This is needed in cases where a rule might immediately need the data generated by a previous rule. 2) Replace the single storage mutex by two new ones: - memoryMutex - needs to be locked at any time that two concurrent goroutines could be accessing (via read or write) the TieredStorage memoryArena. - memoryDeleteMutex - used to prevent any deletion of samples from memoryArena as long as renderView is running and assembling data from it. The LevelDB disk storage does not need to be protected by a mutex when rendering a view since renderView works off a LevelDB snapshot. The rationale against adding memoryMutex directly to the memory storage: taking a mutex does come with a small inherent time cost, and taking it is only required in few places. In fact, no locking is required for the memory storage instance which is part of a view (and not the TieredStorage).	12 years ago
Matt T. Proud	fa6a1f97d0	Expose interfaces for pruner and make pruner tool. ... In order to run database cleanups and diagnostics, we should have a means for pruning a database---even if LevelDB does this for us.	12 years ago
Matt T. Proud	161c8fbf9b	Include deletion processor for long-tail values. ... This commit extracts the model.Values truncation behavior into the actual tiered storage, which uses it and behaves in a peculiar way—notably the retention of previous elements if the chunk were to ever go empty. This is done to enable interpolation between sparse sample values in the evaluation cycle. Nothing necessarily new here—just an extraction. Now, the model.Values TruncateBefore functionality would do what a user would expect without any surprises, which is required for the DeletionProcessor, which may decide to split a large chunk in two if it determines that the chunk contains the cut-off time.	12 years ago
Matt Proud	7f0d816574	Schedule the background compactors to run. ... This commit introduces three background compactors, which compact sparse samples together. 1. Older than five minutes is grouped together into chunks of 50 every 30 minutes. 2. Older than 60 minutes is grouped together into chunks of 250 every 50 minutes. 3. Older than one day is grouped together into chunks of 5000 every 70 minutes.	12 years ago
Julius Volz	caab131ada	Repointerize TieredStorage method receiver types.	12 years ago
juliusv	89de116ea9	Merge pull request #225 from prometheus/refactor/fmt-cleanups ... Slice expression simplifications.	12 years ago
Julius Volz	05afa970d2	Slice expression simplifications.	12 years ago
Matt T. Proud	f897164bcf	Expose TieredStorage.DiskStorage.	12 years ago
Matt T. Proud	ce45787dbf	Storage interface to TieredStorage. ... This commit drops the Storage interface and just replaces it with a publicized TieredStorage type. Storage had been anticipated to be used as a wrapper for testability but just was not used due to practicality. Merely overengineered. My bad. Anyway, we will eventually instantiate the TieredStorage dependencies in main.go and pass them in for more intelligent lifecycle management. These changes will pave the way for managing the curators without Law of Demeter violations.	12 years ago
Bernerd Schaefer	5eb9840ed7	Fix goroutine leak in leveldb.AppendSamples ... The error channels in AppendSamples need to be buffered, since in the presence of errors their values may not be consumed.	12 years ago
Matt T. Proud	a3f1d81e24	Publicize a few storage components for curation. ... This commit introduces the publicization of Stop and other components, which the compaction curator shall take advantage of.	12 years ago
Matt T. Proud	4298bab2b0	Publicize Curator and Processors. ... This commit publicizes the curation and processor frameworks for purposes of making them available in the main processor loop.	12 years ago
Julius Volz	368a792dd2	Adjust memory queue size after change to send arrays over channel.	12 years ago
juliusv	b02debd69c	Merge pull request #205 from prometheus/julius-channel-arrays ... Send sample arrays instead of single samples over channels.	12 years ago
Julius Volz	d8110fcd9c	Send sample arrays instead of single samples over channels.	12 years ago
Matt T. Proud	3362bf36e2	Include curator status in web heads-up-display.	12 years ago
Matt T. Proud	6fac20c8af	Harden the tests against OOMs. ... This commit employs explicit memory freeing for the in-memory storage arenas. Secondarily, we take advantage of smaller channel buffer sizes in the test.	12 years ago
Matt T. Proud	66bc3711ea	Merge pull request #197 from prometheus/feature/storage/curation-table ... Add curation remark table and refactor error mgmt.	12 years ago
Matt T. Proud	d46cd089b5	Merge pull request #199 from prometheus/refactor/telemetry/api-refresh ... Refresh Prometheus client API usage.	12 years ago
Matt T. Proud	3fa260f180	Complete sentence.	12 years ago
Matt T. Proud	e527941b6a	Use tagged struct fields.	12 years ago
Matt T. Proud	a48ab34dd0	Refresh Prometheus client API usage. ... The client API has been updated per https://github.com/prometheus/client_golang/pull/9.	12 years ago
Matt T. Proud	561974308d	Add curation remark table and refactor error mgmt. ... The curator requires the existence of a curator remark table, which stores the progress for a given curation policy. The tests for the curator create an ad hoc table, but core Prometheus presently lacks said table, which this commit adds. Secondarily, the error handling for the LevelDB lifecycle functions in the metric persistence have been wrapped into an UncertaintyGroup, which mirrors some of the functions of sync.WaitGroup but adds error capturing capability to the mix.	12 years ago
Matt T. Proud	b3e34c6658	Implement batch database sample curator. ... This commit introduces to Prometheus a batch database sample curator, which corroborates the high watermarks for sample series against the curation watermark table to see whether a curator of a given type needs to be run. The curator is an abstract executor, which runs various curation strategies across the database. It remarks the progress for each type of curation processor that runs for a given sample series. A curation procesor is responsible for effectuating the underlying batch changes that are request. In this commit, we introduce the CompactionProcessor, which takes several bits of runtime metadata and combine sparse sample entries in the database together to form larger groups. For instance, for a given series it would be possible to have the curator effectuate the following grouping: - Samples Older than Two Weeks: Grouped into Bunches of 10000 - Samples Older than One Week: Grouped into Bunches of 1000 - Samples Older than One Day: Grouped into Bunches of 100 - Samples Older than One Hour: Grouped into Bunches of 10 The benefits hereof of such a compaction are 1. a smaller search space in the database keyspace, 2. better employment of compression for repetious values, and 3. reduced seek times.	12 years ago
Julius Volz	2202cd71c9	Track alerts over time and write out alert timeseries.	12 years ago
Johannes 'fish' Ziemke	1ad41d4c00	Call closer.Close() earlier.	12 years ago
Johannes 'fish' Ziemke	22da76e8ab	Close of reportTicker to exit goroutine.	12 years ago
Johannes 'fish' Ziemke	5043c6fce7	Have goroutine exit on signal via defer block.	12 years ago
juliusv	af7ddc36e2	Merge pull request #176 from prometheus/optimization/view-materialization/slice-chunking ... Truncate irrelevant chunk values.	12 years ago
Julius Volz	9b8c671ec9	Fixes/cleanups to renderView() samples truncation.	12 years ago
Matt T. Proud	05504d3642	WIP - Truncate irrelevant chunk values. ... This does not work with the view tests.	12 years ago
Matt T. Proud	a32602140e	Convert the TestInstant value into UTC. ... For the forthcoming Curator, we don't record timezone information in the samples, nor do we in the curation remarks. All times are recorded UTC. That said, for the test environment to better match production, the special instant should be in UTC.	12 years ago
Matt T. Proud	b1a8e51b07	Extract dto.SampleValueSeries into model.Values.	12 years ago
Matt T. Proud	422003da8e	Convert trailing float64s.	12 years ago
Matt T. Proud	db4ffbb262	Wrap dto.SampleKey with business logic type. ... The curator work can be done easier if dto.SampleKey is no longer directly accessed but rather has a higher level type around it that captures a certain modicum of business logic. This doesn't look terribly interesting today, but it will get more so.	12 years ago
Matt T. Proud	f9e99bd08a	Refresh SampleValue to 64-bit floating point. ... We always knew that this needed to be fixed.	12 years ago
Matt T. Proud	092c7bd88e	Stochastic test support plural SampleValueSeries. ... After SampleValue was refactored into SampleValueSeries, which involves plural values under a common super key, the stochastic test was never refreshed to reflect this reality. We had other tests that validated the functionality, but this one was insufficently forward-ported.	12 years ago
Julius Volz	99dcbe0f94	Integrate memory and disk layers in view rendering.	12 years ago
Julius Volz	63625bd244	Make view use memory persistence, remove obsolete code. ... This makes the memory persistence the backing store for views and adjusts the MetricPersistence interface accordingly. It also removes unused Get* method implementations from the LevelDB persistence so they don't need to be adapted to the new interface. In the future, we should rethink these interfaces. All staleness and interpolation handling is now removed from the storage layer and will be handled only by the query layer in the future.	12 years ago
Matt T. Proud	d468271e2f	Fix append queue telemetry and parameterize sizes. ... The original append queue telemetry never worked, because it was updated only upon the exit of the select statement, which would usually liberate the queues of contents. This has been fixed to be reported arbitrarily. The queue sizes are now parameterizable via flags.	12 years ago
Julius Volz	95b081f9bc	Stop serving tiered storage after draining it.	12 years ago
Matt T. Proud	a55602df4a	Validate diskFrontier domain for series candidate. ... It is the case with the benchmark tool that we thought that we generated multiple series and saved them to the disk as such, when in reality, we overwrote the fields of the outgoing metrics via Go map reference behavior. This was accidental. In the course of diagnosing this, a few errors were found: 1. ``newSeriesFrontier`` should check to see if the candidate fingerprint is within the given domain of the ``diskFrontier``. If not, as the contract in the docstring stipulates, a ``nil`` ``seriesFrontier`` should be emitted. 2. In the interests of aiding debugging, the raw LevelDB ``levigoIterator`` type now includes a helpful forensics ``String()`` method. This work produced additional cleanups: 1. ``Close() error`` with the storage stack is technically incorrect, since nowhere in the bowels of it does an error actually occur. The interface has been simplified to remove this for now.	12 years ago
Matt T. Proud	d79c932a8e	Merge pull request #120 from prometheus/feature/storage/compaction ... Spin up curator run in the tests.	12 years ago
Matt T. Proud	c3e3460ca6	Spin up curator run in the tests. ... After this commit, we'll need to add validations that it does the desired work, which we presently know that it doesn't. Given the changes I made with a plethora of renamings, I want to commit this now before it gets even larger.	12 years ago
Matt T. Proud	461da0b3a8	Merge pull request #117 from prometheus/feature/storage/compaction ... Spin up storage layers for made fixtures.	12 years ago
Matt T. Proud	d0ad6cbeaa	Spin up storage layers for made fixtures.	12 years ago
Julius Volz	c59f3fc538	Fix formatting in tiered_test.go.	12 years ago
juliusv	39826d7335	Merge pull request #107 from prometheus/julius-fix-get-fingerprints ... Fix bug in GetFingerprintsForLabelSet().	12 years ago
Julius Volz	2668700e54	Fix bug in GetFingerprintsForLabelSet().	12 years ago
Matt T. Proud	c53a72a894	Test data for the curator.	12 years ago
Matt T. Proud	6dcaa28806	Include LevelDB fixture generators for curator. ... This will help reduce common boilerplate for our test process with respect to LevelDB-related things.	12 years ago
Julius Volz	55ca65aa6e	More userfriendly output when we fail to create the tiered storage.	12 years ago
Matt T. Proud	c4e971d7d9	Merge pull request #101 from prometheus/refactor/test/directory-extraction ... Create temporary directory handler.	12 years ago
Matt T. Proud	b86b0ea41a	Create temporary directory handler.	12 years ago
Julius Volz	8cf2af3923	Abort view job processing on timeout.	12 years ago
Julius Volz	2b8f0b2cc7	Constantize metric name label name.	12 years ago
Julius Volz	e096896932	PR comment fixups.	12 years ago
Julius Volz	dd67ab115b	Change GetAllMetricNames() to GetAllValuesForLabel().	12 years ago
Julius Volz	42bdf921d1	Fetch integrated memory/disk data for simple Get* functions.	12 years ago
Julius Volz	11bb94a7e5	Implement GetAllMetricNames() for memory storage.	12 years ago
Julius Volz	991dc68d78	Rename misnamed oldestSampleTimestamp variable.	12 years ago
Matt T. Proud	3e97a3630d	Include nascent curator scaffolding. ... The curator doesn't do anything yet; rather, this is the type definition including the anciliary testing scaffold. Improve Makefile and Git developer experience. The top-level Makefile was a bit overloaded in terms of generation of assets and their management. This has been offloaded into separate Makefiles. The Git developer experience sucked due to lack of .gitignore policies. Also: Fix faulty skiplist naming from old merge.	12 years ago
Matt T. Proud	b2e4c88b80	Wrap LevelDB iterator operations behind interface. ... The LevelDB storage types return an interface type now that wraps around the underlying iterator. This both enhances testability but improves upon, in my opinion, the interface design for the LevelDB iterator. Secondarily, the resource reaping behaviors for the LevelDB iterators have been improved by dropping the externalized io.Closer object. Finally, the iterator provisioning methods provide the option for indicating whether one wants a snapshotted iterator or not.	12 years ago
Matt T. Proud	f2a30cf20c	Several important cleanups and deprecations. ... EachFunc is deprecated. Remove deprecated ``Pair`` and ``GetAll``. These were originally used for forensic and the old gorest impl. Nothing today in the user-facing path nor the tests uses them, especially since the advent of the ForEach protocol in the interface.	12 years ago
Matt T. Proud	70448711ec	Merge pull request #95 from prometheus/feature/persistence/batching ... Several interface cleanups.	12 years ago
Matt T. Proud	8f6b55be71	Several interface cleanups. ... - Kill Close in Persistent and document interface. - Extract batching behavior into interface. - Kill IteratorManager, which was used for unknown reasons.	12 years ago
Julius Volz	a33d2726bc	Mark range op as consumed if it receives no data points in range.	12 years ago
Julius Volz	3c9d6cb66c	Add several needed persistence proxy methods to tiered storage.	12 years ago
Julius Volz	081d250929	Fix view's GetRangeValues() reverse iteration behavior.	12 years ago
Julius Volz	0be0aa59c2	Wait until storage is drained before closing the underlying leveldb.	12 years ago
Julius Volz	becc278eb6	Fix two bugs in range op time advancement.	12 years ago
Matt T. Proud	ceb6611957	Fix regression in subsequent range op. compactions. ... We have an anomaly whereby subsequent range operations fail to be compacted into one single range operation. This fixes such behavior.	12 years ago
Matt T. Proud	669abdfefe	``make format`` invocation.	12 years ago
Julius Volz	bdb067b47f	Implement remaining View Get* methods.	12 years ago
Julius Volz	1f42364733	Fix typo in comment.	12 years ago
Matt T. Proud	758a3f0764	Add documentation and cull junk.	12 years ago
Matt T. Proud	bd8bb0edfd	One additional reduction.	12 years ago
Matt T. Proud	73b463e814	Additional simplifications.	12 years ago
Matt T. Proud	fd47ac570f	Implied simplifications.	12 years ago
Matt T. Proud	51a0f21cf8	Interim documentation	12 years ago
Matt T. Proud	b470f925b7	Extract rewriting of interval queries.	12 years ago
Matt T. Proud	eb721fd220	Include note about greediest range.	12 years ago
Julius Volz	e50de005f9	Populate metric in SampleSet returned from GetRangeValues()	12 years ago
Julius Volz	6001d22f87	Change Get* methods to receive fingerprints instead of metrics.	12 years ago
Julius Volz	95f8885c8a	Adopt new ops sorting interface in view rendering.	12 years ago
Julius Volz	4d79dc3602	Replace renderView() by cleaner and more correct reimplementation.	12 years ago
Julius Volz	e0dbc8c561	Fix edge cases in data extraction for point and interval ops.	12 years ago
Julius Volz	a4361e4116	Rename extractSampleValue -> extractSampleValues.	12 years ago
Julius Volz	4e7db57e76	Fix iterator behavior in view.GetSampleAtTime()	12 years ago
Julius Volz	bb9c5ed7aa	Fix nil pointer exception in frontier building.	12 years ago
Matt T. Proud	896e172463	Extract time group optimizations.	12 years ago
Matt T. Proud	5a71814778	Additional greediness.	12 years ago
Matt T. Proud	b00ca7e422	Refactor some greediness computations.	12 years ago
Matt T. Proud	978acd4e96	Simplify time group optimizations. ... The old code performed well according to the benchmarks, but the new code shaves 1/6th of the time off the original and with less code.	12 years ago
Matt T. Proud	d7b534e624	Update documentation.	12 years ago
Matt T. Proud	1f7ed52b46	Start writing high watermarks.	12 years ago
Julius Volz	a224dda9f0	Fix diskFrontier.ContainsFingerprint() return value.	12 years ago
Matt T. Proud	47ce7ad302	Extract appending from goroutine.	12 years ago