627 Commits (1df0fb5569844c14c19dc27641b9a3a9a156de16)

Author	SHA1	Message	Date
Julien Pivotto	009017a3fb	Revert "Remove deleted target from discovery manager" ... Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	1 year ago
Julien Pivotto	103b8567d6	Merge pull request #12541 from haleyao/main ... Remove deleted target from discovery manager	1 year ago
Julien Pivotto	ea039fcebf	Merge pull request #11463 from proggga/small_refactor ... marathon.go: Simplified conditions in method	1 year ago
Marc Tuduri	98383fdc63	sd: change hetzner role type and constants to be exportable ... Signed-off-by: Marc Tuduri <marctc@protonmail.com>	1 year ago
Julien Pivotto	2bdb2e627f	Merge pull request #10914 from wangrzneu/add-endpointslice-label ... Add more labels for endpointslice and endpoints role in k8s discovery	1 year ago
Julian Tölle	7aa7965716	build(deps): bump github.com/hetznercloud/hcloud-go to v2.0.0 ... Version 2 introduced a breaking change in the `id` field of all resources. They were changed from `int` to `int64` to make sure that all future numerical IDs are supported on all architectures. You can learn more about this [here](https://docs.hetzner.cloud/#deprecation-notices-%E2%9A%A0%EF%B8%8F) Signed-off-by: Julian Tölle <julian.toelle@hetzner-cloud.de>	1 year ago
Daniel Swarbrick	de89a8c827	Linode SD: cast InstanceSpec values to int64 to avoid overflows ... InstanceSpec struct members are untyped integers, so they can overflow on 32-bit arch when bit-shifted left. Signed-off-by: Daniel Swarbrick <daniel.swarbrick@gmail.com>	1 year ago
Mikhail Fesenko	02e11cc2a7	Fix from discussion ... Signed-off-by: Mikhail Fesenko <proggga@gmail.com>	1 year ago
Mikhail Fesenko	17cdfdd79f	maraphon.go: Simplified conditions in method ... Signed-off-by: Mikhail Fesenko <proggga@gmail.com>	1 year ago
haleyao	c5a37ddad5	Remove deleted target from discovery manager ... Signed-off-by: haleyao <haleyao@tencent.com>	1 year ago
Julien Pivotto	076056ccdf	Merge pull request #11642 from zoonage/main ... Do not add pods to target group if the PodIP status is not set	1 year ago
Taavi Väänänen	0f4c27e2bf	discovery/openstack: Include instance image ID in labels ... Adds a new label to include the ID of the image that an instance is using. This can be used for example to filter a job to only include instances using a certain image as that image includes some exporter. Sometimes the image information isn't available, such as when the image is private and the user doesn't have the roles required to see it. In those cases we just don't set the label, as the rest of the information from the discovery provider can still be used. Signed-off-by: Taavi Väänänen <hi@taavi.wtf>	1 year ago
Matt Harbison	02277bbe0d	Fix path handling in File-SD watcher to allow directory monitoring on Windows ... Previously, `d.paths` were normalized to backslashes on Windows, even when if the config file used Unix style. The end result meant always watching `./`, so changes for this config were always ignored: scrape_configs: - job_name: 'envmsc1' file_sd_configs: - files: - 'targets/envmsc1.d/*.yml' - 'targets/envmsc1.d/*.yaml' Additionally, unlike the other platforms, no warning was emitted on startup about not being able to install the watch if the directory didn't exist. Now it is logged. Signed-off-by: Matt Harbison <mharbison@atto.com>	1 year ago
renzheng.wang	b2c5de2e65	fix lint issue ... Signed-off-by: renzheng.wang <wangrzneu@gmail.com>	2 years ago
renzheng.wang	98ffad01b8	update tests and docs ... Signed-off-by: renzheng.wang <wangrzneu@gmail.com>	2 years ago
renzheng.wang	866fa25b20	add label and labelpresent for endpointslice role in k8s discovery ... Signed-off-by: renzheng.wang <wangrzneu@gmail.com>	2 years ago
Julien Pivotto	0dc31ade41	Add support for consul path_prefix ... Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Mickael Carl	2f35619710	discovery/kubernetes: attach node labels when the endpoints TargetRef's kind are Node ... Signed-off-by: Mickael Carl <mcarl@apple.com>	2 years ago
cui fliter	276ca6a883	fix some comments ... Signed-off-by: cui fliter <imcusg@gmail.com>	2 years ago
Matthieu MOREL	bae9a21200	Merge branch 'main' into linter/nilerr ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	2 years ago
beorn7	5b53aa1108	style: Replace `else if` cascades with `switch` ... Wiser coders than myself have come to the conclusion that a `switch` statement is almost always superior to a statement that includes any `else if`. The exceptions that I have found in our codebase are just these two: * The `if else` is followed by an additional statement before the next condition (separated by a `;`). * The whole thing is within a `for` loop and `break` statements are used. In this case, using `switch` would require tagging the `for` loop, which probably tips the balance. Why are `switch` statements more readable? For one, fewer curly braces. But more importantly, the conditions all have the same alignment, so the whole thing follows the natural flow of going down a list of conditions. With `else if`, in contrast, all conditions but the first are "hidden" behind `} else if `, harder to spot and (for no good reason) presented differently from the first condition. I'm sure the aforemention wise coders can list even more reasons. In any case, I like it so much that I have found myself recommending it in code reviews. I would like to make it a habit in our code base, without making it a hard requirement that we would test on the CI. But for that, there has to be a role model, so this commit eliminates all `if else` occurrences, unless it is autogenerated code or fits one of the exceptions above. Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
beorn7	c3c7d44d84	lint: Adjust to the lint warnings raised by current versions of golint-ci ... We haven't updated golint-ci in our CI yet, but this commit prepares for that. There are a lot of new warnings, and it is mostly because the "revive" linter got updated. I agree with most of the new warnings, mostly around not naming unused function parameters (although it is justified in some cases for documentation purposes – while things like mocks are a good example where not naming the parameter is clearer). I'm pretty upset about the "empty block" warning to include `for` loops. It's such a common pattern to do something in the head of the `for` loop and then have an empty block. There is still an open issue about this: https://github.com/mgechev/revive/issues/810 I have disabled "revive" altogether in files where empty blocks are used excessively, and I have made the effort to add individual `// nolint:revive` where empty blocks are used just once or twice. It's borderline noisy, though, but let's go with it for now. I should mention that none of the "empty block" warnings for `for` loop bodies were legitimate. Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
Matthieu MOREL	fb3eb21230	enable gocritic, unconvert and unused linters ... Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	2 years ago
Julien Pivotto	5f3a02f1e2	Update go dependencies ... Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Fish-pro	43d77f7c41	Use http constants instead of string ... Signed-off-by: Fish-pro <zechun.chen@daocloud.io>	2 years ago
Peter Nicholson	138a1362d8	Add support for EndpointSlice conditions ... Signed-off-by: Peter Nicholson <petergoods@hotmail.com>	2 years ago
Frederic Branczyk	9f91215bf6	Merge pull request #11844 from bawhetst/add-pod-container-id ... discovery/kubernetes: add container ID as a meta label for pod targets	2 years ago
Bryan Boreham	b768247df8	Merge pull request #11760 from bboreham/discovery-log-setname ... service discovery: add name to log messages	2 years ago
Bryan Boreham	2f58be840d	service discovery: add config name to log messages ... This makes it easier to connect a log message with the config it relates to. Each SD config has a name, either the scrape job name or something like "config-0" for Alertmanager config. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	2 years ago
Ben Whetstone	32e9f6a39c	Add container ID as a meta label for pod targets ... Signed-off-by: Ben Whetstone <ben.whetstone@sysdig.com>	2 years ago
Jens Erat	728fdc959e	Kubernetes SD: disable resync timer ... While originally the resync period also forced refreshing from Kubernetes API server, this has been removed for some years now because watching the API server got more stable [1]. Today, this just results in all entities being sent to the service discovery again, which is valid from a general Prometheus perspective, but results in unnecessary CPU load and also breaks service discovery metrics. In especially, this makes monitoring "do we actually observe changes from Kubernetes API server" impossible (receiving constant updates from Kubernetes service discovery is a pretty valid assumption, for example nodes get frequent status updates, ...). Signed-off-by: Jens Erat <jens.erat@mercedes-benz.com>	2 years ago
David Fridman	52adf55631	Add VM size label to azure service discovery (#11575) (#11650) ... * Add VM size label to azure service discovery (#11575) Signed-off-by: davidifr <davidfr.mail@gmail.com> * Add VM size label to azure service discovery (#11575) Signed-off-by: davidifr <davidfr.mail@gmail.com> * Add VM size label to azure service discovery (#11575) Signed-off-by: davidifr <davidfr.mail@gmail.com> Signed-off-by: davidifr <davidfr.mail@gmail.com>	2 years ago
Julien Pivotto	3677d61a4b	Update kubernetes dependencies ... A new API is available for AddEventHandlers, to get errors but also be able to cancel handlers. Doing the easy thing for the release, which is just to log errors. We could see how to improve this in the future to handle the errors properly and cancel the handlers. Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Aaron George	d542483e8c	k8s discovery: Ensure that the pod IP is in the status before adding to target group ... Signed-off-by: Aaron George <aaron@ometria.com> Signed-off-by: Aaron George <aaron@ometria.com>	2 years ago
Levi Harrison	f81fae2414	Add common HTTP client to AWS SDs (#11611) ... * Common client in EC2 and Lightsail Signed-off-by: Levi Harrison <git@leviharrison.dev> * Azure -> AWS Signed-off-by: Levi Harrison <git@leviharrison.dev> Signed-off-by: Levi Harrison <git@leviharrison.dev>	2 years ago
Michael Fuller	15ba7a0d2d	file sd: create and increment an inotify error counter when file-SD i… (#11066) ... * file sd: create and increment an inotify error counter when file-SD is unable to watch files. Additionally, order metrics alphabetically. Signed-off-by: Michael Fuller <mfuller@digitalocean.com> * file.go: consistent naming and help for prometheus_sd_file_watcher_errors_total Signed-off-by: Michael Fuller <mfuller@digitalocean.com> Signed-off-by: Michael Fuller <mfuller@digitalocean.com> Co-authored-by: Michael Fuller <mfuller@digitalocean.com>	2 years ago
Julien Pivotto	7a67a728a8	Followup on OVHCloud merge (#11529) ... Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu> Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Marine Bal	16c3aa75c0	Add service discovery for OvhCloud (#10802) ... * feat(ovhcloud): add ovhcloud management Signed-off-by: Marine Bal <marine.bal@corp.ovh.com> Co-authored-by: Arnaud Sinays <sinaysarnaud@gmail.com>	2 years ago
Viacheslav Panasovets	3d2e18bad5	Fix time.Since() in defer. Wrap in anonymous function (#11489) ... Function arguments in defer evaluated during definition of defer, not during execution Signed-off-by: Slavik Panasovets <slavik@google.com> Signed-off-by: Slavik Panasovets <slavik@google.com>	2 years ago
David Cañadillas	51a44e6657	Adding Consul Enterprise Admin Partitions (#11482) ... * Adding Consul Enterprise Admin Partitions Signed-off-by: dcanadillas <dcanadillas@hashicorp.com>	2 years ago
Maciej Borsz	56eba3ace2	Use protobuf encoding in client-go ... Signed-off-by: Maciej Borsz <maciejborsz@google.com>	2 years ago
Brian Candler	4a493db432	Add __meta_ec2_region label (#11326) ... Fixes #11320 Signed-off-by: Brian Candler <b.candler@pobox.com> Signed-off-by: Brian Candler <b.candler@pobox.com>	2 years ago
Julien Pivotto	96d5a32659	Update go to 1.19, set min version to 1.18 (#11279) ... * Update go to 1.19, set min version to 1.18 Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu> * Update golangci-lint Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu> Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Julien Pivotto	15fa34936b	PuppetDB SD: Add __meta_puppetdb_query label (#11238) ... Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Cosrider	bef6556ca5	delete redundant alias (#11180) ... Signed-off-by: Cosrider <cosrider7@gmail.com> Signed-off-by: Cosrider <cosrider7@gmail.com>	2 years ago
Renato Costa	d521933053	Fix incorrect use of loop variable in parallel test (#11205) ... This fixes an occurrence of a loop variable being captured in a parallel test (`TestInitialUpdate`). Prior to this commit, only the last test case declared in that test would actually execute. To work around this problem, we create a copy of the range variable before the paralllel test, as suggested in the documentation for the `testing` package: https://pkg.go.dev/testing#hdr-Subtests_and_Sub_benchmarks The test immediately after the one fixed here (`TestInvalidFile`) followed the same pattern but correctly created a copy of the loop variable, illustrating how easy it is to forget to do this in practice. Issue was automatically found using the `loopvarcapture` linter. Signed-off-by: Renato Costa <renato@cockroachlabs.com> Signed-off-by: Renato Costa <renato@cockroachlabs.com>	2 years ago
Karl Piplies	3782cb40d5	add loadbalancerip to service labels ... Signed-off-by: Karl Piplies <karl.piplies@mercedes-benz.com>	2 years ago
David Leadbeater	d677ec489e	Support using MX records for DNS discovery (#10099) ... It's currently possible to use blackbox_exporter to probe MX records themselves. However it's not possible to do an end-to-end test, like is possible with SRV records. This makes it possible to use MX records as a source of hostnames in the same way as SRV records. Signed-off-by: David Leadbeater <dgl@dgl.cx>	2 years ago
Abirdcfly	465558e93a	fix minor code unreachability error (#11040) ... Signed-off-by: Abirdcfly <fp544037857@gmail.com>	2 years ago
Frederic Branczyk	414c3e549c	Merge pull request #11002 from yngwiewang/feature/k8s-service-port-number ... feat:(kubernetes_sd): add __meta_kubernetes_service_port_number (#10945)	2 years ago