prometheus

Commit Graph

Author	SHA1	Message	Date
Bjoern Rabenstein	1909686789	Make metrics exported by the Prometheus server itself more consistent. - Always spell out the time unit (e.g. milliseconds instead of ms). - Remove "_total" from the names of metrics that are not counters. - Make use of the "Namespace" and "Subsystem" fields in the options. - Removed the "capacity" facet from all metrics about channels/queues. These are all fixed via command line flags and will never change during the runtime of a process. Also, they should not be part of the same metric family. I have added separate metrics for the capacity of queues as convenience. (They will never change and are only set once.) - I left "metric_disk_latency_microseconds" unchanged, although that metric measures the latency of the storage device, even if it is not a spinning disk. "SSD" is read by many as "solid state disk", so it's not too far off. (It should be "solid state drive", of course, but "metric_drive_latency_microseconds" is probably confusing.) - Brian suggested to not mix "failure" and "success" outcome in the same metric family (distinguished by labels). For now, I left it as it is. We are touching some bigger issue here, especially as other parts in the Prometheus ecosystem are following the same principle. We still need to come to terms here and then change things consistently everywhere. Change-Id: If799458b450d18f78500f05990301c12525197d3	10 years ago
Brian Brazil	4a2b96f848	Remove backoff on scrape failure. Having metrics with variable timestamps inconsistently spaced when things fail will make it harder to write correct rules. Update status page, requires some refactoring to insert a function. Change-Id: Ie1c586cca53b8f3b318af8c21c418873063738a8	10 years ago
Julius Volz	1bb7074fec	Fix HTTP connection leak upon non-OK status. Change-Id: Ie7fbd7dcc089b8306b40631be3e3d736c23c1cd3	10 years ago
Bjoern Rabenstein	bacc31d5cc	Remove work-around that required copying all bytes of a scrape. Now that the subtle bug in matttproud/golang_protobuf_extensions is fixed, we do not need to copy the bytes of a scrape into a buffer first before starting to parse it. Change-Id: Ib73ecae16173ddd219cda56388a8f853332f8853	10 years ago
Bjoern Rabenstein	8956faeccb	Migrate to new client_golang. This change will only be submitted when the new client_golang has been moved to the new version. Change-Id: Ifceb59333072a08286a8ac910709a8ba2e3a1581	10 years ago
Bjoern Rabenstein	814e479723	Treat non-200 HTTP response as error. Change-Id: I2a9f3b47012b3c4839be53aa44c66d16dd41a24a	10 years ago
Bjoern Rabenstein	ca6a4fccef	Weed out our homegrown test.Tester. The Go stdlib has testing.TB now, which fulfills the exact same purpose. Change-Id: I0db9c73400e208ca376b932a02b7e3402234b87c	11 years ago
Brian Brazil	23255f1499	Fix negative Next Retrieval on status page. Change-Id: Ifa754034660a251fee71f166dbf057697ec4e872	11 years ago
Bjoern Rabenstein	64811caaec	Make Prometheus announce its new super-power: text format! Change-Id: Ia2ddfb28999c145e4d46c395381a9bf89d43148c	11 years ago
Julius Volz	84df022025	Cleanup server address handling, support IPv6. This fixes https://github.com/prometheus/prometheus/issues/377, as IPv6 server addresses are now handled correctly. Change-Id: Iebde7cfdadb0a52041472517e6fdcff4303a25ab	11 years ago
Julius Volz	b382e8b7bd	Remove overly verbose DNS-SD logging line. Change-Id: Ie4534437ab88b9a6b99f5cb6c2f32c9588c1fff6	11 years ago
Julius Volz	0378c2ca1f	Nonexistent labels in BY-clauses shouldn't propagate to result. This fixes bug 2. of https://github.com/prometheus/prometheus/issues/374 Change-Id: Ia4a13153616bafce5bf10597966b071434422d09	11 years ago
Stuart Nelson	48a6326d25	Added DNS-SD lookup counter for successful/unsuccessful lookups Change-Id: I0a71e994a989cecace280b5134a31ebc2ace7591	11 years ago
Julius Volz	fb44580110	Cleanup/fix program termination sequence. Change-Id: I2bc58a2583fb079c9ef383cfc7a5e0fbe613f1cd	11 years ago
Julius Volz	740d448983	Use custom timestamp type for sample timestamps and related code. So far we've been using Go's native time.Time for anything related to sample timestamps. Since the range of time.Time is much bigger than what we need, this has created two problems: - there could be time.Time values which were out of the range/precision of the time type that we persist to disk, therefore causing incorrectly ordered keys. One bug caused by this was: https://github.com/prometheus/prometheus/issues/367 It would be good to use a timestamp type that's more closely aligned with what the underlying storage supports. - sizeof(time.Time) is 192, while Prometheus should be ok with a single 64-bit Unix timestamp (possibly even a 32-bit one). Since we store samples in large numbers, this seriously affects memory usage. Furthermore, copying/working with the data will be faster if it's smaller. MEMORY USAGE RESULTS Initial memory usage comparisons for a running Prometheus with 1 timeseries and 100,000 samples show roughly a 13% decrease in total (VIRT) memory usage. In my tests, this advantage for some reason decreased a bit the more samples the timeseries had (to 5-7% for millions of samples). This I can't fully explain, but perhaps garbage collection issues were involved. WHEN TO USE THE NEW TIMESTAMP TYPE The new clientmodel.Timestamp type should be used whenever time calculations are either directly or indirectly related to sample timestamps. For example: - the timestamp of a sample itself - all kinds of watermarks - anything that may become or is compared to a sample timestamp (like the timestamp passed into Target.Scrape()). When to still use time.Time: - for measuring durations/times not related to sample timestamps, like duration telemetry exporting, timers that indicate how frequently to execute some action, etc. NOTE ON OPERATOR OPTIMIZATION TESTS We don't use operator optimization code anymore, but it still lives in the code as dead code. It still has tests, but I couldn't get all of them to pass with the new timestamp format. I commented out the failing cases for now, but we should probably remove the dead code soon. I just didn't want to do that in the same change as this. Change-Id: I821787414b0debe85c9fffaeb57abd453727af0f	11 years ago
Johannes 'fish' Ziemke	8c08a5031f	Add search domain support to SRV lookups This adds search domain support by trying to resolve a name by appending each search domain configured in /etc/resolv.conf until the query succeeds (NOERROR) and has at least one answer. Change-Id: Ibdc5138c5d8cc049e11fab90c3d5243d5a06852c	11 years ago
Julius Volz	274934bcd3	Revert "Revert "Merge pull request #317 from prometheus/fix/miekg-dns-for-srv"" This reverts commit `88099328d1`. Change-Id: I7bf74de5fda458e2e6f9eea2eacd0e256f95bdee	11 years ago
Johannes 'fish' Ziemke	88099328d1	Revert "Merge pull request #317 from prometheus/fix/miekg-dns-for-srv" This reverts commit `e3bc6fc9dc`, reversing changes made to `1cf9e5840a`. Conflicts: retrieval/target_provider.go Change-Id: Icb6e98fb30419e9e2fe9b686c243702ced372014	11 years ago
Julius Volz	788587426b	Make scrape timeouts configurable per job. Change-Id: I77a7514ad9e7969771f873d63d6353ec50082a62	11 years ago
Julius Volz	d69b85e6c9	Add global label support via Ingesters.	11 years ago
Julius Volz	0003027dce	Add needed trailing spaces in logs.	11 years ago
Julius Volz	aa5d251f8d	Use github.com/golang/glog for all logging.	11 years ago
Matt T. Proud	a5141e4d0a	Depointerize storage conf. and chain ingester. The storage builders need to work with the assumption that they have a copy of the underlying configuration data if any mutations are made.	11 years ago
Julius Volz	f8b20f30ac	Make retrieval work with client's new Ingester interface.	11 years ago
Julius Volz	3b970c5133	Add variable interpolation to notification messages. This includes required refactorings to enable replacing the http client (for testing) and moving the NotificationReq type definitions to the "notifications" package, so that this package doesn't need to depend on "rules" anymore and that it can instead use a representation of the required data which only includes the necessary fields.	11 years ago
Julius Volz	35ee2cd3cb	Add alertmanager notification support to Prometheus. Alert definitions now also have mandatory SUMMARY and DESCRIPTION fields that get sent along a firing alert to the alert manager.	11 years ago
Julius Volz	81f0b85013	Return [] instead of null for empty result vectors.	12 years ago
Julius Volz	331be19af6	Fix broken retrieval tests. These have been broken since `06b4a40661`	12 years ago
Matt T. Proud	f7704af4f8	Code Review: Formatting comments.	12 years ago
Matt T. Proud	06b4a40661	Represent targets in a tabular interface. This commit represents a target group's endpoints in a tabular fashion for better differentiation of their state in a concise manner.	12 years ago
Matt T. Proud	e20e6980e9	Completely extract response payload for decoding. This commit forces the extraction framework to read the entire response payload into a buffer before attempting to decode it, for the underlying Protocol Buffer message readers do not block on partial messages.	12 years ago
Julius Volz	9a48f57b66	Continue scraping old targets on SD fail. When we have trouble resolving the targets for a job via service discovery, we shouldn't just stop scraping the targets we currently have.	12 years ago
juliusv	24715f0ee5	Merge pull request #322 from prometheus/refactor/client/new-model Include Accept header for telemetry request.	12 years ago
Matt T. Proud	b8c7fd8c34	Include Accept header for telemetry request. This pull request introduces a HTTP Accept header to indicate a preference for Protocol Buffer-encoded messages.	12 years ago
Johannes 'fish' Ziemke	4bdf1adb6c	Use github.com/miekg/dns for resolving SRV records	12 years ago
Matt T. Proud	30b1cf80b5	WIP - Snapshot of Moving to Client Model.	12 years ago
Julius Volz	91cf1e9a26	Fix DNS-SD target refresh condition.	12 years ago
Julius Volz	d9b4f98b44	Integrate DNS-SD support for discovering job targets.	12 years ago
Julius Volz	1fe3d3b06b	Remove obsolete argument from target handling code.	12 years ago
Julius Volz	558281890b	Minor "go tool vet" cleanups	12 years ago
Matt T. Proud	d4db3cf00b	Code Review: Last replacement wins.	12 years ago
Matt T. Proud	9cde48754b	Fix race conditions in TargetPool. The race condition detector found a few anomalies whereby a TargetPool could be read during a mutation. This has been fixed.	12 years ago
Julius Volz	dcfd09c801	Prepend "exporter_" to labels that already exist in exported metrics. If the metrics exported by a process already contain any of a target's base labels (such as "job" or "instance", but also any manually assigned target-group label), don't overwrite that label, but instead add a new label consisting of the original label name prepended with "exporter_". This is to accomodate intermediate exporter jobs, which might indicate e.g. the jobs and instances for which they are exporting data.	12 years ago
Julius Volz	081191afb8	Remember and display last scrape errors in web UI.	12 years ago
Matt T. Proud	8f4c7ece92	Destroy naked returns in half of corpus. The use of naked return values is frowned upon. This is the first of two bulk updates to remove them.	12 years ago
Bernerd Schaefer	428d91c86f	Rename test helper files to helpers_test.go This ensures that these files are properly included only in testing.	12 years ago
Matt T. Proud	244a4a9cdb	Update to go1.1. This commit updates the documentation, Makefiles, formatting, and code semantics to support the 1.1. runtime, which includes ... 1. ``make advice``, 2. ``make format``, and 3. ``go fix`` on various targets.	12 years ago
Julius Volz	9cea5d9df8	Convert the Prometheus configuration to protocol buffers.	12 years ago
Julius Volz	d8110fcd9c	Send sample arrays instead of single samples over channels.	12 years ago
Matt T. Proud	6fac20c8af	Harden the tests against OOMs. This commit employs explicit memory freeing for the in-memory storage arenas. Secondarily, we take advantage of smaller channel buffer sizes in the test.	12 years ago

1 2

93 Commits (1aee992800fe96212f75592d8ffa6f526d050c87)