169 Commits (18bbec050c6dfcbf0927778406ad104a03931254)

Author	SHA1	Message	Date
Fabian Reinartz	1d3cdd0d67	Merge branch 'master' into dev-2.0-rebase	8 years ago
Fabian Reinartz	d80a3de235	pkg/textparse: add documentation	8 years ago
Fabian Reinartz	157e698958	web/api: fix min/max timestamps to valid range	8 years ago
Frederic Branczyk	bd92571bdd	web/api: make target and alertmanager api responses consistent	8 years ago
Frederic Branczyk	389c6d0043	web/api: add alertmanager api	8 years ago
beorn7	767c0709b1	Retrieval: Avoid copying Target ... retreival.Target contains a mutex. It was copied in the Targets() call. This potentially can wreak a lot of havoc. It might even have caused the issues reported as #2266 and #2262 .	8 years ago
Fabian Reinartz	bc20d93f0a	storage: rename iterator value getters to At()	8 years ago
Fabian Reinartz	28f547bcc7	api/v1: fix tests, restore series queries	8 years ago
Fabian Reinartz	f8fc1f5bb2	*: migrate ingestion to new batch Appender	8 years ago
Fabian Reinartz	5817cb5bde	*: migrate from model.* to promql.* types	8 years ago
Frederic Branczyk	33b583d50e	web/api: add targets endpoint	8 years ago
Fabian Reinartz	30af47535d	Merge remote-tracking branch 'origin/release-1.2'	8 years ago
Anders Daljord Morken	5c025a2f41	query_range: Validate that start comes before end	8 years ago
Fabian Reinartz	8fa18d564a	storage: enhance Querier interface usage ... This extracts Querier as an instantiateable and closeable object rather than just defining extending methods of the storage interface. This improves composability and allows abstracting query transactions, which can be useful for transaction-level caches, consistent data views, and encapsulating teardown.	8 years ago
Julius Volz	f92532f254	api: Consolidate web API contexts ... This is based on the common/route changes in https://github.com/prometheus/common/pull/61.	8 years ago
Julius Volz	c187308366	storage: Contextify storage interfaces. ... This is based on https://github.com/prometheus/prometheus/pull/1997. This adds contexts to the relevant Storage methods and already passes PromQL's new per-query context into the storage's query methods. The immediate motivation supporting multi-tenancy in Frankenstein, but this could also be used by Prometheus's normal local storage to support cancellations and timeouts at some point.	8 years ago
Julius Volz	ed5a0f0abe	promql: Allow per-query contexts. ... For Weaveworks' Frankenstein, we need to support multitenancy. In Frankenstein, we initially solved this without modifying the promql package at all: we constructed a new promql.Engine for every query and injected a storage implementation into that engine which would be primed to only collect data for a given user. This is problematic to upstream, however. Prometheus assumes that there is only one engine: the query concurrency gate is part of the engine, and the engine contains one central cancellable context to shut down all queries. Also, creating a new engine for every query seems like overkill. Thus, we want to be able to pass per-query contexts into a single engine. This change gets rid of the promql.Engine's built-in base context and allows passing in a per-query context instead. Central cancellation of all queries is still possible by deriving all passed-in contexts from one central one, but this is now the responsibility of the caller. The central query context is now created in main() and passed into the relevant components (web handler / API, rule manager). In a next step, the per-query context would have to be passed to the storage implementation, so that the storage can implement multi-tenancy or other features based on the contextual information.	8 years ago
Anders Daljord Morken	e9885ecb94	Bugfix: Avoid divide-by-zero panic on query_range?step=0	8 years ago
Julius Volz	3bfec97d46	Make the storage interface higher-level. ... See discussion in https://groups.google.com/forum/#!topic/prometheus-developers/bkuGbVlvQ9g The main idea is that the user of a storage shouldn't have to deal with fingerprints anymore, and should not need to do an individual preload call for each metric. The storage interface needs to be made more high-level to not expose these details. This also makes it easier to reuse the same storage interface for remote storages later, as fewer roundtrips are required and the fingerprint concept doesn't work well across the network. NOTE: this deliberately gets rid of a small optimization in the old query Analyzer, where we dedupe instants and ranges for the same series. This should have a minor impact, as most queries do not have multiple selectors loading the same series (and at the same offset).	8 years ago
Fabian Reinartz	97f62c021e	api: drop legacy API	9 years ago
beorn7	da8cb10b43	Partition the status tab into items in a dropdown ... I got feedback from different sources about rules and targets being too heavy in the status tab if their are lots of them. This change also allows for more fine-granular locking.	9 years ago
Julius Volz	0c1e7a5b00	Support time range in /api/v1/series endpoint. ... This adds optional "start" and "end" form values that may be used to restrict the time range of returned series. Fixes https://github.com/prometheus/prometheus/issues/1542	9 years ago
Jonathan Boulle	38098f8c95	Add missing license headers ... Prometheus is Apache 2 licensed, and most source files have the appropriate copyright license header, but some were missing it without apparent reason. Correct that by adding it.	9 years ago
beorn7	4b574e8a61	Switch chunk encoding to type 2 where it was hardcoded type 1 before ... The chunk encoding was hardcoded there because it mostly doesn't matter what encoding is chosen in that test. Since type 1 is battle-hardened enough, I'm switching to type 2 here so that we can catch unexpected problems as a byproduct. My expectation is that the chunk encoding doesn't matter anyway, as said, but then "unexpected problems" contains the word "unexpected".	9 years ago
beorn7	836f1db04c	Improve MetricsForLabelMatchers ... WIP: This needs more tests. It now gets a from and through value, which it may opportunistically use to optimize the retrieval. With possible future range indices, this could be used in a very efficient way. This change merely applies some easy checks, which should nevertheless solve the use case of heavy rule evaluations on servers with a lot of series churn. Idea is the following: - Only archive series that are at least as old as the headChunkTimeout (which was already extremely unlikely to happen). - Then maintain a high watermark for the last archival, i.e. no archived series has a sample more recent than that watermark. - Any query that doesn't reach to a time before that watermark doesn't have to touch the archive index at all. (A production server at Soundcloud with the aforementioned series churn and heavy rule evaluations spends 50% of its CPU time in archive index lookups. Since rule evaluations usually only touch very recent values, most of those lookup should disappear with this change.) - Federation with a very broad label matcher will profit from this, too. As a byproduct, the un-needed MetricForFingerprint method was removed from the Storage interface.	9 years ago
beorn7	a7408bfb47	Unify duration parsing ... It's actually happening in several places (and for flags, we use the standard Go time.Duration...). This at least reduces all our home-grown parsing to one place (in model).	9 years ago
Julius Volz	1ae23bf5e9	Handle OPTIONS HTTP requests correctly. ... Fixes https://github.com/prometheus/prometheus/issues/1346	9 years ago
Tobias Schmidt	7a6a0630d1	Merge pull request #1213 from prometheus/fix-wrong-http-status-codes ... Return HTTP server error codes for execution errors	9 years ago
Tobias Schmidt	bf84faa010	Return HTTP server error codes for execution errors	9 years ago
Tobias Schmidt	50079a85a1	Make time parameter optional in v1 query API ... If no time paramter is provided, the current server timestamp is used.	9 years ago
Fabian Reinartz	33aab4169c	Anchor regexes in vector matching ... This commit makes the regex behavior of vector matching consistent with configuration and label_replace() by anchoring it. Fixes #1200	9 years ago
Julius Volz	0088aa4d45	Merge pull request #1132 from prometheus/fix-quoting-and-escaping ... Support escape sequences in strings and add raw strings	9 years ago
Julius Volz	46c5260761	Support escape sequences in strings and add raw strings. ... This adapts some functionality from the Go standard library for string literal lexing and unquoting/unescaping. The following string types are now supported: Double- or single-quoted strings: These support all escape sequences that Go supports in double-quoted string literals. The difference is that Prometheus also has single-quoted strings (instead of single-quoted runes in Go). Raw newlines are not allowed. Backtick-quoted raw strings: Strings quoted in backticks are treated as raw strings just like in Go and may contain raw newlines and other special characters directly. Fixes https://github.com/prometheus/prometheus/issues/1122 Fixes https://github.com/prometheus/prometheus/issues/1121	9 years ago
Fabian Reinartz	e3b6ec9784	Switch to common/log	9 years ago
Fabian Reinartz	398bbf906b	Switch to common/route package	9 years ago
Fabian Reinartz	171f50706a	Fix unkeyed field errors.	9 years ago
Fabian Reinartz	f8a25f6af7	Apply HTTP handler compression everywhere	9 years ago
Julius Volz	995d3b831d	Fix most golint warnings. ... This is with `golint -min_confidence=0.5`. I left several lint warnings untouched because they were either incorrect or I felt it was better not to change them at the moment.	9 years ago
Fabian Reinartz	d6b8da8d43	Switch promql types to common/model	9 years ago
Fabian Reinartz	1535ef1457	Replace metric.SamplePair with model.SamplePair	9 years ago
Fabian Reinartz	438e232c9b	Fix grouping of import blocks	9 years ago
Fabian Reinartz	306e8468a0	Switch from client_golang/model to common/model	9 years ago
Fabian Reinartz	62b4e89b39	Restore legacy API scalar format	10 years ago
Fabian Reinartz	3d67d75935	promql: implement JSON array format for scalar and string	10 years ago
Fabian Reinartz	77e8983221	promql: add MarshalJSON method for SamplePair	10 years ago
Fabian Reinartz	8f904d6a54	api/v1: fix response format tests	10 years ago
Fabian Reinartz	b36fa7ad61	api/v1: fix Content-Type in response	10 years ago
Julius Volz	bc1c789bab	Disallow cross-origin DELETE and POST requests.	10 years ago
Fabian Reinartz	1eff186555	Merge pull request #810 from prometheus/fabxc/lmatch ... Match empty labels.	10 years ago
Fabian Reinartz	5b91ea9b36	storage: improve label matching and allow unset matching. ... Matching of empty labels now also matches metrics where the label was not explicitly set to the empty string.	10 years ago
Fabian Reinartz	94cd321be1	promql: error if all label matchers are empty.	10 years ago
Fabian Reinartz	85d7c7640a	web: remove flags, refactor handlers	10 years ago
Fabian Reinartz	7bb7e565a4	web/api: add GET and DELETE /series endpoints	10 years ago
Fabian Reinartz	7be94ce962	web/api: improve errors, add tests	10 years ago
Fabian Reinartz	75b0b7420e	web/api: replace /metrics/names with /label/:name/values endpoint.	10 years ago
Fabian Reinartz	5b713911e3	web/api: enable running API legacy and v1 in parallel	10 years ago
Fabian Reinartz	ab9c98acac	web/api: add initial API v1 implementation.	10 years ago
Fabian Reinartz	e88e5f680b	web: simplify prefix handling using util/route package.	10 years ago
Fabian Reinartz	78047326b4	web: cleanup initialization of web service.	10 years ago
Fabian Reinartz	0de6edbdfc	Move pkg/ to util/	10 years ago
Fabian Reinartz	dfaf31a1da	Move web/httputils to pkg/httputil and add DeadlineClient to it	10 years ago
Julius Volz	d7c015c149	Convert pathPrefix to not have trailing slash.	10 years ago
Björn Rabenstein	c44e7cd105	Merge pull request #706 from prometheus/beorn7/persistence2 ... Improve iterator performance.	10 years ago
beorn7	3b9c421a69	Weed out all the [Gg]et* method names. ... The only exception is getNumChunksToPersist to avoid naming the struct member numChunksToPersist in a weird way.	10 years ago
Julius Volz	267fd34156	Switch Prometheus to use github.com/prometheus/log. ... This change is conceptually very simple, although the diff is large. It switches logging from "github.com/golang/glog" to "github.com/prometheus/log", while not actually changing any log messages. V(1)-style logging has been changed to be log.Debug*().	10 years ago
Fabian Reinartz	279831cdf1	Fix and improve parsing error output.	10 years ago
Fabian Reinartz	25cdff3527	Remove `name` arg from `Parse*` functions, enhance parsing errors.	10 years ago
Fabian Reinartz	3ca11bcaf5	Switch Prometheus to promql package. ... This commit removes all functionality from rules/ that is now handled in promql/. All parts of Prometheus are changed to use the promql/ package.	10 years ago
Ceesjan Luiten	0e18784c64	Make all paths absolute to support proxies	10 years ago
Julius Volz	33702da8a8	Use simple Now() func in API instead of utility.Time.	10 years ago
Julius Volz	a5a553f1da	Add initial HTTP API tests. ... This covers the /query (instant query) endpoint for now. Others to follow.	10 years ago
Julius Volz	3f2686d0b3	Remove unused fields from MetricsService.	10 years ago
Julius Volz	c9b76def4c	Report all query API HTTP errors in JSON format.	10 years ago
Julius Volz	df314ead84	Remove unnecessary "else" branch in query API.	10 years ago
Julius Volz	a68b880c27	Add tests for new timestamp/duration functions. ... ...and fix the first bugs in them where they truncate precision below a second.	10 years ago
Julius Volz	cb816ea14a	Improve timestamp/duration parsing in query API. ... Don't handle `0` as a special timestamp value for "now" anymore, except in the `QueryRange()` case, where existing API consumers still expect `0` to mean "now". Also, properly return errors now for malformed timestamp/duration float values.	10 years ago
Julius Volz	8a4acefd66	Allow custom timestamps in instant query API.	10 years ago
Julius Volz	c78436d707	Remove unused API time dependency injection.	10 years ago
beorn7	fa1935a644	Remove /api/targets call and do not show job and instance labels on status. ... /api/targets was undocumented and never used and also broken. Showing instance and job labels on the status page (next to targets) does not make sense as those labels are set in an obvious way. Also add a doc comment to TargetStateToClass.	10 years ago
Fabian Reinartz	fa1e90003b	Query timeout added. ... This is related to #454. Queries now timeout after a duration set by the -query.timeout flag. The TotalEvalTimer is now started/stopped inside any of the ast.Eval* functions.	10 years ago
Bjoern Rabenstein	5859b74f1b	Clean up license issues. ... - Move CONTRIBUTORS.md to the more common AUTHORS. - Added the required NOTICE file. - Changed "Prometheus Team" to "The Prometheus Authors". - Reverted the erroneous changes to the Apache License.	10 years ago
Julius Volz	cc27fb8aab	Rename remaining all-caps constants in AST layer. ... Change-Id: Ibe97e30981969056ffcdb89e63c1468ea1ffa140	10 years ago
Bjoern Rabenstein	39efe6358b	Fix typos and import order. ... This doesn't make the import order consistend everywhere, just where it was touched by the previous commit. Change-Id: I82fc75f8691da9901c7ceb808e6f6fe8e5d62c0e	10 years ago
Bjoern Rabenstein	b1e4956142	Apply a giant code cleanup. ... Essentially: - Remove unused code. - Make it 'go vet' clean. The only remaining warnings are in generated code. - Make it 'golint' clean. The only remaining warnings are in gerenated code. - Smoothed out same minor things. Change-Id: I3fe5c1fbead27b0e7a9c247fee2f5a45bc2d42c6	10 years ago
Julius Volz	c3fcea45e3	Support finer time resolutions than 1 second. ... Change-Id: I4c5f1d6d2361e841999b23283d1961b1bd0c2859	10 years ago
Brian Brazil	f114bbd4e7	Make query_range more robust. ... Gracefully handle decimal values, by truncating them. Limit amount of steps, to avoid accidentally pulling too much data. This limit returns up to ~500kB per timeseries, and allows for 60s granularity for a week and 1h granularity for a year. Change-Id: Ie549fc24deb2eecbc6c5d1b6088a548a6b02e849	10 years ago
Bjoern Rabenstein	71206dbc06	More code cleanups. ... Add license text everywhere. And others.... Change-Id: I11ccde267a2ef7eb366c4788ba7aeae14ba7545c	10 years ago
Bjoern Rabenstein	f5f9f3514a	Major code cleanup. ... - Make it go-vet and golint clean. - Add comments, TODOs, etc. Change-Id: If1392d96f3d5b4cdde597b10c8dff1769fcfabe2	10 years ago
Julius Volz	e7ed39c9a6	Initial experimental snapshot of next-gen storage. ... Change-Id: Ifb8709960dbedd1d9f5efd88cdd359ee9fa9d26d	10 years ago
Julius Volz	21cafe6cd7	Only evict memory series after they are on disk. ... This fixes the problem where samples become temporarily unavailable for queries while they are being flushed to disk. Although the entire flushing code could use some major refactoring, I'm explicitly trying to do the minimal change to fix the problem since there's a whole new storage implementation in the pipeline. Change-Id: I0f5393a30b88654c73567456aeaea62f8b3756d9	10 years ago
Bjoern Rabenstein	8956faeccb	Migrate to new client_golang. ... This change will only be submitted when the new client_golang has been moved to the new version. Change-Id: Ifceb59333072a08286a8ac910709a8ba2e3a1581	10 years ago
Brian Brazil	1828b1f55c	Only log every query when debugging. ... Change-Id: I4f988d81cda6f6deb0ed7f497de4aa75409b158f	10 years ago
Julius Volz	01f652cb4c	Separate storage implementation from interfaces. ... This was initially motivated by wanting to distribute the rule checker tool under `tools/rule_checker`. However, this was not possible without also distributing the LevelDB dynamic libraries because the tool transitively depended on Levigo: rule checker -> query layer -> tiered storage layer -> leveldb This change separates external storage interfaces from the implementation (tiered storage, leveldb storage, memory storage) by putting them into separate packages: - storage/metric: public, implementation-agnostic interfaces - storage/metric/tiered: tiered storage implementation, including memory and LevelDB storage. I initially also considered splitting up the implementation into separate packages for tiered storage, memory storage, and LevelDB storage, but these are currently so intertwined that it would be another major project in itself. The query layers and most other parts of Prometheus now have notion of the storage implementation anymore and just use whatever implementation they get passed in via interfaces. The rule_checker is now a static binary :) Change-Id: I793bbf631a8648ca31790e7e772ecf9c2b92f7a0	11 years ago
Julius Volz	740d448983	Use custom timestamp type for sample timestamps and related code. ... So far we've been using Go's native time.Time for anything related to sample timestamps. Since the range of time.Time is much bigger than what we need, this has created two problems: - there could be time.Time values which were out of the range/precision of the time type that we persist to disk, therefore causing incorrectly ordered keys. One bug caused by this was: https://github.com/prometheus/prometheus/issues/367 It would be good to use a timestamp type that's more closely aligned with what the underlying storage supports. - sizeof(time.Time) is 192, while Prometheus should be ok with a single 64-bit Unix timestamp (possibly even a 32-bit one). Since we store samples in large numbers, this seriously affects memory usage. Furthermore, copying/working with the data will be faster if it's smaller. *MEMORY USAGE RESULTS* Initial memory usage comparisons for a running Prometheus with 1 timeseries and 100,000 samples show roughly a 13% decrease in total (VIRT) memory usage. In my tests, this advantage for some reason decreased a bit the more samples the timeseries had (to 5-7% for millions of samples). This I can't fully explain, but perhaps garbage collection issues were involved. *WHEN TO USE THE NEW TIMESTAMP TYPE* The new clientmodel.Timestamp type should be used whenever time calculations are either directly or indirectly related to sample timestamps. For example: - the timestamp of a sample itself - all kinds of watermarks - anything that may become or is compared to a sample timestamp (like the timestamp passed into Target.Scrape()). When to still use time.Time: - for measuring durations/times not related to sample timestamps, like duration telemetry exporting, timers that indicate how frequently to execute some action, etc. *NOTE ON OPERATOR OPTIMIZATION TESTS* We don't use operator optimization code anymore, but it still lives in the code as dead code. It still has tests, but I couldn't get all of them to pass with the new timestamp format. I commented out the failing cases for now, but we should probably remove the dead code soon. I just didn't want to do that in the same change as this. Change-Id: I821787414b0debe85c9fffaeb57abd453727af0f	11 years ago
Conor Hennessy	eba01d1119	Remove usage of gorest. ... Due to on going issues, we've decided to remove gorest. It started with gorest not being thread-safe (it does introspection to create a new handler which is an easy process to mess up with multiple threads of execution): https://code.google.com/p/gorest/issues/detail?id=15 While the issue has been marked fixed, it looks like the patch has introduced more problems than the original issue and simply doesn't work properly. I'm not sure the behaviour was thought through properly. If a new instance is needed every request then a handler-factory is needed or the library needs to set expectations about how the new objects should interact with their constructor state. While it was tempting to try out another routing library, I think for now it's better to use dumb vanilla Go routing. At least until we decide which URL format we intend to standardize on. Change-Id: Ica3da135d05f8ab8fc206f51eeca4f684f8efa0e	11 years ago
Julius Volz	a50ee8df30	Always set CORS headers at beginning of API handler. ... Change-Id: Icde9a74260c4bb919f09c3e10c6dd5f372ccdaec	11 years ago
Julius Volz	788587426b	Make scrape timeouts configurable per job. ... Change-Id: I77a7514ad9e7969771f873d63d6353ec50082a62	11 years ago
Julius Volz	0003027dce	Add needed trailing spaces in logs.	11 years ago
Julius Volz	aa5d251f8d	Use github.com/golang/glog for all logging.	11 years ago
Julius Volz	35ee2cd3cb	Add alertmanager notification support to Prometheus. ... Alert definitions now also have mandatory SUMMARY and DESCRIPTION fields that get sent along a firing alert to the alert manager.	11 years ago