prometheus

Commit Graph

Author	SHA1	Message	Date
Julius Volz	5e2d1c1464	Deprecate `keeping_extra`, rename it to `keep_common`. `keep_common` is more in line with the function name `drop_common_labels()` terminology-wise, and also more in line with `group_left`/`group_right` (no `...ing` verb suffix). We could also go the full way and call it `keep_common_labels`. That would have the benefit of being even more consistent with the function `drop_common_labels()` and would be more explanatory, but it also seems quite long.	2015-06-12 14:21:05 +02:00
Fabian Reinartz	c716d8a47b	promql: fix aggregation expression String() method. Fixes #794.	2015-06-12 09:48:01 +02:00

Author

SHA1

Message

Date

Julius Volz

5e2d1c1464

Deprecate `keeping_extra`, rename it to `keep_common`.

`keep_common` is more in line with the function name
`drop_common_labels()` terminology-wise, and also more in line with
`group_left`/`group_right` (no `...ing` verb suffix).

We could also go the full way and call it `keep_common_labels`. That
would have the benefit of being even more consistent with the function
`drop_common_labels()` and would be more explanatory, but it also seems
quite long.

2015-06-12 14:21:05 +02:00

Fabian Reinartz

c716d8a47b

promql: fix aggregation expression String() method.

Fixes #794.

2015-06-12 09:48:01 +02:00

2 Commits (17eebbc3b4dc534d87120ba6685f3f44212fb644)