prometheus

Commit Graph

Author	SHA1	Message	Date
Simon Pasquier	3155642108	web/ui/react-app: bump elliptic package version (#7477 ) Signed-off-by: Simon Pasquier <spasquie@redhat.com>	4 years ago
Mark Hansen	f0a439bfc5	Web: Scroll hash-fragment links with navbar height (#7456 ) Previously, hash-fragment links like this: http://mark-t510:9090/targets#job-alertmanager Would scroll to have the header at the top, obscured by the nav bar. Tested in both old and new UIs. Fixes #7434 Signed-off-by: Mark Hansen <markhansen@google.com>	4 years ago
Simon Pasquier	cf6890a3a8	web/ui: bump jQuery to 3.5.1 for the legacy UI (#7447 ) jQuery prior to 3.4.0 is affected by an Object.prototype pollution vulnerability (CVE-2019-11358). Even though our code doesn't seem to be vulnerable to the issue, lets upgrade to the latest jQuery release so we don't have to bother. Signed-off-by: Simon Pasquier <spasquie@redhat.com>	4 years ago
Bartlomiej Plotka	b788986717	storage: Adjusted fully storage layer support for chunk iterators: Remote read client, readyStorage, fanout. (#7059 ) * Fixed nits introduced by https://github.com/prometheus/prometheus/pull/7334 * Added ChunkQueryable implementation to fanout and readyStorage. * Added more comments. * Changed NewVerticalChunkSeriesMerger to CompactingChunkSeriesMerger, removed tiny interface by reusing VerticalSeriesMergeFunc for overlapping algorithm for both chunks and series, for both querying and compacting (!) + made sure duplicates are merged. * Added ErrChunkSeriesSet * Added Samples interface for seamless []promb.Sample to []tsdbutil.Sample conversion. * Deprecating non chunks serieset based StreamChunkedReadResponses, added chunk one. * Improved tests. * Split remote client into Write (old storage) and read. * Queryable client is now SampleAndChunkQueryable. Since we cannot use nice QueryableFunc I moved all config based options to sampleAndChunkQueryableClient to aboid boilerplate. In next commit: Changes for TSDB. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>	4 years ago
Nuno Cardoso	f97d2ddb6e	REACT UI: CollapsibleAlertPanel - value field more friendly human readable (scientific notation -> number) (#7426 ) * value field more human readable Signed-off-by: kisc <nuno_kisc@hotmail.com> * fix typo Signed-off-by: Nuno Cardoso <nuno_kisc@hotmail.com> * add function convertSCToNumber Signed-off-by: nunokisc <nuno_kisc@hotmail.com> * add convertSCToNumber test Signed-off-by: nunokisc <nuno_kisc@hotmail.com> * normalize function name Signed-off-by: kisc <nuno_kisc@hotmail.com> * convertScientificNotationToNumber to parsePrometheusFloat Signed-off-by: kisc <nuno_kisc@hotmail.com>	4 years ago
Marco Pracucci	153f859b74	Fixed returned API status code on error (#7435 ) * Fixed returned API status code on error Signed-off-by: Marco Pracucci <marco@pracucci.com> * Fixed linter Signed-off-by: Marco Pracucci <marco@pracucci.com> * Simplified code Signed-off-by: Marco Pracucci <marco@pracucci.com>	4 years ago
Lisa Carpenter	dff31c2826	preserve state on page reload for alert status filters and annotations with useLocalStorage(), add toggleAnnotations method, and add passing tests (#7374 ) Signed-off-by: Lisa Carpenter <carpenter.lisa@gmail.com>	5 years ago
Kemal Akkoyun	66dfb951c4	: Consistent Error/Warning handling for SeriesSet iterator: Allowing Async Select (#7251 ) Add errors and Warnings to SeriesSet Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Change Querier interface and refactor accordingly Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Refactor promql/engine to propagate warnings at eval stage Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Address review issues Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Make sure all the series from all Selects are pre-advanced Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Address review issues Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Separate merge series sets Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Clean Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Refactor merge querier failure handling Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Refactored and simplified fanout with improvements from incoming chunk iterator PRs. * Secondary logic is hidden, instead of weird failed series set logic we had. * Fanout is well commented * Fanout closing record all errors * MergeQuerier improved API (clearer) * deferredGenericMergeSeriesSet is not needed as we return no samples anyway for failed series sets (next = false). Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Fix formatting Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Fix CI issues Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Added final tests for error handling. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Addressed Brian's comments. * Moved hints in populate to be allocated only when needed. * Used sync.Once in secondary Querier to achieve all-or-nothing partial response logic. * Select after first Next is done will panic. NOTE: in lazySeriesSet in theory we could just panic, I think however we can totally just return error, it will panic in expand anyway. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Utilize errWithWarnings Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Fix recently introduced expansion issue Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Add tests for secondary querier error handling Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Implement lazy merge Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Add name to test cases Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Reorganize Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Address review comments Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Address review comments Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Remove redundant warnings Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> * Fix rebase mistake Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com> Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>	5 years ago
Ben Kochie	e963d953ea	Update yarn.lock (#7356 ) Fixes websocket-extensions security warning. Signed-off-by: Ben Kochie <superq@gmail.com>	5 years ago
Jess G	fdc49fae5b	Added time range parameters to labelNames API (#7288 ) * add time range params to labelNames api Signed-off-by: jessicagreben <Jessica.greben1+github@gmail.com> * evaluate min/max time range when reading labels from the head Signed-off-by: jessicagreben <Jessica.greben1+github@gmail.com> * add time range params to labelValues api Signed-off-by: jessicagreben <Jessica.greben1+github@gmail.com> * fix test, add docs Signed-off-by: jessicagreben <Jessica.greben1+github@gmail.com> * add a test for head min max range Signed-off-by: jessicagreben <Jessica.greben1+github@gmail.com> * fix test to match comment Signed-off-by: jessicagreben <Jessica.greben1+github@gmail.com> * address CR comments Signed-off-by: jessicagreben <Jessica.greben1+github@gmail.com> * combine vars only used once Signed-off-by: jessicagreben <Jessica.greben1+github@gmail.com> * add time range params to labelNames api Signed-off-by: jessicagreben <Jessica.greben1+github@gmail.com> * evaluate min/max time range when reading labels from the head Signed-off-by: jessicagreben <Jessica.greben1+github@gmail.com> * add time range params to labelValues api Signed-off-by: jessicagreben <Jessica.greben1+github@gmail.com> * fix test, add docs Signed-off-by: jessicagreben <Jessica.greben1+github@gmail.com> * add a test for head min max range Signed-off-by: jessicagreben <Jessica.greben1+github@gmail.com> * fix test to match comment Signed-off-by: jessicagreben <Jessica.greben1+github@gmail.com> * address CR comments Signed-off-by: jessicagreben <Jessica.greben1+github@gmail.com> * combine vars only used once Signed-off-by: jessicagreben <Jessica.greben1+github@gmail.com> * fix test Signed-off-by: jessicagreben <Jessica.greben1+github@gmail.com> * restart ci Signed-off-by: jessicagreben <Jessica.greben1+github@gmail.com> * use range expectedLabelNames instead of range actualLabelNames in test Signed-off-by: jessicagreben <Jessica.greben1+github@gmail.com>	5 years ago
Ben Kochie	c7d9516695	Bump jquery to fix secuirty warning (#7311 ) * Use major version dependency to make updates easier. * Pin to >= 3.5. Signed-off-by: Ben Kochie <superq@gmail.com>	5 years ago
Ganesh Vernekar	1c99adb9fd	Callbacks for lifecycle of series in TSDB (#7159 ) * Callbacks for lifecycle of series in TSDB Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in> * Add more comments Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	5 years ago
gotjosh	bfcd9282a8	API: Allow AlertmanagerRetriever and RulesRetriever to receive a Context (#7256 ) * API: Allow AlertmanagerRetriever and RulesRetriever to receive a Context Signed-off-by: gotjosh <josue@grafana.com> * Use single line functions where possible Signed-off-by: gotjosh <josue@grafana.com>	5 years ago
Julius Volz	6e19c4697d	React UI: Don't null out data when clicking on current tab (#7243 ) Fixes https://github.com/prometheus/prometheus/issues/7241 Signed-off-by: Julius Volz <julius.volz@gmail.com>	5 years ago
Ganesh Vernekar	d4b9fe801f	M-map full chunks of Head from disk (#6679 ) When appending to the head and a chunk is full it is flushed to the disk and m-mapped (memory mapped) to free up memory Prom startup now happens in these stages - Iterate the m-maped chunks from disk and keep a map of series reference to its slice of mmapped chunks. - Iterate the WAL as usual. Whenever we create a new series, look for it's mmapped chunks in the map created before and add it to that series. If a head chunk is corrupted the currpted one and all chunks after that are deleted and the data after the corruption is recovered from the existing WAL which means that a corruption in m-mapped files results in NO data loss. [Mmaped chunks format](https://github.com/prometheus/prometheus/blob/master/tsdb/docs/format/head_chunks.md) - main difference is that the chunk for mmaping now also includes series reference because there is no index for mapping series to chunks. [The block chunks](https://github.com/prometheus/prometheus/blob/master/tsdb/docs/format/chunks.md) are accessed from the index which includes the offsets for the chunks in the chunks file - example - chunks of series ID have offsets 200, 500 etc in the chunk files. In case of mmaped chunks, the offsets are stored in memory and accessed from that. During WAL replay, these offsets are restored by iterating all m-mapped chunks as stated above by matching the series id present in the chunk header and offset of that chunk in that file. Prombench results _WAL Replay_ 1h Wal reply time 30% less wal reply time - 4m31 vs 3m36 2h Wal reply time 20% less wal reply time - 8m16 vs 7m _Memory During WAL Replay_ High Churn: 10-15% less RAM - 32gb vs 28gb 20% less RAM after compaction 34gb vs 27gb No Churn: 20-30% less RAM - 23gb vs 18gb 40% less RAM after compaction 32.5gb vs 20gb Screenshots are in [this comment](https://github.com/prometheus/prometheus/pull/6679#issuecomment-621678932) Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>	5 years ago
Ben Ye	1e4e37144d	Fixed wrongly handled not ready TSDB on web and API. (#7182 ) * fix federate endpoint panic Signed-off-by: yeya24 <yb532204897@gmail.com> * Fixed all cases of not ready TSDB being wrongly handled. * Fixed issue for federation. * Ensured this will never happen again thanks to interfaces * Fixes same issue for stats. * Added tests for readiness. * Fixed bug in stats. It was: status.MaxTime = db.Head().MaxTime() status.MinTime = db.Head().MaxTime() Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Addressed Brian's comments. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Addressed Brian's comments. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>	5 years ago
Julien Pivotto	fc3fb3265a	Merge pull request #7145 from prometheus/release-2.17 Backport release 2.17 into master	5 years ago
Julien Pivotto	9072cf7203	Merge pull request #7137 from roidelapluie/cherrypicks Cherry-pick three bugfixes from master to release-2.17	5 years ago
beorn7	69ac27e1b4	Make `series` method return a finalizer, too Signed-off-by: beorn7 <beorn@grafana.com>	5 years ago
Julian Taylor	e2c06a8898	register federation failure metrics (#7081 ) Closes gh-7080 Signed-off-by: Julian Taylor <juliantaylor108@gmail.com>	5 years ago
Julien Pivotto	a2fcdeb1ef	Defer finalizer (#7129 ) Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
beorn7	f9f423ec0a	Ensure queries are closed in API calls Signed-off-by: beorn7 <beorn@grafana.com>	5 years ago
Julien Pivotto	209d4bb8a1	Defer finalizer (#7129 ) Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	5 years ago
gotjosh	24af5049bb	API: Allow `TargetRetriever` to receive a Context (#7125 ) Fixes #7103 Signed-off-by: gotjosh <josue@grafana.com>	5 years ago
Marek Slabicki	8224ddec23	Capitalizing first letter of all log lines (#7043 ) Signed-off-by: Marek Slabicki <thaniri@gmail.com>	5 years ago
Ben Ye	ecda6013ed	Use only local tsdb for federation (#7096 ) Signed-off-by: yeya24 <yb532204897@gmail.com>	5 years ago
Julian Taylor	05442b31c8	register federation failure metrics (#7081 ) Closes gh-7080 Signed-off-by: Julian Taylor <juliantaylor108@gmail.com>	5 years ago
Chris Marchbanks	62bd77bf93	Fix react tests (#7077 ) https://github.com/facebook/create-react-app/issues/8689 is causing our tests to fail in the CI pipeline. As the comments suggest, downgrading to react-scripts 3.4.0 fixes the problem. In addition, fix a test warning due to a missing id field. Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>	5 years ago
Brian Brazil	7646cbca32	Use .UTC everywhere we use time.Unix (#7066 ) time.Unix attaches the local timezone, which can then leak out (e.g. in the alert json). While this is harmless, we should be consistent. Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>	5 years ago
Bartlomiej Plotka	d5c33877f9	storage: Added Chunks{Queryable/Querier/SeriesSet/Series/Iteratable. Added generic Merge{SeriesSet/Querier} implementation. (#7005 ) * storage: Added Chunks{Queryable/Querier/SeriesSet/Series/Iteratable. Added generic Merge{SeriesSet/Querier} implementation. ## Rationales: In many places (e.g. chunk Remote read, Thanos Receive fetching chunk from TSDB), we operate on encoded chunks not samples. This means that we unnecessary decode/encode, wasting CPU, time and memory. This PR adds chunk iterator interfaces and makes the merge code to be reused between both seriesSets I will make the use of it in following PR inside tsdb itself. For now fanout implements it and mergers. All merges now also allows passing series mergers. This opens doors for custom deduplications other than TSDB vertical ones (e.g. offline one we have in Thanos). ## Changes * Added Chunk versions of all iterating methods. It all starts in Querier/ChunkQuerier. The plan is that Storage will implement both chunked and samples. * Added Seek to chunks.Iterator interface for iterating over chunks. * NewMergeChunkQuerier was added; Both this and NewMergeQuerier are now using generigMergeQuerier to share the code. Generic code was added. * Improved tests. * Added some TODO for further simplifications in next PRs. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Addressed Brian's comments. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Moved s/Labeled/SeriesLabels as per Krasi suggestion. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Addressed Krasi's comments. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Second iteration of Krasi comments. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Another round of comments. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>	5 years ago
Ben Kochie	269e7c8091	Fix golint issues. Signed-off-by: Ben Kochie <superq@gmail.com>	5 years ago
Ben Kochie	24ecae9956	Update yarn deps (#7027 ) Fix security warnings. Signed-off-by: Ben Kochie <superq@gmail.com>	5 years ago
Bartlomiej Plotka	c4eefd1b3a	storage: Removed SelectSorted method; Simplified interface; Added requirement for remote read to sort response. This is technically BREAKING CHANGE, but it was like this from the beginning: I just notice that we rely in Prometheus on remote read being sorted. This is because we use selected data from remote reads in MergeSeriesSet which rely on sorting. I found during work on https://github.com/prometheus/prometheus/pull/5882 that we do so many repetitions because of this, for not good reason. I think I found a good balance between convenience and readability with just one method. Smaller the interface = better. Also I don't know what TestSelectSorted was testing, but now it's testing sorting. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>	5 years ago
Jaga Santagostino	350f25eed3	changes from PR requests (#6880 ) Signed-off-by: Jaga Santagostino <jagasantagostino@gmail.com>	5 years ago
Bartlomiej Plotka	fe802f29c9	storage: Removed SelectSorted method; Simplified interface; Added requirement for remote read to sort response. This is technically BREAKING CHANGE, but it was like this from the beginning: I just notice that we rely in Prometheus on remote read being sorted. This is because we use selected data from remote reads in MergeSeriesSet which rely on sorting. I found during work on https://github.com/prometheus/prometheus/pull/5882 that we do so many repetitions because of this, for not good reason. I think I found a good balance between convenience and readability with just one method. Smaller the interface = better. Also I don't know what TestSelectSorted was testing, but now it's testing sorting. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>	5 years ago
Boyko	84b00564f4	API_V1: Extract time param parsing logic (#6860 ) * extract API time param parsing logic in a func Signed-off-by: blalov <boiskila@gmail.com>	5 years ago
李国忠	3fff701b77	[comments] change word ‘dependencie’ to ‘dependencies’ (#6904 ) Signed-off-by: fuling <fuling.lgz@alibaba-inc.com>	5 years ago
Simon Kirsten	45fbed94d6	React UI: Fixed data table for matrix always showing 1 as value (#6896 ) Signed-off-by: Simon Kirsten <1972314+skirsten@users.noreply.github.com> React UI: Fixed data table for matrix always showing 1 as value	5 years ago
Chris Marchbanks	0e78908407	Escape target selector for tooltip on targets page (#6892 ) This fixes an issue where the /new/targets page will not load when there are jobs with invalid CSS characters in them, such as the namespace/service/0 form used by the Prometheus Operator. Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>	5 years ago
LongKB	82f7ed208b	Remove some duplicated words (#6882 ) Signed-off-by: Pham Duc Hanh <hanhpd@fujitsu.com>	5 years ago
李国忠	ddd4dcec19	[fix] ui: th to td (#6874 ) Signed-off-by: fuling <fuling.lgz@alibaba-inc.com>	5 years ago
Ben Kochie	65a19421a4	Update React vendoring (#6855 ) * Update React vendoring Update webpack-scripts to 3.4.0 * Fix security warning for `serialize-javascript`. Signed-off-by: Ben Kochie <superq@gmail.com> * Fix eslint errors. Signed-off-by: Ben Kochie <superq@gmail.com> * Update test snapshot. Signed-off-by: Ben Kochie <superq@gmail.com>	5 years ago
Bartlomiej Plotka	c4e74e241f	Merge pull request #6744 from slrtbtfs/split_parser Split promql package into parser and engine	5 years ago
Bartlomiej Plotka	c869e046a5	Merge pull request #6840 from pstibrany/context_from_request_should_not_return_error Don't return error in ContextFromRequest function.	5 years ago
李国忠	d276b5fb65	[format]Js: format checktimedrift() success (#6850 ) Signed-off-by: fuling <fuling.lgz@alibaba-inc.com>	5 years ago
Tobias Guggenmos	4835bbf376	Merge branch 'master' into split_parser	5 years ago
Peter Štibraný	318cd413fc	Don't return error in ContextFromRequest function. Previously it could return error if RemoteAddr didn't have correct format, but since this field has no specified format, that was little too strict. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>	5 years ago
Bartlomiej Plotka	48ead578a0	Moved tsdbconfig to main. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>	5 years ago
Bartlomiej Plotka	a20bebf7eb	Moved readyStorage to main. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>	5 years ago
Bartlomiej Plotka	8a775bc468	Moved unit agnostic options to separate pkg. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>	5 years ago

1 2 3 4 5 ...

975 Commits (0f76024eebfef07ea97057478b59089e18a4a298)