prometheus

Commit Graph

Author	SHA1	Message	Date
Linas Medziunas	1cd6c1cde5	ValidateHistogram: strict Count check in absence of NaNs Signed-off-by: Linas Medziunas <linas.medziunas@gmail.com>	1 year ago
Dimitar Dimitrov	9e3df532d8	Export `promql.Engine.FindMinMaxTime` This function is useful to analyze promQL queries. We want to use this in Mimir to record the time range which the query touches. I also chose to remove the `Engine` receiver because it was unnecessary, and it makes it easier to use, but happy to refactor that if you disagree. The function is untested on its own. If you prefer to have unit tests now that its exported, I can look into adding some. Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>	1 year ago
Björn Rabenstein	a43669e611	Merge pull request #12928 from alexandear/ci-enable-godot ci(lint): enable godot; append dot at the end of comments	1 year ago
Julien Pivotto	f568221610	Merge pull request #13057 from prometheus/release-2.48 Merge release-2.48 back into main	1 year ago
Oleksandr Redko	fa90ca46e5	ci(lint): enable godot; append dot at the end of comments Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>	1 year ago
Oleksandr Redko	8e5f0387a2	ci(lint): enable nolintlint and remove redundant comments (#12926 ) Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>	1 year ago
Bryan Boreham	49c5e7afe1	PromQL: reduce garbage in range-query evaluation The temporary variable was allocated on the heap, and it is unnecessary. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	1 year ago
zenador	80e977aae6	Remove `NewPossibleNonCounterInfo` and minimise creating empty annotations (#13012 ) * Remove NewPossibleNonCounterInfo until it can be made more efficient, and avoid creating empty annotations as much as possible Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	1 year ago
Marc Tuduri	af7c31ee10	PR feedback Signed-off-by: Marc Tuduri <marctc@protonmail.com>	1 year ago
Marc Tuduri	8fededf6ad	promql(histograms): Change sample total calculation for histograms Signed-off-by: Marc Tuduri <marctc@protonmail.com>	1 year ago
Jeanette Tan	9a8bd8eac6	Fix possible non-counter warning for empty names and native histograms Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	1 year ago
Julius Volz	191c24a0ed	Fix: Exempt "_bucket" suffix from PossibleNonCounterInfo warning (#12982 ) Related to PR #12152 Signed-off-by: Julius Volz <julius.volz@gmail.com> Signed-off-by: Levi Harrison <git@leviharrison.dev>	1 year ago
Jeanette Tan	0cbf0c1c68	Revise according to code review Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	1 year ago
Jeanette Tan	feaa93da77	Add warning when monotonicity is forced in the input to histogram_quantile Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	1 year ago
Alan Protasio	a15e884e7a	Prevent Prometheus from overallocating memory on subquery with large amount of steps. (#12734 ) * change initial points slice size Signed-off-by: Alan Protasio <alanprot@gmail.com> * refactor on the steps calculation and moving the getXPoint/putXPoint method to the evaluator Signed-off-by: Alan Protasio <alanprot@gmail.com> * prevent potential panic Signed-off-by: Alan Protasio <alanprot@gmail.com> * Update promql/engine.go Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Alan Protasio <alanprot@gmail.com> * Update promql/engine.go Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Alan Protasio <alanprot@gmail.com> * Update promql/engine.go Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Alan Protasio <alanprot@gmail.com> * Update promql/engine.go Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com> Signed-off-by: Alan Protasio <alanprot@gmail.com> * Allocating slice with maximum size of 5k Signed-off-by: Alan Protasio <alanprot@gmail.com> * adding comments Signed-off-by: Alan Protasio <alanprot@gmail.com> --------- Signed-off-by: Alan Protasio <alanprot@gmail.com> Co-authored-by: Bartlomiej Plotka <bwplotka@gmail.com>	1 year ago
Goutham Veeramachaneni	86729d4d7b	Update exp package (#12650 )	1 year ago
Bryan Boreham	91054875d6	Merge pull request #12732 from bboreham/simplify-rangeeval promql: simplify inner loop of rangeEval	1 year ago
zenador	69edd8709b	Add warnings (and annotations) to PromQL query results (#12152 ) Return annotations (warnings and infos) from PromQL queries This generalizes the warnings we have already used before (but only for problems with remote read) as "annotations". Annotations can be warnings or infos (the latter could be false positives). We do not treat them different in the API for now and return them all as "warnings". It would be easy to distinguish them and return infos separately, should that appear useful in the future. The new annotations are then used to create a lot of warnings or infos during PromQL evaluations. Partially these are things we have wanted for a long time (e.g. inform the user that they have applied `rate` to a metric that doesn't look like a counter), but the new native histograms have created even more needs for those annotations (e.g. if a query tries to aggregate float numbers with histograms). The annotations added here are not yet complete. A prominent example would be a warning about a range too short for a rate calculation. But such a warnings is more tricky to create with good fidelity and we will tackle it later. Another TODO is to take annotations into account when evaluating recording rules. --------- Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	1 year ago
Arve Knudsen	156222cc50	Add context argument to LabelQuerier.LabelValues (#12665 ) Add context argument to LabelQuerier.LabelValues and LabelQuerier.SortedLabelValues. Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	1 year ago
Arve Knudsen	a964349e97	Add context argument to LabelQuerier.LabelNames (#12666 ) Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	1 year ago
Arve Knudsen	4451ba10b4	Add context argument to IndexReader.Postings (#12667 ) Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	1 year ago
Arve Knudsen	6daee89e5f	Add context argument to Querier.Select (#12660 ) Signed-off-by: Arve Knudsen <arve.knudsen@gmail.com>	1 year ago
Julien Pivotto	284ba3426b	Merge pull request #12758 from bboreham/trim-rangequery-benchmarks PromQL: reduce numbers of benchmarks	1 year ago
Bryan Boreham	e4dd3469ac	lint Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	1 year ago
Bryan Boreham	5ce990cabc	promql: simplify rangeEval a bit more We can't have both a float and a histogram at the same timestep. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	1 year ago
Bryan Boreham	c5671c6d97	Merge pull request #12755 from bboreham/rangequery-benchmark-mmap promql: force mmap of head chunks in BenchmarkRangeQuery	1 year ago
Bryan Boreham	1ea57a3f8c	PromQL: reduce numbers of benchmarks Make it more likely that contributors will run the benchmark suite. count_values needs more than 2GB at 1,000 steps, so just run it for 100. And remove 10-step variant because it doesn't add much to 100 and 1000-step benchmarks. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	1 year ago
Bryan Boreham	0d283effa8	promql: force mmap of head chunks in BenchmarkRangeQuery Otherwise we have a highly unusual situation of over 100 chunks in the headChunks list of each series, which heavily skews performance. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	1 year ago
Gregor Zeitlinger	f01718262a	Unit tests for native histograms (#12668 ) promql: Extend testing framework to support native histograms This includes both the internal testing framework as well as the rules unit test feature of promtool. This also adds a bunch of basic tests. Many of the code level tests can now be converted to tests within the framework, and more tests can be added easily. --------- Signed-off-by: Harold Dost <h.dost@criteo.com> Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com> Signed-off-by: Stephen Lang <stephen.lang@grafana.com> Co-authored-by: Harold Dost <h.dost@criteo.com> Co-authored-by: Stephen Lang <stephen.lang@grafana.com> Co-authored-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>	1 year ago
zenador	54aaa2bd7e	Add `histogram_stdvar` and `histogram_stddev` functions (#12614 ) * Add new function: histogram_stdvar and histogram_stddev Signed-off-by: Jeanette Tan <jeanette.tan@grafana.com>	1 year ago
beorn7	aa82fe198f	tsdb: Fix histogram validation So far, `ValidateHistogram` would not detect if the count did not include the count in the zero bucket. This commit fixes the problem and updates all the tests that have been undetected offenders so far. Note that this problem would only ever create false negatives, so we never falsely rejected to store a histogram because of it. On the other hand, `ValidateFloatHistogram` has been to strict with the count being at least as large as the sum of the counts in all the buckets. Float precision issues could create false positives here, see products of PromQL evaluations, it's actually quite hard to put an upper limit no the floating point imprecision. Users could produce the weirdest expressions, maxing out float precision problems. Therefore, this commit simply removes that particular check from `ValidateFloatHistogram`. Signed-off-by: beorn7 <beorn@grafana.com>	1 year ago
Bryan Boreham	3879488476	promql: simplify inner loop of rangeEval Took out the loops with break after one iteration, and extract some common code to a function. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	1 year ago
Michael Hoffmann	4d8e380269	promql: allow tests to be imported (#12050 ) Signed-off-by: Michael Hoffmann <mhoffm@posteo.de>	1 year ago
Bryan Boreham	5cea37c069	Merge pull request #12682 from bboreham/contains-same-label-set promql engine: check unique labels using existing map ContainsSameLabelset constructs a map with the same hash key as the one used to compile the output of rangeEval, so we can use that one and save work. Need to hold the timestamp so we can be sure we saw the same series in the same evaluation.	1 year ago
Bryan Boreham	0670e4771a	promql engine: check unique labels using existing map `ContainsSameLabelset` constructs a map with the same hash key as the one used to compile the output of `rangeEval`, so we can use that one and save work. Need to hold the timestamp so we can be sure we saw the same series in the same evaluation. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>	1 year ago
Bryan Boreham	8d47b3d497	Merge pull request #12579 from charleskorn/timestamp Don't recreate iterator for each series on each timestep when evaluating a query with `timestamp()`	1 year ago
Charles Korn	d396282941	Address PR feedback: clarify comment Signed-off-by: Charles Korn <charles.korn@grafana.com>	1 year ago
Charles Korn	145d7457fe	Address PR feedback: use loop to create expected test result Signed-off-by: Charles Korn <charles.korn@grafana.com>	1 year ago
Charles Korn	6087c555ed	Address PR feedback: clarify comment Signed-off-by: Charles Korn <charles.korn@grafana.com>	1 year ago
Charles Korn	fb3935e8f9	Address PR feedback: rename method Signed-off-by: Charles Korn <charles.korn@grafana.com>	1 year ago
Julius Volz	531567d46e	Drop metric name for "atan2" binary operator The operator changes the meaning of the metric, so the metric name should be dropped. Technically this would be a breaking change, but it's also very obviously a bug and not likely that anyone depends on it. Signed-off-by: Julius Volz <julius.volz@gmail.com>	1 year ago
Charles Korn	6903d6edd8	Add test to confirm `timestamp()` behaves correctly when evaluating a range query. Signed-off-by: Charles Korn <charles.korn@grafana.com>	1 year ago
Charles Korn	fde6ebb17d	Create per-series iterators only once per selector, rather than recreating it for each time step. Signed-off-by: Charles Korn <charles.korn@grafana.com>	1 year ago
Charles Korn	993618adea	Don't create a new iterator for every time step. Signed-off-by: Charles Korn <charles.korn@grafana.com>	1 year ago
Charles Korn	b114c0888d	Simplify loop Signed-off-by: Charles Korn <charles.korn@grafana.com>	1 year ago
Charles Korn	a142998052	Expand series set just once Signed-off-by: Charles Korn <charles.korn@grafana.com>	1 year ago
Charles Korn	eeface2e17	Inline method Signed-off-by: Charles Korn <charles.korn@grafana.com>	1 year ago
Charles Korn	a2a2cc757e	Extract timestamp special case to its own method. Signed-off-by: Charles Korn <charles.korn@grafana.com>	1 year ago
Charles Korn	15fa680117	Add benchmark for query using timestamp() Signed-off-by: Charles Korn <charles.korn@grafana.com>	1 year ago
Julien Pivotto	0a48f93111	Merge pull request #10367 from ianwoolf/pr_add_close_for_query_logger add Close for ActiveQueryTracker to close the file.	1 year ago

1 2 3 4 5 ...

829 Commits (08c17df24434d289f13319928ef22f79f926d9b2)