prometheus

Commit Graph

Author	SHA1	Message	Date
Simon Pasquier	7704cde4ea	discovery(k8s): add metadata labels to endpointslices This commit adds 2 new metadata labels for the endpointslice role: * `__meta_kubernetes_endpointslice_endpoint_node_name` * `__meta_kubernetes_endpointslice_endpoint_zone` The latter is only present when the `discovery.k8s.io/v1` API group is available. I also updated the configuration doc and added an entry for the `__meta_kubernetes_endpointslice_endpoint_hostname` label which was missing. Signed-off-by: Simon Pasquier <spasquie@redhat.com>	7 months ago
hanghuge	c14a158d03	Signed-off-by: hanghuge <cmoman@outlook.com> Fix unavailable link Signed-off-by: hanghuge <cmoman@outlook.com>	8 months ago
machine424	0e81ab44a2	discovery(k8s): add a metric to track failed requests, failures will still be logged. Signed-off-by: machine424 <ayoubmrini424@gmail.com>	9 months ago
machine424	92544c00bf	discovery: kubernetes: Avoid creating unnecessary Kubernetes indexers in RoleEndpointSlice This was due to a missing "return", see https://github.com/prometheus/prometheus/pull/13554#discussion_r1490965817 Signed-off-by: machine424 <ayoubmrini424@gmail.com>	10 months ago
Bryan Boreham	6005ac6f9d	Merge pull request #9311 from Creatone/creatone/use-testify-3 tests: Move from t.Errorf and others. (Part 3)	10 months ago
Ayoub Mrini	581d8d86b4	Pod status changes not discovered by Kube Endpoints SD (#13337 ) * fix(discovery/kubernetes/endpoints): react to changes on Pods because some modifications can occur on them without triggering an update on the related Endpoints (The Pod phase changing from Pending to Running e.g.). --------- Signed-off-by: machine424 <ayoubmrini424@gmail.com> Co-authored-by: Guillermo Sanchez Gavier <gsanchez@newrelic.com>	10 months ago
Paweł Szulik	7f24efccdb	Refactor discovery tests to use testify. Signed-off-by: Paweł Szulik <paul.szulik@gmail.com>	10 months ago
Paulin Todev	78411d5e8b	SD Managers taking over responsibility for registration of debug metrics (#13375 ) SD Managers take over responsibility for SD metrics registration --------- Signed-off-by: Paulin Todev <paulin.todev@gmail.com> Signed-off-by: Björn Rabenstein <github@rabenste.in> Co-authored-by: Björn Rabenstein <github@rabenste.in>	10 months ago
machine424	2d01e56695	chore(kubernetes): check preconditions earlier and avoid unnecessary checks or iterations Signed-off-by: machine424 <ayoubmrini424@gmail.com>	11 months ago
Paulin Todev	d2e997030e	Fix linter issues Signed-off-by: Paulin Todev <paulin.todev@gmail.com>	12 months ago
Paulin Todev	27bb57a37b	Define metric label values in one place Signed-off-by: Paulin Todev <paulin.todev@gmail.com>	12 months ago
Paulin Todev	108a749a45	Set up labels for counters in advance Signed-off-by: Paulin Todev <paulin.todev@gmail.com>	12 months ago
Paulin Todev	6de80d7fb0	Allow non-default registry to be used for metrics of SD components Signed-off-by: Paulin Todev <paulin.todev@gmail.com>	12 months ago
Matthieu MOREL	9c4782f1cc	golangci-lint: enable testifylint linter (#13254 ) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	12 months ago
Oleksandr Redko	fa90ca46e5	ci(lint): enable godot; append dot at the end of comments Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>	1 year ago
Matthieu MOREL	68e6b4dd34	ci(lint): enable errorlint on discovery (#12918 ) Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	1 year ago
Oleksandr Redko	8e5f0387a2	ci(lint): enable nolintlint and remove redundant comments (#12926 ) Signed-off-by: Oleksandr Redko <Oleksandr_Redko@epam.com>	1 year ago
Julien Pivotto	2bdb2e627f	Merge pull request #10914 from wangrzneu/add-endpointslice-label Add more labels for endpointslice and endpoints role in k8s discovery	1 year ago
Julien Pivotto	076056ccdf	Merge pull request #11642 from zoonage/main Do not add pods to target group if the PodIP status is not set	1 year ago
renzheng.wang	b2c5de2e65	fix lint issue Signed-off-by: renzheng.wang <wangrzneu@gmail.com>	2 years ago
renzheng.wang	98ffad01b8	update tests and docs Signed-off-by: renzheng.wang <wangrzneu@gmail.com>	2 years ago
renzheng.wang	866fa25b20	add label and labelpresent for endpointslice role in k8s discovery Signed-off-by: renzheng.wang <wangrzneu@gmail.com>	2 years ago
Mickael Carl	2f35619710	discovery/kubernetes: attach node labels when the endpoints TargetRef's kind are Node Signed-off-by: Mickael Carl <mcarl@apple.com>	2 years ago
cui fliter	276ca6a883	fix some comments Signed-off-by: cui fliter <imcusg@gmail.com>	2 years ago
Matthieu MOREL	bae9a21200	Merge branch 'main' into linter/nilerr Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	2 years ago
beorn7	5b53aa1108	style: Replace `else if` cascades with `switch` Wiser coders than myself have come to the conclusion that a `switch` statement is almost always superior to a statement that includes any `else if`. The exceptions that I have found in our codebase are just these two: * The `if else` is followed by an additional statement before the next condition (separated by a `;`). * The whole thing is within a `for` loop and `break` statements are used. In this case, using `switch` would require tagging the `for` loop, which probably tips the balance. Why are `switch` statements more readable? For one, fewer curly braces. But more importantly, the conditions all have the same alignment, so the whole thing follows the natural flow of going down a list of conditions. With `else if`, in contrast, all conditions but the first are "hidden" behind `} else if `, harder to spot and (for no good reason) presented differently from the first condition. I'm sure the aforemention wise coders can list even more reasons. In any case, I like it so much that I have found myself recommending it in code reviews. I would like to make it a habit in our code base, without making it a hard requirement that we would test on the CI. But for that, there has to be a role model, so this commit eliminates all `if else` occurrences, unless it is autogenerated code or fits one of the exceptions above. Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
beorn7	c3c7d44d84	lint: Adjust to the lint warnings raised by current versions of golint-ci We haven't updated golint-ci in our CI yet, but this commit prepares for that. There are a lot of new warnings, and it is mostly because the "revive" linter got updated. I agree with most of the new warnings, mostly around not naming unused function parameters (although it is justified in some cases for documentation purposes – while things like mocks are a good example where not naming the parameter is clearer). I'm pretty upset about the "empty block" warning to include `for` loops. It's such a common pattern to do something in the head of the `for` loop and then have an empty block. There is still an open issue about this: https://github.com/mgechev/revive/issues/810 I have disabled "revive" altogether in files where empty blocks are used excessively, and I have made the effort to add individual `// nolint:revive` where empty blocks are used just once or twice. It's borderline noisy, though, but let's go with it for now. I should mention that none of the "empty block" warnings for `for` loop bodies were legitimate. Signed-off-by: beorn7 <beorn@grafana.com>	2 years ago
Matthieu MOREL	fb3eb21230	enable gocritic, unconvert and unused linters Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>	2 years ago
Peter Nicholson	138a1362d8	Add support for EndpointSlice conditions Signed-off-by: Peter Nicholson <petergoods@hotmail.com>	2 years ago
Ben Whetstone	32e9f6a39c	Add container ID as a meta label for pod targets Signed-off-by: Ben Whetstone <ben.whetstone@sysdig.com>	2 years ago
Jens Erat	728fdc959e	Kubernetes SD: disable resync timer While originally the resync period also forced refreshing from Kubernetes API server, this has been removed for some years now because watching the API server got more stable [1]. Today, this just results in all entities being sent to the service discovery again, which is valid from a general Prometheus perspective, but results in unnecessary CPU load and also breaks service discovery metrics. In especially, this makes monitoring "do we actually observe changes from Kubernetes API server" impossible (receiving constant updates from Kubernetes service discovery is a pretty valid assumption, for example nodes get frequent status updates, ...). Signed-off-by: Jens Erat <jens.erat@mercedes-benz.com>	2 years ago
Julien Pivotto	3677d61a4b	Update kubernetes dependencies A new API is available for AddEventHandlers, to get errors but also be able to cancel handlers. Doing the easy thing for the release, which is just to log errors. We could see how to improve this in the future to handle the errors properly and cancel the handlers. Signed-off-by: Julien Pivotto <roidelapluie@o11y.eu>	2 years ago
Aaron George	d542483e8c	k8s discovery: Ensure that the pod IP is in the status before adding to target group Signed-off-by: Aaron George <aaron@ometria.com> Signed-off-by: Aaron George <aaron@ometria.com>	2 years ago
Maciej Borsz	56eba3ace2	Use protobuf encoding in client-go Signed-off-by: Maciej Borsz <maciejborsz@google.com>	2 years ago
Karl Piplies	3782cb40d5	add loadbalancerip to service labels Signed-off-by: Karl Piplies <karl.piplies@mercedes-benz.com>	2 years ago
Frederic Branczyk	414c3e549c	Merge pull request #11002 from yngwiewang/feature/k8s-service-port-number feat:(kubernetes_sd): add __meta_kubernetes_service_port_number (#10945)	2 years ago
Robert Fratto	97be65387d	discovery/kubernetes: fix broken tests Signed-off-by: Robert Fratto <robertfratto@gmail.com>	2 years ago
Robert Fratto	823d24d1e9	discovery/kubernetes: add container image as metadata This commits adds a __meta_kubernetes_pod_container_image as a new metadata label. This can be used to alert on mismatched versions of targets who don't have a build_info metric, as well as injecting it into log lines for other consumers of discovery/kubernetes (e.g., Promtail). Signed-off-by: Robert Fratto <robertfratto@gmail.com>	2 years ago
yngwiewang	1abbf5a5c5	add __meta_kubernetes_service_port_number (#10945 ) Signed-off-by: yngwiewang <yngwiewang@163.com>	2 years ago
Filip Petkovski	05da373dcb	kubernetes_sd: Allow attaching node labels for endpoint role The Kubernetes service discovery can only add node labels to targets from the pod role. This commit extends this functionality to the endpoints and endpointslices roles. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>	2 years ago
Filip Petkovski	7a78897d0b	Improve reliability of Kubernetes SD tests (#10761 ) The tests for Kubernetes SD rely on comparing target groups by first serializing them to JSON. However, the target group MarshalJSON function only serializes the __address__ label, which makes eliminates all other labels from the comparison. This commit implements a separate marshaling function intended for use in Kubernetes SD tests. The function serializes all target labels, making comparisons much more reliable. The commit also fixes all tests that started to fail due to the newly introduced change. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>	3 years ago
Matthieu MOREL	f43749e82f	refactor (discovery): move from github.com/pkg/errors to 'errors' and 'fmt' (#10807 ) Signed-off-by: Matthieu MOREL <mmorel-35@users.noreply.github.com> Co-authored-by: Matthieu MOREL <mmorel-35@users.noreply.github.com>	3 years ago
Matthieu MOREL	e2ede285a2	refactor: move from io/ioutil to io and os packages (#10528 ) * refactor: move from io/ioutil to io and os packages * use fs.DirEntry instead of os.FileInfo after os.ReadDir Signed-off-by: MOREL Matthieu <matthieu.morel@cnp.fr>	3 years ago
nixargh	e76c6aac50	Fix #10507 : explicitly include gcp auth from k8s.io to kubernetes discovery Signed-off-by: nixargh <nixargh@protonmail.com>	3 years ago
Furkan	2939966634	Kubernetes SD: Support discovery.k8s.io/v1 EndpointSlice Fixes #9498 Signed-off-by: Furkan <furkan.turkal@trendyol.com> Signed-off-by: Erkan Zileli <erkan.zileli@trendyol.com> Co-authored-by: Batuhan Apaydin <batuhan.apaydin@trendyol.com>	3 years ago
fpetkovski	16bd0d7d5c	Index pods by node name Signed-off-by: fpetkovski <filip.petkovsky@gmail.com>	3 years ago
fpetkovski	fa798d3042	Allow attaching node metadata Signed-off-by: fpetkovski <filip.petkovsky@gmail.com>	3 years ago
cui fliter	c9b56d1a49	all: fix some typos (#10389 ) Signed-off-by: cuishuang <imcusg@gmail.com>	3 years ago
beorn7	35010daa90	Merge branch 'release-2.33' into beorn7/cleaning-up-cherrypicking-fallout	3 years ago
Julien Pivotto	9d63502204	k8s: improve 'own_namespace' Fail configuration unmarshalling if kubeconfig or api url are set with "own namespace" Only read namespace file if needed. Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>	3 years ago

1 2 3 4

183 Commits (0833d2a230c422ad5ce99e096702ce1802efae73)