github
/
prometheus
mirror of https://github.com/prometheus/prometheus
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix AllPostings added twice (#13893) 

* handle all postings added twice

---------

Signed-off-by: Ben Ye <benye@amazon.com>
pull/13197/merge
Ben Ye 2024-11-10 09:17:21 -08:00 committed by GitHub
parent 76432aaf4e
commit f9057544cb
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tsdb/querier.go
View File

@ -193,6 +193,11 @@ func selectChunkSeriesSet(ctx context.Context, sortSeries bool, hints *storage.S
// PostingsForMatchers assembles a single postings iterator against the index reader // PostingsForMatchers assembles a single postings iterator against the index reader
// based on the given matchers. The resulting postings are not ordered by series. // based on the given matchers. The resulting postings are not ordered by series.
func PostingsForMatchers(ctx context.Context, ix IndexReader, ms ...*labels.Matcher) (index.Postings, error) { func PostingsForMatchers(ctx context.Context, ix IndexReader, ms ...*labels.Matcher) (index.Postings, error) {
if len(ms) == 1 && ms[0].Name == "" && ms[0].Value == "" {
k, v := index.AllPostingsKey()
return ix.Postings(ctx, k, v)
}
var its, notIts []index.Postings var its, notIts []index.Postings
// See which label must be non-empty. // See which label must be non-empty.
// Optimization for case like {l=~".", l!="1"}. // Optimization for case like {l=~".", l!="1"}.
@ -247,13 +252,10 @@ func PostingsForMatchers(ctx context.Context, ix IndexReader, ms ...*labels.Matc
return nil, ctx.Err() return nil, ctx.Err()
} }
switch { switch {
case m.Name == "" && m.Value == "": // Special-case for AllPostings, used in tests at least. case m.Name == "" && m.Value == "":
k, v := index.AllPostingsKey() // We already handled the case at the top of the function,
allPostings, err := ix.Postings(ctx, k, v) // and it is unexpected to get all postings again here.
if err != nil { return nil, errors.New("unexpected all postings")
return nil, err
}
its = append(its, allPostings)
case m.Type == labels.MatchRegexp && m.Value == ".*": case m.Type == labels.MatchRegexp && m.Value == ".*":
// .* regexp matches any string: do nothing. // .* regexp matches any string: do nothing.
case m.Type == labels.MatchNotRegexp && m.Value == ".*": case m.Type == labels.MatchNotRegexp && m.Value == ".*":