From daebf68ea240e4ac156d919c32dd9bdcccdc1621 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Elif=20T=2E=20Ku=C5=9F?= <elifkus@gmail.com>
Date: Thu, 29 Mar 2018 18:02:28 +0300
Subject: [PATCH] Rewrote tests for relabel and template (#3754)

* relabel: use testutil for testing

* template: use testutil for testing
---
 relabel/relabel_test.go   |  9 +++------
 template/template_test.go | 22 ++++++++--------------
 2 files changed, 11 insertions(+), 20 deletions(-)

diff --git a/relabel/relabel_test.go b/relabel/relabel_test.go
index 3ee534158..52ab2d10a 100644
--- a/relabel/relabel_test.go
+++ b/relabel/relabel_test.go
@@ -14,12 +14,12 @@
 package relabel
 
 import (
-	"reflect"
 	"testing"
 
 	"github.com/prometheus/common/model"
 
 	"github.com/prometheus/prometheus/config"
+	"github.com/prometheus/prometheus/util/testutil"
 )
 
 func TestRelabel(t *testing.T) {
@@ -412,11 +412,8 @@ func TestRelabel(t *testing.T) {
 		},
 	}
 
-	for i, test := range tests {
+	for _, test := range tests {
 		res := Process(test.input, test.relabel...)
-
-		if !reflect.DeepEqual(res, test.output) {
-			t.Errorf("Test %d: relabel output mismatch: expected %#v, got %#v", i+1, test.output, res)
-		}
+		testutil.Equals(t, res, test.output)
 	}
 }
diff --git a/template/template_test.go b/template/template_test.go
index 5b9069879..d7ce8c4a3 100644
--- a/template/template_test.go
+++ b/template/template_test.go
@@ -22,6 +22,7 @@ import (
 
 	"github.com/prometheus/prometheus/pkg/labels"
 	"github.com/prometheus/prometheus/promql"
+	"github.com/prometheus/prometheus/util/testutil"
 )
 
 type testTemplatesScenario struct {
@@ -256,7 +257,7 @@ func TestTemplateExpansion(t *testing.T) {
 		panic(err)
 	}
 
-	for i, s := range scenarios {
+	for _, s := range scenarios {
 		queryFunc := func(_ context.Context, _ string, _ time.Time) (promql.Vector, error) {
 			return s.queryResult, nil
 		}
@@ -269,21 +270,14 @@ func TestTemplateExpansion(t *testing.T) {
 			result, err = expander.Expand()
 		}
 		if s.shouldFail {
-			if err == nil {
-				t.Fatalf("%d. Error not returned from %v", i, s.text)
-			}
-			if err.Error() != s.errorMsg {
-				t.Fatalf("%d. Error message returned is wrong:\n returned: %v\n expected: %v", i, err.Error(), s.errorMsg)
-			}
+			testutil.NotOk(t, err, "%v", s.text)
 			continue
 		}
-		if err != nil {
-			t.Fatalf("%d. Error returned from %v: %v", i, s.text, err)
-			continue
-		}
-		if result != s.output {
-			t.Fatalf("%d. Error in result from %v: Expected '%v' Got '%v'", i, s.text, s.output, result)
-			continue
+
+		testutil.Ok(t, err)
+
+		if err == nil {
+			testutil.Equals(t, result, s.output)
 		}
 	}
 }