github
/
prometheus
mirror of https://github.com/prometheus/prometheus
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove superfluous nil check in Group.metrics 

Signed-off-by: Marco Pracucci <marco@pracucci.com>
pull/12946/head
Marco Pracucci 2024-01-29 10:21:57 +01:00
parent 046cd7599f
commit cbbbd6e70a
No known key found for this signature in database
GPG Key ID: 74C1BD403D2DF9B5
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
rules/group.go
View File

@ -592,9 +592,8 @@ func (g *Group) Eval(ctx context.Context, ts time.Time) {
} }
wg.Wait() wg.Wait()
if g.metrics != nil {
g.metrics.GroupSamples.WithLabelValues(GroupKey(g.File(), g.Name())).Set(samplesTotal.Load()) g.metrics.GroupSamples.WithLabelValues(GroupKey(g.File(), g.Name())).Set(samplesTotal.Load())
}
g.cleanupStaleSeries(ctx, ts) g.cleanupStaleSeries(ctx, ts)
} }

1
rules/manager_test.go
View File

@ -679,6 +679,7 @@ func TestDeletedRuleMarkedStale(t *testing.T) {
Appendable: st, Appendable: st,
RuleConcurrencyController: sequentialRuleEvalController{}, RuleConcurrencyController: sequentialRuleEvalController{},
}, },
metrics: NewGroupMetrics(nil),
} }
newGroup.CopyState(oldGroup) newGroup.CopyState(oldGroup)