drop metric name for bool modifier (#3821)

fixes #3820
7 years ago · a53d4ed197
2 changed files with 4 additions and 1 deletions
--- a/promql/engine.go
+++ b/promql/engine.go
@ -1151,7 +1151,7 @@ func (ev *evaluator) VectorscalarBinop(op itemType, lhs Vector, rhs Scalar, swap
 		}
 		if keep {
 			lhsSample.V = value
-			if shouldDropMetricName(op) {
+			if shouldDropMetricName(op) || returnBool {
 				lhsSample.Metric = dropMetricName(lhsSample.Metric)
 			}
 			vec = append(vec, lhsSample)
--- a/promql/testdata/operators.test
+++ b/promql/testdata/operators.test
@ -236,6 +236,9 @@ eval instant at 50m 0 == bool 1
 eval instant at 50m 1 == bool 1
 	1

+eval instant at 50m http_requests{job="api-server", instance="0", group="production"} == bool 100
+	{job="api-server", instance="0", group="production"} 1
+
 # group_left/group_right.

 clear