Browse Source

Re-use timer instead of creating new ones on every sample

The docs for `time.After()` note that "The underlying Timer is not
recovered by the garbage collector until the timer fires".
pull/3731/head
Bryan Boreham 7 years ago
parent
commit
8a4535e6ad
  1. 8
      storage/remote/queue_manager.go

8
storage/remote/queue_manager.go

@ -430,6 +430,8 @@ func (s *shards) runShard(i int) {
// anyways.
pendingSamples := model.Samples{}
timer := time.NewTimer(s.qm.cfg.BatchSendDeadline)
for {
select {
case sample, ok := <-queue:
@ -449,7 +451,11 @@ func (s *shards) runShard(i int) {
s.sendSamples(pendingSamples[:s.qm.cfg.MaxSamplesPerSend])
pendingSamples = pendingSamples[s.qm.cfg.MaxSamplesPerSend:]
}
case <-time.After(s.qm.cfg.BatchSendDeadline):
if !timer.Stop() {
<-timer.C
}
timer.Reset(s.qm.cfg.BatchSendDeadline)
case <-timer.C:
if len(pendingSamples) > 0 {
s.sendSamples(pendingSamples)
pendingSamples = pendingSamples[:0]

Loading…
Cancel
Save