From 79020b1e8565de3578825ca756c4e0b9aea3c7f8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gy=C3=B6rgy=20Krajcsovits?= Date: Tue, 18 Jun 2024 15:22:03 +0200 Subject: [PATCH] Comment float histogram as well MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: György Krajcsovits --- scrape/target.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scrape/target.go b/scrape/target.go index ebe86c156..9ef4471fb 100644 --- a/scrape/target.go +++ b/scrape/target.go @@ -378,6 +378,8 @@ func (app *bucketLimitAppender) AppendHistogram(ref storage.SeriesRef, lset labe } } if fh != nil { + // Return with an early error if the histogram has too many buckets and the + // schema is not exponential, in which case we can't reduce the resolution. if len(fh.PositiveBuckets)+len(fh.NegativeBuckets) > app.limit && !histogram.IsExponentialSchema(fh.Schema) { return 0, errBucketLimit }