From ec7db0d541194d171b6d9fe53d725575b7efe62d Mon Sep 17 00:00:00 2001 From: Matthias Rampke Date: Thu, 13 Jun 2019 08:56:30 +0000 Subject: [PATCH] Work around golangci-lint issues MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The version on goreleaser is broken and different from the one in Github: golangci/golangci-lint#575 – use the direct Github URL as a workaround. Additionally, the installer script attempts to `install -d /go/bin` on CircleCI, which doesn't work due to permissions. Patch that line out – we don't need it because we make sure the directory exists anyway. Signed-off-by: Matthias Rampke --- Makefile.common | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile.common b/Makefile.common index 6b94f8391..d7aea1b86 100644 --- a/Makefile.common +++ b/Makefile.common @@ -248,7 +248,9 @@ proto: ifdef GOLANGCI_LINT $(GOLANGCI_LINT): mkdir -p $(FIRST_GOPATH)/bin - curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s -- -b $(FIRST_GOPATH)/bin $(GOLANGCI_LINT_VERSION) + curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/$(GOLANGCI_LINT_VERSION)/install.sh \ + | sed -e '/install -d/d' \ + | sh -s -- -b $(FIRST_GOPATH)/bin $(GOLANGCI_LINT_VERSION) endif ifdef GOVENDOR