From 2368d2c45bf21c9187a2a91e389e7af641fdf781 Mon Sep 17 00:00:00 2001
From: Fabian Reinartz <fab.reinartz@gmail.com>
Date: Mon, 26 Jun 2017 00:24:54 +0200
Subject: [PATCH] retrieval: fix memory leak in scrape cache

---
 retrieval/scrape.go | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/retrieval/scrape.go b/retrieval/scrape.go
index fba930e7e..f002b3394 100644
--- a/retrieval/scrape.go
+++ b/retrieval/scrape.go
@@ -508,6 +508,11 @@ func (c *scrapeCache) getRef(met string) (string, bool) {
 }
 
 func (c *scrapeCache) addRef(met, ref string, lset labels.Labels) {
+	// Clean up the label set cache before overwriting the ref for a previously seen
+	// metric representation. It won't be caught by the cleanup in iterDone otherwise.
+	if e, ok := c.refs[met]; ok {
+		delete(c.lsets, e.ref)
+	}
 	c.refs[met] = &refEntry{ref: ref, lastIter: c.iter}
 	// met is the raw string the metric was ingested as. The label set is not ordered
 	// and thus it's not suitable to uniquely identify cache entries.