From 3c047a35184db4ff351dbf29f0ee9860b063c313 Mon Sep 17 00:00:00 2001 From: Linas Medziunas Date: Thu, 28 Sep 2023 09:08:09 +0300 Subject: [PATCH] Expand docs comments Signed-off-by: Linas Medziunas --- model/histogram/float_histogram.go | 1 + model/histogram/histogram.go | 1 + 2 files changed, 2 insertions(+) diff --git a/model/histogram/float_histogram.go b/model/histogram/float_histogram.go index 54ff5d4df..f1cb6e5a9 100644 --- a/model/histogram/float_histogram.go +++ b/model/histogram/float_histogram.go @@ -307,6 +307,7 @@ func (h *FloatHistogram) Sub(other *FloatHistogram) *FloatHistogram { // Exact match is when there are no new buckets (even empty) and no missing buckets, // and all the bucket values match. Spans can have different empty length spans in between, // but they must represent the same bucket layout to match. +// Non-metadata float fields (Sum, Count, ZeroCount) are compared as binary (using math.Float64bits). func (h *FloatHistogram) Equals(h2 *FloatHistogram) bool { if h2 == nil { return false diff --git a/model/histogram/histogram.go b/model/histogram/histogram.go index 31c3ce9fe..88883472d 100644 --- a/model/histogram/histogram.go +++ b/model/histogram/histogram.go @@ -172,6 +172,7 @@ func (h *Histogram) CumulativeBucketIterator() BucketIterator[uint64] { // Exact match is when there are no new buckets (even empty) and no missing buckets, // and all the bucket values match. Spans can have different empty length spans in between, // but they must represent the same bucket layout to match. +// Non-metadata float field (Sum) is compared as binary (using math.Float64bits). func (h *Histogram) Equals(h2 *Histogram) bool { if h2 == nil { return false