From 2b0c87b1b6ee494c75448f23e6465c8cf20acda0 Mon Sep 17 00:00:00 2001
From: Bryan Boreham <bjboreham@gmail.com>
Date: Wed, 8 May 2024 11:47:03 +0100
Subject: [PATCH] test: turn TestKahanSum into scripted test

This saves having a function solely to call kahanSumInc.

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
---
 promql/functions.go            | 9 ---------
 promql/functions_test.go       | 7 -------
 promql/testdata/functions.test | 8 ++++++++
 3 files changed, 8 insertions(+), 16 deletions(-)

diff --git a/promql/functions.go b/promql/functions.go
index 2e15a1467..9b3be2287 100644
--- a/promql/functions.go
+++ b/promql/functions.go
@@ -948,15 +948,6 @@ func funcTimestamp(vals []parser.Value, args parser.Expressions, enh *EvalNodeHe
 	return enh.Out, nil
 }
 
-func kahanSum(samples []float64) float64 {
-	var sum, c float64
-
-	for _, v := range samples {
-		sum, c = kahanSumInc(v, sum, c)
-	}
-	return sum + c
-}
-
 func kahanSumInc(inc, sum, c float64) (newSum, newC float64) {
 	t := sum + inc
 	// Using Neumaier improvement, swap if next term larger than sum.
diff --git a/promql/functions_test.go b/promql/functions_test.go
index 6d5c3784e..08e4900f5 100644
--- a/promql/functions_test.go
+++ b/promql/functions_test.go
@@ -15,7 +15,6 @@ package promql
 
 import (
 	"context"
-	"math"
 	"testing"
 	"time"
 
@@ -80,9 +79,3 @@ func TestFunctionList(t *testing.T) {
 		require.True(t, ok, "function %s exists in parser package, but not in promql package", i)
 	}
 }
-
-func TestKahanSum(t *testing.T) {
-	vals := []float64{1.0, math.Pow(10, 100), 1.0, -1 * math.Pow(10, 100)}
-	expected := 2.0
-	require.Equal(t, expected, kahanSum(vals))
-}
diff --git a/promql/testdata/functions.test b/promql/testdata/functions.test
index e01c75a7f..2c198374a 100644
--- a/promql/testdata/functions.test
+++ b/promql/testdata/functions.test
@@ -764,6 +764,14 @@ eval instant at 1m avg_over_time(metric10[1m])
 eval instant at 1m sum_over_time(metric10[1m])/count_over_time(metric10[1m])
   {} 0
 
+# Test if very big intermediate values cause loss of detail.
+clear
+load 10s
+  metric 1 1e100 1 -1e100
+
+eval instant at 1m sum_over_time(metric[1m])
+  {} 2
+
 # Tests for stddev_over_time and stdvar_over_time.
 clear
 load 10s