|
|
|
// Copyright 2013 The Prometheus Authors
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
// you may not use this file except in compliance with the License.
|
|
|
|
// You may obtain a copy of the License at
|
|
|
|
//
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
//
|
|
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
// See the License for the specific language governing permissions and
|
|
|
|
// limitations under the License.
|
|
|
|
|
|
|
|
package rules
|
|
|
|
|
|
|
|
import (
|
|
|
|
"reflect"
|
|
|
|
"testing"
|
|
|
|
|
|
|
|
"github.com/prometheus/common/model"
|
promql: Allow per-query contexts.
For Weaveworks' Frankenstein, we need to support multitenancy. In
Frankenstein, we initially solved this without modifying the promql
package at all: we constructed a new promql.Engine for every
query and injected a storage implementation into that engine which would
be primed to only collect data for a given user.
This is problematic to upstream, however. Prometheus assumes that there
is only one engine: the query concurrency gate is part of the engine,
and the engine contains one central cancellable context to shut down all
queries. Also, creating a new engine for every query seems like overkill.
Thus, we want to be able to pass per-query contexts into a single engine.
This change gets rid of the promql.Engine's built-in base context and
allows passing in a per-query context instead. Central cancellation of
all queries is still possible by deriving all passed-in contexts from
one central one, but this is now the responsibility of the caller. The
central query context is now created in main() and passed into the
relevant components (web handler / API, rule manager).
In a next step, the per-query context would have to be passed to the
storage implementation, so that the storage can implement multi-tenancy
or other features based on the contextual information.
8 years ago
|
|
|
"golang.org/x/net/context"
|
|
|
|
|
|
|
|
"github.com/prometheus/prometheus/promql"
|
|
|
|
"github.com/prometheus/prometheus/storage/local"
|
|
|
|
)
|
|
|
|
|
|
|
|
func TestRuleEval(t *testing.T) {
|
|
|
|
storage, closer := local.NewTestStorage(t, 2)
|
|
|
|
defer closer.Close()
|
|
|
|
engine := promql.NewEngine(storage, nil)
|
promql: Allow per-query contexts.
For Weaveworks' Frankenstein, we need to support multitenancy. In
Frankenstein, we initially solved this without modifying the promql
package at all: we constructed a new promql.Engine for every
query and injected a storage implementation into that engine which would
be primed to only collect data for a given user.
This is problematic to upstream, however. Prometheus assumes that there
is only one engine: the query concurrency gate is part of the engine,
and the engine contains one central cancellable context to shut down all
queries. Also, creating a new engine for every query seems like overkill.
Thus, we want to be able to pass per-query contexts into a single engine.
This change gets rid of the promql.Engine's built-in base context and
allows passing in a per-query context instead. Central cancellation of
all queries is still possible by deriving all passed-in contexts from
one central one, but this is now the responsibility of the caller. The
central query context is now created in main() and passed into the
relevant components (web handler / API, rule manager).
In a next step, the per-query context would have to be passed to the
storage implementation, so that the storage can implement multi-tenancy
or other features based on the contextual information.
8 years ago
|
|
|
queryCtx, cancelQueries := context.WithCancel(context.Background())
|
|
|
|
defer cancelQueries()
|
|
|
|
|
|
|
|
now := model.Now()
|
|
|
|
|
|
|
|
suite := []struct {
|
|
|
|
name string
|
|
|
|
expr promql.Expr
|
|
|
|
labels model.LabelSet
|
|
|
|
result model.Vector
|
|
|
|
}{
|
|
|
|
{
|
|
|
|
name: "nolabels",
|
|
|
|
expr: &promql.NumberLiteral{Val: 1},
|
|
|
|
labels: model.LabelSet{},
|
|
|
|
result: model.Vector{&model.Sample{
|
|
|
|
Value: 1,
|
|
|
|
Timestamp: now,
|
|
|
|
Metric: model.Metric{"__name__": "nolabels"},
|
|
|
|
}},
|
|
|
|
},
|
|
|
|
{
|
|
|
|
name: "labels",
|
|
|
|
expr: &promql.NumberLiteral{Val: 1},
|
|
|
|
labels: model.LabelSet{"foo": "bar"},
|
|
|
|
result: model.Vector{&model.Sample{
|
|
|
|
Value: 1,
|
|
|
|
Timestamp: now,
|
|
|
|
Metric: model.Metric{"__name__": "labels", "foo": "bar"},
|
|
|
|
}},
|
|
|
|
},
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, test := range suite {
|
|
|
|
rule := NewRecordingRule(test.name, test.expr, test.labels)
|
promql: Allow per-query contexts.
For Weaveworks' Frankenstein, we need to support multitenancy. In
Frankenstein, we initially solved this without modifying the promql
package at all: we constructed a new promql.Engine for every
query and injected a storage implementation into that engine which would
be primed to only collect data for a given user.
This is problematic to upstream, however. Prometheus assumes that there
is only one engine: the query concurrency gate is part of the engine,
and the engine contains one central cancellable context to shut down all
queries. Also, creating a new engine for every query seems like overkill.
Thus, we want to be able to pass per-query contexts into a single engine.
This change gets rid of the promql.Engine's built-in base context and
allows passing in a per-query context instead. Central cancellation of
all queries is still possible by deriving all passed-in contexts from
one central one, but this is now the responsibility of the caller. The
central query context is now created in main() and passed into the
relevant components (web handler / API, rule manager).
In a next step, the per-query context would have to be passed to the
storage implementation, so that the storage can implement multi-tenancy
or other features based on the contextual information.
8 years ago
|
|
|
result, err := rule.eval(now, engine, queryCtx, "")
|
|
|
|
if err != nil {
|
|
|
|
t.Fatalf("Error evaluating %s", test.name)
|
|
|
|
}
|
|
|
|
if !reflect.DeepEqual(result, test.result) {
|
|
|
|
t.Fatalf("Error: expected %q, got %q", test.result, result)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func TestRecordingRuleHTMLSnippet(t *testing.T) {
|
|
|
|
expr, err := promql.ParseExpr(`foo{html="<b>BOLD<b>"}`)
|
|
|
|
if err != nil {
|
|
|
|
t.Fatal(err)
|
|
|
|
}
|
|
|
|
rule := NewRecordingRule("testrule", expr, model.LabelSet{"html": "<b>BOLD</b>"})
|
|
|
|
|
|
|
|
const want = `<a href="/test/prefix/graph?g0.expr=testrule&g0.tab=0">testrule</a>{html="<b>BOLD</b>"} = <a href="/test/prefix/graph?g0.expr=foo%7Bhtml%3D%22%3Cb%3EBOLD%3Cb%3E%22%7D&g0.tab=0">foo{html="<b>BOLD<b>"}</a>`
|
|
|
|
|
|
|
|
got := rule.HTMLSnippet("/test/prefix")
|
|
|
|
if got != want {
|
|
|
|
t.Fatalf("incorrect HTML snippet; want:\n\n%s\n\ngot:\n\n%s", want, got)
|
|
|
|
}
|
|
|
|
}
|