You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
prometheus/model/labels/matcher.go

121 lines
2.7 KiB

// Copyright 2017 The Prometheus Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package labels
import (
"fmt"
)
// MatchType is an enum for label matching types.
type MatchType int
// Possible MatchTypes.
const (
MatchEqual MatchType = iota
MatchNotEqual
MatchRegexp
MatchNotRegexp
)
Use global string map for MatchType.String() (#9237) * Use global string map for MatchType.String() We were unnecessarily creating a new map for each call of String(). This is a 10x improvement in MatchType.String() performance in time, from 53ns to 4ns on my i7 laptop, and I guess that this method is being called quite often so why throw out the resources. I was surprised that benchmark says that there are no allocations made in the old version. I also tries using `//go:generate stringer` and the result is even better, at about 2.8ns, but having to keep the generated code updated isn't worth the change (at least it's bigger than a small change I was intended to do) Benchmark comparison: name \ time/op old global_map stringer MatchType_String 53.6ns ± 1% 4.1ns ± 1% 2.8ns ± 1% name \ alloc/op old global_map stringer MatchType_String 0.00B 0.00B 0.00B name \ allocs/op old global_map stringer MatchType_String 0.00 0.00 0.00 Old benchmark: goos: darwin goarch: amd64 pkg: github.com/prometheus/prometheus/pkg/labels cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz BenchmarkMatchType_String 21766578 54.36 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 21742339 53.28 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 21985470 53.37 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 21676282 53.50 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 22075573 53.33 ns/op 0 B/op 0 allocs/op PASS ok github.com/prometheus/prometheus/pkg/labels 6.252s New with global map: goos: darwin goarch: amd64 pkg: github.com/prometheus/prometheus/pkg/labels cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz BenchmarkMatchType_String 283412692 4.129 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 294859941 4.091 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 295750158 4.113 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 282827982 4.072 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 292942393 4.047 ns/op 0 B/op 0 allocs/op PASS ok github.com/prometheus/prometheus/pkg/labels 8.238s Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Use array instead of map Since MatchType is an iota type, we can safely use an array here. This solution is even better: name \ time/op old global_map stringer array MatchType_String 53.6ns ± 1% 4.1ns ± 1% 2.8ns ± 1% 1.0ns ± 1% name \ alloc/op old global_map stringer array MatchType_String 0.00B 0.00B 0.00B 0.00B name \ allocs/op old global_map stringer array MatchType_String 0.00 0.00 0.00 0.00 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Benchmark all MatchType values Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com> Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Use constants for limits Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com> Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com>
3 years ago
var matchTypeToStr = [...]string{
MatchEqual: "=",
MatchNotEqual: "!=",
MatchRegexp: "=~",
MatchNotRegexp: "!~",
}
func (m MatchType) String() string {
Use global string map for MatchType.String() (#9237) * Use global string map for MatchType.String() We were unnecessarily creating a new map for each call of String(). This is a 10x improvement in MatchType.String() performance in time, from 53ns to 4ns on my i7 laptop, and I guess that this method is being called quite often so why throw out the resources. I was surprised that benchmark says that there are no allocations made in the old version. I also tries using `//go:generate stringer` and the result is even better, at about 2.8ns, but having to keep the generated code updated isn't worth the change (at least it's bigger than a small change I was intended to do) Benchmark comparison: name \ time/op old global_map stringer MatchType_String 53.6ns ± 1% 4.1ns ± 1% 2.8ns ± 1% name \ alloc/op old global_map stringer MatchType_String 0.00B 0.00B 0.00B name \ allocs/op old global_map stringer MatchType_String 0.00 0.00 0.00 Old benchmark: goos: darwin goarch: amd64 pkg: github.com/prometheus/prometheus/pkg/labels cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz BenchmarkMatchType_String 21766578 54.36 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 21742339 53.28 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 21985470 53.37 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 21676282 53.50 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 22075573 53.33 ns/op 0 B/op 0 allocs/op PASS ok github.com/prometheus/prometheus/pkg/labels 6.252s New with global map: goos: darwin goarch: amd64 pkg: github.com/prometheus/prometheus/pkg/labels cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz BenchmarkMatchType_String 283412692 4.129 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 294859941 4.091 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 295750158 4.113 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 282827982 4.072 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 292942393 4.047 ns/op 0 B/op 0 allocs/op PASS ok github.com/prometheus/prometheus/pkg/labels 8.238s Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Use array instead of map Since MatchType is an iota type, we can safely use an array here. This solution is even better: name \ time/op old global_map stringer array MatchType_String 53.6ns ± 1% 4.1ns ± 1% 2.8ns ± 1% 1.0ns ± 1% name \ alloc/op old global_map stringer array MatchType_String 0.00B 0.00B 0.00B 0.00B name \ allocs/op old global_map stringer array MatchType_String 0.00 0.00 0.00 0.00 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Benchmark all MatchType values Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com> Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Use constants for limits Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com> Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com>
3 years ago
if m < MatchEqual || m > MatchNotRegexp {
panic("unknown match type")
}
Use global string map for MatchType.String() (#9237) * Use global string map for MatchType.String() We were unnecessarily creating a new map for each call of String(). This is a 10x improvement in MatchType.String() performance in time, from 53ns to 4ns on my i7 laptop, and I guess that this method is being called quite often so why throw out the resources. I was surprised that benchmark says that there are no allocations made in the old version. I also tries using `//go:generate stringer` and the result is even better, at about 2.8ns, but having to keep the generated code updated isn't worth the change (at least it's bigger than a small change I was intended to do) Benchmark comparison: name \ time/op old global_map stringer MatchType_String 53.6ns ± 1% 4.1ns ± 1% 2.8ns ± 1% name \ alloc/op old global_map stringer MatchType_String 0.00B 0.00B 0.00B name \ allocs/op old global_map stringer MatchType_String 0.00 0.00 0.00 Old benchmark: goos: darwin goarch: amd64 pkg: github.com/prometheus/prometheus/pkg/labels cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz BenchmarkMatchType_String 21766578 54.36 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 21742339 53.28 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 21985470 53.37 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 21676282 53.50 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 22075573 53.33 ns/op 0 B/op 0 allocs/op PASS ok github.com/prometheus/prometheus/pkg/labels 6.252s New with global map: goos: darwin goarch: amd64 pkg: github.com/prometheus/prometheus/pkg/labels cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz BenchmarkMatchType_String 283412692 4.129 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 294859941 4.091 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 295750158 4.113 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 282827982 4.072 ns/op 0 B/op 0 allocs/op BenchmarkMatchType_String 292942393 4.047 ns/op 0 B/op 0 allocs/op PASS ok github.com/prometheus/prometheus/pkg/labels 8.238s Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Use array instead of map Since MatchType is an iota type, we can safely use an array here. This solution is even better: name \ time/op old global_map stringer array MatchType_String 53.6ns ± 1% 4.1ns ± 1% 2.8ns ± 1% 1.0ns ± 1% name \ alloc/op old global_map stringer array MatchType_String 0.00B 0.00B 0.00B 0.00B name \ allocs/op old global_map stringer array MatchType_String 0.00 0.00 0.00 0.00 Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Benchmark all MatchType values Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com> Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> * Use constants for limits Signed-off-by: Oleg Zaytsev <mail@olegzaytsev.com> Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com> Co-authored-by: Ganesh Vernekar <15064823+codesome@users.noreply.github.com>
3 years ago
return matchTypeToStr[m]
}
// Matcher models the matching of a label.
type Matcher struct {
Type MatchType
Name string
Value string
re *FastRegexMatcher
}
// NewMatcher returns a matcher object.
func NewMatcher(t MatchType, n, v string) (*Matcher, error) {
m := &Matcher{
Type: t,
Name: n,
Value: v,
}
if t == MatchRegexp || t == MatchNotRegexp {
re, err := NewFastRegexMatcher(v)
if err != nil {
return nil, err
}
m.re = re
}
return m, nil
}
// MustNewMatcher panics on error - only for use in tests!
func MustNewMatcher(mt MatchType, name, val string) *Matcher {
m, err := NewMatcher(mt, name, val)
if err != nil {
panic(err)
}
return m
}
func (m *Matcher) String() string {
return fmt.Sprintf("%s%s%q", m.Name, m.Type, m.Value)
}
// Matches returns whether the matcher matches the given string value.
func (m *Matcher) Matches(s string) bool {
switch m.Type {
case MatchEqual:
return s == m.Value
case MatchNotEqual:
return s != m.Value
case MatchRegexp:
return m.re.MatchString(s)
case MatchNotRegexp:
return !m.re.MatchString(s)
}
panic("labels.Matcher.Matches: invalid match type")
}
// Inverse returns a matcher that matches the opposite.
func (m *Matcher) Inverse() (*Matcher, error) {
switch m.Type {
case MatchEqual:
return NewMatcher(MatchNotEqual, m.Name, m.Value)
case MatchNotEqual:
return NewMatcher(MatchEqual, m.Name, m.Value)
case MatchRegexp:
return NewMatcher(MatchNotRegexp, m.Name, m.Value)
case MatchNotRegexp:
return NewMatcher(MatchRegexp, m.Name, m.Value)
}
panic("labels.Matcher.Matches: invalid match type")
}
// GetRegexString returns the regex string.
func (m *Matcher) GetRegexString() string {
if m.re == nil {
return ""
}
return m.re.GetRegexString()
}