|
|
|
// Copyright 2017 The Prometheus Authors
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
// you may not use this file except in compliance with the License.
|
|
|
|
// You may obtain a copy of the License at
|
|
|
|
//
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
//
|
|
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
// See the License for the specific language governing permissions and
|
|
|
|
// limitations under the License.
|
|
|
|
|
|
|
|
package storage
|
|
|
|
|
|
|
|
import (
|
|
|
|
"context"
|
|
|
|
"log/slog"
|
|
|
|
|
|
|
|
"github.com/prometheus/common/model"
|
|
|
|
|
|
|
|
"github.com/prometheus/prometheus/model/exemplar"
|
Style cleanup of all the changes in sparsehistogram so far
A lot of this code was hacked together, literally during a
hackathon. This commit intends not to change the code substantially,
but just make the code obey the usual style practices.
A (possibly incomplete) list of areas:
* Generally address linter warnings.
* The `pgk` directory is deprecated as per dev-summit. No new packages should
be added to it. I moved the new `pkg/histogram` package to `model`
anticipating what's proposed in #9478.
* Make the naming of the Sparse Histogram more consistent. Including
abbreviations, there were just too many names for it: SparseHistogram,
Histogram, Histo, hist, his, shs, h. The idea is to call it "Histogram" in
general. Only add "Sparse" if it is needed to avoid confusion with
conventional Histograms (which is rare because the TSDB really has no notion
of conventional Histograms). Use abbreviations only in local scope, and then
really abbreviate (not just removing three out of seven letters like in
"Histo"). This is in the spirit of
https://github.com/golang/go/wiki/CodeReviewComments#variable-names
* Several other minor name changes.
* A lot of formatting of doc comments. For one, following
https://github.com/golang/go/wiki/CodeReviewComments#comment-sentences
, but also layout question, anticipating how things will look like
when rendered by `godoc` (even where `godoc` doesn't render them
right now because they are for unexported types or not a doc comment
at all but just a normal code comment - consistency is queen!).
* Re-enabled `TestQueryLog` and `TestEndopints` (they pass now,
leaving them disabled was presumably an oversight).
* Bucket iterator for histogram.Histogram is now created with a
method.
* HistogramChunk.iterator now allows iterator recycling. (I think
@dieterbe only commented it out because he was confused by the
question in the comment.)
* HistogramAppender.Append panics now because we decided to treat
staleness marker differently.
Signed-off-by: beorn7 <beorn@grafana.com>
3 years ago
|
|
|
"github.com/prometheus/prometheus/model/histogram"
|
|
|
|
"github.com/prometheus/prometheus/model/labels"
|
|
|
|
"github.com/prometheus/prometheus/model/metadata"
|
|
|
|
tsdb_errors "github.com/prometheus/prometheus/tsdb/errors"
|
|
|
|
)
|
|
|
|
|
|
|
|
type fanout struct {
|
|
|
|
logger *slog.Logger
|
|
|
|
|
|
|
|
primary Storage
|
|
|
|
secondaries []Storage
|
|
|
|
}
|
|
|
|
|
|
|
|
// NewFanout returns a new fanout Storage, which proxies reads and writes
|
|
|
|
// through to multiple underlying storages.
|
|
|
|
//
|
|
|
|
// The difference between primary and secondary Storage is only for read (Querier) path and it goes as follows:
|
|
|
|
// * If the primary querier returns an error, then any of the Querier operations will fail.
|
|
|
|
// * If any secondary querier returns an error the result from that queries is discarded. The overall operation will succeed,
|
|
|
|
// and the error from the secondary querier will be returned as a warning.
|
|
|
|
//
|
|
|
|
// NOTE: In the case of Prometheus, it treats all remote storages as secondary / best effort.
|
|
|
|
func NewFanout(logger *slog.Logger, primary Storage, secondaries ...Storage) Storage {
|
|
|
|
return &fanout{
|
|
|
|
logger: logger,
|
|
|
|
primary: primary,
|
|
|
|
secondaries: secondaries,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// StartTime implements the Storage interface.
|
|
|
|
func (f *fanout) StartTime() (int64, error) {
|
|
|
|
// StartTime of a fanout should be the earliest StartTime of all its storages,
|
|
|
|
// both primary and secondaries.
|
|
|
|
firstTime, err := f.primary.StartTime()
|
|
|
|
if err != nil {
|
|
|
|
return int64(model.Latest), err
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, s := range f.secondaries {
|
|
|
|
t, err := s.StartTime()
|
|
|
|
if err != nil {
|
|
|
|
return int64(model.Latest), err
|
|
|
|
}
|
|
|
|
if t < firstTime {
|
|
|
|
firstTime = t
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return firstTime, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *fanout) Querier(mint, maxt int64) (Querier, error) {
|
|
|
|
primary, err := f.primary.Querier(mint, maxt)
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
|
|
|
|
secondaries := make([]Querier, 0, len(f.secondaries))
|
|
|
|
for _, storage := range f.secondaries {
|
|
|
|
querier, err := storage.Querier(mint, maxt)
|
|
|
|
if err != nil {
|
|
|
|
// Close already open Queriers, append potential errors to returned error.
|
|
|
|
errs := tsdb_errors.NewMulti(err, primary.Close())
|
|
|
|
for _, q := range secondaries {
|
|
|
|
errs.Add(q.Close())
|
|
|
|
}
|
|
|
|
return nil, errs.Err()
|
|
|
|
}
|
|
|
|
if _, ok := querier.(noopQuerier); !ok {
|
|
|
|
secondaries = append(secondaries, querier)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return NewMergeQuerier([]Querier{primary}, secondaries, ChainedSeriesMerge), nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *fanout) ChunkQuerier(mint, maxt int64) (ChunkQuerier, error) {
|
|
|
|
primary, err := f.primary.ChunkQuerier(mint, maxt)
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
|
|
|
|
secondaries := make([]ChunkQuerier, 0, len(f.secondaries))
|
|
|
|
for _, storage := range f.secondaries {
|
|
|
|
querier, err := storage.ChunkQuerier(mint, maxt)
|
|
|
|
if err != nil {
|
|
|
|
// Close already open Queriers, append potential errors to returned error.
|
|
|
|
errs := tsdb_errors.NewMulti(err, primary.Close())
|
|
|
|
for _, q := range secondaries {
|
|
|
|
errs.Add(q.Close())
|
|
|
|
}
|
|
|
|
return nil, errs.Err()
|
|
|
|
}
|
|
|
|
secondaries = append(secondaries, querier)
|
|
|
|
}
|
|
|
|
return NewMergeChunkQuerier([]ChunkQuerier{primary}, secondaries, NewCompactingChunkSeriesMerger(ChainedSeriesMerge)), nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *fanout) Appender(ctx context.Context) Appender {
|
|
|
|
primary := f.primary.Appender(ctx)
|
|
|
|
secondaries := make([]Appender, 0, len(f.secondaries))
|
|
|
|
for _, storage := range f.secondaries {
|
|
|
|
secondaries = append(secondaries, storage.Appender(ctx))
|
|
|
|
}
|
|
|
|
return &fanoutAppender{
|
|
|
|
logger: f.logger,
|
|
|
|
primary: primary,
|
|
|
|
secondaries: secondaries,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Close closes the storage and all its underlying resources.
|
|
|
|
func (f *fanout) Close() error {
|
|
|
|
errs := tsdb_errors.NewMulti(f.primary.Close())
|
|
|
|
for _, s := range f.secondaries {
|
|
|
|
errs.Add(s.Close())
|
|
|
|
}
|
|
|
|
return errs.Err()
|
|
|
|
}
|
|
|
|
|
|
|
|
// fanoutAppender implements Appender.
|
|
|
|
type fanoutAppender struct {
|
|
|
|
logger *slog.Logger
|
|
|
|
|
|
|
|
primary Appender
|
|
|
|
secondaries []Appender
|
|
|
|
}
|
|
|
|
|
|
|
|
// SetOptions propagates the hints to both primary and secondary appenders.
|
|
|
|
func (f *fanoutAppender) SetOptions(opts *AppendOptions) {
|
|
|
|
if f.primary != nil {
|
|
|
|
f.primary.SetOptions(opts)
|
|
|
|
}
|
|
|
|
for _, appender := range f.secondaries {
|
|
|
|
appender.SetOptions(opts)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *fanoutAppender) Append(ref SeriesRef, l labels.Labels, t int64, v float64) (SeriesRef, error) {
|
|
|
|
ref, err := f.primary.Append(ref, l, t, v)
|
|
|
|
if err != nil {
|
|
|
|
return ref, err
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, appender := range f.secondaries {
|
|
|
|
if _, err := appender.Append(ref, l, t, v); err != nil {
|
|
|
|
return 0, err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return ref, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *fanoutAppender) AppendExemplar(ref SeriesRef, l labels.Labels, e exemplar.Exemplar) (SeriesRef, error) {
|
|
|
|
ref, err := f.primary.AppendExemplar(ref, l, e)
|
|
|
|
if err != nil {
|
|
|
|
return ref, err
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, appender := range f.secondaries {
|
|
|
|
if _, err := appender.AppendExemplar(ref, l, e); err != nil {
|
|
|
|
return 0, err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return ref, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *fanoutAppender) AppendHistogram(ref SeriesRef, l labels.Labels, t int64, h *histogram.Histogram, fh *histogram.FloatHistogram) (SeriesRef, error) {
|
|
|
|
ref, err := f.primary.AppendHistogram(ref, l, t, h, fh)
|
|
|
|
if err != nil {
|
|
|
|
return ref, err
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, appender := range f.secondaries {
|
|
|
|
if _, err := appender.AppendHistogram(ref, l, t, h, fh); err != nil {
|
|
|
|
return 0, err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return ref, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *fanoutAppender) AppendHistogramCTZeroSample(ref SeriesRef, l labels.Labels, t, ct int64, h *histogram.Histogram, fh *histogram.FloatHistogram) (SeriesRef, error) {
|
|
|
|
ref, err := f.primary.AppendHistogramCTZeroSample(ref, l, t, ct, h, fh)
|
|
|
|
if err != nil {
|
|
|
|
return ref, err
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, appender := range f.secondaries {
|
|
|
|
if _, err := appender.AppendHistogramCTZeroSample(ref, l, t, ct, h, fh); err != nil {
|
|
|
|
return 0, err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return ref, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *fanoutAppender) UpdateMetadata(ref SeriesRef, l labels.Labels, m metadata.Metadata) (SeriesRef, error) {
|
|
|
|
ref, err := f.primary.UpdateMetadata(ref, l, m)
|
|
|
|
if err != nil {
|
|
|
|
return ref, err
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, appender := range f.secondaries {
|
|
|
|
if _, err := appender.UpdateMetadata(ref, l, m); err != nil {
|
|
|
|
return 0, err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return ref, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *fanoutAppender) AppendCTZeroSample(ref SeriesRef, l labels.Labels, t, ct int64) (SeriesRef, error) {
|
|
|
|
ref, err := f.primary.AppendCTZeroSample(ref, l, t, ct)
|
|
|
|
if err != nil {
|
|
|
|
return ref, err
|
|
|
|
}
|
|
|
|
|
|
|
|
for _, appender := range f.secondaries {
|
|
|
|
if _, err := appender.AppendCTZeroSample(ref, l, t, ct); err != nil {
|
|
|
|
return 0, err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return ref, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *fanoutAppender) Commit() (err error) {
|
|
|
|
err = f.primary.Commit()
|
|
|
|
|
|
|
|
for _, appender := range f.secondaries {
|
|
|
|
if err == nil {
|
|
|
|
err = appender.Commit()
|
|
|
|
} else {
|
|
|
|
if rollbackErr := appender.Rollback(); rollbackErr != nil {
|
|
|
|
f.logger.Error("Squashed rollback error on commit", "err", rollbackErr)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
func (f *fanoutAppender) Rollback() (err error) {
|
|
|
|
err = f.primary.Rollback()
|
|
|
|
|
|
|
|
for _, appender := range f.secondaries {
|
|
|
|
rollbackErr := appender.Rollback()
|
style: Replace `else if` cascades with `switch`
Wiser coders than myself have come to the conclusion that a `switch`
statement is almost always superior to a statement that includes any
`else if`.
The exceptions that I have found in our codebase are just these two:
* The `if else` is followed by an additional statement before the next
condition (separated by a `;`).
* The whole thing is within a `for` loop and `break` statements are
used. In this case, using `switch` would require tagging the `for`
loop, which probably tips the balance.
Why are `switch` statements more readable?
For one, fewer curly braces. But more importantly, the conditions all
have the same alignment, so the whole thing follows the natural flow
of going down a list of conditions. With `else if`, in contrast, all
conditions but the first are "hidden" behind `} else if `, harder to
spot and (for no good reason) presented differently from the first
condition.
I'm sure the aforemention wise coders can list even more reasons.
In any case, I like it so much that I have found myself recommending
it in code reviews. I would like to make it a habit in our code base,
without making it a hard requirement that we would test on the CI. But
for that, there has to be a role model, so this commit eliminates all
`if else` occurrences, unless it is autogenerated code or fits one of
the exceptions above.
Signed-off-by: beorn7 <beorn@grafana.com>
2 years ago
|
|
|
switch {
|
|
|
|
case err == nil:
|
|
|
|
err = rollbackErr
|
style: Replace `else if` cascades with `switch`
Wiser coders than myself have come to the conclusion that a `switch`
statement is almost always superior to a statement that includes any
`else if`.
The exceptions that I have found in our codebase are just these two:
* The `if else` is followed by an additional statement before the next
condition (separated by a `;`).
* The whole thing is within a `for` loop and `break` statements are
used. In this case, using `switch` would require tagging the `for`
loop, which probably tips the balance.
Why are `switch` statements more readable?
For one, fewer curly braces. But more importantly, the conditions all
have the same alignment, so the whole thing follows the natural flow
of going down a list of conditions. With `else if`, in contrast, all
conditions but the first are "hidden" behind `} else if `, harder to
spot and (for no good reason) presented differently from the first
condition.
I'm sure the aforemention wise coders can list even more reasons.
In any case, I like it so much that I have found myself recommending
it in code reviews. I would like to make it a habit in our code base,
without making it a hard requirement that we would test on the CI. But
for that, there has to be a role model, so this commit eliminates all
`if else` occurrences, unless it is autogenerated code or fits one of
the exceptions above.
Signed-off-by: beorn7 <beorn@grafana.com>
2 years ago
|
|
|
case rollbackErr != nil:
|
|
|
|
f.logger.Error("Squashed rollback error on rollback", "err", rollbackErr)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|