fix(docker): hide write buttons for non authorized [EE-6775] (#11261)

pull/11279/head
Chaim Lev-Ari 2024-02-27 12:36:47 +02:00 committed by GitHub
parent de3a3f88a0
commit eba08cdca0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
5 changed files with 84 additions and 40 deletions

View File

@ -79,7 +79,7 @@ const ngModule = angular
) )
.component( .component(
'dockerConfigsDatatable', 'dockerConfigsDatatable',
r2a(withUIRouter(ConfigsDatatable), [ r2a(withUIRouter(withCurrentUser(ConfigsDatatable)), [
'dataset', 'dataset',
'onRemoveClick', 'onRemoveClick',
'onRefresh', 'onRefresh',
@ -121,7 +121,11 @@ const ngModule = angular
.component('dockerEventsDatatable', r2a(EventsDatatable, ['dataset'])) .component('dockerEventsDatatable', r2a(EventsDatatable, ['dataset']))
.component( .component(
'dockerSecretsDatatable', 'dockerSecretsDatatable',
r2a(withUIRouter(SecretsDatatable), ['dataset', 'onRefresh', 'onRemove']) r2a(withUIRouter(withCurrentUser(SecretsDatatable)), [
'dataset',
'onRefresh',
'onRemove',
])
) )
.component( .component(
'dockerStacksDatatable', 'dockerStacksDatatable',

View File

@ -1,5 +1,7 @@
import { Clipboard, Plus, Trash2 } from 'lucide-react'; import { Clipboard, Plus, Trash2 } from 'lucide-react';
import { Authorized, useAuthorizations } from '@/react/hooks/useUser';
import { Datatable, TableSettingsMenu } from '@@/datatables'; import { Datatable, TableSettingsMenu } from '@@/datatables';
import { TableSettingsMenuAutoRefresh } from '@@/datatables/TableSettingsMenuAutoRefresh'; import { TableSettingsMenuAutoRefresh } from '@@/datatables/TableSettingsMenuAutoRefresh';
import { useRepeater } from '@@/datatables/useRepeater'; import { useRepeater } from '@@/datatables/useRepeater';
@ -26,6 +28,11 @@ export function ConfigsDatatable({ dataset, onRefresh, onRemoveClick }: Props) {
useRepeater(tableState.autoRefreshRate, onRefresh); useRepeater(tableState.autoRefreshRate, onRefresh);
const hasWriteAccessQuery = useAuthorizations([
'DockerConfigCreate',
'DockerConfigDelete',
]);
return ( return (
<Datatable <Datatable
dataset={dataset} dataset={dataset}
@ -42,8 +49,11 @@ export function ConfigsDatatable({ dataset, onRefresh, onRemoveClick }: Props) {
/> />
</TableSettingsMenu> </TableSettingsMenu>
)} )}
renderTableActions={(selectedRows) => ( disableSelect={!hasWriteAccessQuery.authorized}
renderTableActions={(selectedRows) =>
hasWriteAccessQuery.authorized && (
<div className="flex items-center gap-3"> <div className="flex items-center gap-3">
<Authorized authorizations="DockerConfigDelete">
<Button <Button
icon={Trash2} icon={Trash2}
color="dangerlight" color="dangerlight"
@ -52,11 +62,20 @@ export function ConfigsDatatable({ dataset, onRefresh, onRemoveClick }: Props) {
> >
Remove Remove
</Button> </Button>
<Button icon={Plus} as={Link} props={{ to: 'docker.configs.new' }}> </Authorized>
<Authorized authorizations="DockerConfigCreate">
<Button
icon={Plus}
as={Link}
props={{ to: 'docker.configs.new' }}
>
Add config Add config
</Button> </Button>
</Authorized>
</div> </div>
)} )
}
/> />
); );
} }

View File

@ -3,6 +3,7 @@ import { Lock, Plus, Trash2 } from 'lucide-react';
import { SecretViewModel } from '@/docker/models/secret'; import { SecretViewModel } from '@/docker/models/secret';
import { isoDate } from '@/portainer/filters/filters'; import { isoDate } from '@/portainer/filters/filters';
import { Authorized, useAuthorizations } from '@/react/hooks/useUser';
import { buildNameColumn } from '@@/datatables/buildNameColumn'; import { buildNameColumn } from '@@/datatables/buildNameColumn';
import { Datatable, TableSettingsMenu } from '@@/datatables'; import { Datatable, TableSettingsMenu } from '@@/datatables';
@ -53,6 +54,11 @@ export function SecretsDatatable({
const tableState = useTableState(store, storageKey); const tableState = useTableState(store, storageKey);
useRepeater(tableState.autoRefreshRate, onRefresh); useRepeater(tableState.autoRefreshRate, onRefresh);
const hasWriteAccessQuery = useAuthorizations([
'DockerSecretCreate',
'DockerSecretDelete',
]);
return ( return (
<Datatable <Datatable
title="Secrets" title="Secrets"
@ -60,11 +66,14 @@ export function SecretsDatatable({
columns={columns} columns={columns}
dataset={dataset || []} dataset={dataset || []}
isLoading={!dataset} isLoading={!dataset}
disableSelect={!hasWriteAccessQuery.authorized}
settingsManager={tableState} settingsManager={tableState}
emptyContentLabel="No secret available." emptyContentLabel="No secret available."
renderTableActions={(selectedItems) => ( renderTableActions={(selectedItems) =>
hasWriteAccessQuery.authorized && (
<TableActions selectedItems={selectedItems} onRemove={onRemove} /> <TableActions selectedItems={selectedItems} onRemove={onRemove} />
)} )
}
renderTableSettings={() => ( renderTableSettings={() => (
<TableSettingsMenu> <TableSettingsMenu>
<TableSettingsMenuAutoRefresh <TableSettingsMenuAutoRefresh
@ -86,6 +95,7 @@ function TableActions({
}) { }) {
return ( return (
<div className="flex items-center gap-2"> <div className="flex items-center gap-2">
<Authorized authorizations="DockerSecretDelete">
<Button <Button
color="dangerlight" color="dangerlight"
disabled={selectedItems.length === 0} disabled={selectedItems.length === 0}
@ -96,7 +106,9 @@ function TableActions({
> >
Remove Remove
</Button> </Button>
</Authorized>
<Authorized authorizations="DockerSecretCreate">
<Button <Button
as={Link} as={Link}
props={{ to: '.new' }} props={{ to: '.new' }}
@ -106,6 +118,7 @@ function TableActions({
> >
Add secret Add secret
</Button> </Button>
</Authorized>
</div> </div>
); );
} }

View File

@ -88,6 +88,14 @@ export function useIsEdgeAdmin({
}; };
} }
/**
* Check if the user has some of the authorizations
*
* @param authorizations a list of authorizations to check
* @param forceEnvironmentId to force the environment id, used where the environment id can't be loaded from the router, like sidebar
* @param adminOnlyCE if true, will return false if the user is not an admin in CE
* @returns query result with isLoading and authorized - authorized is true if the user has some of the authorizations
*/
export function useAuthorizations( export function useAuthorizations(
authorizations: string | string[], authorizations: string | string[],
forceEnvironmentId?: EnvironmentId, forceEnvironmentId?: EnvironmentId,
@ -137,7 +145,7 @@ export function useIsEnvironmentAdmin({
} }
/** /**
* will return true if the user has the authorizations. assumes the user is authenticated and not an admin * will return true if the user has some of the authorizations. assumes the user is authenticated and not an admin
* *
* @private Please use `useAuthorizations` instead. Exported only for angular's authentication service app/portainer/services/authentication.js:154 * @private Please use `useAuthorizations` instead. Exported only for angular's authentication service app/portainer/services/authentication.js:154
*/ */