From e1e81731b956a833960119bf18139b3184b5b57d Mon Sep 17 00:00:00 2001
From: Oscar Zhou <100548325+oscarzhou-portainer@users.noreply.github.com>
Date: Thu, 10 Nov 2022 08:28:09 +1300
Subject: [PATCH] fix(setting/auth): allow to save all auth method if custom
 ldap server is empty string (#7990)

---
 .../ldap-settings-custom/ldap-settings-custom.html     | 10 +---------
 .../authentication/settingsAuthenticationController.js |  2 +-
 2 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/app/portainer/settings/authentication/ldap/ldap-settings-custom/ldap-settings-custom.html b/app/portainer/settings/authentication/ldap/ldap-settings-custom/ldap-settings-custom.html
index 1e2816c59..b6fc0360d 100644
--- a/app/portainer/settings/authentication/ldap/ldap-settings-custom/ldap-settings-custom.html
+++ b/app/portainer/settings/authentication/ldap/ldap-settings-custom/ldap-settings-custom.html
@@ -34,15 +34,7 @@
   </label>
   <div class="col-sm-9 col-lg-10">
     <div class="mb-3 flex" ng-repeat="url in $ctrl.settings.URLs track by $index">
-      <input
-        type="text"
-        class="form-control"
-        id="ldap_url"
-        ng-model="$ctrl.settings.URLs[$index]"
-        placeholder="e.g. 10.0.0.10:389 or myldap.domain.tld:389"
-        ng-model-options="{ allowInvalid: true }"
-        required
-      />
+      <input type="text" class="form-control" id="ldap_url" ng-model="$ctrl.settings.URLs[$index]" placeholder="e.g. 10.0.0.10:389 or myldap.domain.tld:389" required />
       <button ng-if="$index > 0" class="btn btn-sm btn-danger" type="button" ng-click="$ctrl.removeLDAPUrl($index)">
         <pr-icon icon="'trash-2'" feather="true" size="'md'"></pr-icon>
       </button>
diff --git a/app/portainer/views/settings/authentication/settingsAuthenticationController.js b/app/portainer/views/settings/authentication/settingsAuthenticationController.js
index 9caa3be8b..8214e8cf8 100644
--- a/app/portainer/views/settings/authentication/settingsAuthenticationController.js
+++ b/app/portainer/views/settings/authentication/settingsAuthenticationController.js
@@ -166,7 +166,7 @@ function SettingsAuthenticationController($q, $scope, $state, Notifications, Set
     }
 
     settings.URLs = settings.URLs.map((url) => {
-      if (url === '') {
+      if (url === undefined || url === '') {
         return;
       }