github
/
portainer
mirror of https://github.com/portainer/portainer
1
0
Fork 0
Code Issues Releases Wiki Activity

fix(app/edge-stack): UI notification on creation error (#325)

pull/11389/merge
LP B 2025-01-17 20:33:01 +01:00 committed by GitHub
parent 154ca9f1b1
commit cab667c23b
2 changed files with 20 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/react-tools/react-query.ts
View File

@ -10,8 +10,13 @@ import {
import { notifyError } from '@/portainer/services/notifications'; import { notifyError } from '@/portainer/services/notifications';
/** /**
* @deprecated use withGlobalError * @deprecated for `useQuery` ONLY. Use `withGlobalError`.
* `onError` and other callbacks are not supported on react-query v5 *
* `onError` and other callbacks are not supported on `useQuery` in react-query v5
*
* Using `withError` is fine for mutations (`useMutation`)
*
* see https://tkdodo.eu/blog/breaking-react-querys-api-on-purpose
*/ */
export function withError(fallbackMessage?: string, title = 'Failure') { export function withError(fallbackMessage?: string, title = 'Failure') {
return { return {

19
app/react/edge/edge-stacks/CreateView/useCreate.tsx
View File

@ -6,6 +6,7 @@ import { TemplateViewModel } from '@/react/portainer/templates/app-templates/vie
import { CustomTemplate } from '@/react/portainer/templates/custom-templates/types'; import { CustomTemplate } from '@/react/portainer/templates/custom-templates/types';
import { notifySuccess } from '@/portainer/services/notifications'; import { notifySuccess } from '@/portainer/services/notifications';
import { transformAutoUpdateViewModel } from '@/react/portainer/gitops/AutoUpdateFieldset/utils'; import { transformAutoUpdateViewModel } from '@/react/portainer/gitops/AutoUpdateFieldset/utils';
import { mutationOptions, withError } from '@/react-tools/react-query';
import { import {
BasePayload, BasePayload,
@ -49,12 +50,18 @@ export function useCreate({
), ),
}); });
mutation.mutate(getPayload(method, values), { mutation.mutate(
onSuccess: () => { getPayload(method, values),
notifySuccess('Success', 'Edge stack created'); mutationOptions(
router.stateService.go('^'); {
}, onSuccess: () => {
}); notifySuccess('Success', 'Edge stack created');
router.stateService.go('^');
},
},
withError('unable to create edge stack')
)
);
function getPayload( function getPayload(
method: 'string' | 'file' | 'git', method: 'string' | 'file' | 'git',