From c8051b68d445ecd482c3eb3f02a6c894c06e34dc Mon Sep 17 00:00:00 2001
From: Oscar Zhou <100548325+oscarzhou-portainer@users.noreply.github.com>
Date: Thu, 3 Nov 2022 10:06:56 +1300
Subject: [PATCH] fix(auth/ldap): allow to save internal authentication if
 custom ldap server is not set [EE-3155] (#7959)

---
 .../ldap-settings-custom/ldap-settings-custom.html     | 10 +++++++++-
 .../authentication/settingsAuthenticationController.js |  4 ++++
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/app/portainer/settings/authentication/ldap/ldap-settings-custom/ldap-settings-custom.html b/app/portainer/settings/authentication/ldap/ldap-settings-custom/ldap-settings-custom.html
index b6fc0360d..1e2816c59 100644
--- a/app/portainer/settings/authentication/ldap/ldap-settings-custom/ldap-settings-custom.html
+++ b/app/portainer/settings/authentication/ldap/ldap-settings-custom/ldap-settings-custom.html
@@ -34,7 +34,15 @@
   </label>
   <div class="col-sm-9 col-lg-10">
     <div class="mb-3 flex" ng-repeat="url in $ctrl.settings.URLs track by $index">
-      <input type="text" class="form-control" id="ldap_url" ng-model="$ctrl.settings.URLs[$index]" placeholder="e.g. 10.0.0.10:389 or myldap.domain.tld:389" required />
+      <input
+        type="text"
+        class="form-control"
+        id="ldap_url"
+        ng-model="$ctrl.settings.URLs[$index]"
+        placeholder="e.g. 10.0.0.10:389 or myldap.domain.tld:389"
+        ng-model-options="{ allowInvalid: true }"
+        required
+      />
       <button ng-if="$index > 0" class="btn btn-sm btn-danger" type="button" ng-click="$ctrl.removeLDAPUrl($index)">
         <pr-icon icon="'trash-2'" feather="true" size="'md'"></pr-icon>
       </button>
diff --git a/app/portainer/views/settings/authentication/settingsAuthenticationController.js b/app/portainer/views/settings/authentication/settingsAuthenticationController.js
index 440e710dc..9caa3be8b 100644
--- a/app/portainer/views/settings/authentication/settingsAuthenticationController.js
+++ b/app/portainer/views/settings/authentication/settingsAuthenticationController.js
@@ -166,6 +166,10 @@ function SettingsAuthenticationController($q, $scope, $state, Notifications, Set
     }
 
     settings.URLs = settings.URLs.map((url) => {
+      if (url === '') {
+        return;
+      }
+
       if (url.includes(':')) {
         return url;
       }