From bcdc342cbd08b52186db6a590cab5dce946aa403 Mon Sep 17 00:00:00 2001
From: Richard Wei <54336863+WaysonWei@users.noreply.github.com>
Date: Wed, 22 Sep 2021 16:01:42 +1200
Subject: [PATCH] fix(k8s): fixerror handling for namespace restricted user
 EE-1703 (#5693)

* fix error handler for namespace when user have no namespace access
---
 .../helm/helm-templates/helm-templates.html   |  10 +-
 .../create/createApplication.html             |   4 +-
 .../create/createConfiguration.html           | 121 +++++++++---------
 app/kubernetes/views/deploy/deploy.html       |   8 +-
 .../views/deploy/deployController.js          |   8 +-
 5 files changed, 82 insertions(+), 69 deletions(-)

diff --git a/app/kubernetes/components/helm/helm-templates/helm-templates.html b/app/kubernetes/components/helm/helm-templates/helm-templates.html
index 1c1cda61f..1cdae0d32 100644
--- a/app/kubernetes/components/helm/helm-templates/helm-templates.html
+++ b/app/kubernetes/components/helm/helm-templates/helm-templates.html
@@ -39,7 +39,7 @@
             Configuration
           </div>
           <!-- namespace-input -->
-          <div class="form-group">
+          <div class="form-group" ng-if="$ctrl.state.resourcePool">
             <label for="resource-pool-selector" class="col-sm-2 control-label text-left">Namespace</label>
             <div class="col-sm-10">
               <select
@@ -52,13 +52,7 @@
               ></select>
             </div>
           </div>
-          <div class="form-group" ng-if="!$ctrl.state.resourcePool">
-            <div class="col-sm-12 small text-danger">
-              <i class="fa fa-exclamation-circle red-icon" aria-hidden="true" style="margin-right: 2px;"></i>
-              This namespace has exhausted its resource capacity and you will not be able to deploy the application. Contact your administrator to expand the capacity of the
-              namespace.
-            </div>
-          </div>
+
           <div class="form-group" ng-if="!$ctrl.state.resourcePool">
             <div class="col-sm-12 small text-muted">
               <i class="fa fa-exclamation-circle orange-icon" aria-hidden="true" style="margin-right: 2px;"></i>
diff --git a/app/kubernetes/views/applications/create/createApplication.html b/app/kubernetes/views/applications/create/createApplication.html
index ef6916c59..20785d089 100644
--- a/app/kubernetes/views/applications/create/createApplication.html
+++ b/app/kubernetes/views/applications/create/createApplication.html
@@ -141,6 +141,7 @@
                 <div class="col-sm-12">
                   <por-image-registry
                     model="ctrl.formValues.ImageModel"
+                    ng-if="ctrl.formValues.ResourcePool"
                     auto-complete="false"
                     label-class="col-sm-1"
                     input-class="col-sm-11"
@@ -152,7 +153,7 @@
                   ></por-image-registry>
                 </div>
               </div>
-
+            <div ng-if="ctrl.formValues.ResourcePool">
               <div class="col-sm-12 form-section-title">
                 Stack
               </div>
@@ -1607,6 +1608,7 @@
                 form-values="ctrl.formValues"
                 old-form-values="ctrl.savedFormValues"
               ></kubernetes-summary-view>
+              </div>
             </div>
 
             <div class="col-sm-12 form-section-title" ng-if="ctrl.state.appType !== ctrl.KubernetesDeploymentTypes.GIT">
diff --git a/app/kubernetes/views/configurations/create/createConfiguration.html b/app/kubernetes/views/configurations/create/createConfiguration.html
index 040c138c5..8c21a33df 100644
--- a/app/kubernetes/views/configurations/create/createConfiguration.html
+++ b/app/kubernetes/views/configurations/create/createConfiguration.html
@@ -49,7 +49,7 @@
             </div>
 
             <!-- resource-pool -->
-            <div class="form-group">
+            <div class="form-group" ng-if="ctrl.formValues.ResourcePool">
               <label for="resource-pool-selector" class="col-sm-1 control-label text-left">Namespace</label>
               <div class="col-sm-11">
                 <select
@@ -57,6 +57,7 @@
                   id="resource-pool-selector"
                   ng-model="ctrl.formValues.ResourcePool"
                   ng-options="resourcePool.Namespace.Name for resourcePool in ctrl.resourcePools"
+                  ng-change="ctrl.onResourcePoolSelectionChange()"
                   data-cy="k8sConfigCreate-namespaceDropdown"
                 ></select>
               </div>
@@ -68,69 +69,75 @@
                 namespace.
               </div>
             </div>
+            <div class="form-group" ng-if="!ctrl.formValues.ResourcePool">
+              <div class="col-sm-12 small text-muted">
+                <i class="fa fa-exclamation-circle orange-icon" aria-hidden="true" style="margin-right: 2px;"></i>
+                You do not have access to any namespace. Contact your administrator to get access to a namespace.
+              </div>
+            </div>
             <!-- !resource-pool -->
-
-            <div class="col-sm-12 form-section-title">
-              Configuration type
-            </div>
-
-            <div class="form-group">
-              <div class="col-sm-12 small text-muted">
-                Select the type of data that you want to save in the configuration.
+            <div ng-if="ctrl.formValues.ResourcePool">
+              <div class="col-sm-12 form-section-title">
+                Configuration type
               </div>
-            </div>
 
-            <!-- type options -->
-            <div class="form-group" style="margin-bottom: 0;">
-              <div class="boxselector_wrapper">
-                <div>
-                  <input type="radio" id="type_basic" ng-value="ctrl.KubernetesConfigurationTypes.CONFIGMAP" ng-model="ctrl.formValues.Type" />
-                  <label for="type_basic" data-cy="k8sConfigCreate-nonSensitiveButton">
-                    <div class="boxselector_header">
-                      <i class="fa fa-file-code" aria-hidden="true" style="margin-right: 2px;"></i>
-                      Non-sensitive
-                    </div>
-                    <p>This configuration holds non-sensitive information</p>
-                  </label>
-                </div>
-                <div>
-                  <input type="radio" id="type_secret" ng-value="ctrl.KubernetesConfigurationTypes.SECRET" ng-model="ctrl.formValues.Type" />
-                  <label for="type_secret" data-cy="k8sConfigCreate-sensitiveButton">
-                    <div class="boxselector_header">
-                      <i class="fa fa-user-secret" aria-hidden="true" style="margin-right: 2px;"></i>
-                      Sensitive
-                    </div>
-                    <p>This configuration holds sensitive information</p>
-                  </label>
+              <div class="form-group">
+                <div class="col-sm-12 small text-muted">
+                  Select the type of data that you want to save in the configuration.
                 </div>
               </div>
-            </div>
-            <!-- !type options -->
 
-            <div class="col-sm-12 form-section-title" ng-if="ctrl.formValues.Type == ctrl.KubernetesConfigurationTypes.SECRET">
-              Information
-            </div>
-            <div class="form-group" ng-if="ctrl.formValues.Type == ctrl.KubernetesConfigurationTypes.SECRET">
-              <div class="col-sm-12 small text-muted">
-                Creating a sensitive configuration will create a Kubernetes Secret of type <code>Opaque</code>. You can find more information about this in the
-                <a href="https://kubernetes.io/docs/concepts/configuration/secret/#secret-types" target="_blank">official documentation</a>.
+              <!-- type options -->
+              <div class="form-group" style="margin-bottom: 0;">
+                <div class="boxselector_wrapper">
+                  <div>
+                    <input type="radio" id="type_basic" ng-value="ctrl.KubernetesConfigurationTypes.CONFIGMAP" ng-model="ctrl.formValues.Type" />
+                    <label for="type_basic" data-cy="k8sConfigCreate-nonSensitiveButton">
+                      <div class="boxselector_header">
+                        <i class="fa fa-file-code" aria-hidden="true" style="margin-right: 2px;"></i>
+                        Non-sensitive
+                      </div>
+                      <p>This configuration holds non-sensitive information</p>
+                    </label>
+                  </div>
+                  <div>
+                    <input type="radio" id="type_secret" ng-value="ctrl.KubernetesConfigurationTypes.SECRET" ng-model="ctrl.formValues.Type" />
+                    <label for="type_secret" data-cy="k8sConfigCreate-sensitiveButton">
+                      <div class="boxselector_header">
+                        <i class="fa fa-user-secret" aria-hidden="true" style="margin-right: 2px;"></i>
+                        Sensitive
+                      </div>
+                      <p>This configuration holds sensitive information</p>
+                    </label>
+                  </div>
+                </div>
               </div>
+              <!-- !type options -->
+
+              <div class="col-sm-12 form-section-title" ng-if="ctrl.formValues.Type == ctrl.KubernetesConfigurationTypes.SECRET">
+                Information
+              </div>
+              <div class="form-group" ng-if="ctrl.formValues.Type == ctrl.KubernetesConfigurationTypes.SECRET">
+                <div class="col-sm-12 small text-muted">
+                  Creating a sensitive configuration will create a Kubernetes Secret of type <code>Opaque</code>. You can find more information about this in the
+                  <a href="https://kubernetes.io/docs/concepts/configuration/secret/#secret-types" target="_blank">official documentation</a>.
+                </div>
+              </div>
+
+              <kubernetes-configuration-data
+                ng-if="ctrl.formValues"
+                form-values="ctrl.formValues"
+                is-valid="ctrl.state.isDataValid"
+                is-creation="true"
+                is-editor-dirty="ctrl.state.isEditorDirty"
+              ></kubernetes-configuration-data>
+
+              <!-- summary -->
+              <kubernetes-summary-view
+                ng-if="!(!kubernetesConfigurationCreationForm.$valid || !ctrl.isFormValid() || ctrl.state.actionInProgress)"
+                form-values="ctrl.formValues"
+              ></kubernetes-summary-view>
             </div>
-
-            <kubernetes-configuration-data
-              ng-if="ctrl.formValues"
-              form-values="ctrl.formValues"
-              is-valid="ctrl.state.isDataValid"
-              is-creation="true"
-              is-editor-dirty="ctrl.state.isEditorDirty"
-            ></kubernetes-configuration-data>
-
-            <!-- summary -->
-            <kubernetes-summary-view
-              ng-if="!(!kubernetesConfigurationCreationForm.$valid || !ctrl.isFormValid() || ctrl.state.actionInProgress)"
-              form-values="ctrl.formValues"
-            ></kubernetes-summary-view>
-
             <!-- actions -->
             <div class="col-sm-12 form-section-title" style="margin-top: 10px;">
               Actions
@@ -140,7 +147,7 @@
                 <button
                   type="button"
                   class="btn btn-primary btn-sm"
-                  ng-disabled="!kubernetesConfigurationCreationForm.$valid || !ctrl.isFormValid() || ctrl.state.actionInProgress"
+                  ng-disabled="!kubernetesConfigurationCreationForm.$valid || !ctrl.isFormValid() || ctrl.state.actionInProgress || !ctrl.formValues.ResourcePool"
                   ng-click="ctrl.createConfiguration()"
                   button-spinner="ctrl.state.actionInProgress"
                   data-cy="k8sConfigCreate-CreateConfigButton"
diff --git a/app/kubernetes/views/deploy/deploy.html b/app/kubernetes/views/deploy/deploy.html
index bf892cfd6..65b2e9740 100644
--- a/app/kubernetes/views/deploy/deploy.html
+++ b/app/kubernetes/views/deploy/deploy.html
@@ -16,12 +16,18 @@
               <uib-tab-heading> <i class="fa fa-code space-right" aria-hidden="true"></i> Deploy </uib-tab-heading>
 
               <form class="form-horizontal" style="margin-top: 20px;">
-                <div class="form-group">
+                <div class="form-group" ng-if="ctrl.formValues.Namespace">
                   <label for="target_node" class="col-lg-1 col-sm-2 control-label text-left">Namespace</label>
                   <div class="col-lg-11 col-sm-10">
                     <select class="form-control" ng-model="ctrl.formValues.Namespace" ng-options="namespace.Name as namespace.Name for namespace in ctrl.namespaces"></select>
                   </div>
                 </div>
+                <div class="form-group" ng-if="!ctrl.formValues.Namespace">
+                  <div class="col-sm-12 small text-muted">
+                    <i class="fa fa-exclamation-circle orange-icon" aria-hidden="true" style="margin-right: 2px;"></i>
+                    You do not have access to any namespace. Contact your administrator to get access to a namespace.
+                  </div>
+                </div>
 
                 <div class="col-sm-12 form-section-title">
                   Build method
diff --git a/app/kubernetes/views/deploy/deployController.js b/app/kubernetes/views/deploy/deployController.js
index 4614febc1..648f17601 100644
--- a/app/kubernetes/views/deploy/deployController.js
+++ b/app/kubernetes/views/deploy/deployController.js
@@ -107,7 +107,9 @@ class KubernetesDeployController {
       this.state.BuildMethod === KubernetesDeployBuildMethods.WEB_EDITOR && _.isEmpty(this.formValues.EditorContent) && _.isEmpty(this.formValues.Namespace);
     const isURLFormInvalid = this.state.BuildMethod == KubernetesDeployBuildMethods.WEB_EDITOR.URL && _.isEmpty(this.formValues.ManifestURL);
 
-    return isGitFormInvalid || isWebEditorInvalid || isURLFormInvalid || this.state.actionInProgress;
+    const isNamespaceInvalid = _.isEmpty(this.formValues.Namespace);
+
+    return isGitFormInvalid || isWebEditorInvalid || isURLFormInvalid || this.state.actionInProgress || isNamespaceInvalid;
   }
 
   onChangeFormValues(values) {
@@ -230,7 +232,9 @@ class KubernetesDeployController {
       });
 
       this.namespaces = namespaces;
-      this.formValues.Namespace = this.namespaces[0].Name;
+      if (this.namespaces.length > 0) {
+        this.formValues.Namespace = this.namespaces[0].Name;
+      }
     } catch (err) {
       this.Notifications.error('Failure', err, 'Unable to load namespaces data');
     }