Merge pull request #201 from crosbymichael/csrf

Add CSRF Protection
pull/2/head
Kevan Ahlquist 2016-04-02 21:05:13 -05:00
commit 7e1d5338cf
4 changed files with 44 additions and 4 deletions

View File

@ -25,6 +25,10 @@ angular.module('dockerui', [
'volumes']) 'volumes'])
.config(['$routeProvider', '$httpProvider', function ($routeProvider, $httpProvider) { .config(['$routeProvider', '$httpProvider', function ($routeProvider, $httpProvider) {
'use strict'; 'use strict';
$httpProvider.defaults.xsrfCookieName = 'csrfToken';
$httpProvider.defaults.xsrfHeaderName = 'X-CSRF-Token';
$routeProvider.when('/', { $routeProvider.when('/', {
templateUrl: 'app/components/dashboard/dashboard.html', templateUrl: 'app/components/dashboard/dashboard.html',
controller: 'DashboardController' controller: 'DashboardController'
@ -79,6 +83,10 @@ angular.module('dockerui', [
time: 10000 time: 10000
}); });
} }
var csrfToken = response.headers('X-Csrf-Token');
if (csrfToken) {
document.cookie = 'csrfToken=' + csrfToken;
}
return response; return response;
} }
}; };
@ -88,4 +96,4 @@ angular.module('dockerui', [
// You need to set this to the api endpoint without the port i.e. http://192.168.1.9 // You need to set this to the api endpoint without the port i.e. http://192.168.1.9
.constant('DOCKER_ENDPOINT', 'dockerapi') .constant('DOCKER_ENDPOINT', 'dockerapi')
.constant('DOCKER_PORT', '') // Docker port, leave as an empty string if no port is requred. If you have a port, prefix it with a ':' i.e. :4243 .constant('DOCKER_PORT', '') // Docker port, leave as an empty string if no port is requred. If you have a port, prefix it with a ':' i.e. :4243
.constant('UI_VERSION', 'v0.9.0-beta'); .constant('UI_VERSION', 'v0.10.1-beta');

View File

@ -1,6 +1,6 @@
{ {
"name": "dockerui", "name": "dockerui",
"version": "0.9.0-beta", "version": "0.10.1-beta",
"homepage": "https://github.com/crosbymichael/dockerui", "homepage": "https://github.com/crosbymichael/dockerui",
"authors": [ "authors": [
"Michael Crosby <crosbymichael@gmail.com>", "Michael Crosby <crosbymichael@gmail.com>",

View File

@ -10,12 +10,18 @@ import (
"net/url" "net/url"
"os" "os"
"strings" "strings"
"github.com/gorilla/csrf"
"io/ioutil"
"fmt"
"github.com/gorilla/securecookie"
) )
var ( var (
endpoint = flag.String("e", "/var/run/docker.sock", "Dockerd endpoint") endpoint = flag.String("e", "/var/run/docker.sock", "Dockerd endpoint")
addr = flag.String("p", ":9000", "Address and port to serve dockerui") addr = flag.String("p", ":9000", "Address and port to serve dockerui")
assets = flag.String("a", ".", "Path to the assets") assets = flag.String("a", ".", "Path to the assets")
authKey []byte
authKeyFile = "authKey.dat"
) )
type UnixHandler struct { type UnixHandler struct {
@ -85,9 +91,35 @@ func createHandler(dir string, e string) http.Handler {
h = createUnixHandler(e) h = createUnixHandler(e)
} }
// Use existing csrf authKey if present or generate a new one.
dat, err := ioutil.ReadFile(authKeyFile)
if err != nil {
fmt.Println(err)
authKey = securecookie.GenerateRandomKey(32)
err := ioutil.WriteFile(authKeyFile, authKey, 0644)
if err != nil {
fmt.Println("unable to persist auth key", err)
}
} else {
authKey = dat
}
CSRF := csrf.Protect(
authKey,
csrf.HttpOnly(false),
csrf.Secure(false),
)
mux.Handle("/dockerapi/", http.StripPrefix("/dockerapi", h)) mux.Handle("/dockerapi/", http.StripPrefix("/dockerapi", h))
mux.Handle("/", fileHandler) mux.Handle("/", fileHandler)
return mux return CSRF(csrfWrapper(mux))
}
func csrfWrapper(h http.Handler) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.Header().Set("X-CSRF-Token", csrf.Token(r))
h.ServeHTTP(w, r)
})
} }
func main() { func main() {

View File

@ -2,7 +2,7 @@
"author": "Michael Crosby & Kevan Ahlquist", "author": "Michael Crosby & Kevan Ahlquist",
"name": "dockerui", "name": "dockerui",
"homepage": "https://github.com/crosbymichael/dockerui", "homepage": "https://github.com/crosbymichael/dockerui",
"version": "0.9.0-beta", "version": "0.10.1-beta",
"repository": { "repository": {
"type": "git", "type": "git",
"url": "git@github.com:crosbymichael/dockerui.git" "url": "git@github.com:crosbymichael/dockerui.git"