From 6a5f44b5baf8d61f3d68e26f17f089f61db152a6 Mon Sep 17 00:00:00 2001 From: Ali <83188384+testA113@users.noreply.github.com> Date: Thu, 26 Oct 2023 22:56:03 +0100 Subject: [PATCH] fix(errors): display kube confgimap and secret errors [EE-5558] (#10539) --- app/react/kubernetes/configs/configmap.service.ts | 13 ++++--------- app/react/kubernetes/configs/secret.service.ts | 13 ++++--------- 2 files changed, 8 insertions(+), 18 deletions(-) diff --git a/app/react/kubernetes/configs/configmap.service.ts b/app/react/kubernetes/configs/configmap.service.ts index 0d4ff73b3..4b5a8f6de 100644 --- a/app/react/kubernetes/configs/configmap.service.ts +++ b/app/react/kubernetes/configs/configmap.service.ts @@ -10,7 +10,6 @@ import { } from '@/portainer/services/notifications'; import { isFulfilled, isRejected } from '@/portainer/helpers/promise-utils'; import { pluralize } from '@/portainer/helpers/strings'; -import PortainerError from '@/portainer/error'; import { parseKubernetesAxiosError } from '../axiosError'; @@ -122,14 +121,10 @@ async function getConfigMapsForCluster( environmentId: EnvironmentId, namespaces: string[] ) { - try { - const configMaps = await Promise.all( - namespaces.map((namespace) => getConfigMaps(environmentId, namespace)) - ); - return configMaps.flat(); - } catch (e) { - throw new PortainerError('Unable to retrieve ConfigMaps', e); - } + const configMaps = await Promise.all( + namespaces.map((namespace) => getConfigMaps(environmentId, namespace)) + ); + return configMaps.flat(); } // get all configmaps for a namespace diff --git a/app/react/kubernetes/configs/secret.service.ts b/app/react/kubernetes/configs/secret.service.ts index f808366a2..b002788ec 100644 --- a/app/react/kubernetes/configs/secret.service.ts +++ b/app/react/kubernetes/configs/secret.service.ts @@ -10,7 +10,6 @@ import { } from '@/portainer/services/notifications'; import { isFulfilled, isRejected } from '@/portainer/helpers/promise-utils'; import { pluralize } from '@/portainer/helpers/strings'; -import PortainerError from '@/portainer/error'; import { parseKubernetesAxiosError } from '../axiosError'; @@ -118,14 +117,10 @@ async function getSecretsForCluster( environmentId: EnvironmentId, namespaces: string[] ) { - try { - const secrets = await Promise.all( - namespaces.map((namespace) => getSecrets(environmentId, namespace)) - ); - return secrets.flat(); - } catch (e) { - throw new PortainerError('Unable to retrieve secrets for cluster', e); - } + const secrets = await Promise.all( + namespaces.map((namespace) => getSecrets(environmentId, namespace)) + ); + return secrets.flat(); } // get all secrets for a namespace