From 6094dc115b34ae103c741e045610cdf8d2c51628 Mon Sep 17 00:00:00 2001
From: Prabhat Khera <91852476+prabhat-org@users.noreply.github.com>
Date: Mon, 11 Mar 2024 13:38:59 +1300
Subject: [PATCH] fix(container): autocomplete off for create container form
 [EE-6761] (#11337)

* autocomplete off doe create container form

* address review commets

* remove auto complete off from forms
---
 .../edge-stacks/createEdgeStackView/create-edge-stack-view.html | 2 +-
 app/kubernetes/views/deploy/deploy.html                         | 2 +-
 app/portainer/views/stacks/create/createstack.html              | 2 +-
 app/portainer/views/stacks/edit/stack.html                      | 2 +-
 .../form-components/AutocompleteSelect/AutocompleteSelect.tsx   | 1 +
 .../portainer/gitops/ComposePathField/ComposePathField.tsx      | 1 +
 .../templates/custom-templates/CreateView/InnerForm.tsx         | 2 +-
 .../portainer/templates/custom-templates/EditView/InnerForm.tsx | 2 +-
 8 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/app/edge/views/edge-stacks/createEdgeStackView/create-edge-stack-view.html b/app/edge/views/edge-stacks/createEdgeStackView/create-edge-stack-view.html
index 0abddccac..c7a992d5e 100644
--- a/app/edge/views/edge-stacks/createEdgeStackView/create-edge-stack-view.html
+++ b/app/edge/views/edge-stacks/createEdgeStackView/create-edge-stack-view.html
@@ -4,7 +4,7 @@
   <div class="col-sm-12">
     <rd-widget>
       <rd-widget-body>
-        <form class="form-horizontal" name="$ctrl.form" autocomplete="off">
+        <form class="form-horizontal" name="$ctrl.form">
           <!-- name-input -->
           <div class="form-group">
             <label for="stack_name" class="col-sm-1 control-label required text-left"> Name </label>
diff --git a/app/kubernetes/views/deploy/deploy.html b/app/kubernetes/views/deploy/deploy.html
index c5bd5d8c6..480b1c195 100644
--- a/app/kubernetes/views/deploy/deploy.html
+++ b/app/kubernetes/views/deploy/deploy.html
@@ -12,7 +12,7 @@
           <uib-tabset active="ctrl.state.activeTab" justified="true" type="pills">
             <uib-tab index="0">
               <uib-tab-heading> <pr-icon icon="'code'"></pr-icon> Deploy </uib-tab-heading>
-              <form class="form-horizontal mt-6" name="ctrl.deploymentForm" autocomplete="off">
+              <form class="form-horizontal mt-6" name="ctrl.deploymentForm">
                 <div class="col-sm-12 form-section-title"> Deploy from </div>
                 <box-selector
                   slim="true"
diff --git a/app/portainer/views/stacks/create/createstack.html b/app/portainer/views/stacks/create/createstack.html
index ea04f9b09..d925bf5b9 100644
--- a/app/portainer/views/stacks/create/createstack.html
+++ b/app/portainer/views/stacks/create/createstack.html
@@ -4,7 +4,7 @@
   <div class="col-sm-12">
     <rd-widget>
       <rd-widget-body>
-        <form class="form-horizontal" name="createStackForm" autocomplete="off">
+        <form class="form-horizontal" name="createStackForm">
           <!-- name-input -->
           <div class="form-group">
             <label for="stack_name" class="col-sm-1 control-label text-left">Name</label>
diff --git a/app/portainer/views/stacks/edit/stack.html b/app/portainer/views/stacks/edit/stack.html
index 191ae640d..0ebc3401f 100644
--- a/app/portainer/views/stacks/edit/stack.html
+++ b/app/portainer/views/stacks/edit/stack.html
@@ -139,7 +139,7 @@
               <pr-icon icon="'edit-2'" class-name="'mr-1'"></pr-icon>
               Editor
             </uib-tab-heading>
-            <form class="form-horizontal" ng-if="state.showEditorTab" style="margin-top: 10px" name="stackUpdateForm" autocomplete="off">
+            <form class="form-horizontal" ng-if="state.showEditorTab" style="margin-top: 10px" name="stackUpdateForm">
               <div class="form-group">
                 <span class="col-sm-12 text-muted small" style="margin-bottom: 7px" ng-if="stackType == STACK_TYPES.DockerCompose && composeSyntaxMaxVersion == 2">
                   This stack will be deployed using the equivalent of <code>docker compose</code>. Only Compose file format version <b>2</b> is supported at the moment.
diff --git a/app/react/components/form-components/AutocompleteSelect/AutocompleteSelect.tsx b/app/react/components/form-components/AutocompleteSelect/AutocompleteSelect.tsx
index cdb5d1754..c44e88efa 100644
--- a/app/react/components/form-components/AutocompleteSelect/AutocompleteSelect.tsx
+++ b/app/react/components/form-components/AutocompleteSelect/AutocompleteSelect.tsx
@@ -53,6 +53,7 @@ export function AutocompleteSelect({
         placeholder={placeholder}
         readOnly={readOnly}
         id={inputId}
+        autoComplete="off"
       />
       {!selected && searchResults && searchResults.length > 0 && (
         <ComboboxPopover>
diff --git a/app/react/portainer/gitops/ComposePathField/ComposePathField.tsx b/app/react/portainer/gitops/ComposePathField/ComposePathField.tsx
index 6a885130c..9d793e65a 100644
--- a/app/react/portainer/gitops/ComposePathField/ComposePathField.tsx
+++ b/app/react/portainer/gitops/ComposePathField/ComposePathField.tsx
@@ -73,6 +73,7 @@ export function ComposePathField({
               }}
               placeholder={isCompose ? 'docker-compose.yml' : 'manifest.yml'}
               id="stack_repository_path"
+              autoComplete="off"
             />
           )}
         </FormControl>
diff --git a/app/react/portainer/templates/custom-templates/CreateView/InnerForm.tsx b/app/react/portainer/templates/custom-templates/CreateView/InnerForm.tsx
index 5a682c015..d0bd52d28 100644
--- a/app/react/portainer/templates/custom-templates/CreateView/InnerForm.tsx
+++ b/app/react/portainer/templates/custom-templates/CreateView/InnerForm.tsx
@@ -61,7 +61,7 @@ export function InnerForm({
   const texts = textByType[values.Type];
 
   return (
-    <Form className="form-horizontal" autoComplete="off">
+    <Form className="form-horizontal">
       <CommonFields
         values={values}
         onChange={(newValues) =>
diff --git a/app/react/portainer/templates/custom-templates/EditView/InnerForm.tsx b/app/react/portainer/templates/custom-templates/EditView/InnerForm.tsx
index cda6774d0..a5f5d0bb2 100644
--- a/app/react/portainer/templates/custom-templates/EditView/InnerForm.tsx
+++ b/app/react/portainer/templates/custom-templates/EditView/InnerForm.tsx
@@ -65,7 +65,7 @@ export function InnerForm({
   const texts = textByType[values.Type];
 
   return (
-    <Form className="form-horizontal" autoComplete="off">
+    <Form className="form-horizontal">
       <CommonFields
         values={values}
         onChange={(newValues) =>